* Handle panic gracefully when unbond begin fails
See #1831
* Handle failure to query delegation gracefully.
Closes#1907
* Update PENDING.md
* Reuse stake's error functions
* New ErrBadValidatorAddr error
UnmarshalValidator() checks the address length first;
it does not make sense to attempt unmarshalling if the
address is wrong.
* New ErrBadDelegationAddr error
* Introduce ErrBad{Redelegation,UnbondingDelegation}Addr custom errors to replace errors.New() calls
* Replace ErrBadUnbondingDelegationAddr with ErrBadDelegationAddr to avoid duplication
Thanks: @melekes for pointing this out
* Use sdk.AddrLen instead of hardcoded address length
* s/triple/tuple/ ## mention PR id in PENDING.md
* changelog
* ...
* decimal func working
* decimal complete, untested
* fixing tests
* decimal compile errors resolved
* test compile errors
* precision multiplier test
* 1% laptop battery
* fixed TestNewDecFromStr
* equalities working
* fix bankers round chop
* ...
* working, some decimal issues resolved
* fix rounding error
* rounding works
* decimal works
* ...
* deleted rational
* rational conversion working
* revert changelog
* code compiles (not tests)
* went through all NewDec, made sure they were converted from NewRat properly
* test debugging
* all testing bugs besides the json marshalling fixed
* json unmarshal
* lint
* document update
* fix lcd test
* cli test fix
* mostly undo Dece -> Rate
* val comments
* Efficiency improvements
This now caches all of the precision multipliers (as they were all
used in non-mutative functions), and caches the precisionInt calculation.
(Now it just copies the already calculated value)
* Cache another precisionInt() call.
* Improve banker rounding efficiency
* remove defer, make negation in-place.
* chris val comments
* bez comments
* Aditya comments
* ...
* val comments
* rebasing start
* ...
* compiling
* tests pass
* cli fix
* anton, cwgoes, val comments
* val and jae comments
* type
* undo reuse quo
* tools: Add unparam linter
unparam detects unused parameters in functions, and a parameter to
a function which only ever takes on one value. The latter is an
indication that more tests are required.
There are many nolints in this PR, as I believe that writing tests
to fix alot of these situations is out of scope for this PR / it
will be changed in future commits. There are some nolints for
when we have to comply to normal api's.
* crypto/keys no longer used by x/gov/client/rest/rest.go
* x/stake: Limit the size of rationals from user input
This commit sets the maximum number of decimal points that can be
passed in from messages. This is enforced on the validate basic of
MsgBeginUnbonding and MsgBeginRedelegation. The cli has been
updated to truncate the user input to the specified precision. This
also updates types/rational to return big ints for Num() and Den().
Closes#887
* Switch NewFromDecimal to error instead of truncating
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK
Adds support for Ledger into gaiacli
Cherry-picks updated error handling from #1158
* tools: Add ineffassign linter
This errors on assignments that don't actually do anything. i.e.
x, err := myFunc(1)
y, err = myFunc(2)
This will call out that the first function's call error was never
used.
* Fix makefile, add misspell to makefile
Federico Kunze
Ethan Buchman
Alessio Treglia
Rigel
Fabian
Alexander Bezobchuk
Aditya
Sunny Aggarwal
Christopher Goes
ValarDragon
sunnya97
Dev Ojha
Sherry Ma