Aaron Craelius
9592f34cde
Fully remove StdTx usage in ante handler tests ( #6845 )
...
* WIP on removing StdTx from ante handler tests
* Fix recheck
* Fix basic_test
* Don't use StdTx in ante_test
* Use TxConfig sign mode handler in anteHandler
* Fix TestAnteHandlerAccountNumbers
* Amino don't panic
* Fix more tests
* All proto ante tests pass
* Fix last tests
* Amino register concrete
* Add tests
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-07-29 15:52:22 +00:00
SaReN
919e906866
Minor Code Cleanup - gRPC queries ( #6862 )
...
* add missing RegisterQueryService
* Update generated proto files
* Update grpc tests for auth,bank
* Make format
* fix godoc
* Address suggestions
* Update godoc
2020-07-28 12:53:35 +00:00
Marie
f59df68a97
Migrate x/genutil to use TxConfig ( #6734 )
...
* Update genutil collect and gentx to use TxGenerator
* Remove print statement
* Use Tx in genutil DeliverGenTxs
* Use Tx in genutil genesis_state
* Use Tx in ValidateGenesis
* Use amino txJSONDecoder and txBinaryEncoder in genutil InitGenesis
* Use TxConfig in place of TxGenerator
* Add gentx tests
* Remove commented line
* Test fixes
* Apply suggestions from code review
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Fixes
* Fixes
* Fixes
* Fixes
* Remove unneeded test case (doesn't apply to proto marshaling)
* linting
* Refactor to use new TxEncodingConfig interface in genutil module
* Replace golang/protobuf with gogo/protobuf package
* Use TxEncodingConfig in InitTestnet
* Remove old amino.go file
* Use TxJSONDecoder in genutil ValidateGenesis
* Add parameter to ValidateGenesis to resolve the tx JSON decoder issue
* Address review feedback
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-25 08:10:04 +00:00
SaReN
928f7fccff
Add wrap tx builder to TxConfig ( #6836 )
...
* Add wrap tx builder
* Add tests
* update for StdTx
* fix StdTxConfig
* Update generator
* Add godoc
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-24 22:24:57 +00:00
Anil Kumar Kammari
e906c012a0
add page flag for CLI queries ( #6824 )
...
* add page flag for CLI queries
* fix review suggestions
* Fix `page` flag default value
* fix offset calc
* Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
* fix review suggestions
* refactor
* fix returning error
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-24 08:17:11 +00:00
Marko
e6a56226a8
context: remove verifier & trust node ( #6805 )
...
* remove verifier
* more removal of trustnode flag
* add todo
* fix lint
* remove file
* remove viper and add link to issue
* remve mention of trustnode
2020-07-23 06:44:18 +00:00
Alessio Treglia
e0a81d2cca
crypto: move ledger code to its own subfolder ( #6817 )
...
crypto -> crypto/ledger:
- crypto.LedgerShowAddress -> ledger.ShowAddress
- crypto.NewPrivKeyLedgerSecp256k1 - > ledger.NewPrivKeySecp256k1
- crypto.NewPrivKeyLedgerSecp256k1Unsafe -> ledger.NewPrivKeySecp256k1Unsafe
Closes : #6780
2020-07-22 18:51:12 +02:00
Alexander Bezobchuk
ab664e9a43
Merge PR #6815 : Code & Doc Cleanup
2020-07-22 11:02:36 -04:00
Alexander Bezobchuk
61d69a978f
Merge PR #6806 : Docs & Cleanup
2020-07-21 11:28:43 -04:00
Alexander Bezobchuk
0ccc48d2a3
CLI/Tests: Remove Fixtures ( #6799 )
...
* remove fixtures
* setup tests
* update x/mint
* cli: update x/staking commands
* tests: convert x/staking CLI tests
* tests: fix x/auth CLI tests
* cli updates
* fix buiild
* fix build
* Update x/gov/client/cli/cli_test.go
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* remove GenerateOrBroadcastTx
* move TestCLIQueryConn
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-07-21 13:54:07 +00:00
Alexander Bezobchuk
515b25b94e
Context: Remove Init/New ( #6797 )
...
* init commit
* remove new/init functions
* update CLI commands
* tests: fix TestCLIQueryConn
* remove viper
2020-07-20 16:42:46 +00:00
billy rennekamp
cde3f46d52
Add validation to prevent empty store keys ( #6754 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-20 18:05:01 +02:00
Jonathan Gimeno
54141887b5
Add home default to other commands. ( #6789 )
...
* Add home default to other commands.
* add defaultNodeHome to rest of commands
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-20 15:12:33 +00:00
Amaury Martiny
5c0e3b4de5
x/auth/ante: Migrate tests to use the new client.TxConfig ( #6661 )
...
* WIP: using encoding config
* Make it compile, test fails
* test should be okay
* Make tests pass
* Add comments
* Convert more tests
* Make TestAnteHandlerSigErrors work
* Make first 2 tests pass
* TestAnteHandlerAccountNumbers
* Use table tests
* Remove print
* Use test table
* TestAnteHandlerSigErrors
* TestAnteHandlerAccountNumbers
* TestAnteHandlerAccountNumbers
* Refactor TestAccount
* Refactor getSignBytes
* TestAnteHandlerAccountNumbersAtBlockHeightZero
* TestAnteHandlerSequences
* TestAnteHandlerFees
* TestAnteHandlerMultiSigner
* TestAnteHandlerBadSignBytes
* TestAnteHandlerSetPubKey
* TestAnteHandlerSigLimitExceeded
* TestCustomSignatureVerificationGasConsumer
* TestAnteHandlerReCheck
* Make all tests pass
* Refactor a little bit more
* Fee test
* SetupTest
* All tests pass
* Refactor to RunTestCase
* Don't use StdFee
* Revert some little stuff
* Finish up last couple of test cases
* Less verbose
* s/TxGenerator/TxConfig
* Add comments
* Indent
* Move KeyTestPubAddr to testdata
* Move testdata to /testutil
* Revert to use signature: nil step in signing
* Add comments
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-20 08:30:12 -04:00
atheeshp
3123d07ad9
Update x/{mint,slashing,evidence} cli to use gRPC query client ( #6704 )
...
* changes cli to use gRPC in mint, slashing
* added command for signing infos
* gRPC query client migration of evidence
* review changes
* added unpack any
* fixed build error
* fixed failing tests issue
* added read flags
* added pagination flags
* updated docs
* fixed tests issue
* failing tests
* fixed tests
* review changes
* review changes
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
2020-07-19 06:16:57 -04:00
Alexander Bezobchuk
e59781eca7
Merge PR #6765 : x/auth: Finish CLI Refactor
2020-07-17 16:20:45 -04:00
Cory
32de79d0aa
refactor auths broadcast cmd in alignment with #6216 ( #6713 )
...
* refactor auths broadcast cmd in alignment with #6216
* add TxResponse proto definition, and related refactoring
* re-run make proto-gen, updating staking.pb.go
* cleanup TxResponse tests to handle nil return values
* properly handle nil Tx value in TxResponse's implementation of UnpackInterfaces
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-17 17:17:21 +00:00
atheeshp
c37f683cc1
x/staking: cli migration to use gRPC query client ( #6728 )
...
* migrated to use gRPC query client
* removed codecs usage
* review change
* added read command flags
* added pagination flags
* fixed limit issue
* added helper function for default pagination flags
* review changes
* review change
* review changes
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-17 15:23:42 +00:00
billy rennekamp
a6ac7f496e
Tiny change to flag help description for gas-prices ( #6701 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-07-13 08:36:34 -04:00
Alexander Bezobchuk
e7554bb3b0
Fix Gas Flag Usage + CLI Flag APIs ( #6685 )
...
* Use new APIs
* fix usage
* fix usage of gas flag
* tests: TestParseGasSetting
2020-07-11 08:13:46 +00:00
Alexander Bezobchuk
e1476c1f9d
x/distribution: CLI & Module Tweaks ( #6684 )
...
* init commit
* cleanup methods
* fix
2020-07-10 19:59:26 +00:00
Alexander Bezobchuk
400c3cb08e
Merge PR #6652 : x/distribution: In-Process Testing & CLI Refactor
2020-07-10 10:45:46 -04:00
Jonathan Gimeno
6ceedc9e4f
Remove TxBuilder references to viper. ( #6653 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-07-10 11:05:35 +02:00
Alessio Treglia
255ed06eb4
testutil: add ApplyMockIODiscardOutErr, simplify existing functions ( #6665 )
2020-07-10 08:55:48 +02:00
Alessio Treglia
a940214a49
testutil cleanup and reorg ( #6658 )
...
Prepare migrating testing auxiliary functions from tests
to testutil.
Remove local duplicates on testutil.WriteToNewTempFile().
Always favor testutil.NewTestCaseDir() over ioutil.TempDir().
Add test cases for the testing auxiliary functions.
2020-07-09 14:21:20 +02:00
Alessio Treglia
57ac28c814
client/flags: remove NewCompletionCmd() ( #6632 )
...
The functionality was adopted tendermint upstream, see
* https://github.com/tendermint/tendermint/pull/4665
2020-07-07 19:29:30 +02:00
Alexander Bezobchuk
8670a10564
Merge PR #6595 : Single Binary & Command Refactor
2020-07-07 11:40:46 -04:00
Alexander Bezobchuk
de7885a594
keys: CLI Remove Viper ( #6613 )
...
* init commit
* Update ListKeysCmd
* updates
* updates
* test updates
* fix tests
* keys: Fix Test_runAddCmdLedgerWithCustomCoinType
* keys: Fix Test_runAddCmdLedger
* keys: Fix Test_runAddCmdBasic
* keys: Fix root tests
* keys: Fix Test_runMigrateCmd
* keys: Fix Test_runListCmd
* keys: Fix remaining tests
2020-07-06 19:50:09 +00:00
Aaron Craelius
2f44fbf2ab
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT ( #6385 )
...
* Add TxWrapper, encoder, decoder and DirectModeHandler
* fix pkg name
* Update API and leave test TODO's
* Update TxWrapper API
* tests for tx wrapper (#6410 )
* WIP: added test for direct mode handler
* updated code
* Add msg
* Update TxWrapper API
* Fix pubkey declaration
* Add pubkey for tests
* Fix SetFee
* Remove logs
* Avoid global var declaration for tests
* Add test for GetPubKeys
* Fix direct signing tests
* Add more test cases for GetSignBytes
* Revert SetFee API
* Remove logs
* Refactor tests
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
* Refactoring
* Refactoring
* Integrate SignatureV2 API
* Fix wrapper tests
* Fix tests
* Linting and API tweaks
* Update API
* WIP on updating API
* Fix tests
* Update to new SigVerifiableTx
* Rename
* Update docs to reflect ADR 020
* proto-gen
* proto docs
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* Add tests
* Refactor and improving test coverage
* WIP on test coverage
* WIP on test coverage
* proto-gen
* Fix CompactBitArray.Size() bug
* Rename
* Remove Builder interface
* Address review comments
* Update x/auth/tx/sigs.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Address review feedback
* Fix build issues
* Resolve conflicts
* Fix ValidateBasic test coverage
* Add test for malicious multisig
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-06 17:03:45 +00:00
Alessio Treglia
b832e103b1
client/keys: make add command's output parseable ( #6603 )
...
client/input/input.go: GetConfirmation() should communicate
with the user via the io.Writer instance passed in as
argument.
client/keys/add.go: replace cmd.PrintErrln() calls with
fmt.Fprintln(cmd.ErrOrStderr(), ...) because of cobra's
PrintErr* functions broken behaviour. For more information
please see https://github.com/spf13/cobra/pull/894
Closes : #6601
Thanks: @noandrea for pointing this out.
2020-07-05 13:22:49 +02:00
Aaron Craelius
849429ecda
Add proper support for Any in gRPC queries ( #6594 )
...
* Add proper gRPC Any support via AnyUnpacker
* Wire up grpc query router AnyUnpacker
2020-07-03 16:42:12 +00:00
Alexander Bezobchuk
14d1ee5437
Use Context in Command instead of Argument + Util ( #6572 )
...
* Use context
* use PersistentPreRunE
* undo
* use init context
* Update types
* update tests
* implement tests
* Update simapp/cmd/simcli/main.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update simapp/cmd/simcli/main.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/bank/client/cli/tx.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* fix build
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-02 13:02:28 +00:00
Jonathan Gimeno
8f96ec0585
REST bank transfers fail due to encoding. ( #6536 )
...
Bank module REST endpoint bank/accounts/{addr}/transfers
was returning invalid StdTx format.
2020-07-02 05:16:39 +02:00
Alexander Bezobchuk
37cc04081e
Fix Current Integration Tests ( #6570 )
...
* fix attempt
* fix test
2020-07-01 18:37:59 +00:00
Aaron Craelius
99ea4b759a
Fix testdata proto-gen ( #6568 )
2020-07-01 15:26:29 +00:00
Alexander Bezobchuk
d5049413ef
Merge PR #6525 : x/bank: Refactor CLI & Tests
2020-06-30 16:59:21 -04:00
Anil Kumar Kammari
74eb56dd2a
Add test suite for client TxBuilder ( #6460 )
...
* Add tests
* Fix gofmt
* typecast tests
* Fix review comments
* typecast SigVerificableTx
* cleanup
* Refactor
* Linting and move encode/decode tests to suite
* Fix lint
* Move test suite
* godoc
* Refactor
* Refactor
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-06-29 14:05:30 +00:00
Aaron Craelius
712d23740f
Migrate x/auth cmd's to TxGenerator marshaling ( #6391 )
...
* Migrate encode, decode, and broadcast cmd's to use TxGenerator marshal methods
* Fix tests, add EncodingConfig
* Add simapp/encoding.go and wire up with simcli
* add godocs
* fix tests
* Debugging CLI Tests
* Fix integration test
* 6391 - lint issues and code coverage (#6414 )
* fixed lint issue of "txEncodeRespStr"
* added tests for encode.go
* WIP: added tests for decode.go
* added txEncoder at bytes
* updated decode test
* updated txBytes to use TxEncoder in decoder test
* added a require after TxEncoder
* removed file save
* debug decode command
* fixed decode tests
* added decode cli
* updated encode and decode in a single file
* separated decode test from encode test
* review changes
* removed register interface
* review change
* Fix tests
* WIP add test for tx sign
* removed commented code
* Fix flags
* WIP add test for sign
* Address review suggestions
* fixed command issue
* Add tests for TxEncoder
* Revert sign changes
* Fix TxEncoder tests
* Fix GetSign Cmd
* Add tx test
* Remove duplicate validation
* Add tests for TxDecoder
* Fix tests
* Fix tests
* Output to clientCtx.Output
* Fix cli_tests
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-18 20:29:41 +00:00
Aaron Craelius
257354dbff
x/bank: convert query CLI commands to use gRPC query client ( #6367 )
...
* Convert x/bank query cli methods to use gRPC query client
* WIP on x/bank cli query migration
* lint
* Fix integration tests
* Remove Println in favor of updated PrintOutput
* Add PrintOutput tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-18 03:36:25 -04:00
Aaron Craelius
c13809062a
Update TxBuilder to use SignatureV2 ( #6443 )
...
* Update TxBuilder to use SignatureV2
* Fix unit tests
* Lint
* lint
* Cleanup
* Address review feedback
* Add Sign tests
* Add more cases for sign tests
* Fix lint
* Fix gofmt
* Deprecate StdTx
* Undeprecate StdTx, but leave a comment to use the protobuf Tx
* Address review comment
Co-authored-by: anilCSE <anil@vitwit.com>
2020-06-16 19:57:37 +00:00
Alexander Bezobchuk
8ee7d1f403
Merge PR #6399 : SDK Telemetry
2020-06-16 11:11:02 -04:00
Alexander Bezobchuk
35312d098e
JSON Codec Updates ( #6444 )
...
* Initial commit
* More updates
* Fix tests
* CLI test updates
* Updates
* Updates
2020-06-16 00:20:50 +00:00
Alexander Bezobchuk
6a05b83069
Merge PR #6426 : Migrate API Server
2020-06-15 13:39:09 -04:00
dauTT
24b9be0ef8
x/bank: remove alias.go usage ( #6439 )
...
* x/bank: remove alias.go usage
* Fix simd_test.go
2020-06-14 23:06:16 +00:00
Federico Kunze
0215b5c6cd
client: fix signing algorithm ( #6405 )
...
* crypto/keyring: fix signing algorithm
* client: tests
* minor fixes
* changelog
* address @alexanderbez comments
* Update crypto/keyring/keyring.go
* Update crypto/keyring/signing_algorithms.go
* Update crypto/keyring/keyring.go
* Update crypto/keyring/signing_algorithms.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* fix test
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 14:30:42 +00:00
Aaron Craelius
4e0a475751
Make client.Context implement gRPC ClientConn ( #6342 )
...
* Add QueryConn to client.Context
* Add integration test
* imports
* spelling
* Make client.Context implement grpc ClientConn
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-08 13:41:30 +00:00
Aaron Craelius
81d647e505
Move codec.RegisterCrypto and codec.Cdc to new packages ( #6330 )
...
* Move codec.Cdc to legacy_global.Cdc
* Update CHANGELOG.md
* Updates
* nit
* Fix imports
* Updates
* Use cosmos multisig instead of tendermint multisig everywhere
* Fix tests
* Rename legacy_global -> legacy
* Add doc.go
* Linting, move all RegisterCrypto calls to crypto/codec
* Update crypto/codec/amino.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 10:38:24 +00:00
SaReN
39f53ac22f
client: rename CliContext to Context ( #6290 )
...
* Refactor CliContext as Context
* Fix lint issues
* Fix goimports
* Fix gov tests
* Resolved ci-lint issues
* Add changelog
* Rename cliCtx to clientCtx
* Fix mocks and routes
* Add changelog
* Update changelog
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* merge client/rpc/ro{ot,utes}.go
* Update docs
* client/rpc: remove redundant client/rpc.RegisterRPCRoutes
* regenerate mocks
* Update ADRs
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-01 12:46:03 +00:00
Alexander Bezobchuk
f8bad078b7
Bump Tendermint version ( #6300 )
2020-05-28 14:46:28 +00:00
Aaron Craelius
850419fffd
Tx CLI proto module interface ( #5989 )
...
* WIP
* WIP
* WIP on removing x/auth dependency from client/tx
* Revert unneeded changes
* Simplify cli tx UX
* Wire up bank tx REST routes
* Fix assignment issue
* Wire up bank NewSendTxCmd
* fix lint
* revert file
* revert file
* fix simcli
* Refactor AccountRetriever
* Fix build
* Fix build
* Fix build
* Fix integration tests
* Fix tests
* Docs, linting
* Linting
* WIP on all modules
* Implement other module new tx cmd's
* Fix cmd's
* Refactor existing GetTxCmd
* Fix cmd
* Removing deprecated code
* Update ADR 020 & CHANGELOG
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Fix client/tx tests
* Fix mocks
* Fix tests
* Lint fixes
* REST tx migration
* Wire up REST
* Linting
* Update CHANGELOG, docs
* Fix tests
* lint
* Address review feedback
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* group vars
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-21 21:29:34 +00:00