Aaron Craelius
9592f34cde
Fully remove StdTx usage in ante handler tests ( #6845 )
...
* WIP on removing StdTx from ante handler tests
* Fix recheck
* Fix basic_test
* Don't use StdTx in ante_test
* Use TxConfig sign mode handler in anteHandler
* Fix TestAnteHandlerAccountNumbers
* Amino don't panic
* Fix more tests
* All proto ante tests pass
* Fix last tests
* Amino register concrete
* Add tests
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-07-29 15:52:22 +00:00
Alexander Bezobchuk
ab664e9a43
Merge PR #6815 : Code & Doc Cleanup
2020-07-22 11:02:36 -04:00
Alexander Bezobchuk
0ccc48d2a3
CLI/Tests: Remove Fixtures ( #6799 )
...
* remove fixtures
* setup tests
* update x/mint
* cli: update x/staking commands
* tests: convert x/staking CLI tests
* tests: fix x/auth CLI tests
* cli updates
* fix buiild
* fix build
* Update x/gov/client/cli/cli_test.go
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* remove GenerateOrBroadcastTx
* move TestCLIQueryConn
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-07-21 13:54:07 +00:00
Amaury Martiny
5c0e3b4de5
x/auth/ante: Migrate tests to use the new client.TxConfig ( #6661 )
...
* WIP: using encoding config
* Make it compile, test fails
* test should be okay
* Make tests pass
* Add comments
* Convert more tests
* Make TestAnteHandlerSigErrors work
* Make first 2 tests pass
* TestAnteHandlerAccountNumbers
* Use table tests
* Remove print
* Use test table
* TestAnteHandlerSigErrors
* TestAnteHandlerAccountNumbers
* TestAnteHandlerAccountNumbers
* Refactor TestAccount
* Refactor getSignBytes
* TestAnteHandlerAccountNumbersAtBlockHeightZero
* TestAnteHandlerSequences
* TestAnteHandlerFees
* TestAnteHandlerMultiSigner
* TestAnteHandlerBadSignBytes
* TestAnteHandlerSetPubKey
* TestAnteHandlerSigLimitExceeded
* TestCustomSignatureVerificationGasConsumer
* TestAnteHandlerReCheck
* Make all tests pass
* Refactor a little bit more
* Fee test
* SetupTest
* All tests pass
* Refactor to RunTestCase
* Don't use StdFee
* Revert some little stuff
* Finish up last couple of test cases
* Less verbose
* s/TxGenerator/TxConfig
* Add comments
* Indent
* Move KeyTestPubAddr to testdata
* Move testdata to /testutil
* Revert to use signature: nil step in signing
* Add comments
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-20 08:30:12 -04:00
Alexander Bezobchuk
e7554bb3b0
Fix Gas Flag Usage + CLI Flag APIs ( #6685 )
...
* Use new APIs
* fix usage
* fix usage of gas flag
* tests: TestParseGasSetting
2020-07-11 08:13:46 +00:00
Alessio Treglia
a940214a49
testutil cleanup and reorg ( #6658 )
...
Prepare migrating testing auxiliary functions from tests
to testutil.
Remove local duplicates on testutil.WriteToNewTempFile().
Always favor testutil.NewTestCaseDir() over ioutil.TempDir().
Add test cases for the testing auxiliary functions.
2020-07-09 14:21:20 +02:00
Aaron Craelius
2f44fbf2ab
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT ( #6385 )
...
* Add TxWrapper, encoder, decoder and DirectModeHandler
* fix pkg name
* Update API and leave test TODO's
* Update TxWrapper API
* tests for tx wrapper (#6410 )
* WIP: added test for direct mode handler
* updated code
* Add msg
* Update TxWrapper API
* Fix pubkey declaration
* Add pubkey for tests
* Fix SetFee
* Remove logs
* Avoid global var declaration for tests
* Add test for GetPubKeys
* Fix direct signing tests
* Add more test cases for GetSignBytes
* Revert SetFee API
* Remove logs
* Refactor tests
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
* Refactoring
* Refactoring
* Integrate SignatureV2 API
* Fix wrapper tests
* Fix tests
* Linting and API tweaks
* Update API
* WIP on updating API
* Fix tests
* Update to new SigVerifiableTx
* Rename
* Update docs to reflect ADR 020
* proto-gen
* proto docs
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* Add tests
* Refactor and improving test coverage
* WIP on test coverage
* WIP on test coverage
* proto-gen
* Fix CompactBitArray.Size() bug
* Rename
* Remove Builder interface
* Address review comments
* Update x/auth/tx/sigs.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Address review feedback
* Fix build issues
* Resolve conflicts
* Fix ValidateBasic test coverage
* Add test for malicious multisig
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-06 17:03:45 +00:00
Jonathan Gimeno
8f96ec0585
REST bank transfers fail due to encoding. ( #6536 )
...
Bank module REST endpoint bank/accounts/{addr}/transfers
was returning invalid StdTx format.
2020-07-02 05:16:39 +02:00
Alexander Bezobchuk
d5049413ef
Merge PR #6525 : x/bank: Refactor CLI & Tests
2020-06-30 16:59:21 -04:00
Aaron Craelius
712d23740f
Migrate x/auth cmd's to TxGenerator marshaling ( #6391 )
...
* Migrate encode, decode, and broadcast cmd's to use TxGenerator marshal methods
* Fix tests, add EncodingConfig
* Add simapp/encoding.go and wire up with simcli
* add godocs
* fix tests
* Debugging CLI Tests
* Fix integration test
* 6391 - lint issues and code coverage (#6414 )
* fixed lint issue of "txEncodeRespStr"
* added tests for encode.go
* WIP: added tests for decode.go
* added txEncoder at bytes
* updated decode test
* updated txBytes to use TxEncoder in decoder test
* added a require after TxEncoder
* removed file save
* debug decode command
* fixed decode tests
* added decode cli
* updated encode and decode in a single file
* separated decode test from encode test
* review changes
* removed register interface
* review change
* Fix tests
* WIP add test for tx sign
* removed commented code
* Fix flags
* WIP add test for sign
* Address review suggestions
* fixed command issue
* Add tests for TxEncoder
* Revert sign changes
* Fix TxEncoder tests
* Fix GetSign Cmd
* Add tx test
* Remove duplicate validation
* Add tests for TxDecoder
* Fix tests
* Fix tests
* Output to clientCtx.Output
* Fix cli_tests
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-18 20:29:41 +00:00
Aaron Craelius
257354dbff
x/bank: convert query CLI commands to use gRPC query client ( #6367 )
...
* Convert x/bank query cli methods to use gRPC query client
* WIP on x/bank cli query migration
* lint
* Fix integration tests
* Remove Println in favor of updated PrintOutput
* Add PrintOutput tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-18 03:36:25 -04:00
Aaron Craelius
c13809062a
Update TxBuilder to use SignatureV2 ( #6443 )
...
* Update TxBuilder to use SignatureV2
* Fix unit tests
* Lint
* lint
* Cleanup
* Address review feedback
* Add Sign tests
* Add more cases for sign tests
* Fix lint
* Fix gofmt
* Deprecate StdTx
* Undeprecate StdTx, but leave a comment to use the protobuf Tx
* Address review comment
Co-authored-by: anilCSE <anil@vitwit.com>
2020-06-16 19:57:37 +00:00
dauTT
24b9be0ef8
x/bank: remove alias.go usage ( #6439 )
...
* x/bank: remove alias.go usage
* Fix simd_test.go
2020-06-14 23:06:16 +00:00
SaReN
39f53ac22f
client: rename CliContext to Context ( #6290 )
...
* Refactor CliContext as Context
* Fix lint issues
* Fix goimports
* Fix gov tests
* Resolved ci-lint issues
* Add changelog
* Rename cliCtx to clientCtx
* Fix mocks and routes
* Add changelog
* Update changelog
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* merge client/rpc/ro{ot,utes}.go
* Update docs
* client/rpc: remove redundant client/rpc.RegisterRPCRoutes
* regenerate mocks
* Update ADRs
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-01 12:46:03 +00:00
Aaron Craelius
850419fffd
Tx CLI proto module interface ( #5989 )
...
* WIP
* WIP
* WIP on removing x/auth dependency from client/tx
* Revert unneeded changes
* Simplify cli tx UX
* Wire up bank tx REST routes
* Fix assignment issue
* Wire up bank NewSendTxCmd
* fix lint
* revert file
* revert file
* fix simcli
* Refactor AccountRetriever
* Fix build
* Fix build
* Fix build
* Fix integration tests
* Fix tests
* Docs, linting
* Linting
* WIP on all modules
* Implement other module new tx cmd's
* Fix cmd's
* Refactor existing GetTxCmd
* Fix cmd
* Removing deprecated code
* Update ADR 020 & CHANGELOG
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Fix client/tx tests
* Fix mocks
* Fix tests
* Lint fixes
* REST tx migration
* Wire up REST
* Linting
* Update CHANGELOG, docs
* Fix tests
* lint
* Address review feedback
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* group vars
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-21 21:29:34 +00:00
Aaron Craelius
9a38883e9c
Merge PR #6258 : Fix test breakage and run proto-gen
2020-05-20 13:23:38 -04:00
Marko
bef3689245
linter: enable nolintlint ( #6162 )
...
* nolintlint enable
* remove space
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-05-08 08:46:12 +00:00
Alessio Treglia
2879c0702c
x/ibc: fix missing return statement ( #6099 )
...
* enable the wsl linter
Fix various wsl-related warnings.
x/ibc/04-channel/keeper/handshake.go: fix missing return statement in ChanOpenTry().
* goimports -w files
* remove unknown linter references
* run make format
* Revert "run make format"
This reverts commit f810b62b9e4993f08506663d4e5f2ec2228a9863.
* run make format
2020-04-29 22:36:34 -04:00
Aaron Craelius
cc90f2e002
Merge pull request #6085 : Move codec/std to std
2020-04-27 15:40:50 -04:00
Aaron Craelius
bb4642ad0d
Decouple client/tx from x/auth ( #5992 )
...
As part of #5864 part 2), this PR decouples the new client/tx
package from x/auth (as an incremental step to deprecating
all the tx logic in x/auth) and adds StdFee, StdSignature,
StdSignMsgBase and StdTxBase to codec/std, while
deprecating the corresponding types in x/auth.
2020-04-15 23:55:02 +02:00
Alessio Treglia
a1feca39c2
Enter the new keyring interface ( #5904 )
...
crypto/keyring:
`Keybase` interface gives way to its successor: `Keyring`. `LegacyKeybase`
interface is added in order to guarantee limited backward compatibility with
the old `Keybase` interface for the sole purpose of migrating keys across
the new keyring backends.
The package no longer depends on the `github.com/types.Config`
singleton.
`SupportedAlgos` and `SupportedLedgerAlgos` methods have been removed.
The keyring just fails when trying to perform an action with an unsupported
algorithm.
crypto/ subdirs reorganization:
`crypto/keys/hd` was moved to `crypto/hd`, which now groups together
all HD wallets related types and utilities.
client/input:
* Removal of unnecessary `GetCheckPassword`, `PrintPrefixed` functions.
* `GetConfirmation`'s signature changed to take in a io.Writer for better integration
with `cobra.Command` types.
client/context:
* In-memory keyring is allocated in the context when `--gen-only` flag is passed
in. `GetFromFields` does no longer silently allocate a keyring, it takes one as
argument.
Co-authored with @jgimeno
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
2020-04-08 11:38:28 +02:00
Alexander Bezobchuk
bc9949e383
Merge PR #5936 : Handle and return error on tx.SetMsgs
2020-04-06 10:24:40 -04:00
Alessio Treglia
ca19fbc5f8
types/rest: add convenience functions for error checking ( #5900 )
2020-04-01 09:50:22 +02:00
Aleksandr Bezobchuk
da400156c3
Fix tests
2020-03-26 12:50:39 -04:00
Aleksandr Bezobchuk
75412d00f8
Rename to Println
2020-03-25 15:17:12 -04:00
Aleksandr Bezobchuk
6a33b424a6
Do not sanitize memo
2020-03-25 15:15:43 -04:00
Aleksandr Bezobchuk
e950dd34aa
Error when keybase is nil during Sign
2020-03-25 15:12:39 -04:00
Aleksandr Bezobchuk
f4e6bd6ad7
Fix build
2020-03-25 14:30:42 -04:00
Aleksandr Bezobchuk
3e0cf99e81
Finish remaining x/bank REST handlers
2020-03-25 14:23:34 -04:00
Aleksandr Bezobchuk
d962526b70
Implement and use CLIContext.Print
2020-03-25 12:24:13 -04:00
Aleksandr Bezobchuk
70d0241373
tx tests
2020-03-24 19:07:27 -04:00
Aleksandr Bezobchuk
33c090ee17
Use auth instead of func interface
2020-03-24 18:56:20 -04:00
Aleksandr Bezobchuk
0f4473936d
Fix imports
2020-03-24 16:51:59 -04:00
Aleksandr Bezobchuk
8bb0cfdf6f
Use JSON for SimulationResponse
2020-03-24 16:45:34 -04:00
Aleksandr Bezobchuk
d4d4da4a6e
Implement client and factory
2020-03-24 16:36:12 -04:00
Aleksandr Bezobchuk
b0f784d8f9
Implement factory and remove tx generator from CLIContext
2020-03-24 15:55:52 -04:00
Aleksandr Bezobchuk
b557d4278f
Update CanonicalSignBytes godoc
2020-03-16 11:52:07 -04:00
Aleksandr Bezobchuk
98f62db242
Fix linting
2020-03-15 14:10:15 -04:00
Aleksandr Bezobchuk
c49af0b8dd
Update context
2020-03-13 13:59:14 -04:00
Alessio Treglia
73700df8c3
Merge PR #4555 : Move client/{tx,rest,utils} into x/auth/client
2019-06-15 14:34:11 +02:00
colin axner
c777fb9108
Merge PR #4505 : Support height queries in REST client
2019-06-07 09:02:07 -04:00
Alexander Bezobchuk
3180e68c7b
Merge PR #4499 : Remove Client Codec Redundancy
2019-06-06 11:43:15 -04:00
frog power 4000
5f9c3fdf88
Merge PR #4451 : Client and Module Modularization
2019-06-05 19:26:16 -04:00
frog power 4000
73e5ef7c13
reduce module interdependancy, /client refactor ( #4415 )
...
* abstract staking BuildCreateValidatorMsg, genutil defines its own flags
* client/ refactor
* staking move keys from keeper to types
2019-05-28 09:44:04 +01:00
Alessio Treglia
71d71f2206
Remove gaia ( #4347 )
...
Gaia is removed from cosmos-sdk repository.
Few changes were required to make sure no packages depend on gaia subpackages.
CI config is amended accordingly.
Unnecessary targets are removed from Makefile.
Simulations run through a lightweight version of gaia renamed to simapp.
Closes : #4104
2019-05-18 10:42:24 +02:00
Frank Yang
8bb2569abc
R4R: Fix /txs/encode endpoint ( #4212 )
...
Closes : #4141
2019-05-06 15:53:12 +01:00
Frank Yang
1cfc868d86
Support query txs' TotalCount in GET /txs ( #4214 )
...
Closes : #3942
2019-05-04 12:09:02 +01:00
Alexander Bezobchuk
0e54369850
Merge PR #4177 : Update Staking Validators Rest Query
...
* Support pagination and status query params for /staking/validators
* Rename BondStatusToString to String
2019-04-24 11:48:39 -04:00
Alessio Treglia
85021d4ca9
No packages must depend on cmd/gaia/ ( #4048 )
...
Preparation work for moving gaia out of the SDK.
2019-04-04 15:36:39 +01:00
Alexander Bezobchuk
e2928d5b70
Merge PR ##4007: Add Block Time in Txs Responses
2019-04-02 21:09:37 -04:00