Commit Graph

462 Commits

Author SHA1 Message Date
Sunny Aggarwal 50ed0fa1ae asdf 2018-07-09 00:35:28 -07:00
Christopher Goes 3805c35aff Merge pull request #1582: Simplify auth.StdSignMsg fields, add testcase
* Simplify auth.StdSignMsg

* Add StdSignMsg.Bytes() test
2018-07-06 19:26:22 -04:00
Ismail Khoffi abce54ea60
Merge branch 'develop' into sort_getsignbytes 2018-07-06 01:31:34 +01:00
Liamsi b7f902fba5 sort *all* GetSignBytes:
- call MustSortJSON before return JSON bytes to guarantee alphabetic
ordering

- moved SortJSON and MustSortJSON to types package to avoid cyclic
package dep
2018-07-06 01:12:57 +01:00
Liamsi 0f1ceb073e sort all relevant GetSignBytes:
- call SortJSON before return JSON bytes to guarantee alphabetic
ordering
2018-07-06 00:23:12 +01:00
Ethan Buchman 586ab68b2a
Merge pull request #1490 from cosmos/dev/improve_send_error_msgs
gaiacli: Improve error messages for `send` command
2018-07-05 17:22:16 -04:00
Alexander Bezobchuk 0b9e0f2afc Merge PR #1492: Improve Module Test Coverage
* Merge pull request #1492: Improve Module Test Coverage
* Revert renaming of SignCheckDeliver [#1492]
* Remove named fields from stake unit tests & fix comments [#1492]
* update for tmlibs->tendermint/libs
* Remove tmlibs dependency
2018-07-04 06:21:36 +02:00
Ethan Buchman f78f30c67a update for tm v0.22.0. tmlibs->tendermint/libs 2018-07-02 16:34:06 -04:00
ValarDragon 819eedd281 gaiacli: Improve error messages for `send` command
Now provides better error messages when the account you're sending
from has no money, or it has insufficient funds. (Avoids making
the user interpret ABCI errors)

closes #1489
2018-06-30 01:32:01 -07:00
Dev Ojha 955a0c9af7 Switch asserts to require (#1483)
* meta: Switch the majority of asserts to require

Switch most assert statements to require, to ease debugging.
Closes #1418

* Fix imports
2018-06-30 03:10:15 +02:00
Dev Ojha 097dd8a164 tools: Add unparam linter (#1443)
* tools: Add unparam linter

unparam detects unused parameters in functions, and a parameter to
a function which only ever takes on one value. The latter is an
indication that more tests are required.

There are many nolints in this PR, as I believe that writing tests
to fix alot of these situations is out of scope for this PR / it
will be changed in future commits. There are some nolints for
when we have to comply to normal api's.

* crypto/keys no longer used by x/gov/client/rest/rest.go
2018-06-29 18:22:24 -04:00
Christopher Goes 59aadf42aa
Ledger integration (#931)
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK
Adds support for Ledger into gaiacli
Cherry-picks updated error handling from #1158
2018-06-29 02:54:47 +02:00
Dev Ojha ac3adff1e8 Merge PR #1438: Tools: Add errcheck linter
This linter ensures that all errors are checked.
This is disabled in the client directories, since its not needed on
those writes
2018-06-29 00:52:10 +02:00
Dev Ojha 49f421db19 Merge PR #1332: benchmarks: Add benchmark for block time to bank module
* benchmarks: Add benchmark folder, and single benchmark for block time
* Move benchmark into module
* Fix merge conflict errors
* Fix spelling
* Add instructions to run benchmark
* Update auth_app_test.go
2018-06-28 00:33:56 +02:00
Christopher Goes 8bdf06b9f6 Remove Viper from ante handler 2018-06-26 23:45:31 +02:00
Dev Ojha 893bb4027d Merge PR #1377: types: remove GetMemo from Tx
This method is an unneccessary requirement on Tx. Auth casts the Tx
to StdTx, so the memo can be obtained in previous usecases from
StdTx. This also makes it more clear for when something is
implementing StdTx vs Tx.

Resolves #1375
2018-06-26 04:37:21 +02:00
Dev Ojha 2e97baabf6 Merge PR #1358: Fix typos and gofmt files
* Fix typos
* gofmt -s files
* Add mispellings and gofmt checks to circle CI
* circleci: Install misspell in the linting step
2018-06-25 20:23:17 +02:00
Sunny Aggarwal c3c570898d Merge PR #1340: Reverted ChangePubKey
* removed msgChangePubKey
* changelog
* removed setPubKey
2018-06-22 21:53:24 +02:00
Joon ec6acda6a4 Merge PR #1331: Remove TxBytes from NewContext 2018-06-22 03:03:05 +02:00
Sunny Aggarwal dc2c8f900b Merge PR #1168: Governance MVP 2018-06-22 02:19:14 +02:00
Aditya f049a56376 Merge PR #1266: Multiple messages
* Started work on multiple msgs, types and x/auth tests pass
* Fix issues in x, examples, and baseapp
* Added baseapp tests for multiple msgs
* Documentation fixes
* Fix baseapp tests with sdk.Int
* Modify test
* Transaction handling is now atomic
* Fix test comment
* Minor doc fixes and code cleanup
* Added baseapp result changes
* Use address in validator update accumulation
* Started work on multiple msgs, types and x/auth tests pass
* Fix issues in x, examples, and baseapp
* Added baseapp tests for multiple msgs
* Documentation fixes
* Fix baseapp tests with sdk.Int
* Modify test
* Transaction handling is now atomic
* Fix test comment
* Minor doc fixes and code cleanup
* Added baseapp result changes
* Use address in validator update accumulation
* Added ante tests for multisigner
* Remove validatorUpdates from tx result
* Better error logs
* Put Memo in StdSignBytes and formatting
* Updated changelog
2018-06-22 00:05:25 +02:00
Dev Ojha e2d23040a8 Merge PR #1325: Refactor Complete Setup to not take in a testing parameter
* Refactor Complete Setup to not take in a testing parameter
* Update changelog
2018-06-21 18:55:08 +02:00
Christopher Goes 918e217e1f
Merge PR #1280: Implement simple transaction memos
* AltBytes -> Memo, memo CLI support & thread-through
* Check memo size, update changelog
* Update existing testcases
* Nuke CircleCI caches
* Charge gas proportional to memo size
* Fix gas allocations in ante handler testcases
* Add testcases
* Update changelog
* Fix tiny CLI bug & add to CLI tests
* Add '--memo' to gaiacli
* Add testcase for large memos
* Address PR comments
2018-06-20 21:27:36 +02:00
Joon 314b5a854d Merge PR #1218: sdk.Int in sdk.Coin
implement Int, Int256, Uint256
pass ci
pass ci
add to changelog, add boundcheck to test
add comments, fix cli_test.go
fix errors
apply requested changes
panics on New*WithDecimal
fix Int.BigInt()
fix stake tests
* Panic on uint division-by-zero
* Set ok=false on NewIntFromString, NewUintFromString failure
* Nuke CircleCI caches
2018-06-15 23:16:45 +02:00
Fabian 42e72956f4 Merge PR #1252: Query node version
introduce non store queries
add version query
update lcd spec
changelog
moved version query into baseapp
2018-06-14 07:49:21 +02:00
David Kajpust ec2fedd36c Merge PR #1227: Set all Error strings 1st letters to lowercase. Fixes issue #1154 2018-06-13 21:13:22 +02:00
Christopher Goes 5bf58ee444
Merge PR #1210: Fix testcases (another fast-forward merge issue) 2018-06-12 09:47:59 +02:00
Rigel dc62279ae1
Merge pull request #1200 from cosmos/cwgoes/slashing-bugfixes
Slashing bugfixes (start height, handler registration)
2018-06-11 20:12:02 -07:00
Sunny Aggarwal 161cb474d4 Account Numbers for Replay Protection with Account Pruning (#1077)
* in progress
* passes current tests
* added tests and got working
* changelog and docs
* removed prints
* oops
* works!
* issue in test_cli
* number 9 number 9 number 9
* at least it does only the 9 issue now
* hallelujah it works!
* removed print statement
* rebased
* gah
2018-06-12 04:30:54 +02:00
Fabian 8ece807301 Merge PR #1085: Re-enable tx history in LCD
* reenable tx search
* removed not needed argument
* register types for decoding
* trying to fix indexing tests
* added tx hash query test
* Fix x/bank tagging
* remove dead code
* remove print
* extended tests for tx querying
* changelog
* added txs address querying
* linted
* rename
* use prefix for bech32 addresses in tags
* changed error message
* Fix tiny linter issue
2018-06-11 22:09:29 +02:00
Christopher Goes b9c1bcbd74
Tiny linter fix 2018-06-11 03:22:38 +02:00
Christopher Goes a4865ef6aa
Add mock.SignCheck, update testcase to assert error code 2018-06-11 03:14:20 +02:00
Dev Ojha 9c4bbf7dfd Merge PR #1195: gaiacli - Add error message for when account isn't found 2018-06-09 08:40:22 +02:00
Rigel 0b9751ac98
Merge pull request #1170 from cosmos/rigel/test_framework
mock test framework for modules
2018-06-08 13:30:24 -07:00
rigelrozanski 6af81fc62e cleanup 2018-06-08 13:13:51 -07:00
rigelrozanski 17948ccf04 auth-mock simulate block now commits, stake app_test cleanup 2018-06-08 11:28:07 -07:00
rigelrozanski 42def02ae9 pr comments 2018-06-08 10:03:37 -07:00
rigelrozanski b5d847288d move original mock into server 2018-06-07 21:33:06 -07:00
rigelrozanski abab7c2e42 modules test within mock application 2018-06-07 20:55:14 -07:00
Christopher Goes 34ec53a761
Update CHANGELOG.md, update x/auth to avoid base64 2018-06-08 01:50:59 +02:00
Fabian 5f409ce832 Merge PR #1086: Bech32Cosmos output/input for the LCD
* refactored bech32ization
* updated keys endpoints for bech32
* bech32 for sending and querying
* trying to change output of validator addresses
* fixed validator output
* linted
* fixed merge conflict
* added bech32 to staking endpoints
* removed some logging statements
* added GetAccPubKeyBech32Cosmos
* fixed cli tests
* updated swagger
* merged standard bech32 change
* renamed bech32cosmos to bech32
* bech32ify json output for key add
* readded changelog
* fixed changelog merge issue
* Update CHANGELOG.md
2018-06-06 06:53:04 +02:00
Zaki Manian ce850dca3b Switch from bech32cosmos to bech32 2018-06-01 16:23:58 +02:00
Christopher Goes 12a7c0373a
Merge pull request #1072 from ValarDragon/dev/tx_encoding
Change to go-wire UnmarshalJSON for bank transactions
2018-05-31 23:51:27 +02:00
ValarDragon 0371109039 Register crypto on amino codecs, update changelog 2018-05-31 12:55:21 -07:00
ValarDragon e9545d69ed Switch the default modules to use wire.codec's MarshalJSON instead of json.Marshal 2018-05-31 11:51:15 -07:00
Zaki Manian f33f49a840 Almost from scratch reimplementation of bech32cosmos integration. 2018-05-27 13:47:23 +02:00
Sunny Aggarwal bf02cdcf97 address Chris review 2018-05-25 21:14:49 -07:00
Sunny Aggarwal 4f6c77d8cb antehandler tests 2018-05-25 21:10:09 -07:00
Sunny Aggarwal f81a70b315 added keeper tests 2018-05-25 20:48:27 -07:00
Sunny Aggarwal d3bdb09ffc passes, needs tests 2018-05-25 20:29:40 -07:00
sunnya97 5d7c3af1b8 works 2018-05-23 22:09:01 -07:00
sunnya97 56d1c48812 in progress 2018-05-23 19:49:35 -07:00
sunnya97 cb52712660 in progress 2018-05-23 19:49:35 -07:00
rigelrozanski e70249b631 more bucky comments, single status validator, only one store now for core validator object 2018-05-20 17:39:04 -04:00
rigelrozanski 26be2a231b working addressed bucky comments 2018-05-18 18:57:47 -04:00
rigelrozanski e145676fcc revert absent validator changes 2018-05-17 10:47:25 -04:00
rigelrozanski 750cbc53ec stake cleanup, functionality for total prevote power 2018-05-17 09:17:14 -04:00
rigelrozanski d871605241 staking fee distribution working commit 2018-05-17 09:15:06 -04:00
Ethan Buchman 4bdcad572b remove gasLimit from NewContext 2018-05-15 22:19:09 -04:00
Christopher Goes 4134bf922c
Address PR comments 2018-05-16 02:06:17 +02:00
Christopher Goes 4775437426
Unexport verifyCost 2018-05-16 01:15:22 +02:00
Christopher Goes 38716d5edc
ConsumeGas for pubkey.VerifyBytes 2018-05-16 01:14:31 +02:00
Christopher Goes 1c4ed7b833
Gas-wrap ctx.KVStore 2018-05-16 01:13:48 +02:00
Christopher Goes 26991803ee
GasMeter & context updates 2018-05-16 01:13:47 +02:00
Christopher Goes c81e37ce7a
Return tags on changePubkey 2018-05-15 23:40:01 +02:00
Sunny Aggarwal ea6d3e8efc should work maybe? 2018-05-15 16:52:30 -04:00
Christopher Goes 62fc3e2c49
Context-accessible logger field 2018-05-01 13:52:49 +02:00
Sunny Aggarwal 9f4f35a6db
removed Get from account 2018-05-01 00:15:27 +02:00
Sunny Aggarwal fdb610bea7
updated documentation 2018-05-01 00:15:27 +02:00
Sunny Aggarwal 754481af2c
got rid of Get on Msg interface 2018-05-01 00:15:27 +02:00
Sunny Aggarwal ee2800ff6d
updated documentation 2018-05-01 00:15:27 +02:00
Sunny Aggarwal af0e71fa0d
got rid of Get on Msg interface 2018-05-01 00:15:15 +02:00
rigelrozanski 10ddd7a3d3 refactor export function, working 2018-04-27 20:06:50 -04:00
Christopher Goes ad77affb53 Add IterateAccounts & account export 2018-04-27 20:04:29 -04:00
rigelrozanski 260ab69e4f cleanup, move simplestaking to democoin 2018-04-26 22:59:30 -04:00
rigelrozanski 556896679a ... 2018-04-26 14:26:39 -04:00
Christopher Goes 5b4fb85f7e
Fn suffix & http.HandlerFunc 2018-04-25 22:32:22 +02:00
Christopher Goes fd40d39556
Only one CoreContext for all REST commands 2018-04-25 16:49:31 +02:00
Christopher Goes 56ac948dc6
REST folder restructure & cleanup 2018-04-25 16:18:06 +02:00
Sunny Aggarwal 016a1c8ec9 removed seal 2018-04-22 23:36:15 -07:00
rigelrozanski d28efaac27 many renames / golint compliance 2018-04-19 00:49:24 -04:00
Christopher Goes f8e44b5b00 Error codespacing (#809)
* Initial codespacing layout (ref #766)
* Add codespace to Router (ref #766)
* Implement Codespacer and update modules
* Default codespaces, testcases
* Update error formatting, codespacer tests
* Add RegisterOrPanic testcase
* Update CHANGELOG
2018-04-17 19:16:21 -07:00
Christopher Goes 474fa1dfd1
Switch to BurnFeeHandler 2018-04-17 01:06:07 +02:00
Christopher Goes 3bbb15f454
Add tx to feeHandler, move around in example apps 2018-04-16 14:58:19 +02:00
Christopher Goes 39ee95abe4
Refactor to use FeeHandler function 2018-04-16 14:15:03 +02:00
Christopher Goes 7fafa9e021
Add testcases 2018-04-16 14:00:01 +02:00
Christopher Goes e870163ec0
Implement fee pool pseudo-account in sdk.AccountMapper 2018-04-16 13:59:56 +02:00
Ethan Buchman f5c285f5ee more MarshalJSONIndent 2018-04-09 23:18:56 +03:00
Ethan Buchman 1860f988b6 fix tests 2018-04-07 20:56:49 +03:00
Jae Kwon c4bc888375 Fix almost all tests 2018-04-07 00:02:00 -07:00
Jae Kwon 49fdf80d9d WIP commit 2018-04-06 17:25:08 -07:00
Christopher Goes 12f4a21d03
Reuse Tendermint client instance (closes #671) 2018-04-03 22:16:03 +02:00
Christopher Goes 7214149f1d
Move client context initialization from viper to separate package 2018-04-03 22:16:03 +02:00
Christopher Goes 579e5d4cdc
Add CoreContext for CLI/REST options 2018-04-03 22:15:12 +02:00
Christopher Goes 720b37c6f2
Rename client/builder to client/core (ref #721) 2018-04-03 22:14:11 +02:00
rigelrozanski c1d8aefecd testing staking
...

...
2018-03-28 19:01:50 +02:00
Christopher Goes 578392d4b2 Address Rigel review - also run gofmt 2018-03-28 11:24:31 +02:00
Ethan Buchman 723889570e ErrTxParse->ErrTxDecode; check for empty bytes in account and tx 2018-03-21 02:44:17 +01:00
Ethan Buchman c529eccc6e parser -> decoder 2018-03-21 02:28:15 +01:00
Ethan Buchman e4b8010077 ParseAccount -> AccountDecoder 2018-03-21 02:22:15 +01:00
Ethan Buchman 984aff12da
Merge pull request #642 from cosmos/sunny/errors
move some errors to sdk from bank
2018-03-19 22:37:30 +01:00
Sunny Aggarwal 3e91e12a2f moved errors to sdk from bank 2018-03-18 03:42:54 +01:00
Ethan Buchman 64852138b6 fix the tests. includes some hacks 2018-03-18 02:02:26 +01:00
Ethan Buchman 683663f680 fixes post rebase 2018-03-17 23:09:04 +01:00
Fabian Weber cf6f04978c adjusted sending + tx tests 2018-03-17 22:17:56 +01:00
Fabian Weber 1cd6ec1084 most tests working 2018-03-17 22:14:19 +01:00
Fabian Weber 579bd56127 fixed some tests 2018-03-17 22:14:19 +01:00
Fabian 0121c98a1e add /accounts endpoints but failing 2018-03-17 22:14:19 +01:00
Ethan Buchman 7c3213fa00 fixes from review 2018-03-17 22:08:19 +01:00
Ethan Buchman 2ed4de5e8d shame: forgot x/auth/context_test.go 2018-03-17 21:40:44 +01:00
Ethan Buchman dd4a86b856 x/auth: crank the test coverage 2018-03-17 21:20:24 +01:00
Ethan Buchman 3babf8c2d9 fix and clean fees and x/auth 2018-03-17 19:54:18 +01:00
Matt Bell 6dc46064cb Started on fee tests 2018-03-17 18:34:57 +01:00
Matt Bell 1b16f0c684 Deduct fee from fee payer's account balance 2018-03-17 18:34:06 +01:00
Ethan Buchman 45f8ccbe90 x/auth: cleanup ante handler 2018-03-17 18:34:06 +01:00
Yukai Tu aee516f595 Fix auth handler public key issue 2018-03-16 17:57:28 -07:00
Ethan Buchman 20e2c24f9d x/auth: ante_test.go 2018-03-13 01:42:13 +01:00
Ethan Buchman 1955e3436f x/auth: mapper_test.go 2018-03-13 01:42:13 +01:00
Ethan Buchman 661d0fd7e8 types: StdSignDoc includes sequence for each sig 2018-03-13 01:42:13 +01:00
Ethan Buchman a05ea5fcc9 implement replay protection 2018-03-13 01:42:13 +01:00
Ethan Buchman 9b8db6b37c x/auth: clean up ante handler 2018-03-13 01:42:13 +01:00
rigelrozanski b68500e948 ... 2018-03-05 00:45:31 +00:00
rigelrozanski 9349d95cd9 add some unmarshal panics 2018-03-04 17:24:23 +00:00
rigelrozanski b6347db664 refactor client 2018-03-04 17:21:37 +00:00
Ethan Buchman 630a5fe579 revert to old go-wire 2018-03-02 04:24:07 -05:00
Ethan Buchman 62d6a5de46 crypto.Address -> sdk.Address 2018-03-02 02:49:07 -05:00
rigelrozanski 0469358286 rebase fixes 2018-03-01 03:17:48 +00:00
rigelrozanski 3be46395cf restructure to remove deps on example 2018-03-01 02:36:57 +00:00
Ethan Buchman c31f871de6 finish removing TestApp and TestTx 2018-02-17 16:32:30 -05:00
rigelrozanski 1555c4876e pretty good refactor 2018-02-17 16:32:30 -05:00
rigelrozanski 938ee94e9e WIP refactor working 2018-02-17 16:32:30 -05:00
rigelrozanski 6681904af9 wip refactoring basecoin 2018-02-17 16:32:30 -05:00
rigelrozanski 44536faf08 wip refactoring basecoin 2018-02-17 16:32:30 -05:00
Adrian Brink 8837af66bd Refactor CoinMapper
CoinMapper is now called CoinKeeper to differentiate it from
AccountMapper. A Mapper retrieves things from a store. A Keeper exposes
functionality of coins and maintain invariants.

bank.NewHandler takes a CoinKeeper instead of the entire AccountMapper.
2018-02-13 13:33:19 -05:00
Jae Kwon b95b67d520 Separation of Tx from Msg; CodeType 2018-01-26 06:54:03 -08:00
Jae Kwon 05036e35d2 CacheWrap after AnteHandler 2018-01-26 06:54:03 -08:00
Jae Kwon c6bad0b325 Add first Basecoin test harness 2018-01-26 06:54:03 -08:00
Jae Kwon be665d53fe Substore->Store; BaseApp has db; Mapper 2018-01-22 06:20:46 -08:00
Jae Kwon 6be2532459 wire.UnmarshalBinary expects a pointer to struct, never a pointer pointer 2018-01-21 20:58:52 -08:00
Jae Kwon 561da6353f x/auth/Account -> x/auth/BaseAccount; RegisterWireBaseAccount() 2018-01-20 22:10:41 -08:00
Jae Kwon bd8bbf9d98 BasecoinApp init refactor 2018-01-20 19:06:29 -08:00
Jae Kwon 8fda920de0 auth.AccountStore assumes go-wire; Remove GetTxBytes() from Tx 2018-01-20 18:11:38 -08:00
Ethan Buchman 6d3b5cb402 basecoin: fix codecs, add some tests 2018-01-20 18:11:38 -08:00
Jae Kwon 14a0dce920
Refactor basecoin example (#332)
Refactor basecoin example
2018-01-17 16:59:40 -08:00
Ethan Buchman d74f491072 x/auth: fix test 2018-01-17 19:42:05 -05:00
Ethan Buchman 1b82ff7a9a x/auth: fix test 2018-01-15 20:19:39 -05:00
Ethan Buchman 381424460c basecoin compiles 2018-01-14 22:49:57 -05:00
Ethan Buchman 5f76febce8 auth and bank compile 2018-01-12 19:17:17 -08:00
Jae Kwon fcd8e88e65 Fix x/coin imports 2018-01-12 19:17:17 -08:00
Jae Kwon ba2b4f0f21 WIP: refactor
Refactor

* No more decorators, but rather types.AntiHandler
* No more handlers, but rather types.MsgHandler
* Ability to pass "stores" in NewXYZHandler()
* Coins live in types, and Accounts have coins
* Coinstore -> bank
2018-01-12 19:17:17 -08:00
Jae Kwon 51e6144c0d Initial commit for permissioning... 2018-01-12 19:17:17 -08:00
Ethan Buchman e908cfbb6f move account back to types 2018-01-09 19:11:00 -08:00
Ethan Buchman 3ba3d6b02f move coins and accounts out of types 2018-01-09 19:11:00 -08:00
Ethan Buchman 1d07f88867 new basecoin example 2018-01-03 20:20:21 -05:00
Ethan Buchman a9b2636439 Coin (#312)
* wip: tests and fixes for kvstore iteration
* update for latest tmlibs
* types compiles
* x/coin almost compiles
* x/coin: move things out of the way so it builds
* rebase fixes
* update glide
* add test for ChainDecorators
2017-12-21 03:31:33 -08:00
Jae Kwon 6e8e4331ea ... 2017-11-26 20:29:17 -08:00
Jae Kwon fdc7834dae Bare auth 2017-11-25 01:36:45 -08:00
Jae Kwon 83b43f3378 delete auth/tx 2017-11-09 01:19:07 -05:00
Jae Kwon 7750a698f9 Add basic types Account and Msg 2017-11-03 16:43:04 -05:00
Jae Kwon df325ceaef Move docs 2017-10-31 18:02:16 -05:00
Jae Kwon 561d77cae0 remove errors module 2017-10-31 17:58:12 -05:00
Jae Kwon 8d305039c8 modules -> x 2017-10-31 17:51:44 -05:00