Commit Graph

1664 Commits

Author SHA1 Message Date
Federico Kunze fe695b8f7b Merge PR #4460: Gov Keys and Iterators
* refactor gov keys

* iterators and renamings

* invert queue key order

* changelog

* fix tests

* update alias.go

* Apply suggestions from code review

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

* rename keys

* rename functions

* Apply suggestions from code review

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

* address Aleks' comments

* fix test

* address Karoly's comments
2019-06-04 11:38:11 -07:00
colin axner 6e2f5f3102 R4R: Support "unknown commands" for subcommands (#4465)
Fixes #4284
Now prints:

gaiacli query distr comission --trust-node cosmos1234
ERROR: unknown command "comission" for "distr"

Did you mean this?
	commission

Adds custom argument validation for subcommands with subcommands. Doesn't affect "query" or "tx" subcommands since they reside in gaia repo. All flags except help are disabled for these commands.
2019-06-04 18:07:12 +01:00
Frank Yang 30550257a7 Merge PR #4456: Using `QueryWithData` to query unbonding delegations 2019-06-04 08:05:44 -04:00
colin axner 9c049321a1 Merge PR #4466: Lazy commission validation 2019-06-03 17:14:21 -04:00
4ever9 59ac148061 Merge PR #4469: refactor(querier): use err for return 2019-06-03 09:31:51 -04:00
Alexander Bezobchuk d204afbdae
Merge PR #4461: Port advisory patch to master 2019-05-31 11:14:40 -04:00
Alexander Bezobchuk 2414413e0b
Merge PR #4448: Implement Gov EndBlocker Failed Handler Test 2019-05-30 14:31:35 -04:00
frog power 4000 73e5ef7c13 reduce module interdependancy, /client refactor (#4415)
* abstract staking BuildCreateValidatorMsg, genutil defines its own flags

* client/ refactor

* staking move keys from keeper to types
2019-05-28 09:44:04 +01:00
Joon 91e75cb74a Merge PR #4403: Paramchange proposal skips omitempty fields 2019-05-27 20:47:12 -04:00
frog power 4000 38f49e4114
Merge PR #4389: stake invariance bug
* add trouble seed

* currentStakeRoundUp is now always atleast currentStake + smallest-decimal-precision

* remove unused code

* remove debugs

* @alexanderbez comment

* compile fix

* better comment, increase tolerance to 3 smallest decimal points
2019-05-24 21:23:53 -04:00
Juan Leni 68036ec71f Merge PR #4384: allow splitting withdrawal txs
* allow splitting withdrawal txs

* updating .pending

* small cleanup

* fixing build issue

* Update x/distribution/client/cli/tx.go

Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>

* updating usage text

* fixing merge issue

* changes based on the review

* adding unit tests

* Update x/distribution/client/cli/tx.go

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

* adjustments from review
2019-05-23 19:00:26 -04:00
Alexander Bezobchuk 4f197ff904
Merge PR #4396: Use TxSigLimit instead of default constant value 2019-05-23 14:08:51 -04:00
Alexander Bezobchuk 40518cb655
Merge PR #4395: Improve sig verification error message 2019-05-23 09:45:03 -04:00
Alexander Bezobchuk 80767474d7
Merge PR #4398: Refactor genaccounts genesis state 2019-05-22 17:06:49 -04:00
Christopher Goes dd89c32951 Community pool spend proposal (#4329)
Implement the "CommunityPoolSpendProposal" as described in Cosmos Hub proposal 7.

Also a useful test of Git flow for merging features passed in governance proposals.
2019-05-21 11:02:10 +01:00
Sunny Aggarwal cca3c3cbf2 Merge PR #4374: Don't Burn Deposits for Rejected Governance Proposals Unless Vetoed 2019-05-20 10:13:50 -04:00
frog power 4000 d9ac7d7c33 Merge PR #4349: Autogen alias files 2019-05-20 09:13:32 -04:00
Alexander Bezobchuk cfe31c4090
Merge PR #4372: Use Build's Client/Server Name 2019-05-18 19:06:08 -04:00
Alessio Treglia 71d71f2206
Remove gaia (#4347)
Gaia is removed from cosmos-sdk repository.

Few changes were required to make sure no packages depend on gaia subpackages.

CI config is amended accordingly.

Unnecessary targets are removed from Makefile.

Simulations run through a lightweight version of gaia renamed to simapp.

Closes: #4104
2019-05-18 10:42:24 +02:00
Nicolas Pinto f0b690ba6e Merge PR #4366: Random Fuzzer fix: avoids VotingPeriod=0 2019-05-17 19:46:43 -04:00
frog power 4000 cef788042b Merge PR #4365: Simulator bugfix for multisim 7601778 2019-05-17 19:45:36 -04:00
Nicolas Pinto fd9f322b8c Merge PR #4363: invalid 0stake deposit amount in sim
This fixes the "panic: Governance deposit amount must be a valid sdk.Coins amount, is 0stake" that can happen in the simulator if `DepositParams/MinDeposit` samples the integer `0`.
2019-05-17 16:51:55 -04:00
Alessio Treglia ca4363ffb7 Merge PR #4351: remove x/ dependency on cmd/gaia
* remove x/ dependency on cmd/gaia

This is an alternative patch to what is proposed in #4348

* Add pending entry

* Ditto for CollectGenTxsCmd

* Update pending

* Update tests

* Update pending
2019-05-16 21:34:54 -04:00
frog power 4000 5b7690e5e9
Merge PR #4346: report card minor fixes
* report card minor fixes

* fix
2019-05-16 21:32:20 -04:00
frog power 4000 3fe5869148
Merge PR #4159: Module/Genesis Generalization
* first commit

* gaia cleanup

* ...

* staking multihooks

* missing module function return args

* bank module name constant

* working, module interface for x/

* got this thing compiling

* make test compiles and passes

* remove expanded simulation invariants

* genesis issue

* continued

* continued

* register crisis routes thought mm

* begin blocker to mm

* end blocker to mm

* empty routes not initialized

* move gaia initChainer sanity check to baseapp

* remove codecs from module manager

* reorging genesis stuff

* module manager passed by reference/bugfixes from working last commit

int

int

* move invariant checks from gaia to crisis

* typo

* basic refactors cmd/gaia/init

* working

* MultiStakingHooks from types to x/staking/types

int

* default module manager order of operations from input modules

* working

* typo

* add AppModuleBasic

* moduleBasicManager / non-test code compiles

* working attempting to get tests passing

* make test passes

* sim random genesis fix

* export bug

* ...

* genutil module

* genutil working

* refactored - happy with non-testing code in cmd/

* ...

* lint fixes

* comment improvement

* cli test fix

* compile housing

* working through compile errors

* working gettin' compilin'

* non-test code compiles

* move testnet to its own module

* reworking tests

int

* bez staging PR 1 comments

* concise module function-of names

* moved all tests from genesis_test.go to other genutil tests

* genaccounts package, add genutil and genaccounts to app.go

* docs for genutil genaccounts

* genaccounts iterate fn

* non-test code with genaccounts/ now compiles

* working test compiling

* debugging tests

* resolved all make test compile errors

* test debuggin

* resolved all unit tests, introduced param module

* cli-test compile fixes

* staking initialization bug

* code comment improvements, changelog entries

* BasicGaiaApp -> ModuleBasics

* highlevel explanation in types/module.go

* @alexanderbez comment revisions

* @fedekunze PR comments

* @alexanderbez PR comments (x2)

* @cwgoes comments (minor updates)

* @fedekunze suggestions

* panic on init with multiple validator updates from different modules

* initchain panic makes validate genesis fail

int

* AppModuleGenesis seperation

int

* test

* remove init panic logic in validate genesis replaced with TODO

* set maxprocs to match system's GOMAXPROCS

* Update circleci

* Cap maxprocs in CI to 4

* @alexanderbez recent comments addressed

* less blocks in twouble sims

int

* runsim error output flag

* -e on import_export as well

* error out

int

* Try to fix failures

* runsim
2019-05-16 11:25:32 -04:00
Alexander Bezobchuk 44f972584d
Merge PR #4333: Remove Shares from Client Responses 2019-05-15 10:44:47 -04:00
Alessio Treglia 262c752863
Fix AppendTags usage error (#4336)
Fix AppendTags usage error

Thanks: @mjackson001 for the bug report and patch (original PR: #4274)
Closes: #4273
2019-05-14 16:13:18 +01:00
Frank Yang 7558f76079 Merge PR #4321: Improve offline flag doc 2019-05-13 10:51:48 -04:00
Alexander Bezobchuk 925070ae38
Merge PR #4292: Fix Signing Infos Endpoint 2019-05-09 13:38:15 -04:00
Alexander Bezobchuk 85ffce5f58
Merge PR #4306: Allow generate-only to fully operate offline 2019-05-08 16:06:05 -04:00
Alessio Treglia 06f7b2198a
Replace vet with golangci lint govet (#4277)
Drop go vet in favor of golangci-lint govet check.

Fix golangci-lint warnings.

Upgrade golangci-lint.
2019-05-06 17:50:05 +01:00
Frank Yang 1cfc868d86 Support query txs' TotalCount in GET /txs (#4214)
Closes: #3942
2019-05-04 12:09:02 +01:00
Alexander Bezobchuk 29ed730aff
Merge PR #4244: Param Proposal Simulation Messages; Minting Params Fix 2019-05-02 16:50:01 -04:00
Aaron Craelius 114de631a5 Allow custom key types and address formats (#4232)
Add additional parameter to NewAnteHandler for custom SignatureVerificationGasConsumer (the existing one is now called DefaultSigVerificationGasConsumer).

Add addressVerifier field to sdk.Config which allows for custom address verification (to override the current fixed 20 byte address format).

DefaultSigVerificationGasConsumer now uses type switching as opposed to string comparison.
Other zones like Ethermint can now concretely specify which key types they accept.

Closes: #3685
2019-05-02 20:36:42 +01:00
Alexander Bezobchuk 67f1e12eec
Merge PR #4253: Change User Supplied Param Change Value to json.RawMessage 2019-05-02 14:21:35 -04:00
Alexander Bezobchuk 5653c768bb
Merge PR #4234: Allow tx send (generate-only) to actually work offline 2019-04-30 12:47:26 -04:00
Alexander Bezobchuk 5ca93ac574 Merge PR #4206: Param Change Proposal
* Add params error types

* Update param module keeper to take a codespace

* Update imports

* Implement SetRaw and SetRawWithSubkey

* Implement ParamChange and update aliases

* Add types codec

* Implement ParameterChangeProposal

* Implement TestParameterChangeProposal

* Fix linting errors

* Update tags

* Implement content

* Updata params aliases

* Finish params handler and proposal types

* Move deposit and vote logic to types package

* Move proposal type to types package

* Move errors to types package

* Update proposal

* Move gov messages to types package

* Minor updates to naming

* Move keys to types package

* Move codec to types package

* Move proposal types to types package

* Update aliases

* Add governance alias types

* Implement governance router

* Update gov aliases

* Update gov keeper

* Update private functions needed for the keeper

* Update godocs

* Update the gov message handler

* Update Gaia app

* Make updates to auth

* Update the message codec in the keeper

* Update gov end blocker

* Update types tests

* Minor tweaks

* Add legacy genesis logic

* Update gov aliases

* Move gov keys to types package

* Revertt to using gov/types in params

* Implement params handler test

* Update governance tests

* Fix endblocker tests

* Fix governance querier tests

* Add seal support to gov router

* Update simulationCreateMsgSubmitProposal

* Disable software upgrade proposals

* Move params keys to types package

* Implement param module proposal client logic

* Update gov client logic

* Update gaia app client hooks

* Fix linting errors

* Fix ValidateBasic

* Remove legacy files

* Update paramchange to use strings

* Update paramchange cli cmd

* Update ValidateBasic and errors

* Use PostCommands when adding child cmds

* Fix codec logic

* Update params client and handler

* Update IsValidProposalType

* Update SubmitProposal to test exec

* Implement TestGaiaCLISubmitParamChangeProposal

* Implement TestSubmitParamChangeProposal

* Update swagger.yaml

* Update gaiacli.md

* Update gov spec docs

* Fix linting errors

* Fix unit tests

* Add pending log entries

* Update docs

* Update docs

* Update client/lcd/swagger-ui/swagger.yaml

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update cmd/gaia/cli_test/test_helpers.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update client/lcd/test_helpers.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update x/gov/types/proposal.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Address PR comments

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update gov docs to include quorum notes

* Add logs to handleParameterChangeProposal

* Update docs/spec/governance/02_state.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Support and use new StatusFailed when proposal passes but fails exec

* Add docs/notes warning on param validity

* Update docs

* Update docs/spec/governance/02_state.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/spec/governance/02_state.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Minor doc update

* Update x/gov/client/cli/tx.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Fix usage of fromAddr

* Rige code style  suggestion

* Update x/params/types/proposal.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Fix CI lint errors

* Update NewModuleClient godoc

* Add godoc to rtr.Seal() call

* Rename files

* Rename NewProposalHandler
2019-04-30 12:31:38 -04:00
Juan Leni 1306a25e42 Adding support for Ledger Cosmos App v1.5 (#4227)
This PR adds support for the latest version of the Cosmos App (v.1.5).
The app is not been released yet by Ledger but the PR is backwards compatible.
We can later remove backwards compatibility and enforce v1.5 only.

When creating a new account, `gaiacli` now shows the account/index and address in the device and requires user confirmation.

Related PRs:
https://github.com/cosmos/ledger-cosmos-go/pull/3
https://github.com/cosmos/ledger-cosmos-go/pull/4
https://github.com/cosmos/ledger-cosmos-go/pull/5
https://github.com/cosmos/ledger-cosmos-go/pull/6

Changes in the app can be found here:
https://github.com/LedgerHQ/ledger-app-cosmos/pull/5
2019-04-30 09:58:21 +01:00
Alexander Bezobchuk ec4a1e8f2a
Merge PR #4207: Add rewards and commission tags in txs 2019-04-26 19:11:45 -04:00
Jack Zampolin ea75ae5d47
Merge master into develop 2019-04-26 13:56:02 -04:00
Aleksandr Bezobchuk e7ca82d808
Merge branch 'develop' into release/v0.34.2 2019-04-25 21:40:33 -04:00
Alexander Bezobchuk 13bd5b62cf Release v0.34.2
* Merge PR #4163: Fix v0.33.x export script to port gov data correctly

* Remove TOC

* Add missing changelog entry for v0.34.1

* Merge PR #4182: Cherry pick #4083 into v0.34.2

* Merge PR #4181: Cherry pick 4135 v0.34.2

* Merge PR #4183: Cherry pick 4181 into v0.34.2 

* Support pagination and status query params for /staking/validators

* Rename BondStatusToString to String

* Cherry pick 4181

* Remove pending log

* Fix CODEOWNERS
2019-04-25 17:30:23 -04:00
xwartz 95e3d7d05e Merge PR #4189: Fix ErrNoInputs message typo 2019-04-25 09:16:38 -04:00
Alexander Bezobchuk 94bc55ef4f Merge PR #4183: Cherry pick 4181 into v0.34.2
* Support pagination and status query params for /staking/validators

* Rename BondStatusToString to String

* Cherry pick 4181

* Remove pending log
2019-04-24 12:03:55 -04:00
Alexander Bezobchuk c0e6b38394 Merge PR #4182: Cherry pick #4083 into v0.34.2 2019-04-24 11:51:49 -04:00
Alexander Bezobchuk 0e54369850 Merge PR #4177: Update Staking Validators Rest Query
* Support pagination and status query params for /staking/validators

* Rename BondStatusToString to String
2019-04-24 11:48:39 -04:00
Alexander Bezobchuk df6f2d6e25
Merge PR #4140: Fix Failed Simulation Seeds 2019-04-22 10:57:58 -04:00
Alessio Treglia 93e8f467fe
Turn --from into a positional argument in gaiacli tx send (#4146)
Closes: #4142
2019-04-18 19:48:52 +01:00
Alessio Treglia 769370801d Merge PR #4101: Return per-validator rewards when querying delegator rewards 2019-04-16 09:43:08 -04:00
Alessio Treglia 2581fffaa5 Merge PR #4126: Add module-wide named loggers
Closes: #4124
2019-04-15 23:58:06 -04:00