fd9cdb8ba7
Merge PR #6608 : ibc: remove viper from CLI
2020-07-06 09:25:47 -04:00
4f3efaded4
Add same attributes for all connection/ channel/ packet IBC events ( #6482 )
...
* Emmit events with same attributes in connection handlers
* Emmit events with same attributes in channel handlers
* Add paket_data attribute to EventTypeAcknowledgePacket
* Revert proto changes
* Query channel and connection to emit events with same attributes
* Simplify code
* Update x/ibc/04-channel/keeper/packet.go
* Update x/ibc/04-channel/handler.go
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-03 15:48:48 +00:00
db60e658f8
refactor connection handshake_test ( #6576 )
...
* refactor connopeninit test
* updated opentry
* refactor openack
* update openconfirm
* fix typo and test issue
* fix missing code cov hits
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-02 20:08:29 +00:00
5a22342a24
check ordered channel ordering in RecvPacket ( #6574 )
...
* move nextrecvseq check to recvpacket
* add test for next recv seq not found
* fix test bug, increase cov
* remove dup check and test
* Update x/ibc/04-channel/keeper/packet_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-02 20:03:45 +00:00
2658175b01
remove alias.go from channel ( #6569 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-01 18:25:23 +00:00
497b27305d
x/ibc: remove returning packet from channel keeper funcs ( #6544 )
...
* remove unnecessary return var
* fix changes lost in merge
2020-06-30 11:04:18 -04:00
e8fb76ae44
x/ibc: remove alias.go from 03-connection ( #6543 )
2020-06-30 09:10:53 -04:00
43b4f2f120
remove alias.go from 02-client ( #6542 )
2020-06-30 10:37:05 +00:00
1c575c95b2
Remove CleanupPacket from 04-channel ( #6533 )
...
* remove cleanup func
* remove unused func
2020-06-29 08:54:45 +00:00
43837b16e7
Refactor 04-channel/keeper tests to ibc testing pkg ( #6400 )
...
* update testing pkg and first keeper test
* fix version bug
* add more helper testing funcs
* move create header to testing pkg
* fix connection state bug
* add staking genesis state
* update simapp with setting validator helper func
* update simapp with valset helper
* fix app hash issue
* update to query from correct iavl proof height
* first keeper test passing
* second test passing 🎉
* fix build
* update tests in all keeper_test
* fix lint
* begin refactoring querier test
* update first querier test and update testing helpers
* finish updating rest of querier tests
* rename ChannelID in TestChannel to ID
* remove usage of chain id for calling helper funcs
* update openinit and opentry tests
* finish opening channel handshake tests
* finish handshake tests
* general testing pkg cleanup
* finish packetsend refactor
* update recvpacket
* packet executed refactored
* finish packet test 🎉
* all tests passing
* cleanup and increase code cov
* remove todos in favor of opened issue #6509
* bump invalid id to meet validation requirements
* bubble up proof height + 1
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* fix uninit conn test
* fix compile and address various pr review issues
* Update x/ibc/04-channel/keeper/handshake_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Update x/ibc/04-channel/keeper/handshake_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* address @AdityaSripal comments and increase cov
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-26 16:36:04 +00:00
4e73e0f817
Update proto files & definitions in accordance with ADR023 ( #6413 )
...
* consolidate proto files into single directory, turn on PACKAGE_DIRECTORY_MATCH linting
* add third_party root for third party proto files
* move ibc proto files to top level folder, rename .proto files to types.proto as before
* update protocgen script, and run code generation
* move vesting proto definition to cosmos namespace, rename from types.proto in alignment with buf.build naming conventions
* update Makefile so proto dependencies are set with new structure when updated
* add comment for sed usage in makefile
* remove unused aliases of proto generated types
* add settings.json instructions to contributing.md for including protobuf paths
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-06-18 10:04:26 -07:00
1c8249e26d
x/ibc: tx client protobuf migration ( #6461 )
...
* ibc/03-connection: tx client migration
* update commands
* update ibc-transfer
* remove unused queryRoute
* initialize clientCtx
2020-06-17 21:56:48 +02:00
d82114df2b
ibc/04-channel: move UNORDERED channel ack to RecvPacket ( #6457 )
2020-06-17 05:36:09 -04:00
35312d098e
JSON Codec Updates ( #6444 )
...
* Initial commit
* More updates
* Fix tests
* CLI test updates
* Updates
* Updates
2020-06-16 00:20:50 +00:00
8cf8098861
x/capability: remove alias.go usage ( #6438 )
2020-06-14 19:05:45 +02:00
14e3aa1265
x/staking: remove alias.go usage ( #6397 )
...
* x/staking: remove alias.go usage
* Fix formatting and Add entry in CHANGELOG.md
* Add missing end curly parenthesis
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-12 14:54:37 +00:00
ddbb9a2321
run make format ( #6416 )
2020-06-12 10:17:36 -04:00
55a7226535
x/ibc: channel from client state query ( #6401 )
...
* x/ibc: channel from client state query
* 04-channel/client: add CLI and REST queries
* querier test
2020-06-12 08:06:24 -04:00
d82c2e6a94
Enforce ProofSpecs in 23-Commitment ( #6374 )
...
* enforce spec ordering
* modify clients to pass in specs to verify functions
* start fixing tests
* Apply suggestions from code review
* enforce spec length and proof length match
* fix all tests
* add argument to constructor:
* fixed msg client and tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* finish fixes from review
* add back proof-specific checks
* Apply suggestions from code review
* more robust proof spec checks
* add CHANGELOG entries
* do not hardcode proofspecs in 23-commitment
* fix client modules
* fix tests
* appease linter
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-12 10:45:40 +00:00
9048ffa8d3
Update ibc proof to be bytes ( #6393 )
...
* update interfaces to use []byte instead of commitment proof
* update 03/04 msgs with bytes
* fix compile errors
* fix channel tests
* fix connection tests
* fix testing, tm, and localhost tests
* fix ante tests
* update 03-connection spec
* update channel msgs spec
* small fixes after self review
* rm unused import
* Update x/ibc/03-connection/client/utils/utils.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* add empty proof test and rm ics 20 from ibc spec
* fix merge issues
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-12 00:19:25 +02:00
b09d6728ec
Rename all methods IsEmpty to Empty to be consistent with all codebase ( #6409 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 23:32:24 +02:00
affe7265cb
Update connection and channel to use types_test package name ( #6395 )
...
* convert connection types test pacakge name
* convert channel types test package name
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-11 00:31:54 +00:00
744c1ce250
x/ibc: simulation store decoders ( #6247 )
...
* x/ibc: simulation store decoders
* x/ibc: missing decoders
* fixes
* 02-client: decoder test
* 03-connection: decoder test
* x/ibc: decoder test
* address comments from review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-10 08:09:51 +00:00
c44813bcdf
x/ibc: commit timeout timestamp ( #6363 )
...
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-06-08 08:03:18 -04:00
52d11acb45
R4R: Fix bug of unordered channel ( #6337 )
...
* fix unordered
* resolve conflicts
2020-06-08 06:19:59 +00:00
b9b578d6de
x/ibc: querying support for unordered channels ( #6294 )
...
* pause
* add querying for packet commitments and unrelayed acks
* add get all packet commitments test
* add query channels test
* add query connection channels test
* add test for query packet commitments
* fix key path and add unrelayed acks test
* fix part of lint
* add unrelayed packetsends func
* fix godoc
* add nolint directive
* fix lint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-06 19:25:45 -04:00
b1f483fe24
move packet executed call to ibc handler ( #6312 )
...
* move packet executed to within ibc handler
* add spec updates
* godoc and nil check to lenght
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 11:24:21 +00:00
2e11c81668
Make sdk.Msg implement proto.Message ( #6327 )
...
* Make sdk.Msg implement proto.Message
* Cleaning up
* Cleaning up
* Update CHANGELOG.md
* Lint fixes
* Lint fixes
* fix tests
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-03 19:52:05 +00:00
39f53ac22f
client: rename CliContext to Context ( #6290 )
...
* Refactor CliContext as Context
* Fix lint issues
* Fix goimports
* Fix gov tests
* Resolved ci-lint issues
* Add changelog
* Rename cliCtx to clientCtx
* Fix mocks and routes
* Add changelog
* Update changelog
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* merge client/rpc/ro{ot,utes}.go
* Update docs
* client/rpc: remove redundant client/rpc.RegisterRPCRoutes
* regenerate mocks
* Update ADRs
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-01 12:46:03 +00:00
654b2fdd10
x/ibc: packet commitment deletion after ack verification ( #6292 )
...
* add deletion of packet commitments to AcknowledgePacket and remove CleanupPacket
* update tests
* add replay test for unordered channels
* add cleanup back, update tests
* remove nolint
* add timeoutonclose handling and fix
* add check for deleted packets
* Update x/ibc/04-channel/keeper/keeper.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add ackexecuted and update tests
* add timeoutexecuted back and update test
* move events to executed funcs
* update handler
* update godoc
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-05-30 21:18:43 -04:00
ca20a39962
x/ibc: constrain acks processing order ( #6244 )
...
* x/ibc: constrain acks processing order
* test
* address @AdityaSripal comments
* address @colin-axner comments
* address @alexanderbez comments
2020-05-18 16:50:07 +00:00
3dcdc582af
x/ibc-transfer: move ICS20 out from x/ibc ( #6222 )
...
* x/transfer: move ICS20 out from x/ibc
* rename to ibc-transfer
2020-05-15 20:36:47 +00:00
b2ad4d2a23
x/ibc: alter id requirements ( #6227 )
...
* x/ibc: alter id requirements
* add regex to validations
* comment
* update error
* test all validators:
* fix tests
* check for only separators
2020-05-15 17:24:31 +00:00
c9ec0ff087
x/ibc: default genesis state for sims ( #6158 )
...
* x/ibc: default genesis state for sims
* add ibc and transfer module to simulations
* minor update
* remove TODO
* add validation to transfer genesis
* fix transfer init genesis
* address @alexanderbez comments
2020-05-14 22:47:11 +00:00
48aebed2ea
x/ibc: /types cleanup ( #6169 )
...
* x/ibc: move /types to /common
* x/ibc/types: remove errors
* remove mocked proofs
* remove invalidProof{}
* create new ibc/types dir
* format
* move keys to host
* move order to channel
* move channel state
* move connection state
* lint
2020-05-13 19:23:33 -04:00
a08aa41213
ibc/07-tendermint: variable trust-level ( #6206 )
...
* ibc/07-tendermint: variable trust-level
* update client state and tests
* fix tests
* address comments from review
* cli: define trust-level as flag
2020-05-13 01:10:25 +00:00
138e0b074f
x/ibc: log fixes ( #6184 )
...
* x/ibc: log fixes
* fix test
2020-05-11 17:17:05 +00:00
bef3689245
linter: enable nolintlint ( #6162 )
...
* nolintlint enable
* remove space
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-05-08 08:46:12 +00:00
b3cada1001
x/ibc: fix event emission on msgs ( #6161 )
...
* add sender events into signer, and update events into keeper
* move all handler functionality to keeper for update
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-05-07 09:55:26 -04:00
f3e3a30e5e
x/ibc: add missing query height ( #6157 )
2020-05-06 13:06:35 -04:00
d7ebee74e7
x/ibc: proto migration pt 1 ( #6097 )
...
* x/ibc: proto migration pt 1
* fix tests
* fixes and godoc
* yaml tags
* rm changelog
* address comments from review
* fix some tests
* fix tests
* add _UNSPECIFIED suffix for default enums
* Update app
* protobuf Any fixes
* use gogoproto
* fix tests
* wrap all messages
* address @alexanderbez comments
* update proto files
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-05-06 11:17:50 -04:00
f2a331fddb
Fix Timeout Handling ( #6118 )
...
* fix timeout
* remove print statement
* fix tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-05 14:46:13 +00:00
54ecf7d629
bump ibc sub module error codes ( #6117 )
...
* bump ibc sub module error codes
* add godoc
* update error numbers
2020-05-04 09:02:23 -04:00
218ec99508
various linter fixes ( #6106 )
...
x/staking: Fix all linter warnings.
Fixed warnings across base packages.
New linters:
- unparam
- nolintlint
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-05-02 21:26:59 +02:00
7143d092c4
x/ibc: add logs ( #6104 )
2020-04-30 08:37:02 -04:00
2879c0702c
x/ibc: fix missing return statement ( #6099 )
...
* enable the wsl linter
Fix various wsl-related warnings.
x/ibc/04-channel/keeper/handshake.go: fix missing return statement in ChanOpenTry().
* goimports -w files
* remove unknown linter references
* run make format
* Revert "run make format"
This reverts commit f810b62b9e4993f08506663d4e5f2ec2228a9863.
* run make format
2020-04-29 22:36:34 -04:00
2d3a8525b9
ibc/04-channel: import export GenesisState ( #6087 )
...
* ibc/04-channel: import export GenesisState
* update tests
* add missing genesis fields
* genesis tests
* keeper tests
* update genesis test
* typo
* rename types
* address comments from review
* minor updates
* typo
2020-04-29 09:17:20 -04:00
cc90f2e002
Merge pull request #6085 : Move codec/std to std
2020-04-27 15:40:50 -04:00
f6e9ee7623
x/ibc: Implement Timeout Timestamp ( #6022 )
...
* add timeout timestamp to packet and timestamp to consensus state
* add timeout timestamp event attribute
* update various issues with adding timestamp
* fix tests, add default timeout timestamp
* add unit test and minor fixes
* remove unnecessary code
* code review fix
* Update x/ibc/03-connection/keeper/keeper.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/02-client/exported/exported.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/04-channel/types/packet.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/07-tendermint/types/consensus_state.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* return time.Time in error message
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-04-22 22:23:42 +00:00
72a2dae3db
Bump Tendermint v0.33.4 ( #6055 )
...
* Bump go.{mod,sum}
* Update APIs from Tendermint
* Add max clock drift to client state
* Test updates
* Update APIs from Tendermint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-04-22 19:21:48 +00:00
Alexander Bezobchuk
dauTT
colin axner
Cory
Federico Kunze
dauTT
Jonathan Gimeno
Aditya
Segue
Aaron Craelius
SaReN
Marko
colin axner
Alessio Treglia