cosmos-sdk/x/bank/keeper
mergify[bot] d862c66a0d
feat: Allow to restrict MintCoins from app.go (backport #10771) (#11227)
* feat: Allow to restrict MintCoins from app.go (#10771)

## Description

Closes: https://github.com/cosmos/cosmos-sdk/issues/10386

This PR adds feature to the bank module so that other modules using bankKeeper would be able to call the keeper with restricted permissions when minting coins. `WithMintCoinsRestriction` would be able to get called within app.go when setting keeper components for each individual keeper, taking a function that would validate minting denom as an argument.

The example below demonstrates adding bank module with restricted permissions.
```
	app.DistrKeeper = distrkeeper.NewKeeper(
		appCodec, keys[distrtypes.StoreKey], app.GetSubspace(distrtypes.ModuleName), app.AccountKeeper, app.BankKeeper.WithMintCoinsRestriction(DistributionMintingRestriction),
		&stakingKeeper, authtypes.FeeCollectorName, app.ModuleAccountAddrs(),
	)
```
while there would be a seperate function that would restrict and validate allowed denoms as such.

```

func DistributionMintingRestriction(ctx sdk.Context, coins sdk.Coins) errors {
  for _, coin := range coins {
    if coin.Denom != ctx.NativeStakingDenom {
       return errors.New(fmt.Sprintf("Distribution can only print denom %s, tried minting %s", ctx.NativeStakingDenom, coin.Denom))
     }
  }
}
```

The sdk's simapp currently does not have any keepers that are to be changed with this implementation added, thus remaining unchanged in `app.go`.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit ea67659950)

# Conflicts:
#	CHANGELOG.md
#	x/bank/keeper/keeper.go

* fix conflicts

* fix tests

* changelog entry

* Update x/bank/spec/02_keepers.md

* Update CHANGELOG.md

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2022-02-21 16:37:26 +01:00
..
genesis.go fix: Bank module init genesis optimization (#9428) 2021-06-01 20:03:32 +00:00
genesis_test.go fix zero coins (#9229) 2021-04-30 16:54:08 +00:00
grpc_query.go codec: Rename codec and marshaler interfaces (#9226) 2021-04-29 10:46:22 +00:00
grpc_query_test.go SDK Core Audit - simapp updates (#9315) 2021-05-17 15:42:44 +00:00
invariants.go Paginate supply queries (#8798) 2021-04-06 14:43:08 +00:00
keeper.go feat: Allow to restrict MintCoins from app.go (backport #10771) (#11227) 2022-02-21 16:37:26 +01:00
keeper_test.go feat: Allow to restrict MintCoins from app.go (backport #10771) (#11227) 2022-02-21 16:37:26 +01:00
migrations.go Move all migration scripts to v043 (#8814) 2021-03-08 22:36:06 +00:00
msg_server.go x/bank v0.43 Audit updates (#9271) 2021-05-10 12:17:55 -04:00
querier.go Paginate supply queries (#8798) 2021-04-06 14:43:08 +00:00
querier_test.go SDK Core Audit - simapp updates (#9315) 2021-05-17 15:42:44 +00:00
send.go perf!: Add HasAccount to the AuthKeeper to save protobuf decoding time (backport #10022) (#10847) 2021-12-31 01:51:29 +01:00
view.go codec: Rename codec and marshaler interfaces (#9226) 2021-04-29 10:46:22 +00:00