cosmos-sdk/client
Robert Zaremba 3a9e696bbf
fix: Signature only flag bug on tx sign command 7632 (#8106)
* fix: Signature only flag bug on tx sign command 7632

* Update client/context.go

Co-authored-by: Cory <cjlevinson@gmail.com>

* Update client/context.go

Co-authored-by: Cory <cjlevinson@gmail.com>

* use named return value and closure (#8111)

This is to correctly handle deferred Close()
calls on writable files.

* set the right 'append' logic for signing transactions

* cleanup

* update tx.Sign interface by adding overwrite option

* Update Changelog

* sign command cleanup

* implementation and changelog update

* fix SignTx and tx.Sign calls

* fix: sign didn't write to a file

* update flags description

* Add tx.Sign tests

* fix grpc/server_test.go

* Update client/tx/tx.go

Co-authored-by: Cory <cjlevinson@gmail.com>

* changelog update

* Add test to verify matching signatures

* cli_test: add integration tests for sign CMD

* add output-file flag test

* add flagAmino test

* Update x/auth/client/cli/tx_sign.go

Co-authored-by: Alessio Treglia <alessio@tendermint.com>

* Update x/auth/client/cli/tx_sign.go

* update amino serialization test

* TestSign: adding unit test for signing with different modes

* Add test with Multi Signers into Robert's TxSign PR (#8142)

* Add test with Multi Signers

* remove true false

* Use SIGN_MODE_DIRECT

* Fix litn

* Use correct pubkeys

* Correct accNum and seq

* Use amino

* cleanups

* client.Sign: raise error when signing tx with multiple signers in Direct

+ added more unit tests

* add more tests

* Update client/tx/tx_test.go

Co-authored-by: Cory <cjlevinson@gmail.com>

* fix TestGetBroadcastCommand_WithoutOfflineFlag

* Any.UnsafeSetCachedValue

* fix note packed messages in tx builder

* reorder unit tests

* Changelog update

* cleaning / linting

* cli_tes: copy validator object instead of modifying it's shared codec

* x/auth cli_test: remove custom codec creation in tests

* Update CHANGELOG.md

* updates to CHANGELOG.md

* remove unused method

* add new instance of transaction builder for TestSign

Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-12-14 21:44:15 +00:00
..
debug Replace tmcrypto.PubKey by our own cryptotypes.PubKey (#7419) 2020-11-09 16:01:43 +00:00
docs Rename Version to Revision in IBC Height (#8020) 2020-11-24 15:38:24 +00:00
flags Use SignModeLegacyAminoJSON when signer is ledger key (#8136) 2020-12-11 13:54:50 +00:00
grpc change TmService's validator pubkey type to any (#8060) 2020-12-07 13:51:38 +00:00
input client/keys: make add command's output parseable (#6603) 2020-07-05 13:22:49 +02:00
keys client/keys: support export of unarmored private key (#8043) 2020-11-30 20:55:39 +00:00
rest docs: Add REST endpoints migration guide (#8011) 2020-11-24 14:34:20 +00:00
rpc Robert/api clientctx (#8107) 2020-12-08 20:17:40 +00:00
tx fix: Signature only flag bug on tx sign command 7632 (#8106) 2020-12-14 21:44:15 +00:00
account_retriever.go Replace tmcrypto.PubKey by our own cryptotypes.PubKey (#7419) 2020-11-09 16:01:43 +00:00
broadcast.go Add tx broadcast gRPC endpoint (#7852) 2020-12-02 17:50:40 +00:00
broadcast_test.go tm: update to latest (#7376) 2020-09-23 13:44:40 +00:00
cmd.go Use SignModeLegacyAminoJSON when signer is ledger key (#8136) 2020-12-11 13:54:50 +00:00
cmd_test.go Merge PR #7485: keyring-dir flag 2020-10-08 13:41:35 -04:00
context.go fix: Signature only flag bug on tx sign command 7632 (#8106) 2020-12-14 21:44:15 +00:00
context_test.go Robert/api clientctx (#8107) 2020-12-08 20:17:40 +00:00
grpc_query.go Add tx broadcast gRPC endpoint (#7852) 2020-12-02 17:50:40 +00:00
grpc_query_test.go Add ADR 031 BaseApp and codec infrastructure (#7519) 2020-10-15 13:07:59 +00:00
query.go Use any as validator pubkey (#7597) 2020-10-23 12:07:52 +00:00
test_helpers.go Replace tmcrypto.PubKey by our own cryptotypes.PubKey (#7419) 2020-11-09 16:01:43 +00:00
tx_config.go Migrate {x/auth, x/gov, x/staking} missing CLI queries to proto (#6994) 2020-09-10 18:26:47 +00:00
utils.go add page flag for CLI queries (#6824) 2020-07-24 08:17:11 +00:00
utils_test.go client: fix Paginate's arguments validation (#6205) 2020-05-13 13:14:43 +00:00