cosmos-sdk/x/ibc
Emmanuel T Odeke 291d966fe9
x/ibc/core/23-commitment/types: fix MerkleProof.Empty comparisons (#8092)
* x/ibc/core/23-commitment/types: fix MerkleProof.Empty comparisons

Fixes invalid pointer creation, reduces on unnecessary allocations
inside MerkleProof.Empty, and changes the method to a pointer; the
invalid pointer creation was symptomatic of broad use of values.

With this change we have improvements whose benchmarks produce:

```shell
name     old time/op    new time/op    delta
Empty-8     311ns ± 5%     232ns ± 5%  -25.49%  (p=0.000 n=20+19)

name     old alloc/op   new alloc/op   delta
Empty-8     56.0B ± 0%      8.0B ± 0%  -85.71%  (p=0.000 n=20+20)

name     old allocs/op  new allocs/op  delta
Empty-8      3.00 ± 0%      1.00 ± 0%  -66.67%  (p=0.000 n=20+20)
```

Fixes #8091

* Move Empty godoc to right place + add comments for blank*
2020-12-07 20:57:15 +00:00
..
applications/transfer Refactor Logging using Zerolog (#8072) 2020-12-03 23:17:21 +00:00
core x/ibc/core/23-commitment/types: fix MerkleProof.Empty comparisons (#8092) 2020-12-07 20:57:15 +00:00
light-clients Implement Connection-specified delay (#8069) 2020-12-07 12:13:06 +00:00
spec ibc: spec overview (#7853) 2020-11-09 12:44:20 +01:00
testing Implement Connection-specified delay (#8069) 2020-12-07 12:13:06 +00:00