cosmos-sdk/client
mergify[bot] 7a03a18c37
fix!: remove grpc query routing through tendermint (backport #10045) (#10269)
* fix!: remove grpc query routing through tendermint (#10045)

<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Revert routing queries through tendermint.

The reason this change was made is because of this error:
```
fatal error: concurrent map read and map write
```

The person who identified this error submitted these steps to reproduce
```
User sends a query with grpc
Tendermint Commit new blocks and tries to Commit IAVL (which causing IAVL versions map to change)
At the same time query tries to read from the same map (iavl.(*MutableTree).VersionExists) to check if requested version is exists
Node exits with fatal error: concurrent map read and map write
```

With the recent changes to IAVL submitted by terra (cc @YunSuk-Yeo) the reason for why we need to route through tendermint is no longer present. We should revert it when 0.17.1 of IAVL is cut, which will be later today.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 80918462a1)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

* revert

Co-authored-by: Marko <marbar3778@yahoo.com>
2021-10-04 19:24:16 +02:00
..
config fix client config don't take effect (#9211) 2021-05-19 08:44:15 +00:00
debug refactor(client): add client/Context.Codec and deprecate JSONCodec (#9498) 2021-06-11 11:49:39 +00:00
docs docs(swagger): add authz & feegrant swagger docs (#9625) (#9632) 2021-07-05 15:23:19 +02:00
flags fix: support output flag on tx commands (backport #9717) (#9771) 2021-07-26 17:23:29 +02:00
grpc feat: add cosmos-sdk Version (#9429) 2021-06-18 12:56:55 +00:00
input client/keys: make add command's output parseable (#6603) 2020-07-05 13:22:49 +02:00
keys fix: --home flag parsing (backport #10226) (#10271) 2021-10-04 12:57:06 +02:00
rest various linter fixes (#8666) 2021-02-23 08:46:01 +00:00
rpc Remove bech32 PubKey support (#7477) 2021-03-25 14:53:22 +00:00
tx chore: revert TxFactory changes (#10053) 2021-09-01 23:58:05 +02:00
account_retriever.go Replace tmcrypto.PubKey by our own cryptotypes.PubKey (#7419) 2020-11-09 16:01:43 +00:00
broadcast.go client: update client error handling to use tx hash from tendermint (#9462) 2021-06-07 02:55:08 -04:00
broadcast_test.go tm: update to latest (#7376) 2020-09-23 13:44:40 +00:00
cmd.go fix: --home flag parsing (backport #10226) (#10271) 2021-10-04 12:57:06 +02:00
cmd_test.go Limit context background (#8093) 2021-02-03 09:47:25 +00:00
context.go fix: file keyring fails to add/import/export keys when input is not stdin (fix #9566) (#9821) (#9881) 2021-08-12 13:41:53 +02:00
context_test.go refactor(client): add client/Context.Codec and deprecate JSONCodec (#9498) 2021-06-11 11:49:39 +00:00
grpc_query.go fix!: remove grpc query routing through tendermint (backport #10045) (#10269) 2021-10-04 19:24:16 +02:00
grpc_query_test.go Add ADR 031 BaseApp and codec infrastructure (#7519) 2020-10-15 13:07:59 +00:00
query.go fix!: update ABCI query to use request height (backport #9879) (#10185) 2021-09-17 00:51:53 +02:00
query_test.go fix!: update ABCI query to use request height (backport #9879) (#10185) 2021-09-17 00:51:53 +02:00
test_helpers.go Replace tmcrypto.PubKey by our own cryptotypes.PubKey (#7419) 2020-11-09 16:01:43 +00:00
tx_config.go Add fee grant module (#8061) 2021-01-29 19:54:51 +00:00
utils.go Add client config subcommand to CLI (#8953) 2021-03-31 12:04:33 +02:00
utils_test.go client: fix Paginate's arguments validation (#6205) 2020-05-13 13:14:43 +00:00