diff --git a/clients/js/src/aptos.ts b/clients/js/src/aptos.ts index 61b04d791..9b3c2bf4d 100644 --- a/clients/js/src/aptos.ts +++ b/clients/js/src/aptos.ts @@ -155,7 +155,7 @@ export async function execute_aptos( // Deploying a wrapped asset requires two transactions: // 1. Publish a new module under a resource account that defines a type T // 2. Initialise a new coin with that type T - // These need to be done in separate transactions, becasue a + // These need to be done in separate transactions, because a // transaction that deploys a module cannot use that module // // Tx 1. diff --git a/clients/js/src/main.ts b/clients/js/src/main.ts index 8f7bac2ba..dc01408cc 100644 --- a/clients/js/src/main.ts +++ b/clients/js/src/main.ts @@ -8,7 +8,7 @@ import { YargsCommandModule } from "./cmds/Yargs"; import { CLI_COMMAND_MODULES } from "./cmds"; yargs(hideBin(process.argv)) - // Build CLI commands dinamically from CLI_COMMAND_MODULES list + // Build CLI commands dynamically from CLI_COMMAND_MODULES list // Documentation about command hierarchy can be found here: https://github.com/yargs/yargs/blob/main/docs/advanced.md#example-command-hierarchy-using-indexmjs .command(CLI_COMMAND_MODULES as YargsCommandModule[]) .strict() diff --git a/scripts/check-docker-pin.sh b/scripts/check-docker-pin.sh index fecd1cf7b..b2f45f557 100755 --- a/scripts/check-docker-pin.sh +++ b/scripts/check-docker-pin.sh @@ -6,7 +6,7 @@ # - https://nickjanetakis.com/blog/docker-tip-18-please-pin-your-docker-image-versions # - https://snyk.io/blog/10-docker-image-security-best-practices/ (Specifically: USE FIXED TAGS FOR IMMUTABILITY) # -# Explaination of regex ignore choices +# Explanation of regex ignore choices # - We ignore sha256 because it suggests that the image dep is pinned # - We ignore scratch because it's literally the docker base image # - We ignore solana AS (builder|ci_tests) because it's a relative reference to another FROM call diff --git a/scripts/guardian-set-init.sh b/scripts/guardian-set-init.sh index 4b2ed888b..d3bb3f123 100755 --- a/scripts/guardian-set-init.sh +++ b/scripts/guardian-set-init.sh @@ -1,5 +1,5 @@ #!/usr/bin/env bash -# This script allows devnet initalization with more than one guardian. +# This script allows devnet initialization with more than one guardian. # First argument is the number of guardians for the initial guardian set. set -exuo pipefail @@ -46,7 +46,7 @@ if ! type -p jq; then exit 1 fi -# 1) guardian public keys - used as the inital guardian set when initializing contracts. +# 1) guardian public keys - used as the initial guardian set when initializing contracts. echo "generating guardian set addresses" # create an array of strings containing the ECDSA public keys of the devnet guardians in the guardianset: # guardiansPublicEth has the leading "0x" that Eth scripts expect. diff --git a/sdk/vaa/payloads.go b/sdk/vaa/payloads.go index 9ab4152b2..d7af3cfc2 100644 --- a/sdk/vaa/payloads.go +++ b/sdk/vaa/payloads.go @@ -78,7 +78,7 @@ var ( ActionCancelUpgrade GovernanceAction = 2 ActionSetIbcComposabilityMwContract GovernanceAction = 3 - // Accountant goverance actions + // Accountant governance actions ActionModifyBalance GovernanceAction = 1 // Wormhole tokenbridge governance actions diff --git a/sdk/vaa/quorum.go b/sdk/vaa/quorum.go index 5621670f5..7d39d3860 100644 --- a/sdk/vaa/quorum.go +++ b/sdk/vaa/quorum.go @@ -11,7 +11,7 @@ func CalculateQuorum(numGuardians int) int { panic("Invalid numGuardians is less than zero") } - // The goal here is to acheive a 2/3 quorum, but since we're + // The goal here is to achieve a 2/3 quorum, but since we're // dividing on int, we need to +1 to avoid the rounding down // effect of integer division // diff --git a/sdk/vaa/quorum_test.go b/sdk/vaa/quorum_test.go index b9531fcbc..45a8a2eac 100644 --- a/sdk/vaa/quorum_test.go +++ b/sdk/vaa/quorum_test.go @@ -77,10 +77,10 @@ func FuzzCalculateQuorum(f *testing.F) { num := CalculateQuorum(numGuardians) // Let's always be sure that there are enough guardians to maintain quorum - assert.LessOrEqual(t, num, numGuardians, "fuzz violation: quorum cannot be acheived because we require more guardians than we have") + assert.LessOrEqual(t, num, numGuardians, "fuzz violation: quorum cannot be achieved because we require more guardians than we have") // Let's always be sure that num is never zero - assert.NotZero(t, num, "fuzz violation: no guardians are required to acheive quorum") + assert.NotZero(t, num, "fuzz violation: no guardians are required to achieve quorum") var floorFloat float64 = 0.66666666666666666 numGuardiansFloat := float64(numGuardians) diff --git a/testing/contract-integrations/src/consts.ts b/testing/contract-integrations/src/consts.ts index 027c32697..70618e85a 100644 --- a/testing/contract-integrations/src/consts.ts +++ b/testing/contract-integrations/src/consts.ts @@ -11,7 +11,7 @@ import { clusterApiUrl } from "@solana/web3.js"; import { ethers } from "ethers"; import { getAddress } from "ethers/lib/utils"; -//Devnet here means the locahost kubernetes environment used by the wormhole-foundation/wormhole official git repository. +//Devnet here means the localhost kubernetes environment used by the wormhole-foundation/wormhole official git repository. //Testnet is the official Wormhole testnet export type Environment = "devnet" | "testnet" | "mainnet"; export const CLUSTER: Environment = "devnet" as Environment; //This is the currently selected environment. diff --git a/whitepapers/0013_ccq.md b/whitepapers/0013_ccq.md index 98714740d..bc88a4913 100644 --- a/whitepapers/0013_ccq.md +++ b/whitepapers/0013_ccq.md @@ -72,7 +72,7 @@ The guardian will listen for requests on the `ccq_req` topic. When a request is The initial release of CCQ will not support on chain requests. -Requests could be made on-chain from supported chains via a new cross-chain query contract. This contract could construct a payload representing the requestor and request, and publish it via the core bridge, generating a standard VAA. Guardians could have a pre-defined list of these emitters to treat as cross-chain query requests and process the requests accordingly. +Requests could be made on-chain from supported chains via a new cross-chain query contract. This contract could construct a payload representing the requester and request, and publish it via the core bridge, generating a standard VAA. Guardians could have a pre-defined list of these emitters to treat as cross-chain query requests and process the requests accordingly. ### Request Validation @@ -100,7 +100,7 @@ Note that for `eth_call_with_finality` queries, the `finality` must be specified #### Signature Verification -Requests messages MUST include a signature in the payload in order to distinguish between a requestor and (potentially, third-party) p2p relayer. +Requests messages MUST include a signature in the payload in order to distinguish between a requester and (potentially, third-party) p2p relayer. That signature SHOULD be created using a separate key. In order to differentiate signatures and prevent replay attacks of requests intended for devnet/testnet from mainnet ones, the following prefixes MUST be used when signing. These prefix strings are padded to 35-bytes to align with [Guardian Key Usage](0009_guardian_key.md) and existing code. @@ -246,7 +246,7 @@ Currently the supported query types on EVM are `eth_call`, `eth_call_by_timestam []byte batch_call_data ``` - Calls are batched to allow specifying multiple calls against the same block. These will be done in the same batch RPC call and are easier for the requestor to verify on chain. + Calls are batched to allow specifying multiple calls against the same block. These will be done in the same batch RPC call and are easier for the requester to verify on chain. ```go [20]byte contract_address @@ -479,7 +479,7 @@ The following are being done to reduce the denial of service threat surface: - Only configured wallets can sign requests. - Invalid requests are dropped without a gossip response. -Note that to prevent requests from creating undue load on guardians' RPC nodes, a mechanism may be needed to rate-limit or impose service fees upon requestors. +Note that to prevent requests from creating undue load on guardians' RPC nodes, a mechanism may be needed to rate-limit or impose service fees upon requesters. ## Replay Protection