adminGuardianSetUpdateToVAA: check for duplicate guardian keys

Sanity check.
2021-01-21 00:25:38 +01:00 · 2021-01-21 00:25:38 +01:00 · c0eef2fe9b
parent ea21b1782f
commit c0eef2fe9b
1 changed files with 8 additions and 1 deletions
--- a/bridge/cmd/guardiand/adminserver.go
+++ b/bridge/cmd/guardiand/adminserver.go
@ -44,7 +44,14 @@ func adminGuardianSetUpdateToVAA(req *nodev1.GuardianSetUpdate, guardianSetIndex
 			return nil, fmt.Errorf("invalid pubkey format at index %d (%s)", i, g.Name)
 		}

-		addrs[i] = ethcommon.HexToAddress(g.Pubkey)
+		ethAddr := ethcommon.HexToAddress(g.Pubkey)
+		for j, pk := range addrs {
+			if pk == ethAddr {
+				return nil, fmt.Errorf("duplicate pubkey at index %d (duplicate of %d): %s", i, j, g.Name)
+			}
+		}
+
+		addrs[i] = ethAddr
 	}

 	v := &vaa.VAA{