Newer versions of forge show this warning:
[⠊] Compiling...
[⠢] Compiling 93 files with 0.8.4
[⠘] Solc 0.8.4 finished in 20.09s
Compiler run successful (with warnings)
warning[2018]: Warning: Function state mutability can be restricted to view
--> forge-test/TokenImplementation.t.sol:76:5:
|
| function simulatePermitSignature(
| ^ (Relevant source part starts here and spans across multiple lines).
This change cleans it up.
The BridgeTest contract inherited from both Bridge and forge-std's
Test contracts. This was fine with the ancient version of
forge-std it was using, but newer forge-std has an isFork() from
foundry-rs/forge-std#236. This makes upgrading forge-std to take
advantage of new features like improved invariant testing or smart
fuzzing impossibru.
This makes it a bit cleaner and also fixes some of the logic in the
testTruncate to not be undefined.
Thanks @scnale for the assist on this one!
* clients/js: worm parse should output valid json
This was really useful when looking at a list of all governance vaas
to see which ones were guardian set upgrades.
* clients/js: update worm parse test fixtures
Since `worm parse` outputs in native json now, ensure the test fixtures
are also in json format.
* clients/js: move quiet.ts --> side-effects.ts
Now that the BigInt side effect for json serialization is in this file,
it isn't just to "quiet" the log warning anymore.
Addresses review feedback from @evan-gray
* sdk: add new governance VAA for IbcReceiverUpdateChainConnection
* Enforce connectionId to be 64 bytes, add tests in rust sdk
* Update PrependBufferBytesFixed to LeftPadBytes, add template function + command for IBC governance VAA
* Add >64 length check for ibcReceiverUpdateChainConnectionConnectionId in runIbcReceiverUpdateChainConnectionTemplate command
* Update naming of governance VAA to reflect new mapping of channelId -> chainId
* Add TargetChainID to admin commands
* Node: Add IBC update channel to admin verify cmd
---------
Co-authored-by: Bruce Riley <briley@jumptrading.com>
bruce-riley
heyitaki
Jeff Schroeder
gator-boi
Jonathan Claudius
A5 Pickle
Conor Patrick
Nikhil Suri
tbjump
tbjump
Csongor Kiss
Evan Gray
Evan Gray