noisymime
/
speeduino
mirror of https://github.com/noisymime/speeduino.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
speeduino/speeduino/schedule_calcs.cpp

58 lines
2.3 KiB
C++
Raw Normal View History

Unit test the schedule calculations (#1010) * Refactor: separate out schedule calcs from speeduino.ino (so they can be unit tested) * Add unit tests for compute_delay * Use PROGMEM to store test input & output * Add some 720 unit tests * Rename unit test file * Test ignition codepaths 2-8 * Test ign1 calcs * Add first injector calc tests * Add 720 deg tests Simplify * Simplify test_calc_inj1_timeout * Claw back RAM * Simplify test framework Channel angle is part of the test data set. * Move schedule calculation unit tests into their own harness Competing for RAM with the rest of Speeduino can cause them to fail, * Performance: inline all schedule calcs. * Unit test end angle * Unit test calculateIgnitionAngle1 * Test start angles also And test end angles for channel 1 * Unit test calculateIgnitionAngle3 * Unit test calculateIgnitionAngle4 * Improve unit test output * Add Nissan360 decoder unit tests. * Add Ford ST170 decoder unit tests * Add NGC decoder unit tests
2023-03-05 22:23:17 -08:00
#include "schedule_calcs.h"
Save 600+ bytes RAM (step 3 of 9) - remove per-channel schedule calculation functions, use generic equivalents instead (#1018) * calculateInjector1Timeout proxies calculateInjectorNTimeout Unit test still pass. * Remove calculateInjector1Timeout, Replace with call to calculateInjectorTimeout All unit tests still pass. * Remove unecassary unit test * calculateIgnition1Timeout proxies calculateIgnitionNTimeout Unit test all pass * Remove calculateIgnition1Timeout, Replace with call to calculateIgnitionTimeout All unit tests still pass. * Remove unecassary unit test * calculateIgnitionAngle\d proxies calculateIgnitionAngle Unit tests all pass * Remove calculateIgnitionAngle\d Just call calculateIgnitionAngle() directly * Route rotary ignition angle calcs through generic calculateIgnitionTrailingRotary function. * Remove calculateIgnitionAngle\d Just call calculateIgnitionTrailingRotary() directly * calculateInjectorStartAngle: inject all parameters Do not rely on global state Easier unit testing. * calculateIgnitionAngle: inject all parameters Do not rely on global state Easier unit testing. * Pull all ignition global vars into schedule_calcs * Conditional compile for schedule calc vars Saves memory * Optimize: break out angleToTimeIntervalRev from angleToTime. The new function will always be inlined. * Optimize - simpler code path when no channel offset (zero) Some optimization of arithmetic operations. * Fix unit tests * Fix bug on injector angle calculations Need while loops to correctly bring intermediate values into range --------- Co-authored-by: Josh Stewart <josh@noisymime.org>
2023-06-25 19:13:53 -07:00
int ignition1StartAngle;
int ignition1EndAngle;
int channel1IgnDegrees; /**< The number of crank degrees until cylinder 1 is at TDC (This is obviously 0 for virtually ALL engines, but there's some weird ones) */
int ignition2StartAngle;
int ignition2EndAngle;
int channel2IgnDegrees; /**< The number of crank degrees until cylinder 2 (and 5/6/7/8) is at TDC */
int ignition3StartAngle;
int ignition3EndAngle;
int channel3IgnDegrees; /**< The number of crank degrees until cylinder 2 (and 5/6/7/8) is at TDC */
int ignition4StartAngle;
int ignition4EndAngle;
int channel4IgnDegrees; /**< The number of crank degrees until cylinder 2 (and 5/6/7/8) is at TDC */
#if (IGN_CHANNELS >= 5)
int ignition5StartAngle;
int ignition5EndAngle;
int channel5IgnDegrees; /**< The number of crank degrees until cylinder 2 (and 5/6/7/8) is at TDC */
#endif
#if (IGN_CHANNELS >= 6)
int ignition6StartAngle;
int ignition6EndAngle;
int channel6IgnDegrees; /**< The number of crank degrees until cylinder 2 (and 5/6/7/8) is at TDC */
#endif
#if (IGN_CHANNELS >= 7)
int ignition7StartAngle;
int ignition7EndAngle;
int channel7IgnDegrees; /**< The number of crank degrees until cylinder 2 (and 5/6/7/8) is at TDC */
#endif
#if (IGN_CHANNELS >= 8)
int ignition8StartAngle;
int ignition8EndAngle;
int channel8IgnDegrees; /**< The number of crank degrees until cylinder 2 (and 5/6/7/8) is at TDC */
#endif
int channel1InjDegrees; /**< The number of crank degrees until cylinder 1 is at TDC (This is obviously 0 for virtually ALL engines, but there's some weird ones) */
int channel2InjDegrees; /**< The number of crank degrees until cylinder 2 (and 5/6/7/8) is at TDC */
int channel3InjDegrees; /**< The number of crank degrees until cylinder 3 (and 5/6/7/8) is at TDC */
int channel4InjDegrees; /**< The number of crank degrees until cylinder 4 (and 5/6/7/8) is at TDC */
#if (INJ_CHANNELS >= 5)
int channel5InjDegrees; /**< The number of crank degrees until cylinder 5 is at TDC */
#endif
#if (INJ_CHANNELS >= 6)
int channel6InjDegrees; /**< The number of crank degrees until cylinder 6 is at TDC */
#endif
#if (INJ_CHANNELS >= 7)
int channel7InjDegrees; /**< The number of crank degrees until cylinder 7 is at TDC */
#endif
#if (INJ_CHANNELS >= 8)
int channel8InjDegrees; /**< The number of crank degrees until cylinder 8 is at TDC */
#endif
Unit test the schedule calculations (#1010) * Refactor: separate out schedule calcs from speeduino.ino (so they can be unit tested) * Add unit tests for compute_delay * Use PROGMEM to store test input & output * Add some 720 unit tests * Rename unit test file * Test ignition codepaths 2-8 * Test ign1 calcs * Add first injector calc tests * Add 720 deg tests Simplify * Simplify test_calc_inj1_timeout * Claw back RAM * Simplify test framework Channel angle is part of the test data set. * Move schedule calculation unit tests into their own harness Competing for RAM with the rest of Speeduino can cause them to fail, * Performance: inline all schedule calcs. * Unit test end angle * Unit test calculateIgnitionAngle1 * Test start angles also And test end angles for channel 1 * Unit test calculateIgnitionAngle3 * Unit test calculateIgnitionAngle4 * Improve unit test output * Add Nissan360 decoder unit tests. * Add Ford ST170 decoder unit tests * Add NGC decoder unit tests
2023-03-05 22:23:17 -08:00