speeduino/speeduino/decoders.ino

2799 lines
116 KiB
Arduino
Raw Normal View History

2015-05-28 16:49:44 -07:00
/*
Speeduino - Simple engine management for the Arduino Mega 2560 platform
Copyright (C) Josh Stewart
A full copy of the license may be found in the projects root directory
*/
2015-05-16 04:06:54 -07:00
/*
This file contains the various crank and cam wheel decoder functions.
Each decoder must have the following 4 functions (Where xxxx is the decoder name):
* triggerSetup_xxx - Called once from within setup() and configures any required variables
2015-05-16 04:06:54 -07:00
* triggerPri_xxxx - Called each time the primary (No. 1) crank/cam signal is triggered (Called as an interrupt, so variables must be declared volatile)
* triggerSec_xxxx - Called each time the secondary (No. 2) crank/cam signal is triggered (Called as an interrupt, so variables must be declared volatile)
* getRPM_xxxx - Returns the current RPM, as calculated by the decoder
* getCrankAngle_xxxx - Returns the current crank angle, as calculated b the decoder
And each decoder must utlise at least the following variables:
2015-05-18 05:46:22 -07:00
toothLastToothTime - The time (In uS) that the last primary tooth was 'seen'
2017-01-29 22:10:17 -08:00
*
2015-05-16 04:06:54 -07:00
*/
2018-07-21 07:17:08 -07:00
#include <limits.h>
#include "globals.h"
#include "decoders.h"
2018-07-21 07:17:08 -07:00
#include "scheduledIO.h"
#include "scheduler.h"
#include "crankMaths.h"
2015-05-16 04:06:54 -07:00
2016-10-18 19:12:08 -07:00
static inline void addToothLogEntry(unsigned long toothTime)
2015-10-25 12:21:12 -07:00
{
//High speed tooth logging history
2016-10-18 19:12:08 -07:00
toothHistory[toothHistoryIndex] = toothTime;
2015-10-28 07:09:32 -07:00
if(toothHistoryIndex == (TOOTH_LOG_BUFFER-1))
2017-01-29 22:10:17 -08:00
{
2016-10-18 19:12:08 -07:00
if (toothLogRead)
{
2017-01-29 22:10:17 -08:00
toothHistoryIndex = 0;
2017-10-23 22:54:18 -07:00
BIT_CLEAR(currentStatus.status1, BIT_STATUS1_TOOTHLOG1READY);
2017-01-29 22:10:17 -08:00
toothLogRead = false; //The tooth log ready bit is cleared to ensure that we only get a set of concurrent values.
2016-10-18 19:12:08 -07:00
}
}
2015-10-25 12:21:12 -07:00
else
{ toothHistoryIndex++; }
}
/*
As nearly all the decoders use a common method of determining RPM (The time the last full revolution took)
A common function is simpler
degreesOver is the number of crank degrees between tooth #1s. Some patterns have a tooth #1 every crank rev, others are every cam rev.
*/
2018-07-03 00:20:13 -07:00
static inline uint16_t stdGetRPM(uint16_t degreesOver)
2017-06-15 15:45:39 -07:00
{
uint16_t tempRPM = 0;
if( currentStatus.hasSync == true )
{
if( (currentStatus.RPM < currentStatus.crankRPM) && (currentStatus.startRevolutions == 0) ) { tempRPM = 0; } //Prevents crazy RPM spike when there has been less than 1 full revolution
else if( (toothOneTime == 0) || (toothOneMinusOneTime == 0) ) { tempRPM = 0; }
2017-06-15 15:45:39 -07:00
else
{
noInterrupts();
revolutionTime = (toothOneTime - toothOneMinusOneTime); //The time in uS that one revolution would take at current speed (The time tooth 1 was last seen, minus the time it was seen prior to that)
interrupts();
if(degreesOver == 720) { revolutionTime = revolutionTime / 2; }
2017-06-15 15:45:39 -07:00
tempRPM = (US_IN_MINUTE / revolutionTime); //Calc RPM based on last full revolution time (Faster as /)
if(tempRPM >= MAX_RPM) { tempRPM = currentStatus.RPM; } //Sanity check
}
}
else { tempRPM = 0; }
2016-03-31 14:54:58 -07:00
return tempRPM;
}
/*
2017-01-29 22:10:17 -08:00
* Sets the new filter time based on the current settings.
* This ONLY works for even spaced decoders
*/
2016-05-28 05:06:48 -07:00
static inline void setFilter(unsigned long curGap)
{
if(configPage4.triggerFilter == 1) { triggerFilterTime = curGap >> 2; } //Lite filter level is 25% of previous gap
else if(configPage4.triggerFilter == 2) { triggerFilterTime = curGap >> 1; } //Medium filter level is 50% of previous gap
else if (configPage4.triggerFilter == 3) { triggerFilterTime = (curGap * 3) >> 2; } //Aggressive filter level is 75% of previous gap
2017-01-29 22:10:17 -08:00
else { triggerFilterTime = 0; } //trigger filter is turned off.
}
/*
This is a special case of RPM measure that is based on the time between the last 2 teeth rather than the time of the last full revolution
This gives much more volatile reading, but is quite useful during cranking, particularly on low resolution patterns.
It can only be used on patterns where the teeth are evently spaced
It takes an argument of the full (COMPLETE) number of teeth per revolution. For a missing tooth wheel, this is the number if the tooth had NOT been missing (Eg 36-1 = 36)
*/
2016-10-25 16:21:46 -07:00
static inline int crankingGetRPM(byte totalTeeth)
{
2017-06-15 15:45:39 -07:00
uint16_t tempRPM = 0;
if( (currentStatus.startRevolutions >= configPage4.StgCycles) && (currentStatus.hasSync == true) )
2017-06-15 15:45:39 -07:00
{
if( (toothLastToothTime > 0) && (toothLastMinusOneToothTime > 0) && (toothLastToothTime > toothLastMinusOneToothTime) )
2017-07-30 06:09:42 -07:00
{
noInterrupts();
revolutionTime = (toothLastToothTime - toothLastMinusOneToothTime) * totalTeeth;
interrupts();
tempRPM = (US_IN_MINUTE / revolutionTime);
if( tempRPM >= MAX_RPM ) { tempRPM = currentStatus.RPM; } //Sanity check. This can prevent spiking caused by noise on individual teeth. The new RPM should never be above 4x the cranking setting value (Remembering that this function is only called is the current RPM is less than the cranking setting)
}
2017-06-15 15:45:39 -07:00
}
2017-07-30 06:09:42 -07:00
return tempRPM;
}
/*
On decoders that are enabled for per tooth based timing adjustments, this function performs the timer compare changes on the schedules themselves
For each ignition channel, a check is made whether we're at the relevant tooth and whether that ignition schedule is currently running
Only if both these conditions are met will the schedule be updated with the latest timing information.
If it's the correct tooth, but
*/
#define checkPerToothTiming(crankAngle, currentTooth) \
{ \
if ( (currentTooth == ignition1EndTooth) ) \
{ \
if( (ignitionSchedule1.Status == RUNNING) ) { IGN1_COMPARE = IGN1_COUNTER + uS_TO_TIMER_COMPARE( fastDegreesToUS( ignitionLimits( (ignition1EndAngle - crankAngle) ) ) ); } \
else { ignitionSchedule1.endCompare = IGN1_COUNTER + uS_TO_TIMER_COMPARE( fastDegreesToUS( ignitionLimits( (ignition1EndAngle - crankAngle) ) ) ); ignitionSchedule1.endScheduleSetByDecoder = true; } \
} \
\
else if ( (currentTooth == ignition2EndTooth) ) \
{ \
if( (ignitionSchedule2.Status == RUNNING) ) { IGN2_COMPARE = IGN2_COUNTER + uS_TO_TIMER_COMPARE( fastDegreesToUS( ignitionLimits( (ignition2EndAngle - crankAngle) ) ) ); } \
else { ignitionSchedule2.endCompare = IGN2_COUNTER + uS_TO_TIMER_COMPARE( fastDegreesToUS( ignitionLimits( (ignition2EndAngle - crankAngle) ) ) ); ignitionSchedule2.endScheduleSetByDecoder = true; } \
} \
\
else if ( (currentTooth == ignition3EndTooth) ) \
{ \
if( (ignitionSchedule3.Status == RUNNING) ) { IGN3_COMPARE = IGN3_COUNTER + uS_TO_TIMER_COMPARE( fastDegreesToUS( ignitionLimits( (ignition3EndAngle - crankAngle) ) ) ); } \
else { ignitionSchedule3.endCompare = IGN3_COUNTER + uS_TO_TIMER_COMPARE( fastDegreesToUS( ignitionLimits( (ignition3EndAngle - crankAngle) ) ) ); ignitionSchedule3.endScheduleSetByDecoder = true; } \
} \
else if ( (currentTooth == ignition4EndTooth) ) \
{ \
if( (ignitionSchedule4.Status == RUNNING) ) { IGN4_COMPARE = IGN4_COUNTER + uS_TO_TIMER_COMPARE( fastDegreesToUS( ignitionLimits( (ignition4EndAngle - crankAngle) ) ) ); } \
else { ignitionSchedule4.endCompare = IGN4_COUNTER + uS_TO_TIMER_COMPARE_SLOW( fastDegreesToUS( ignitionLimits( (ignition4EndAngle - crankAngle) ) ) ); ignitionSchedule4.endScheduleSetByDecoder = true; } \
} \
}
2017-01-29 22:10:17 -08:00
/*
2015-05-16 04:06:54 -07:00
Name: Missing tooth wheel
Desc: A multi-tooth wheel with one of more 'missing' teeth. The first tooth after the missing one is considered number 1 and isthe basis for the trigger angle
Note: This does not currently support dual wheel (ie missing tooth + single tooth on cam)
*/
void triggerSetup_missingTooth()
{
triggerToothAngle = 360 / configPage4.triggerTeeth; //The number of degrees that passes from tooth to tooth
2018-06-25 19:17:43 -07:00
if(configPage4.TrigSpeed == CAM_SPEED) { triggerToothAngle = 720 / configPage4.triggerTeeth; } //Account for cam speed missing tooth
triggerActualTeeth = configPage4.triggerTeeth - configPage4.triggerMissingTeeth; //The number of physical teeth on the wheel. Doing this here saves us a calculation each time in the interrupt
triggerFilterTime = (int)(1000000 / (MAX_RPM / 60 * configPage4.triggerTeeth)); //Trigger filter time is the shortest possible time (in uS) that there can be between crank teeth (ie at max RPM). Any pulses that occur faster than this time will be disgarded as noise
triggerSecFilterTime = (int)((configPage4.trigPatternSec == SEC_TRIGGER_4_1 ) ? 1000000 * 60 / MAX_RPM / 4 / 2 : 1000000 * 60 / MAX_RPM / 2 / 2); //For 4-1 came wheel. Same as above, but fixed at 2 teeth on the secondary input and divided by 2 (for cam speed)
secondDerivEnabled = false;
decoderIsSequential = false;
checkSyncToothCount = (configPage4.triggerTeeth) >> 1; //50% of the total teeth.
toothLastMinusOneToothTime = 0;
toothCurrentCount = 0;
toothOneTime = 0;
toothOneMinusOneTime = 0;
MAX_STALL_TIME = (3333UL * triggerToothAngle * (configPage4.triggerMissingTeeth + 1)); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
}
2015-05-16 04:06:54 -07:00
void triggerPri_missingTooth()
{
curTime = micros();
curGap = curTime - toothLastToothTime;
2017-06-15 15:45:39 -07:00
if ( curGap >= triggerFilterTime ) //Pulses should never be less than triggerFilterTime, so if they are it means a false trigger. (A 36-1 wheel at 8000pm will have triggers approx. every 200uS)
{
2017-06-15 15:45:39 -07:00
toothCurrentCount++; //Increment the tooth counter
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
addToothLogEntry(curGap);
//if(toothCurrentCount > checkSyncToothCount || currentStatus.hasSync == false)
2016-11-07 22:04:34 -08:00
{
2017-06-15 15:45:39 -07:00
//Begin the missing tooth detection
//If the time between the current tooth and the last is greater than 1.5x the time between the last tooth and the tooth before that, we make the assertion that we must be at the first tooth after the gap
if(configPage4.triggerMissingTeeth == 1) { targetGap = (3 * (toothLastToothTime - toothLastMinusOneToothTime)) >> 1; } //Multiply by 1.5 (Checks for a gap 1.5x greater than the last one) (Uses bitshift to multiply by 3 then divide by 2. Much faster than multiplying by 1.5)
else { targetGap = ((toothLastToothTime - toothLastMinusOneToothTime)) * configPage4.triggerMissingTeeth; } //Multiply by 2 (Checks for a gap 2x greater than the last one)
2017-06-15 15:45:39 -07:00
if( (toothLastToothTime == 0) || (toothLastMinusOneToothTime == 0) ) { curGap = 0; }
2017-06-15 15:45:39 -07:00
if ( (curGap > targetGap) || (toothCurrentCount > triggerActualTeeth) )
{
//Missing tooth detected
if(toothCurrentCount < (triggerActualTeeth) && (currentStatus.hasSync == true) )
{
//This occurs when we're at tooth #1, but haven't seen all the other teeth. This indicates a signal issue so we flag lost sync so this will attempt to resync on the next revolution.
currentStatus.hasSync = false;
currentStatus.syncLossCounter++;
}
2017-07-30 06:09:42 -07:00
//This is to handle a special case on startup where sync can be obtained and the system immediately thinks the revs have jumped:
2017-08-02 07:35:10 -07:00
//else if (currentStatus.hasSync == false && toothCurrentCount < checkSyncToothCount ) { triggerFilterTime = 0; }
2017-06-15 15:45:39 -07:00
else
{
toothCurrentCount = 1;
revolutionOne = !revolutionOne; //Flip sequential revolution tracker
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.hasSync = true;
currentStatus.startRevolutions++; //Counter
2018-06-25 19:17:43 -07:00
if ( configPage4.TrigSpeed == CAM_SPEED ) { currentStatus.startRevolutions++; } //Add an extra revolution count if we're running at cam speed
2017-06-15 15:45:39 -07:00
triggerFilterTime = 0; //This is used to prevent a condition where serious intermitent signals (Eg someone furiously plugging the sensor wire in and out) can leave the filter in an unrecoverable state
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
triggerToothAngleIsCorrect = false; //The tooth angle is double at this point
2017-06-15 15:45:39 -07:00
}
}
else
{
//Filter can only be recalc'd for the regular teeth, not the missing one.
setFilter(curGap);
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
triggerToothAngleIsCorrect = true;
2017-06-15 15:45:39 -07:00
}
2016-11-07 22:04:34 -08:00
}
2017-01-29 22:10:17 -08:00
//EXPERIMENTAL!
if( (configPage2.perToothIgn == true) && (!BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK)) )
{
//ignition1EndTooth = 11;
//ignition1EndAngle = 0;
int16_t crankAngle = ( (toothCurrentCount-1) * triggerToothAngle ) + configPage4.triggerAngle;
//if ( (toothCurrentCount == ignition1EndTooth) && (ignitionSchedule1.Status == RUNNING) ) { IGN1_COMPARE = IGN1_COUNTER + uS_TO_TIMER_COMPARE( fastDegreesToUS( ignitionLimits( (ignition1EndAngle - crankAngle) ) ) ); }
//if ( (toothCurrentCount == ignition1EndTooth) && (ignitionSchedule1.Status == RUNNING) ) { IGN1_COMPARE = IGN1_COUNTER + uS_TO_TIMER_COMPARE( 9048 ); }
//else { if (toothCurrentCount == ignition1EndTooth) { ignitionSchedule1.endCompare = IGN1_COUNTER + uS_TO_TIMER_COMPARE( 9048 ); } }
if( (configPage4.sparkMode == IGN_MODE_SEQUENTIAL) && (revolutionOne == true) && (configPage4.TrigSpeed == CRANK_SPEED) )
{
crankAngle += 360;
checkPerToothTiming(crankAngle, (configPage4.triggerTeeth + toothCurrentCount));
}
else{ checkPerToothTiming(crankAngle, toothCurrentCount); }
}
2017-06-15 15:45:39 -07:00
}
2015-05-16 04:06:54 -07:00
}
void triggerSec_missingTooth()
2017-01-29 22:10:17 -08:00
{
curTime2 = micros();
curGap2 = curTime2 - toothLastSecToothTime;
if( (toothLastSecToothTime == 0)
#ifndef SMALL_FLASH_MODE
|| (toothLastMinusOneSecToothTime == 0 )
#endif
) { curGap2 = 0; }
if ( curGap2 >= triggerSecFilterTime )
{
if ( configPage4.trigPatternSec == SEC_TRIGGER_4_1 )
{
targetGap2 = (3 * (toothLastSecToothTime - toothLastMinusOneSecToothTime)) >> 1; //If the time between the current tooth and the last is greater than 1.5x the time between the last tooth and the tooth before that, we make the assertion that we must be at the first tooth after the gap
toothLastMinusOneSecToothTime = toothLastSecToothTime;
if ( ( curGap2 >= targetGap2 ) || ( secondaryToothCount > 3 ) )
{
secondaryToothCount = 1;
revolutionOne = 1; //Sequential revolution reset
triggerSecFilterTime = 0; //This is used to prevent a condition where serious intermitent signals (Eg someone furiously plugging the sensor wire in and out) can leave the filter in an unrecoverable state
}
else
{
triggerSecFilterTime = curGap2 >> 2; //Set filter at 25% of the current speed. Filter can only be recalc'd for the regular teeth, not the missing one.
secondaryToothCount++;
}
}
else
{
revolutionOne = 1; //Sequential revolution reset
}
toothLastSecToothTime = curTime2;
} //Trigger filter
}
2015-05-18 05:46:22 -07:00
2017-06-15 15:45:39 -07:00
uint16_t getRPM_missingTooth()
2015-05-18 05:46:22 -07:00
{
2017-06-15 15:45:39 -07:00
uint16_t tempRPM = 0;
if( (currentStatus.RPM < currentStatus.crankRPM) )
{
if(toothCurrentCount != 1)
{
2018-06-25 19:17:43 -07:00
if(configPage4.TrigSpeed == CAM_SPEED) { tempRPM = crankingGetRPM(configPage4.triggerTeeth/2); } //Account for cam speed
else { tempRPM = crankingGetRPM(configPage4.triggerTeeth); }
}
else { tempRPM = currentStatus.RPM; } //Can't do per tooth RPM if we're at tooth #1 as the missing tooth messes the calculation
}
2017-06-15 15:45:39 -07:00
else
{
2018-06-25 19:17:43 -07:00
if(configPage4.TrigSpeed == CAM_SPEED) { tempRPM = stdGetRPM(720); } //Account for cam speed
2018-07-03 00:20:13 -07:00
else { tempRPM = stdGetRPM(360); }
2017-06-15 15:45:39 -07:00
}
return tempRPM;
2015-05-18 05:46:22 -07:00
}
int getCrankAngle_missingTooth()
2015-05-18 05:46:22 -07:00
{
2015-05-21 21:14:03 -07:00
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
2015-06-07 05:05:30 -07:00
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
2016-11-08 17:57:04 -08:00
bool tempRevolutionOne;
2017-01-29 22:10:17 -08:00
//Grab some variables that are used in the trigger code and assign them to temp variables.
2015-06-05 06:30:37 -07:00
noInterrupts();
2015-06-07 05:05:30 -07:00
tempToothCurrentCount = toothCurrentCount;
2016-11-08 17:57:04 -08:00
tempRevolutionOne = revolutionOne;
tempToothLastToothTime = toothLastToothTime;
2015-06-05 06:30:37 -07:00
interrupts();
2017-01-29 22:10:17 -08:00
int crankAngle = ((tempToothCurrentCount - 1) * triggerToothAngle) + configPage4.triggerAngle; //Number of teeth that have passed since tooth 1, multiplied by the angle each tooth represents, plus the angle that tooth 1 is ATDC. This gives accuracy only to the nearest tooth.
//Sequential check (simply sets whether we're on the first or 2nd revoltuion of the cycle)
if ( (tempRevolutionOne == true) && (configPage4.TrigSpeed == CRANK_SPEED) ) { crankAngle += 360; }
lastCrankAngleCalc = micros();
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-01-29 22:10:17 -08:00
if (crankAngle >= 720) { crankAngle -= 720; }
else if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += CRANK_ANGLE_MAX; }
2017-01-29 22:10:17 -08:00
2015-05-21 21:14:03 -07:00
return crankAngle;
2015-05-18 05:46:22 -07:00
}
void triggerSetEndTeeth_missingTooth()
{
byte toothAdder = 0;
if( (configPage4.sparkMode == IGN_MODE_SEQUENTIAL) && (configPage4.TrigSpeed == CRANK_SPEED) ) { toothAdder = configPage4.triggerTeeth; }
ignition1EndTooth = ( (ignition1EndAngle - configPage4.triggerAngle) / triggerToothAngle ) - 1;
if(ignition1EndTooth > (configPage4.triggerTeeth + toothAdder)) { ignition1EndTooth -= (configPage4.triggerTeeth + toothAdder); }
if(ignition1EndTooth <= 0) { ignition1EndTooth += configPage4.triggerTeeth; }
if(ignition1EndTooth > (triggerActualTeeth + toothAdder)) { ignition1EndTooth = (triggerActualTeeth + toothAdder); }
ignition2EndTooth = ( (ignition2EndAngle - configPage4.triggerAngle) / triggerToothAngle ) - 1;
if(ignition2EndTooth > (configPage4.triggerTeeth + toothAdder)) { ignition2EndTooth -= (configPage4.triggerTeeth + toothAdder); }
if(ignition2EndTooth <= 0) { ignition2EndTooth += configPage4.triggerTeeth; }
if(ignition1EndTooth > (triggerActualTeeth + toothAdder)) { ignition3EndTooth = (triggerActualTeeth + toothAdder); }
ignition3EndTooth = ( (ignition3EndAngle - configPage4.triggerAngle) / triggerToothAngle ) - 1;
if(ignition3EndTooth > (configPage4.triggerTeeth + toothAdder)) { ignition3EndTooth -= (configPage4.triggerTeeth + toothAdder); }
if(ignition3EndTooth <= 0) { ignition3EndTooth += configPage4.triggerTeeth; }
if(ignition3EndTooth > (triggerActualTeeth + toothAdder)) { ignition3EndTooth = (triggerActualTeeth + toothAdder); }
ignition4EndTooth = ( (ignition4EndAngle - configPage4.triggerAngle) / triggerToothAngle ) - 1;
if(ignition4EndTooth > (configPage4.triggerTeeth + toothAdder)) { ignition4EndTooth -= (configPage4.triggerTeeth + toothAdder); }
if(ignition4EndTooth <= 0) { ignition4EndTooth += configPage4.triggerTeeth; }
if(ignition4EndTooth > (triggerActualTeeth + toothAdder)) { ignition4EndTooth = (triggerActualTeeth + toothAdder); }
lastToothCalcAdvance = currentStatus.advance;
}
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
2015-09-07 23:46:42 -07:00
Name: Dual wheel
2017-01-29 22:10:17 -08:00
Desc: 2 wheels located either both on the crank or with the primary on the crank and the secondary on the cam.
2015-09-07 23:46:42 -07:00
Note: There can be no missing teeth on the primary wheel
2015-05-18 05:46:22 -07:00
*/
2015-09-07 23:46:42 -07:00
void triggerSetup_DualWheel()
{
triggerToothAngle = 360 / configPage4.triggerTeeth; //The number of degrees that passes from tooth to tooth
if(configPage4.TrigSpeed == 1) { triggerToothAngle = 720 / configPage4.triggerTeeth; } //Account for cam speed missing tooth
2015-09-07 23:46:42 -07:00
toothCurrentCount = 255; //Default value
triggerFilterTime = (int)(1000000 / (MAX_RPM / 60 * configPage4.triggerTeeth)); //Trigger filter time is the shortest possible time (in uS) that there can be between crank teeth (ie at max RPM). Any pulses that occur faster than this time will be disgarded as noise
2015-09-07 23:46:42 -07:00
triggerSecFilterTime = (int)(1000000 / (MAX_RPM / 60 * 2)) / 2; //Same as above, but fixed at 2 teeth on the secondary input and divided by 2 (for cam speed)
secondDerivEnabled = false;
decoderIsSequential = true;
triggerToothAngleIsCorrect = true; //This is always true for this pattern
2016-04-26 00:43:19 -07:00
MAX_STALL_TIME = (3333UL * triggerToothAngle); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
2015-09-07 23:46:42 -07:00
}
2015-05-18 05:46:22 -07:00
void triggerPri_DualWheel()
2017-01-29 22:10:17 -08:00
{
2015-09-07 23:46:42 -07:00
curTime = micros();
curGap = curTime - toothLastToothTime;
2017-06-15 15:45:39 -07:00
if ( curGap >= triggerFilterTime )
2017-01-29 22:10:17 -08:00
{
2017-06-15 15:45:39 -07:00
toothCurrentCount++; //Increment the tooth counter
addToothLogEntry(curGap);
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
2017-06-15 15:45:39 -07:00
if ( currentStatus.hasSync == true )
{
if ( (toothCurrentCount == 1) || (toothCurrentCount > configPage4.triggerTeeth) )
2017-06-15 15:45:39 -07:00
{
toothCurrentCount = 1;
revolutionOne = !revolutionOne; //Flip sequential revolution tracker
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.startRevolutions++; //Counter
}
setFilter(curGap); //Recalc the new filter value
}
//EXPERIMENTAL!
if(configPage2.perToothIgn == true)
{
uint16_t crankAngle = ( (toothCurrentCount-1) * triggerToothAngle ) + configPage4.triggerAngle;
checkPerToothTiming(crankAngle, toothCurrentCount);
}
2017-06-15 15:45:39 -07:00
} //TRigger filter
2017-01-29 22:10:17 -08:00
2015-09-07 23:46:42 -07:00
}
void triggerSec_DualWheel()
2017-01-29 22:10:17 -08:00
{
2015-09-07 23:46:42 -07:00
curTime2 = micros();
curGap2 = curTime2 - toothLastSecToothTime;
2017-06-15 15:45:39 -07:00
if ( curGap2 >= triggerSecFilterTime )
2015-09-07 23:46:42 -07:00
{
2017-06-15 15:45:39 -07:00
toothLastSecToothTime = curTime2;
triggerSecFilterTime = curGap2 >> 2; //Set filter at 25% of the current speed
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
if(currentStatus.hasSync == false)
{
toothLastToothTime = micros();
toothLastMinusOneToothTime = micros() - (6000000 / configPage4.triggerTeeth); //Fixes RPM at 10rpm until a full revolution has taken place
toothCurrentCount = configPage4.triggerTeeth;
2017-06-15 15:45:39 -07:00
currentStatus.hasSync = true;
}
else
{
if (toothCurrentCount != configPage4.triggerTeeth) { currentStatus.syncLossCounter++; } //Indicates likely sync loss
if (configPage4.useResync == 1) { toothCurrentCount = configPage4.triggerTeeth; }
}
2017-06-15 15:45:39 -07:00
revolutionOne = 1; //Sequential revolution reset
} //Trigger filter
2017-01-29 22:10:17 -08:00
}
2015-09-07 23:46:42 -07:00
2017-06-15 15:45:39 -07:00
uint16_t getRPM_DualWheel()
2015-09-07 23:46:42 -07:00
{
2017-06-15 15:45:39 -07:00
uint16_t tempRPM = 0;
if( currentStatus.hasSync == true )
{
if(currentStatus.RPM < currentStatus.crankRPM) { tempRPM = crankingGetRPM(configPage4.triggerTeeth); }
2018-07-03 00:20:13 -07:00
else { tempRPM = stdGetRPM(360); }
2017-06-15 15:45:39 -07:00
}
return tempRPM;
2015-09-07 23:46:42 -07:00
}
int getCrankAngle_DualWheel()
2015-09-07 23:46:42 -07:00
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
2016-11-08 17:57:04 -08:00
bool tempRevolutionOne;
2017-01-29 22:10:17 -08:00
//Grab some variables that are used in the trigger code and assign them to temp variables.
2015-09-07 23:46:42 -07:00
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
2016-11-08 17:57:04 -08:00
tempRevolutionOne = revolutionOne;
lastCrankAngleCalc = micros();
2015-09-07 23:46:42 -07:00
interrupts();
2017-01-29 22:10:17 -08:00
2015-09-07 23:46:42 -07:00
//Handle case where the secondary tooth was the last one seen
if(tempToothCurrentCount == 0) { tempToothCurrentCount = configPage4.triggerTeeth; }
2017-01-29 22:10:17 -08:00
int crankAngle = ((tempToothCurrentCount - 1) * triggerToothAngle) + configPage4.triggerAngle; //Number of teeth that have passed since tooth 1, multiplied by the angle each tooth represents, plus the angle that tooth 1 is ATDC. This gives accuracy only to the nearest tooth.
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
//Sequential check (simply sets whether we're on the first or 2nd revoltuion of the cycle)
2016-11-08 17:57:04 -08:00
if (tempRevolutionOne) { crankAngle += 360; }
2017-01-29 22:10:17 -08:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += CRANK_ANGLE_MAX; }
2017-01-29 22:10:17 -08:00
2015-09-07 23:46:42 -07:00
return crankAngle;
2015-05-18 05:46:22 -07:00
}
void triggerSetEndTeeth_DualWheel()
{
ignition1EndTooth = ( (ignition1EndAngle - configPage4.triggerAngle) / triggerToothAngle ) - 1;
if(ignition1EndTooth > configPage4.triggerTeeth) { ignition1EndTooth -= configPage4.triggerTeeth; }
if(ignition1EndTooth <= 0) { ignition1EndTooth += configPage4.triggerTeeth; }
if(ignition1EndTooth > triggerActualTeeth) { ignition1EndTooth = triggerActualTeeth; }
ignition2EndTooth = ( (ignition2EndAngle - configPage4.triggerAngle) / triggerToothAngle ) - 1;
if(ignition2EndTooth > configPage4.triggerTeeth) { ignition2EndTooth -= configPage4.triggerTeeth; }
if(ignition2EndTooth <= 0) { ignition2EndTooth += configPage4.triggerTeeth; }
if(ignition2EndTooth > triggerActualTeeth) { ignition2EndTooth = triggerActualTeeth; }
ignition3EndTooth = ( (ignition3EndAngle - configPage4.triggerAngle) / triggerToothAngle ) - 1;
if(ignition3EndTooth > configPage4.triggerTeeth) { ignition3EndTooth -= configPage4.triggerTeeth; }
if(ignition3EndTooth <= 0) { ignition3EndTooth += configPage4.triggerTeeth; }
if(ignition3EndTooth > triggerActualTeeth) { ignition3EndTooth = triggerActualTeeth; }
ignition4EndTooth = ( (ignition4EndAngle - configPage4.triggerAngle) / triggerToothAngle ) - 1;
if(ignition4EndTooth > configPage4.triggerTeeth) { ignition4EndTooth -= configPage4.triggerTeeth; }
if(ignition4EndTooth <= 0) { ignition4EndTooth += configPage4.triggerTeeth; }
if(ignition4EndTooth > triggerActualTeeth) { ignition4EndTooth = triggerActualTeeth; }
lastToothCalcAdvance = currentStatus.advance;
}
2015-06-13 16:01:55 -07:00
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Name: Basic Distributor
Desc: Tooth equal to the number of cylinders are evenly spaced on the cam. No position sensing (Distributor is retained) so crank angle is a made up figure based purely on the first teeth to be seen
Note: This is a very simple decoder. See http://www.megamanual.com/ms2/GM_7pinHEI.htm
*/
void triggerSetup_BasicDistributor()
{
triggerActualTeeth = configPage2.nCylinders;
if(triggerActualTeeth == 0) { triggerActualTeeth = 1; }
triggerToothAngle = 720 / triggerActualTeeth; //The number of degrees that passes from tooth to tooth
triggerFilterTime = 60000000L / MAX_RPM / configPage2.nCylinders; // Minimum time required between teeth
triggerFilterTime = triggerFilterTime / 2; //Safety margin
triggerFilterTime = 0;
secondDerivEnabled = false;
decoderIsSequential = false;
toothCurrentCount = 0; //Default value
decoderHasFixedCrankingTiming = true;
triggerToothAngleIsCorrect = true;
if(configPage2.nCylinders <= 4) { MAX_STALL_TIME = (1851UL * triggerToothAngle); }//Minimum 90rpm. (1851uS is the time per degree at 90rpm). This uses 90rpm rather than 50rpm due to the potentially very high stall time on a 4 cylinder if we wait that long.
else { MAX_STALL_TIME = (3200UL * triggerToothAngle); } //Minimum 50rpm. (3200uS is the time per degree at 50rpm).
}
void triggerPri_BasicDistributor()
{
curTime = micros();
curGap = curTime - toothLastToothTime;
if ( (curGap >= triggerFilterTime) )
2017-01-29 22:10:17 -08:00
{
2017-06-15 15:45:39 -07:00
if( (toothCurrentCount == triggerActualTeeth) || (currentStatus.hasSync == false) ) //Check if we're back to the beginning of a revolution
{
toothCurrentCount = 1; //Reset the counter
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.hasSync = true;
currentStatus.startRevolutions++; //Counter
}
else
{
toothCurrentCount++; //Increment the tooth counter
}
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
setFilter(curGap); //Recalc the new filter value
addToothLogEntry(curGap);
if ( configPage4.ignCranklock && BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK) )
2017-06-15 15:45:39 -07:00
{
endCoil1Charge();
endCoil2Charge();
endCoil3Charge();
endCoil4Charge();
}
2017-01-29 22:10:17 -08:00
if(configPage2.perToothIgn == true)
{
uint16_t crankAngle = ( (toothCurrentCount-1) * triggerToothAngle ) + configPage4.triggerAngle;
checkPerToothTiming(crankAngle, toothCurrentCount);
}
2017-06-15 15:45:39 -07:00
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
} //Trigger filter
}
void triggerSec_BasicDistributor() { return; } //Not required
2017-06-15 15:45:39 -07:00
uint16_t getRPM_BasicDistributor()
{
uint16_t tempRPM;
if( currentStatus.RPM < currentStatus.crankRPM )
{
tempRPM = crankingGetRPM(triggerActualTeeth) << 1; //crankGetRPM uses teeth per 360 degrees. As triggerActualTeeh is total teeth in 720 degrees, we divide the tooth count by 2
//revolutionTime = revolutionTime >> 1; //Revolution time has to be divided by 2 as otherwise it would be over 720 degrees (triggerActualTeeth = nCylinders)
}
2018-07-03 00:20:13 -07:00
else { tempRPM = stdGetRPM(720); } //Multiply RPM by 2 due to tracking over 720 degrees now rather than 360
//revolutionTime = revolutionTime >> 1; //Revolution time has to be divided by 2 as otherwise it would be over 720 degrees (triggerActualTeeth = nCylinders)
MAX_STALL_TIME = revolutionTime << 1; //Set the stall time to be twice the current RPM. This is a safe figure as there should be no single revolution where this changes more than this
if(triggerActualTeeth == 1) { MAX_STALL_TIME = revolutionTime << 1; } //Special case for 1 cylinder engines that only get 1 pulse every 720 degrees
if(MAX_STALL_TIME < 366667UL) { MAX_STALL_TIME = 366667UL; } //Check for 50rpm minimum
return tempRPM;
}
int getCrankAngle_BasicDistributor()
2015-06-13 16:01:55 -07:00
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
2017-01-29 22:10:17 -08:00
//Grab some variables that are used in the trigger code and assign them to temp variables.
2015-06-13 16:01:55 -07:00
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc= micros(); //micros() is no longer interrupt safe
2015-06-13 16:01:55 -07:00
interrupts();
2017-01-29 22:10:17 -08:00
int crankAngle = ((tempToothCurrentCount - 1) * triggerToothAngle) + configPage4.triggerAngle; //Number of teeth that have passed since tooth 1, multiplied by the angle each tooth represents, plus the angle that tooth 1 is ATDC. This gives accuracy only to the nearest tooth.
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-01-29 22:10:17 -08:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += CRANK_ANGLE_MAX; }
2017-01-29 22:10:17 -08:00
2015-06-13 16:01:55 -07:00
return crankAngle;
}
void triggerSetEndTeeth_BasicDistributor()
{
ignition1EndTooth = ( (ignition1EndAngle - configPage4.triggerAngle) / triggerToothAngle ) - 1;
if(ignition1EndTooth > configPage4.triggerTeeth) { ignition1EndTooth -= configPage4.triggerTeeth; }
if(ignition1EndTooth <= 0) { ignition1EndTooth += configPage4.triggerTeeth; }
if(ignition1EndTooth > triggerActualTeeth) { ignition1EndTooth = triggerActualTeeth; }
lastToothCalcAdvance = currentStatus.advance;
}
2015-06-13 16:01:55 -07:00
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Name: GM7X
Desc: GM 7X trigger wheel. It has six equally spaced teeth and a seventh tooth for cylinder identification.
2015-06-14 05:11:10 -07:00
Note: Within the code below, the sync tooth is referred to as tooth #3 rather than tooth #7. This makes for simpler angle calculations
2015-06-13 16:01:55 -07:00
*/
void triggerSetup_GM7X()
{
triggerToothAngle = 360 / 6; //The number of degrees that passes from tooth to tooth
secondDerivEnabled = false;
decoderIsSequential = false;
2016-04-26 00:43:19 -07:00
MAX_STALL_TIME = (3333UL * triggerToothAngle); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
2015-06-13 16:01:55 -07:00
}
void triggerPri_GM7X()
{
2015-06-14 05:11:10 -07:00
lastGap = curGap;
2015-06-13 16:01:55 -07:00
curTime = micros();
curGap = curTime - toothLastToothTime;
toothCurrentCount++; //Increment the tooth counter
2017-01-29 22:10:17 -08:00
2015-10-25 12:21:12 -07:00
addToothLogEntry(curGap);
2017-01-29 22:10:17 -08:00
2015-06-14 05:11:10 -07:00
//
if( toothCurrentCount > 7 )
{
2017-01-29 22:10:17 -08:00
toothCurrentCount = 1;
toothOneMinusOneTime = toothOneTime;
2015-06-13 16:01:55 -07:00
toothOneTime = curTime;
2017-06-15 15:45:39 -07:00
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
2015-06-14 05:11:10 -07:00
}
else
{
targetGap = (lastGap) >> 1; //The target gap is set at half the last tooth gap
if ( curGap < targetGap) //If the gap between this tooth and the last one is less than half of the previous gap, then we are very likely at the magical 3rd tooth
2017-01-29 22:10:17 -08:00
{
toothCurrentCount = 3;
2015-06-14 05:11:10 -07:00
currentStatus.hasSync = true;
2017-01-29 22:10:17 -08:00
currentStatus.startRevolutions++; //Counter
2017-06-15 15:45:39 -07:00
}
else
{
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
2017-01-29 22:10:17 -08:00
}
2015-06-14 05:11:10 -07:00
}
2015-06-13 16:01:55 -07:00
}
void triggerSec_GM7X() { return; } //Not required
2017-06-15 15:45:39 -07:00
uint16_t getRPM_GM7X()
2015-06-13 16:01:55 -07:00
{
2018-07-03 00:20:13 -07:00
return stdGetRPM(360);
2015-06-13 16:01:55 -07:00
}
int getCrankAngle_GM7X()
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
2015-06-07 05:05:30 -07:00
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
2017-01-29 22:10:17 -08:00
//Grab some variables that are used in the trigger code and assign them to temp variables.
2015-06-06 16:53:28 -07:00
noInterrupts();
2015-06-07 05:05:30 -07:00
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
2015-06-06 16:53:28 -07:00
interrupts();
2017-01-29 22:10:17 -08:00
2015-06-14 05:11:10 -07:00
//Check if the last tooth seen was the reference tooth (Number 3). All others can be calculated, but tooth 3 has a unique angle
int crankAngle;
if( tempToothCurrentCount < 3 )
{
2017-06-15 15:45:39 -07:00
crankAngle = ((tempToothCurrentCount - 1) * triggerToothAngle) + 42; //Number of teeth that have passed since tooth 1, multiplied by the angle each tooth represents, plus the angle that tooth 1 is ATDC. This gives accuracy only to the nearest tooth.
2015-06-14 05:11:10 -07:00
}
else if( tempToothCurrentCount == 3 )
{
crankAngle = 112;
}
else
{
2017-06-15 15:45:39 -07:00
crankAngle = ((tempToothCurrentCount - 2) * triggerToothAngle) + 42; //Number of teeth that have passed since tooth 1, multiplied by the angle each tooth represents, plus the angle that tooth 1 is ATDC. This gives accuracy only to the nearest tooth.
2015-06-14 05:11:10 -07:00
}
2017-01-29 22:10:17 -08:00
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-01-29 22:10:17 -08:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
2017-01-29 22:10:17 -08:00
return crankAngle;
}
void triggerSetEndTeeth_GM7X()
{
lastToothCalcAdvance = currentStatus.advance;
}
2015-07-12 03:34:59 -07:00
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Name: Mitsubishi 4G63 / NA/NB Miata + MX-5 / 4/2
Desc: TBA
2015-07-30 20:50:29 -07:00
Note: https://raw.githubusercontent.com/noisymime/speeduino/master/reference/wiki/decoders/4g63_trace.png
2015-10-28 07:09:32 -07:00
Tooth #1 is defined as the next crank tooth after the crank signal is HIGH when the cam signal is falling.
2015-07-30 20:50:29 -07:00
Tooth number one is at 355* ATDC
2015-07-12 03:34:59 -07:00
*/
void triggerSetup_4G63()
{
triggerToothAngle = 180; //The number of degrees that passes from tooth to tooth (primary)
toothCurrentCount = 99; //Fake tooth count represents no sync
secondDerivEnabled = false;
decoderIsSequential = true;
decoderHasFixedCrankingTiming = true;
triggerToothAngleIsCorrect = true;
2016-04-26 00:43:19 -07:00
MAX_STALL_TIME = 366667UL; //Minimum 50rpm based on the 110 degree tooth spacing
if(initialisationComplete == false) { toothLastToothTime = micros(); } //Set a startup value here to avoid filter errors when starting. This MUST have the initi check to prevent the fuel pump just staying on all the time
//decoderIsLowRes = true;
2017-01-29 22:10:17 -08:00
//Note that these angles are for every rising and falling edge
if(configPage2.nCylinders == 6)
{
//New values below
toothAngles[0] = 715; //Rising edge of tooth #1
toothAngles[1] = 45; //Falling edge of tooth #1
toothAngles[2] = 115; //Rising edge of tooth #2
toothAngles[3] = 165; //Falling edge of tooth #2
toothAngles[4] = 235; //Rising edge of tooth #3
toothAngles[5] = 285; //Falling edge of tooth #3
toothAngles[6] = 355; //Rising edge of tooth #4
toothAngles[7] = 405; //Falling edge of tooth #4
toothAngles[8] = 475; //Rising edge of tooth #5
toothAngles[9] = 525; //Falling edge of tooth $5
toothAngles[10] = 595; //Rising edge of tooth #6
toothAngles[11] = 645; //Falling edge of tooth #6
triggerActualTeeth = 12; //Both sides of all teeth over 720 degrees
}
else
{
// 70 / 110 for 4 cylinder
toothAngles[0] = 715; //Falling edge of tooth #1
toothAngles[1] = 105; //Rising edge of tooth #2
toothAngles[2] = 175; //Falling edge of tooth #2
toothAngles[3] = 285; //Rising edge of tooth #1
toothAngles[4] = 355; //Falling edge of tooth #1
toothAngles[5] = 465; //Rising edge of tooth #2
toothAngles[6] = 535; //Falling edge of tooth #2
toothAngles[7] = 645; //Rising edge of tooth #1
2018-07-28 21:34:48 -07:00
triggerActualTeeth = 8;
}
2016-10-26 14:49:23 -07:00
/*
* https://forums.libreems.org/attachment.php?aid=34
toothAngles[0] = 715; //Falling edge of tooth #1
toothAngles[1] = 49; //Falling edge of wide cam
toothAngles[2] = 105; //Rising edge of tooth #2
toothAngles[3] = 175; //Falling edge of tooth #2
toothAngles[4] = 229; //Rising edge of narrow cam tooth (??)
toothAngles[5] = 285; //Rising edge of tooth #3
toothAngles[6] = 319; //Falling edge of narrow cam tooth
toothAngles[7] = 355; //falling edge of tooth #3
toothAngles[8] = 465; //Rising edge of tooth #4
toothAngles[9] = 535; //Falling edge of tooth #4
toothAngles[10] = 535; //Rising edge of wide cam tooth
toothAngles[11] = 645; //Rising edge of tooth #1
*/
2017-01-29 22:10:17 -08:00
triggerFilterTime = 1500; //10000 rpm, assuming we're triggering on both edges off the crank tooth.
2015-09-12 00:41:30 -07:00
triggerSecFilterTime = (int)(1000000 / (MAX_RPM / 60 * 2)) / 2; //Same as above, but fixed at 2 teeth on the secondary input and divided by 2 (for cam speed)
triggerSecFilterTime_duration = 4000;
secondaryLastToothTime = 0;
2015-07-12 03:34:59 -07:00
}
void triggerPri_4G63()
{
curTime = micros();
2015-08-16 02:35:46 -07:00
curGap = curTime - toothLastToothTime;
if ( (curGap >= triggerFilterTime) || (currentStatus.startRevolutions == 0) )
2017-01-29 22:10:17 -08:00
{
2017-06-15 15:45:39 -07:00
addToothLogEntry(curGap);
triggerFilterTime = curGap >> 2; //This only applies during non-sync conditions. If there is sync then triggerFilterTime gets changed again below with a better value.
2017-06-15 15:45:39 -07:00
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
toothCurrentCount++;
2017-09-11 21:01:28 -07:00
if( (toothCurrentCount == 1) || (toothCurrentCount > triggerActualTeeth) ) //Trigger is on CHANGE, hence 4 pulses = 1 crank rev (or 6 pulses for 6 cylinders)
{
2017-06-15 15:45:39 -07:00
toothCurrentCount = 1; //Reset the counter
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.startRevolutions++; //Counter
}
2017-06-15 15:45:39 -07:00
if (currentStatus.hasSync == true)
{
if ( BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK) && configPage4.ignCranklock && (currentStatus.startRevolutions >= configPage4.StgCycles))
{
if(configPage2.nCylinders == 4)
{
//This operates in forced wasted spark mode during cranking to align with crank teeth
if( (toothCurrentCount == 1) || (toothCurrentCount == 5) ) { endCoil1Charge(); endCoil3Charge(); }
else if( (toothCurrentCount == 3) || (toothCurrentCount == 7) ) { endCoil2Charge(); endCoil4Charge(); }
}
else if(configPage2.nCylinders == 6)
{
if( (toothCurrentCount == 1) || (toothCurrentCount == 7) ) { endCoil1Charge(); }
else if( (toothCurrentCount == 3) || (toothCurrentCount == 9) ) { endCoil2Charge(); }
else if( (toothCurrentCount == 5) || (toothCurrentCount == 11) ) { endCoil3Charge(); }
}
}
2017-06-15 15:45:39 -07:00
//Whilst this is an uneven tooth pattern, if the specific angle between the last 2 teeth is specified, 1st deriv prediction can be used
if( (configPage4.triggerFilter == 1) || (currentStatus.RPM < 1400) )
2017-06-15 15:45:39 -07:00
{
//Lite filter
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) || (toothCurrentCount == 9) || (toothCurrentCount == 11) )
2017-06-15 15:45:39 -07:00
{
if(configPage2.nCylinders == 4)
{
triggerToothAngle = 70;
triggerFilterTime = curGap; //Trigger filter is set to whatever time it took to do 70 degrees (Next trigger is 110 degrees away)
}
else if(configPage2.nCylinders == 6)
2017-06-15 15:45:39 -07:00
{
triggerToothAngle = 70;
2017-06-15 15:45:39 -07:00
triggerFilterTime = (curGap >> 2); //Trigger filter is set to (70/4)=17.5=17 degrees (Next trigger is 50 degrees away).
}
}
else
{
if(configPage2.nCylinders == 4)
{
triggerToothAngle = 110;
triggerFilterTime = (curGap * 3) >> 3; //Trigger filter is set to (110*3)/8=41.25=41 degrees (Next trigger is 70 degrees away).
}
else if(configPage2.nCylinders == 6)
2017-06-15 15:45:39 -07:00
{
triggerToothAngle = 50;
triggerFilterTime = curGap >> 1; //Trigger filter is set to 25 degrees (Next trigger is 70 degrees away).
2017-06-15 15:45:39 -07:00
}
}
}
else if(configPage4.triggerFilter == 2)
2017-06-15 15:45:39 -07:00
{
//Medium filter level
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) || (toothCurrentCount == 9) || (toothCurrentCount == 11) )
{
triggerToothAngle = 70;
if(configPage2.nCylinders == 4)
{
triggerFilterTime = (curGap * 5) >> 2 ; //87.5 degrees with a target of 110
}
else
{
triggerFilterTime = curGap >> 1 ; //35 degrees with a target of 50
}
}
else
{
if(configPage2.nCylinders == 4)
{
triggerToothAngle = 110;
triggerFilterTime = (curGap >> 1); //55 degrees with a target of 70
}
else
{
triggerToothAngle = 50;
triggerFilterTime = (curGap * 3) >> 2; //Trigger filter is set to (50*3)/4=37.5=37 degrees (Next trigger is 70 degrees away).
}
}
2017-06-15 15:45:39 -07:00
}
else if (configPage4.triggerFilter == 3)
2017-06-15 15:45:39 -07:00
{
//Aggressive filter level
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) || (toothCurrentCount == 9) || (toothCurrentCount == 11) )
{
triggerToothAngle = 70;
if(configPage2.nCylinders == 4)
{
triggerFilterTime = (curGap * 11) >> 3;//96.26 degrees with a target of 110
}
else
{
triggerFilterTime = curGap >> 1 ; //35 degrees with a target of 50
}
}
else
{
if(configPage2.nCylinders == 4)
{
triggerToothAngle = 110;
triggerFilterTime = (curGap * 9) >> 5; //61.87 degrees with a target of 70
}
else
{
triggerToothAngle = 50;
triggerFilterTime = curGap; //50 degrees with a target of 70
}
}
2017-06-15 15:45:39 -07:00
}
else
{
//trigger filter is turned off.
triggerFilterTime = 0;
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) || (toothCurrentCount == 9) || (toothCurrentCount == 11) )
{
if(configPage2.nCylinders == 4) { triggerToothAngle = 70; }
else { triggerToothAngle = 70; }
}
else
{
if(configPage2.nCylinders == 4) { triggerToothAngle = 120; }
else { triggerToothAngle = 50; }
}
}
//EXPERIMENTAL!
if(configPage2.perToothIgn == true)
{
if(configPage2.nCylinders == 4)
{
uint16_t crankAngle = toothAngles[(toothCurrentCount-1)];
checkPerToothTiming(crankAngle, toothCurrentCount);
}
}
2017-06-15 15:45:39 -07:00
} //Has sync
2017-09-11 21:01:28 -07:00
else
{
triggerSecFilterTime = 0;
//New secondary method of determining sync
if(READ_PRI_TRIGGER() == true)
{
if(READ_SEC_TRIGGER() == true) { revolutionOne = true; }
else { revolutionOne = false; }
}
else
{
if( (READ_SEC_TRIGGER() == false) && (revolutionOne == true) )
{
//Crank is low, cam is low and the crank pulse STARTED when the cam was high.
if(configPage2.nCylinders == 4) { toothCurrentCount = 1; } //Means we're at 5* BTDC on a 4G63 4 cylinder
//else if(configPage2.nCylinders == 6) { toothCurrentCount = 8; }
}
2017-12-28 16:59:29 -08:00
//If sequential is ever enabled, the below toothCurrentCount will need to change:
else if( (READ_SEC_TRIGGER() == true) && (revolutionOne == true) )
{
//Crank is low, cam is high and the crank pulse STARTED when the cam was high.
2018-07-28 21:34:48 -07:00
if(configPage2.nCylinders == 4) { toothCurrentCount = 5; } //Means we're at 5* BTDC on a 4G63 4 cylinder
else if(configPage2.nCylinders == 6) { toothCurrentCount = 2; currentStatus.hasSync = true; } //Means we're at 45* ATDC on 6G72 6 cylinder
}
2017-09-11 21:01:28 -07:00
}
}
2017-06-15 15:45:39 -07:00
} //Filter time
2015-07-12 03:34:59 -07:00
}
void triggerSec_4G63()
2017-01-29 22:10:17 -08:00
{
//byte crankState = READ_PRI_TRIGGER();
//First filter is a duration based one to ensure the pulse was of sufficient length (time)
//if(READ_SEC_TRIGGER()) { secondaryLastToothTime1 = micros(); return; }
2017-06-15 15:45:39 -07:00
if(currentStatus.hasSync == true)
{
2017-06-15 15:45:39 -07:00
//1166 is the time taken to cross 70 degrees at 10k rpm
//if ( (micros() - secondaryLastToothTime1) < triggerSecFilterTime_duration ) { return; }
//triggerSecFilterTime_duration = (micros() - secondaryLastToothTime1) >> 1;
}
2015-09-12 00:41:30 -07:00
curTime2 = micros();
curGap2 = curTime2 - toothLastSecToothTime;
if ( (curGap2 >= triggerSecFilterTime) )//|| (currentStatus.startRevolutions == 0) )
2017-06-15 15:45:39 -07:00
{
toothLastSecToothTime = curTime2;
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
triggerSecFilterTime = curGap2 >> 1; //Basic 50% filter for the secondary reading
//More aggressive options:
//62.5%:
//triggerSecFilterTime = (curGap2 * 9) >> 5;
//75%:
//triggerSecFilterTime = (curGap2 * 6) >> 3;
2017-09-11 21:01:28 -07:00
//if( (currentStatus.RPM < currentStatus.crankRPM) || (currentStatus.hasSync == false) )
if( (currentStatus.hasSync == false) )
2015-10-28 07:09:32 -07:00
{
2017-06-15 15:45:39 -07:00
triggerFilterTime = 1500; //If this is removed, can have trouble getting sync again after the engine is turned off (but ECU not reset).
2017-09-11 21:01:28 -07:00
triggerSecFilterTime = triggerSecFilterTime >> 1; //Divide the secondary filter time by 2 again, making it 25%. Only needed when cranking
2018-07-28 21:34:48 -07:00
if(READ_PRI_TRIGGER() == true)
2017-06-15 15:45:39 -07:00
{
if(configPage2.nCylinders == 4)
{
2018-07-28 21:34:48 -07:00
if(toothCurrentCount == 8) { currentStatus.hasSync = true; } //Is 8 for sequential, was 4
}
else if(configPage2.nCylinders == 6)
{
if(toothCurrentCount == 7) { currentStatus.hasSync = true; }
}
2017-06-15 15:45:39 -07:00
}
2017-12-28 16:59:29 -08:00
else
{
if(configPage2.nCylinders == 4)
{
2018-07-28 21:34:48 -07:00
if(toothCurrentCount == 5) { currentStatus.hasSync = true; } //Is 5 for sequential, was 1
}
//Cannot gain sync for 6 cylinder here.
2017-12-28 16:59:29 -08:00
}
}
2017-06-15 15:45:39 -07:00
//if ( (micros() - secondaryLastToothTime1) < triggerSecFilterTime_duration && configPage2.useResync )
2018-07-28 21:34:48 -07:00
if ( (currentStatus.RPM < currentStatus.crankRPM) || (configPage4.useResync == 1) )
{
2018-07-28 21:34:48 -07:00
if( (currentStatus.hasSync == true) && (configPage2.nCylinders == 4) )
2017-06-15 15:45:39 -07:00
{
2018-07-28 21:34:48 -07:00
triggerSecFilterTime_duration = (micros() - secondaryLastToothTime1) >> 1;
if(READ_PRI_TRIGGER() == true)
{
//Whilst we're cranking and have sync, we need to watch for noise pulses.
2018-07-28 21:34:48 -07:00
if(toothCurrentCount != 8)
{
// This should never be true, except when there's noise
currentStatus.hasSync = false;
currentStatus.syncLossCounter++;
}
2018-07-28 21:34:48 -07:00
else { toothCurrentCount = 8; } //Why? Just why?
}
2018-07-28 21:34:48 -07:00
} //Has sync and 4 cylinder
} // Use resync or cranking
2017-06-15 15:45:39 -07:00
} //Trigger filter
2015-07-12 03:34:59 -07:00
}
2017-06-15 15:45:39 -07:00
uint16_t getRPM_4G63()
2015-07-12 03:34:59 -07:00
{
2017-06-15 15:45:39 -07:00
uint16_t tempRPM = 0;
2017-01-29 22:10:17 -08:00
//During cranking, RPM is calculated 4 times per revolution, once for each rising/falling of the crank signal.
//Because these signals aren't even (Alternating 110 and 70 degrees), this needs a special function
2017-06-15 15:45:39 -07:00
if(currentStatus.hasSync == true)
2017-01-29 22:10:17 -08:00
{
if( (currentStatus.RPM < currentStatus.crankRPM) || (configPage2.perToothIgn == true) )
2017-06-15 15:45:39 -07:00
{
int tempToothAngle;
unsigned long toothTime;
if( (toothLastToothTime == 0) || (toothLastMinusOneToothTime == 0) ) { tempRPM = 0; }
else
{
noInterrupts();
tempToothAngle = triggerToothAngle;
toothTime = (toothLastToothTime - toothLastMinusOneToothTime); //Note that trigger tooth angle changes between 70 and 110 depending on the last tooth that was seen (or 70/50 for 6 cylinders)
2017-06-15 15:45:39 -07:00
interrupts();
toothTime = toothTime * 36;
tempRPM = ((unsigned long)tempToothAngle * 6000000UL) / toothTime;
2017-08-02 07:35:10 -07:00
revolutionTime = (10UL * toothTime) / tempToothAngle;
2017-09-11 21:01:28 -07:00
MAX_STALL_TIME = 366667UL; // 50RPM
2017-06-15 15:45:39 -07:00
}
}
else
{
2018-07-28 21:34:48 -07:00
if(configPage2.nCylinders == 4) { tempRPM = stdGetRPM(720); }
else if(configPage2.nCylinders == 6) { tempRPM = stdGetRPM(720); }
//EXPERIMENTAL! Add/subtract RPM based on the last rpmDOT calc
//tempRPM += (micros() - toothOneTime) * currentStatus.rpmDOT
MAX_STALL_TIME = revolutionTime << 1; //Set the stall time to be twice the current RPM. This is a safe figure as there should be no single revolution where this changes more than this
2017-09-11 21:01:28 -07:00
if(MAX_STALL_TIME < 366667UL) { MAX_STALL_TIME = 366667UL; } //Check for 50rpm minimum
}
}
2017-06-15 15:45:39 -07:00
return tempRPM;
2015-07-12 03:34:59 -07:00
}
int getCrankAngle_4G63()
2015-07-12 03:34:59 -07:00
{
2017-06-15 15:45:39 -07:00
int crankAngle = 0;
if(currentStatus.hasSync == true)
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
2018-01-03 01:48:35 -08:00
int tempToothCurrentCount;
2017-06-15 15:45:39 -07:00
//Grab some variables that are used in the trigger code and assign them to temp variables.
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
2017-06-15 15:45:39 -07:00
interrupts();
crankAngle = toothAngles[(tempToothCurrentCount - 1)] + configPage4.triggerAngle; //Perform a lookup of the fixed toothAngles array to find what the angle of the last tooth passed was.
2017-06-15 15:45:39 -07:00
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_TOOTH);
2017-06-15 15:45:39 -07:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
}
2015-07-12 03:34:59 -07:00
return crankAngle;
}
void triggerSetEndTeeth_4G63()
{
if((ignition1EndAngle - configPage4.triggerAngle) > 355) { ignition1EndTooth = 1; }
else { ignition1EndTooth = 4; }
//ignition1EndTooth = 1;
//ignition1EndTooth = ( (ignition1EndAngle - configPage4.triggerAngle) /
lastToothCalcAdvance = currentStatus.advance;
}
2015-07-12 21:22:05 -07:00
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
2016-03-31 14:54:58 -07:00
Name: GM
2015-07-12 21:22:05 -07:00
Desc: TBA
Note: Useful references:
http://www.vems.hu/wiki/index.php?page=MembersPage%2FJorgenKarlsson%2FTwentyFourX
2015-08-16 02:35:46 -07:00
Provided that the cam signal is used, this decoder simply counts the teeth and then looks their angles up against a lookup table. The cam signal is used to determine tooth #1
2015-07-12 21:22:05 -07:00
*/
void triggerSetup_24X()
{
triggerToothAngle = 15; //The number of degrees that passes from tooth to tooth (primary)
2015-07-12 21:22:05 -07:00
toothAngles[0] = 12;
toothAngles[1] = 18;
toothAngles[2] = 33;
toothAngles[3] = 48;
toothAngles[4] = 63;
toothAngles[5] = 78;
toothAngles[6] = 102;
toothAngles[7] = 108;
toothAngles[8] = 123;
toothAngles[9] = 138;
toothAngles[10] = 162;
toothAngles[11] = 177;
toothAngles[12] = 183;
toothAngles[13] = 198;
toothAngles[14] = 222;
toothAngles[15] = 237;
toothAngles[16] = 252;
toothAngles[17] = 258;
toothAngles[18] = 282;
toothAngles[19] = 288;
toothAngles[20] = 312;
toothAngles[21] = 327;
toothAngles[22] = 342;
toothAngles[23] = 357;
2016-04-26 00:43:19 -07:00
MAX_STALL_TIME = (3333UL * triggerToothAngle); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
if(initialisationComplete == false) { toothCurrentCount = 25; toothLastToothTime = micros(); } //Set a startup value here to avoid filter errors when starting. This MUST have the initi check to prevent the fuel pump just staying on all the time
secondDerivEnabled = false;
decoderIsSequential = true;
2015-07-12 21:22:05 -07:00
}
void triggerPri_24X()
{
2017-06-15 15:45:39 -07:00
if(toothCurrentCount == 25) { currentStatus.hasSync = false; } //Indicates sync has not been achieved (Still waiting for 1 revolution of the crank to take place)
2015-07-12 21:22:05 -07:00
else
{
2017-06-15 15:45:39 -07:00
curTime = micros();
curGap = curTime - toothLastToothTime;
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
if(toothCurrentCount == 0)
{
toothCurrentCount = 1; //Reset the counter
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
revolutionOne = !revolutionOne; //Sequential revolution flip
2017-06-15 15:45:39 -07:00
currentStatus.hasSync = true;
currentStatus.startRevolutions++; //Counter
triggerToothAngle = 15; //Always 15 degrees for tooth #15
2017-06-15 15:45:39 -07:00
}
else
{
toothCurrentCount++; //Increment the tooth counter
triggerToothAngle = toothAngles[(toothCurrentCount-1)] - toothAngles[(toothCurrentCount-2)]; //Calculate the last tooth gap in degrees
2017-06-15 15:45:39 -07:00
}
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
addToothLogEntry(curGap);
toothLastToothTime = curTime;
2017-06-15 15:45:39 -07:00
}
2015-07-12 21:22:05 -07:00
}
2017-06-15 15:45:39 -07:00
2015-07-12 21:22:05 -07:00
void triggerSec_24X()
2017-01-29 22:10:17 -08:00
{
2015-07-12 21:22:05 -07:00
toothCurrentCount = 0; //All we need to do is reset the tooth count back to zero, indicating that we're at the beginning of a new revolution
revolutionOne = 1; //Sequential revolution reset
2015-07-12 21:22:05 -07:00
}
2017-06-15 15:45:39 -07:00
uint16_t getRPM_24X()
2015-07-12 21:22:05 -07:00
{
2018-07-03 00:20:13 -07:00
return stdGetRPM(360);
2015-07-12 21:22:05 -07:00
}
int getCrankAngle_24X()
2015-07-12 21:22:05 -07:00
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount, tempRevolutionOne;
2017-01-29 22:10:17 -08:00
//Grab some variables that are used in the trigger code and assign them to temp variables.
2015-07-12 21:22:05 -07:00
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
tempRevolutionOne = revolutionOne;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
2015-07-12 21:22:05 -07:00
interrupts();
2017-01-29 22:10:17 -08:00
2015-07-23 21:07:05 -07:00
int crankAngle;
2018-02-11 15:45:02 -08:00
if (tempToothCurrentCount == 0) { crankAngle = 0 + configPage4.triggerAngle; } //This is the special case to handle when the 'last tooth' seen was the cam tooth. 0 is the angle at which the crank tooth goes high (Within 360 degrees).
else { crankAngle = toothAngles[(tempToothCurrentCount - 1)] + configPage4.triggerAngle;} //Perform a lookup of the fixed toothAngles array to find what the angle of the last tooth passed was.
2017-01-29 22:10:17 -08:00
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-01-29 22:10:17 -08:00
//Sequential check (simply sets whether we're on the first or 2nd revoltuion of the cycle)
2018-02-11 15:45:02 -08:00
if (tempRevolutionOne == 1) { crankAngle += 360; }
2017-01-29 22:10:17 -08:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
2017-01-29 22:10:17 -08:00
2015-07-23 21:07:05 -07:00
return crankAngle;
}
void triggerSetEndTeeth_24X()
{
lastToothCalcAdvance = currentStatus.advance;
}
2015-07-23 21:07:05 -07:00
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Name: Jeep 2000
Desc: For '91 to 2000 6 cylinder Jeep engines
Note: Quite similar to the 24X setup. 24 crank teeth over 720 degrees, in groups of 4. Crank wheel is high for 360 crank degrees. AS we only need timing within 360 degrees, only 12 tooth angles are defined.
Tooth number 1 represents the first tooth seen after the cam signal goes high
http://speeduino.com/forum/download/file.php?id=205
*/
void triggerSetup_Jeep2000()
{
triggerToothAngle = 0; //The number of degrees that passes from tooth to tooth (primary)
2015-07-23 21:07:05 -07:00
toothAngles[0] = 174;
toothAngles[1] = 194;
toothAngles[2] = 214;
toothAngles[3] = 234;
toothAngles[4] = 294;
toothAngles[5] = 314;
toothAngles[6] = 334;
toothAngles[7] = 354;
toothAngles[8] = 414;
toothAngles[9] = 434;
toothAngles[10] = 454;
toothAngles[11] = 474;
2016-04-26 00:43:19 -07:00
2017-01-29 22:10:17 -08:00
MAX_STALL_TIME = (3333UL * 60); //Minimum 50rpm. (3333uS is the time per degree at 50rpm). Largest gap between teeth is 60 degrees.
2018-02-11 15:45:02 -08:00
if(initialisationComplete == false) { toothCurrentCount = 13; toothLastToothTime = micros(); } //Set a startup value here to avoid filter errors when starting. This MUST have the initi check to prevent the fuel pump just staying on all the time
secondDerivEnabled = false;
2016-04-26 00:43:19 -07:00
decoderIsSequential = false;
2015-07-23 21:07:05 -07:00
}
void triggerPri_Jeep2000()
{
2017-06-15 15:45:39 -07:00
if(toothCurrentCount == 13) { currentStatus.hasSync = false; } //Indicates sync has not been achieved (Still waiting for 1 revolution of the crank to take place)
2015-07-23 21:07:05 -07:00
else
{
2017-06-15 15:45:39 -07:00
curTime = micros();
curGap = curTime - toothLastToothTime;
if ( curGap >= triggerFilterTime )
{
if(toothCurrentCount == 0)
{
toothCurrentCount = 1; //Reset the counter
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.hasSync = true;
currentStatus.startRevolutions++; //Counter
}
else
{
toothCurrentCount++; //Increment the tooth counter
}
2017-06-15 15:45:39 -07:00
setFilter(curGap); //Recalc the new filter value
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
addToothLogEntry(curGap);
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
} //Trigger filter
} //Sync check
2015-07-23 21:07:05 -07:00
}
void triggerSec_Jeep2000()
2017-01-29 22:10:17 -08:00
{
2015-07-23 21:07:05 -07:00
toothCurrentCount = 0; //All we need to do is reset the tooth count back to zero, indicating that we're at the beginning of a new revolution
2017-01-29 22:10:17 -08:00
return;
2015-07-23 21:07:05 -07:00
}
2017-06-15 15:45:39 -07:00
uint16_t getRPM_Jeep2000()
2015-07-23 21:07:05 -07:00
{
2018-07-03 00:20:13 -07:00
return stdGetRPM(360);
2015-07-23 21:07:05 -07:00
}
int getCrankAngle_Jeep2000()
2015-07-23 21:07:05 -07:00
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
2017-01-29 22:10:17 -08:00
//Grab some variables that are used in the trigger code and assign them to temp variables.
2015-07-23 21:07:05 -07:00
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
2015-07-23 21:07:05 -07:00
interrupts();
2017-01-29 22:10:17 -08:00
2015-07-23 21:07:05 -07:00
int crankAngle;
if (toothCurrentCount == 0) { crankAngle = 146 + configPage4.triggerAngle; } //This is the special case to handle when the 'last tooth' seen was the cam tooth. 146 is the angle at which the crank tooth goes high.
else { crankAngle = toothAngles[(tempToothCurrentCount - 1)] + configPage4.triggerAngle;} //Perform a lookup of the fixed toothAngles array to find what the angle of the last tooth passed was.
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-01-29 22:10:17 -08:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
2017-01-29 22:10:17 -08:00
2015-07-12 21:22:05 -07:00
return crankAngle;
}
void triggerSetEndTeeth_Jeep2000()
{
lastToothCalcAdvance = currentStatus.advance;
}
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
2015-12-14 21:06:42 -08:00
Name: Audi 135
2017-01-29 22:10:17 -08:00
Desc: 135 teeth on the crank and 1 tooth on the cam.
2015-12-14 21:06:42 -08:00
Note: This is very similar to the dual wheel decoder, however due to the 135 teeth not dividing evenly into 360, only every 3rd crank tooth is used in calculating the crank angle. This effectively makes it a 45 tooth dual wheel setup
*/
void triggerSetup_Audi135()
{
triggerToothAngle = 8; //135/3 = 45, 360/45 = 8 degrees every 3 teeth
toothCurrentCount = 255; //Default value
toothSystemCount = 0;
triggerFilterTime = (unsigned long)(1000000 / (MAX_RPM / 60 * 135UL)); //Trigger filter time is the shortest possible time (in uS) that there can be between crank teeth (ie at max RPM). Any pulses that occur faster than this time will be disgarded as noise
2015-12-14 21:06:42 -08:00
triggerSecFilterTime = (int)(1000000 / (MAX_RPM / 60 * 2)) / 2; //Same as above, but fixed at 2 teeth on the secondary input and divided by 2 (for cam speed)
2016-04-26 00:43:19 -07:00
MAX_STALL_TIME = (3333UL * triggerToothAngle); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
2015-12-14 21:06:42 -08:00
secondDerivEnabled = false;
decoderIsSequential = true;
triggerToothAngleIsCorrect = true;
2015-12-14 21:06:42 -08:00
}
void triggerPri_Audi135()
2017-01-29 22:10:17 -08:00
{
2015-12-14 21:06:42 -08:00
curTime = micros();
curGap = curTime - toothSystemLastToothTime;
2017-08-02 07:35:10 -07:00
if ( (curGap > triggerFilterTime) || (currentStatus.startRevolutions == 0) )
2017-06-15 15:45:39 -07:00
{
toothSystemCount++;
2017-06-15 15:45:39 -07:00
if ( currentStatus.hasSync == false ) { toothLastToothTime = curTime; }
else
{
if ( toothSystemCount >= 3 )
{
//We only proceed for every third tooth
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
addToothLogEntry(curGap);
toothSystemLastToothTime = curTime;
toothSystemCount = 0;
toothCurrentCount++; //Increment the tooth counter
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
if ( (toothCurrentCount == 1) || (toothCurrentCount > 45) )
{
toothCurrentCount = 1;
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
revolutionOne = !revolutionOne;
currentStatus.startRevolutions++; //Counter
}
2017-06-15 15:45:39 -07:00
setFilter(curGap); //Recalc the new filter value
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
} //3rd tooth check
} // Sync check
} // Trigger filter
2015-12-14 21:06:42 -08:00
}
void triggerSec_Audi135()
2017-01-29 22:10:17 -08:00
{
2017-03-07 19:02:05 -08:00
/*
2015-12-14 21:06:42 -08:00
curTime2 = micros();
curGap2 = curTime2 - toothLastSecToothTime;
2017-01-29 22:10:17 -08:00
if ( curGap2 < triggerSecFilterTime ) { return; }
2015-12-14 21:06:42 -08:00
toothLastSecToothTime = curTime2;
2017-03-07 19:02:05 -08:00
*/
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
if( currentStatus.hasSync == false )
2015-12-14 21:06:42 -08:00
{
toothCurrentCount = 0;
currentStatus.hasSync = true;
2016-01-02 19:34:51 -08:00
toothSystemCount = 3; //Need to set this to 3 so that the next primary tooth is counted
2015-12-14 21:06:42 -08:00
}
else if (configPage4.useResync == 1) { toothCurrentCount = 0; toothSystemCount = 3; }
2017-06-15 15:45:39 -07:00
else if ( (currentStatus.startRevolutions < 100) && (toothCurrentCount != 45) ) { toothCurrentCount = 0; }
revolutionOne = 1; //Sequential revolution reset
2017-01-29 22:10:17 -08:00
}
2015-12-14 21:06:42 -08:00
2017-06-15 15:45:39 -07:00
uint16_t getRPM_Audi135()
2015-12-14 21:06:42 -08:00
{
2018-07-03 00:20:13 -07:00
return stdGetRPM(360);
2015-12-14 21:06:42 -08:00
}
int getCrankAngle_Audi135()
2017-01-29 22:10:17 -08:00
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
2016-01-02 19:34:51 -08:00
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
bool tempRevolutionOne;
2017-01-29 22:10:17 -08:00
//Grab some variables that are used in the trigger code and assign them to temp variables.
2016-01-02 19:34:51 -08:00
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
tempRevolutionOne = revolutionOne;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
2016-01-02 19:34:51 -08:00
interrupts();
2017-01-29 22:10:17 -08:00
2016-01-02 19:34:51 -08:00
//Handle case where the secondary tooth was the last one seen
if(tempToothCurrentCount == 0) { tempToothCurrentCount = 45; }
2017-01-29 22:10:17 -08:00
int crankAngle = ((tempToothCurrentCount - 1) * triggerToothAngle) + configPage4.triggerAngle; //Number of teeth that have passed since tooth 1, multiplied by the angle each tooth represents, plus the angle that tooth 1 is ATDC. This gives accuracy only to the nearest tooth.
2016-01-02 19:34:51 -08:00
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-01-29 22:10:17 -08:00
//Sequential check (simply sets whether we're on the first or 2nd revoltuion of the cycle)
if (tempRevolutionOne) { crankAngle += 360; }
2017-01-29 22:10:17 -08:00
if (crankAngle >= 720) { crankAngle -= 720; }
else if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += CRANK_ANGLE_MAX; }
2017-01-29 22:10:17 -08:00
2016-01-02 19:34:51 -08:00
return crankAngle;
2015-12-14 21:06:42 -08:00
}
void triggerSetEndTeeth_Audi135()
{
lastToothCalcAdvance = currentStatus.advance;
}
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Name: Honda D17
2017-01-29 22:10:17 -08:00
Desc:
Note:
*/
void triggerSetup_HondaD17()
{
triggerToothAngle = 360 / 12; //The number of degrees that passes from tooth to tooth
2016-04-26 00:43:19 -07:00
MAX_STALL_TIME = (3333UL * triggerToothAngle); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
secondDerivEnabled = false;
decoderIsSequential = false;
}
void triggerPri_HondaD17()
{
lastGap = curGap;
curTime = micros();
curGap = curTime - toothLastToothTime;
toothCurrentCount++; //Increment the tooth counter
2017-01-29 22:10:17 -08:00
addToothLogEntry(curGap);
2017-01-29 22:10:17 -08:00
//
2017-06-15 15:45:39 -07:00
if( (toothCurrentCount == 13) && (currentStatus.hasSync == true) )
2016-02-17 20:00:08 -08:00
{
2017-01-29 22:10:17 -08:00
toothCurrentCount = 0;
2016-02-17 20:00:08 -08:00
}
2017-06-15 15:45:39 -07:00
else if( (toothCurrentCount == 1) && (currentStatus.hasSync == true) )
{
2017-01-29 22:10:17 -08:00
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
2017-01-29 22:10:17 -08:00
currentStatus.startRevolutions++; //Counter
2017-06-15 15:45:39 -07:00
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
}
else
{
2016-02-28 23:26:37 -08:00
//13th tooth
targetGap = (lastGap) >> 1; //The target gap is set at half the last tooth gap
if ( curGap < targetGap) //If the gap between this tooth and the last one is less than half of the previous gap, then we are very likely at the magical 13th tooth
2017-01-29 22:10:17 -08:00
{
toothCurrentCount = 0;
currentStatus.hasSync = true;
2017-06-15 15:45:39 -07:00
}
else
{
//The tooth times below don't get set on tooth 13(The magical 13th tooth should not be considered for any calculations that use those times)
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
2017-01-29 22:10:17 -08:00
}
}
2017-01-29 22:10:17 -08:00
}
void triggerSec_HondaD17() { return; } //The 4+1 signal on the cam is yet to be supported
2017-06-15 15:45:39 -07:00
uint16_t getRPM_HondaD17()
{
2018-07-03 00:20:13 -07:00
return stdGetRPM(360);
}
int getCrankAngle_HondaD17()
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
2017-01-29 22:10:17 -08:00
//Grab some variables that are used in the trigger code and assign them to temp variables.
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
interrupts();
2017-01-29 22:10:17 -08:00
//Check if the last tooth seen was the reference tooth 13 (Number 0 here). All others can be calculated, but tooth 3 has a unique angle
int crankAngle;
if( tempToothCurrentCount == 0 )
{
crankAngle = (11 * triggerToothAngle) + configPage4.triggerAngle; //if temptoothCurrentCount is 0, the last tooth seen was the 13th one. Based on this, ignore the 13th tooth and use the 12th one as the last reference.
}
else
{
crankAngle = ((tempToothCurrentCount - 1) * triggerToothAngle) + configPage4.triggerAngle; //Number of teeth that have passed since tooth 1, multiplied by the angle each tooth represents, plus the angle that tooth 1 is ATDC. This gives accuracy only to the nearest tooth.
}
2017-01-29 22:10:17 -08:00
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-01-29 22:10:17 -08:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
2017-01-29 22:10:17 -08:00
return crankAngle;
}
void triggerSetEndTeeth_HondaD17()
{
lastToothCalcAdvance = currentStatus.advance;
}
2016-02-28 23:26:37 -08:00
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Name: Miata '99 to '05
Desc: TBA (See: http://forum.diyefi.org/viewtopic.php?f=56&t=1077)
Note: 4x 70 degree duration teeth running at cam speed. Believed to be at the same angles as the 4g63 decoder
Tooth #1 is defined as the next crank tooth after the crank signal is HIGH when the cam signal is falling.
Tooth number one is at 355* ATDC
*/
void triggerSetup_Miata9905()
{
triggerToothAngle = 90; //The number of degrees that passes from tooth to tooth (primary)
toothCurrentCount = 99; //Fake tooth count represents no sync
secondDerivEnabled = false;
decoderIsSequential = true;
triggerActualTeeth = 8;
if(initialisationComplete == false) { secondaryToothCount = 0; toothLastToothTime = micros(); } //Set a startup value here to avoid filter errors when starting. This MUST have the initi check to prevent the fuel pump just staying on all the time
else { toothLastToothTime = 0; }
2017-08-29 19:53:56 -07:00
toothLastMinusOneToothTime = 0;
2017-01-29 22:10:17 -08:00
2016-02-28 23:26:37 -08:00
//Note that these angles are for every rising and falling edge
2017-01-29 22:10:17 -08:00
/*
toothAngles[0] = 350;
toothAngles[1] = 100;
toothAngles[2] = 170;
toothAngles[3] = 280;
*/
toothAngles[0] = 710; //
toothAngles[1] = 100; //First crank pulse after the SINGLE cam pulse
toothAngles[2] = 170; //
toothAngles[3] = 280; //
toothAngles[4] = 350; //
toothAngles[5] = 460; //First crank pulse AFTER the DOUBLE cam pulse
toothAngles[6] = 530; //
toothAngles[7] = 640; //
2016-04-26 00:43:19 -07:00
MAX_STALL_TIME = (3333UL * triggerToothAngle); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
2017-01-29 22:10:17 -08:00
triggerFilterTime = 1500; //10000 rpm, assuming we're triggering on both edges off the crank tooth.
2017-08-27 20:02:06 -07:00
triggerSecFilterTime = 0; //Need to figure out something better for this
decoderHasFixedCrankingTiming = true;
triggerToothAngleIsCorrect = true;
2016-02-28 23:26:37 -08:00
}
void triggerPri_Miata9905()
{
curTime = micros();
curGap = curTime - toothLastToothTime;
2017-08-30 22:03:39 -07:00
if ( (curGap >= triggerFilterTime) || (currentStatus.startRevolutions == 0) )
2017-01-29 22:10:17 -08:00
{
2017-06-15 15:45:39 -07:00
toothCurrentCount++;
2017-08-29 19:53:56 -07:00
if( (toothCurrentCount == (triggerActualTeeth + 1)) )
2017-06-15 15:45:39 -07:00
{
toothCurrentCount = 1; //Reset the counter
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
//currentStatus.hasSync = true;
2017-06-15 15:45:39 -07:00
currentStatus.startRevolutions++; //Counter
}
else
{
if( (currentStatus.hasSync == false) || (configPage4.useResync == true) )
{
if(secondaryToothCount == 2)
{
toothCurrentCount = 6;
currentStatus.hasSync = true;
}
}
}
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
if (currentStatus.hasSync == true)
{
addToothLogEntry(curGap);
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
//Whilst this is an uneven tooth pattern, if the specific angle between the last 2 teeth is specified, 1st deriv prediction can be used
if( (configPage4.triggerFilter == 1) || (currentStatus.RPM < 1400) )
2017-08-27 20:02:06 -07:00
{
//Lite filter
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) ) { triggerToothAngle = 70; triggerFilterTime = curGap; } //Trigger filter is set to whatever time it took to do 70 degrees (Next trigger is 110 degrees away)
else { triggerToothAngle = 110; triggerFilterTime = (curGap * 3) >> 3; } //Trigger filter is set to (110*3)/8=41.25=41 degrees (Next trigger is 70 degrees away).
}
else if(configPage4.triggerFilter == 2)
2017-08-27 20:02:06 -07:00
{
//Medium filter level
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) ) { triggerToothAngle = 70; triggerFilterTime = (curGap * 5) >> 2 ; } //87.5 degrees with a target of 110
else { triggerToothAngle = 110; triggerFilterTime = (curGap >> 1); } //55 degrees with a target of 70
}
else if (configPage4.triggerFilter == 3)
2017-08-27 20:02:06 -07:00
{
//Aggressive filter level
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) ) { triggerToothAngle = 70; triggerFilterTime = (curGap * 11) >> 3 ; } //96.26 degrees with a target of 110
else { triggerToothAngle = 110; triggerFilterTime = (curGap * 9) >> 5; } //61.87 degrees with a target of 70
}
else if (configPage4.triggerFilter == 0)
2017-08-27 20:02:06 -07:00
{
//trigger filter is turned off.
triggerFilterTime = 0;
2017-08-29 19:53:56 -07:00
triggerSecFilterTime = 0;
2017-08-27 20:02:06 -07:00
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) ) { triggerToothAngle = 70; } //96.26 degrees with a target of 110
else { triggerToothAngle = 110; }
2017-08-27 20:02:06 -07:00
}
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
} //Has sync
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
//if ( BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK) && configPage4.ignCranklock)
if ( (currentStatus.RPM < (currentStatus.crankRPM + 30)) && configPage4.ignCranklock) //The +30 here is a safety margin. When switching from fixed timing to normal, there can be a situation where a pulse started when fixed and ending when in normal mode causes problems. This prevents that.
{
if( (toothCurrentCount == 1) || (toothCurrentCount == 5) ) { endCoil1Charge(); endCoil3Charge(); }
else if( (toothCurrentCount == 3) || (toothCurrentCount == 7) ) { endCoil2Charge(); endCoil4Charge(); }
}
secondaryToothCount = 0;
2017-06-15 15:45:39 -07:00
} //Trigger filter
2016-02-28 23:26:37 -08:00
}
2017-06-15 15:45:39 -07:00
2016-02-28 23:26:37 -08:00
void triggerSec_Miata9905()
2017-01-29 22:10:17 -08:00
{
2016-02-28 23:26:37 -08:00
curTime2 = micros();
curGap2 = curTime2 - toothLastSecToothTime;
2017-08-28 07:11:50 -07:00
if(BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK) || (currentStatus.hasSync == false) )
{
triggerFilterTime = 1500; //If this is removed, can have trouble getting sync again after the engine is turned off (but ECU not reset).
}
2017-06-15 15:45:39 -07:00
if ( curGap2 >= triggerSecFilterTime )
2016-02-28 23:26:37 -08:00
{
2017-06-15 15:45:39 -07:00
toothLastSecToothTime = curTime2;
lastGap = curGap2;
secondaryToothCount++;
2017-06-15 15:45:39 -07:00
//TODO Add some secondary filtering here
2016-02-28 23:26:37 -08:00
}
}
2017-06-15 15:45:39 -07:00
uint16_t getRPM_Miata9905()
2016-02-28 23:26:37 -08:00
{
2017-01-29 22:10:17 -08:00
//During cranking, RPM is calculated 4 times per revolution, once for each tooth on the crank signal.
2016-02-28 23:26:37 -08:00
//Because these signals aren't even (Alternating 110 and 70 degrees), this needs a special function
2017-06-15 15:45:39 -07:00
uint16_t tempRPM = 0;
if( (currentStatus.RPM < currentStatus.crankRPM) && (currentStatus.hasSync == true) )
2017-01-29 22:10:17 -08:00
{
2017-08-29 19:53:56 -07:00
if( (toothLastToothTime == 0) || (toothLastMinusOneToothTime == 0) ) { tempRPM = 0; }
else
{
int tempToothAngle;
unsigned long toothTime;
noInterrupts();
tempToothAngle = triggerToothAngle;
toothTime = (toothLastToothTime - toothLastMinusOneToothTime); //Note that trigger tooth angle changes between 70 and 110 depending on the last tooth that was seen
interrupts();
toothTime = toothTime * 36;
tempRPM = ((unsigned long)tempToothAngle * 6000000UL) / toothTime;
revolutionTime = (10UL * toothTime) / tempToothAngle;
MAX_STALL_TIME = 366667UL; // 50RPM
2017-08-29 19:53:56 -07:00
}
2016-02-28 23:26:37 -08:00
}
else
{
2018-07-03 00:20:13 -07:00
tempRPM = stdGetRPM(720);
revolutionTime = revolutionTime / 2;
MAX_STALL_TIME = revolutionTime << 1; //Set the stall time to be twice the current RPM. This is a safe figure as there should be no single revolution where this changes more than this
if(MAX_STALL_TIME < 366667UL) { MAX_STALL_TIME = 366667UL; } //Check for 50rpm minimum
}
2017-06-15 15:45:39 -07:00
return tempRPM;
2016-02-28 23:26:37 -08:00
}
int getCrankAngle_Miata9905()
2016-02-28 23:26:37 -08:00
{
2017-06-15 15:45:39 -07:00
int crankAngle = 0;
//if(currentStatus.hasSync == true)
2017-06-15 15:45:39 -07:00
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
//Grab some variables that are used in the trigger code and assign them to temp variables.
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
2017-06-15 15:45:39 -07:00
interrupts();
crankAngle = toothAngles[(tempToothCurrentCount - 1)] + configPage4.triggerAngle; //Perform a lookup of the fixed toothAngles array to find what the angle of the last tooth passed was.
2017-06-15 15:45:39 -07:00
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-06-15 15:45:39 -07:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
}
2017-01-29 22:10:17 -08:00
2016-02-28 23:26:37 -08:00
return crankAngle;
}
void triggerSetEndTeeth_Miata9905()
{
lastToothCalcAdvance = currentStatus.advance;
}
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Name: Mazda AU version
2017-01-29 22:10:17 -08:00
Desc:
Note:
Tooth #2 is defined as the next crank tooth after the single cam tooth
Tooth number one is at 348* ATDC
*/
void triggerSetup_MazdaAU()
{
triggerToothAngle = 108; //The number of degrees that passes from tooth to tooth (primary). This is the maximum gap
toothCurrentCount = 99; //Fake tooth count represents no sync
secondaryToothCount = 0; //Needed for the cam tooth tracking
secondDerivEnabled = false;
decoderIsSequential = true;
2017-01-29 22:10:17 -08:00
toothAngles[0] = 348; //tooth #1
toothAngles[1] = 96; //tooth #2
toothAngles[2] = 168; //tooth #3
toothAngles[3] = 276; //tooth #4
MAX_STALL_TIME = (3333UL * triggerToothAngle); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
2017-01-29 22:10:17 -08:00
triggerFilterTime = 1500; //10000 rpm, assuming we're triggering on both edges off the crank tooth.
triggerSecFilterTime = (int)(1000000 / (MAX_RPM / 60 * 2)) / 2; //Same as above, but fixed at 2 teeth on the secondary input and divided by 2 (for cam speed)
decoderHasFixedCrankingTiming = true;
}
void triggerPri_MazdaAU()
{
curTime = micros();
curGap = curTime - toothLastToothTime;
2017-06-15 15:45:39 -07:00
if ( curGap >= triggerFilterTime )
2017-01-29 22:10:17 -08:00
{
2017-06-15 15:45:39 -07:00
addToothLogEntry(curGap);
2017-06-15 15:45:39 -07:00
toothCurrentCount++;
if( (toothCurrentCount == 1) || (toothCurrentCount == 5) ) //Trigger is on CHANGE, hence 4 pulses = 1 crank rev
{
toothCurrentCount = 1; //Reset the counter
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.hasSync = true;
currentStatus.startRevolutions++; //Counter
}
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
if (currentStatus.hasSync == true)
{
// Locked cranking timing is available, fixed at 12* BTDC
if ( BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK) && configPage4.ignCranklock )
2017-06-15 15:45:39 -07:00
{
if( toothCurrentCount == 1 ) { endCoil1Charge(); }
else if( toothCurrentCount == 3 ) { endCoil2Charge(); }
}
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
//Whilst this is an uneven tooth pattern, if the specific angle between the last 2 teeth is specified, 1st deriv prediction can be used
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) ) { triggerToothAngle = 72; triggerFilterTime = curGap; } //Trigger filter is set to whatever time it took to do 72 degrees (Next trigger is 108 degrees away)
else { triggerToothAngle = 108; triggerFilterTime = (curGap * 3) >> 3; } //Trigger filter is set to (108*3)/8=40 degrees (Next trigger is 70 degrees away).
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
} //Has sync
} //Filter time
}
2017-06-15 15:45:39 -07:00
void triggerSec_MazdaAU()
2017-01-29 22:10:17 -08:00
{
curTime2 = micros();
2016-08-05 00:01:28 -07:00
lastGap = curGap2;
curGap2 = curTime2 - toothLastSecToothTime;
2017-01-29 22:10:17 -08:00
//if ( curGap2 < triggerSecFilterTime ) { return; }
toothLastSecToothTime = curTime2;
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
//if(BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK) || currentStatus.hasSync == false)
if(currentStatus.hasSync == false)
{
//we find sync by looking for the 2 teeth that are close together. The next crank tooth after that is the one we're looking for.
//For the sake of this decoder, the lone cam tooth will be designated #1
if(secondaryToothCount == 2)
2017-01-29 22:10:17 -08:00
{
toothCurrentCount = 1;
currentStatus.hasSync = true;
}
else
{
2017-01-29 22:10:17 -08:00
triggerFilterTime = 1500; //In case the engine has been running and then lost sync.
targetGap = (lastGap) >> 1; //The target gap is set at half the last tooth gap
2016-08-05 00:01:28 -07:00
if ( curGap2 < targetGap) //If the gap between this tooth and the last one is less than half of the previous gap, then we are very likely at the extra (3rd) tooth on the cam). This tooth is located at 421 crank degrees (aka 61 degrees) and therefore the last crank tooth seen was number 1 (At 350 degrees)
{
secondaryToothCount = 2;
}
}
secondaryToothCount++;
}
}
2017-06-15 15:45:39 -07:00
uint16_t getRPM_MazdaAU()
{
2017-06-15 15:45:39 -07:00
uint16_t tempRPM = 0;
2017-01-29 22:10:17 -08:00
2017-06-15 15:45:39 -07:00
if (currentStatus.hasSync == true)
2017-01-29 22:10:17 -08:00
{
2017-06-15 15:45:39 -07:00
//During cranking, RPM is calculated 4 times per revolution, once for each tooth on the crank signal.
//Because these signals aren't even (Alternating 108 and 72 degrees), this needs a special function
if(currentStatus.RPM < currentStatus.crankRPM)
2017-06-15 15:45:39 -07:00
{
int tempToothAngle;
noInterrupts();
tempToothAngle = triggerToothAngle;
revolutionTime = (toothLastToothTime - toothLastMinusOneToothTime); //Note that trigger tooth angle changes between 72 and 108 depending on the last tooth that was seen
interrupts();
revolutionTime = revolutionTime * 36;
tempRPM = (tempToothAngle * 60000000L) / revolutionTime;
}
2018-07-03 00:20:13 -07:00
else { tempRPM = stdGetRPM(360); }
}
2017-06-15 15:45:39 -07:00
return tempRPM;
}
int getCrankAngle_MazdaAU()
{
2017-06-15 15:45:39 -07:00
int crankAngle = 0;
if(currentStatus.hasSync == true)
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
//Grab some variables that are used in the trigger code and assign them to temp variables.
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
2017-06-15 15:45:39 -07:00
interrupts();
crankAngle = toothAngles[(tempToothCurrentCount - 1)] + configPage4.triggerAngle; //Perform a lookup of the fixed toothAngles array to find what the angle of the last tooth passed was.
2017-06-15 15:45:39 -07:00
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-06-15 15:45:39 -07:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
}
2017-01-29 22:10:17 -08:00
return crankAngle;
}
void triggerSetEndTeeth_MazdaAU()
{
lastToothCalcAdvance = currentStatus.advance;
}
2017-01-29 22:10:17 -08:00
/*
Name: Non-360 Dual wheel
2017-01-29 22:10:17 -08:00
Desc: 2 wheels located either both on the crank or with the primary on the crank and the secondary on the cam.
Note: There can be no missing teeth on the primary wheel
*/
void triggerSetup_non360()
{
triggerToothAngle = (360 * configPage4.TrigAngMul) / configPage4.triggerTeeth; //The number of degrees that passes from tooth to tooth multiplied by the additional multiplier
toothCurrentCount = 255; //Default value
triggerFilterTime = (int)(1000000 / (MAX_RPM / 60 * configPage4.triggerTeeth)); //Trigger filter time is the shortest possible time (in uS) that there can be between crank teeth (ie at max RPM). Any pulses that occur faster than this time will be disgarded as noise
triggerSecFilterTime = (int)(1000000 / (MAX_RPM / 60 * 2)) / 2; //Same as above, but fixed at 2 teeth on the secondary input and divided by 2 (for cam speed)
secondDerivEnabled = false;
decoderIsSequential = true;
MAX_STALL_TIME = (3333UL * triggerToothAngle); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
}
void triggerPri_non360()
2017-01-29 22:10:17 -08:00
{
2016-09-21 07:58:04 -07:00
//This is not used, the trigger is identical to the dual wheel one, so that is used instead.
}
void triggerSec_non360()
2017-01-29 22:10:17 -08:00
{
2016-09-21 07:58:04 -07:00
//This is not used, the trigger is identical to the dual wheel one, so that is used instead.
2017-01-29 22:10:17 -08:00
}
2017-06-15 15:45:39 -07:00
uint16_t getRPM_non360()
{
2017-06-15 15:45:39 -07:00
uint16_t tempRPM = 0;
if( (currentStatus.hasSync == true) && (toothCurrentCount != 0) )
{
if(currentStatus.RPM < currentStatus.crankRPM) { tempRPM = crankingGetRPM(configPage4.triggerTeeth); }
2018-07-03 00:20:13 -07:00
else { tempRPM = stdGetRPM(360); }
2017-06-15 15:45:39 -07:00
}
return tempRPM;
}
int getCrankAngle_non360()
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
2017-01-29 22:10:17 -08:00
//Grab some variables that are used in the trigger code and assign them to temp variables.
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
interrupts();
2017-01-29 22:10:17 -08:00
//Handle case where the secondary tooth was the last one seen
if(tempToothCurrentCount == 0) { tempToothCurrentCount = configPage4.triggerTeeth; }
2016-09-21 07:58:04 -07:00
//Number of teeth that have passed since tooth 1, multiplied by the angle each tooth represents, plus the angle that tooth 1 is ATDC. This gives accuracy only to the nearest tooth.
int crankAngle = (tempToothCurrentCount - 1) * triggerToothAngle;
crankAngle = (crankAngle / configPage4.TrigAngMul) + configPage4.triggerAngle; //Have to divide by the multiplier to get back to actual crank angle.
2017-01-29 22:10:17 -08:00
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-01-29 22:10:17 -08:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
2017-01-29 22:10:17 -08:00
return crankAngle;
}
void triggerSetEndTeeth_non360()
{
lastToothCalcAdvance = currentStatus.advance;
}
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Name: Nissan 360 tooth with cam
Desc:
2017-08-27 20:02:06 -07:00
Note: https://wiki.r31skylineclub.com/index.php/Crank_Angle_Sensor
*/
void triggerSetup_Nissan360()
{
triggerFilterTime = (1000000 / (MAX_RPM / 60 * 360UL)); //Trigger filter time is the shortest possible time (in uS) that there can be between crank teeth (ie at max RPM). Any pulses that occur faster than this time will be disgarded as noise
triggerSecFilterTime = (int)(1000000 / (MAX_RPM / 60 * 2)) / 2; //Same as above, but fixed at 2 teeth on the secondary input and divided by 2 (for cam speed)
secondaryToothCount = 0; //Initially set to 0 prior to calculating the secondary window duration
secondDerivEnabled = false;
decoderIsSequential = true;
toothCurrentCount = 1;
triggerToothAngle = 2;
MAX_STALL_TIME = (3333UL * triggerToothAngle); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
}
void triggerPri_Nissan360()
{
curTime = micros();
curGap = curTime - toothLastToothTime;
2017-06-15 15:45:39 -07:00
//if ( curGap < triggerFilterTime ) { return; }
toothCurrentCount++; //Increment the tooth counter
//addToothLogEntry(curGap); Disable tooth logging on this decoder due to overhead
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
2017-08-31 01:01:37 -07:00
if ( currentStatus.hasSync == true )
{
2017-08-31 01:01:37 -07:00
if ( toothCurrentCount == 361 ) //2 complete crank revolutions
{
toothCurrentCount = 1;
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.startRevolutions++; //Counter
}
//Recalc the new filter value
//setFilter(curGap);
2017-08-31 04:04:32 -07:00
//EXPERIMENTAL!
if(configPage2.perToothIgn == true)
2017-08-31 04:04:32 -07:00
{
int16_t crankAngle = ( (toothCurrentCount-1) * 2 ) + configPage4.triggerAngle;
//if(crankAngle > CRANK_ANGLE_MAX_IGN) { crankAngle -= CRANK_ANGLE_MAX_IGN; }
//if(crankAngle < CRANK_ANGLE_MAX_IGN) {
checkPerToothTiming(crankAngle, toothCurrentCount);
2017-08-31 04:04:32 -07:00
}
timePerDegree = curGap >> 1;; //The time per crank degree is simply the time between this tooth and the last one divided by 2
2017-08-31 01:01:37 -07:00
}
}
void triggerSec_Nissan360()
{
curTime2 = micros();
curGap2 = curTime2 - toothLastSecToothTime;
//if ( curGap2 < triggerSecFilterTime ) { return; }
toothLastSecToothTime = curTime2;
2017-06-15 15:45:39 -07:00
//OPTIONAL: Set filter at 25% of the current speed
//triggerSecFilterTime = curGap2 >> 2;
//Calculate number of primary teeth that this window has been active for
2017-08-31 01:01:37 -07:00
byte trigEdge;
if(configPage4.TrigEdgeSec == 0) { trigEdge = LOW; }
2017-08-31 01:01:37 -07:00
else { trigEdge = HIGH; }
if( (secondaryToothCount == 0) || (READ_SEC_TRIGGER() == trigEdge) ) { secondaryToothCount = toothCurrentCount; } //This occurs on the first rotation upon powerup OR the start of a secondary window
2017-06-15 15:45:39 -07:00
else
{
2017-06-15 15:45:39 -07:00
//If we reach here, we are at the end of a secondary window
byte secondaryDuration = toothCurrentCount - secondaryToothCount; //How many primary teeth have passed during the duration of this secondary window
if(currentStatus.hasSync == false)
{
if(configPage2.nCylinders == 4)
{
2017-08-31 04:04:32 -07:00
if( (secondaryDuration >= 15) && (secondaryDuration <= 17) ) //Duration of window = 16 primary teeth
2017-06-15 15:45:39 -07:00
{
toothCurrentCount = 16; //End of first window (The longest) occurs 16 teeth after TDC
currentStatus.hasSync = true;
}
2017-08-31 04:04:32 -07:00
else if( (secondaryDuration >= 11) && (secondaryDuration <= 13) ) //Duration of window = 12 primary teeth
2017-06-15 15:45:39 -07:00
{
toothCurrentCount = 102; //End of second window is after 90+12 primary teeth
currentStatus.hasSync = true;
}
2017-08-31 04:04:32 -07:00
else if( (secondaryDuration >= 7) && (secondaryDuration <= 9) ) //Duration of window = 8 primary teeth
2017-06-15 15:45:39 -07:00
{
toothCurrentCount = 188; //End of third window is after 90+90+8 primary teeth
currentStatus.hasSync = true;
}
2017-08-31 04:04:32 -07:00
else if( (secondaryDuration >= 3) && (secondaryDuration <= 5) ) //Duration of window = 4 primary teeth
2017-06-15 15:45:39 -07:00
{
toothCurrentCount = 274; //End of fourth window is after 90+90+90+4 primary teeth
currentStatus.hasSync = true;
}
else { currentStatus.hasSync = false; currentStatus.syncLossCounter++; } //This should really never happen
}
else if(configPage2.nCylinders == 6)
{
2017-08-31 04:04:32 -07:00
//Pattern on the 6 cylinders is 4-8-12-16-12-8
//We can therefore only get sync on the 4 and 16 pulses as they are the only unique ones
if( (secondaryDuration >= 15) && (secondaryDuration <= 17) ) //Duration of window = 16 primary teeth
2017-06-15 15:45:39 -07:00
{
toothCurrentCount = 136; //End of third window is after 60+60+16 primary teeth
currentStatus.hasSync = true;
}
2017-08-31 04:04:32 -07:00
else if( (secondaryDuration >= 3) && (secondaryDuration <= 5) ) //Duration of window = 4 primary teeth
2017-06-15 15:45:39 -07:00
{
toothCurrentCount = 304; //End of sixth window is after 60+60+60+60+60+4 primary teeth
currentStatus.hasSync = true;
}
}
2017-08-31 04:04:32 -07:00
else { currentStatus.hasSync = false; } //This should really never happen (Only 4 and 6 cylinder engines for this patter)
}
2017-06-15 15:45:39 -07:00
else
{
if (configPage4.useResync == true)
{
//Already have sync, but do a verify every 720 degrees.
if(configPage2.nCylinders == 4)
2017-06-15 15:45:39 -07:00
{
if( (secondaryDuration >= 15) && (secondaryDuration <= 17) ) //Duration of window = 16 primary teeth
{
toothCurrentCount = 16; //End of first window (The longest) occurs 16 teeth after TDC
}
2017-06-15 15:45:39 -07:00
}
else if(configPage2.nCylinders == 6)
2017-06-15 15:45:39 -07:00
{
if(secondaryDuration == 4)
{
toothCurrentCount = 304;
}
} //Cylinder count
} //use resync
2017-06-15 15:45:39 -07:00
} //Has sync
} //First getting sync or not
}
2017-06-15 15:45:39 -07:00
uint16_t getRPM_Nissan360()
{
2017-08-31 01:01:37 -07:00
//Can't use stdGetRPM as there is no separate cranking RPM calc (stdGetRPM returns 0 if cranking)
uint16_t tempRPM;
if( (currentStatus.hasSync == true) && (toothLastToothTime != 0) && (toothLastMinusOneToothTime != 0) )
{
if(currentStatus.startRevolutions < 2)
{
noInterrupts();
revolutionTime = (toothLastToothTime - toothLastMinusOneToothTime) * 180;
interrupts();
}
else
{
noInterrupts();
2017-08-31 01:20:25 -07:00
revolutionTime = (toothOneTime - toothOneMinusOneTime) >> 1; //The time in uS that one revolution would take at current speed (The time tooth 1 was last seen, minus the time it was seen prior to that)
2017-08-31 01:01:37 -07:00
interrupts();
}
tempRPM = (US_IN_MINUTE / revolutionTime); //Calc RPM based on last full revolution time (Faster as /)
if(tempRPM >= MAX_RPM) { tempRPM = currentStatus.RPM; } //Sanity check
MAX_STALL_TIME = revolutionTime << 1; //Set the stall time to be twice the current RPM. This is a safe figure as there should be no single revolution where this changes more than this
}
else { tempRPM = 0; }
return tempRPM;
}
int getCrankAngle_Nissan360()
{
//As each tooth represents 2 crank degrees, we only need to determine whether we're more or less than halfway between teeth to know whether to add another 1 degrees
2017-06-15 15:45:39 -07:00
int crankAngle = 0;
2017-08-31 01:20:25 -07:00
int tempToothLastToothTime;
int tempToothLastMinusOneToothTime;
int tempToothCurrentCount;
noInterrupts();
tempToothLastToothTime = toothLastToothTime;
tempToothLastMinusOneToothTime = toothLastMinusOneToothTime;
tempToothCurrentCount = toothCurrentCount;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
2017-08-31 01:20:25 -07:00
interrupts();
crankAngle = ( (tempToothCurrentCount - 1) * 2) + configPage4.triggerAngle;
2017-08-31 01:20:25 -07:00
unsigned long halfTooth = (tempToothLastToothTime - tempToothLastMinusOneToothTime) >> 1;
if (elapsedTime > halfTooth)
{
//Means we're over halfway to the next tooth, so add on 1 degree
2017-08-31 04:04:32 -07:00
crankAngle += 1;
}
2017-06-15 15:45:39 -07:00
2017-08-31 01:01:37 -07:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
2017-06-15 15:45:39 -07:00
return crankAngle;
}
void triggerSetEndTeeth_Nissan360()
{
//This uses 4 prior teeth, just to ensure there is sufficient time to set the schedule etc
ignition1EndTooth = ( (ignition1EndAngle - configPage4.triggerAngle) / 2 ) - 4;
ignition2EndTooth = ( (ignition2EndAngle - configPage4.triggerAngle) / 2 ) - 4;
ignition3EndTooth = ( (ignition3EndAngle - configPage4.triggerAngle) / 2 ) - 4;
ignition4EndTooth = ( (ignition4EndAngle - configPage4.triggerAngle) / 2 ) - 4;
lastToothCalcAdvance = currentStatus.advance;
}
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Name: Subary 6/7
Desc:
Note:
*/
void triggerSetup_Subaru67()
{
triggerFilterTime = (1000000 / (MAX_RPM / 60 * 360UL)); //Trigger filter time is the shortest possible time (in uS) that there can be between crank teeth (ie at max RPM). Any pulses that occur faster than this time will be disgarded as noise
triggerSecFilterTime = (int)(1000000 / (MAX_RPM / 60 * 2)) / 2; //Same as above, but fixed at 2 teeth on the secondary input and divided by 2 (for cam speed)
secondaryToothCount = 0; //Initially set to 0 prior to calculating the secondary window duration
secondDerivEnabled = false;
decoderIsSequential = true;
toothCurrentCount = 1;
triggerToothAngle = 2;
MAX_STALL_TIME = (3333UL * 93); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
toothAngles[0] = 710; //tooth #1
toothAngles[1] = 83; //tooth #2
toothAngles[2] = 115; //tooth #3
toothAngles[3] = 170; //tooth #4
toothAngles[4] = toothAngles[1] + 180;
toothAngles[5] = toothAngles[2] + 180;
toothAngles[6] = toothAngles[3] + 180;
toothAngles[7] = toothAngles[1] + 360;
toothAngles[8] = toothAngles[2] + 360;
toothAngles[9] = toothAngles[3] + 360;
toothAngles[10] = toothAngles[1] + 540;
toothAngles[11] = toothAngles[2] + 540;
}
void triggerPri_Subaru67()
{
curTime = micros();
//curGap = curTime - toothLastToothTime;
2017-06-15 15:45:39 -07:00
//if ( curGap < triggerFilterTime ) { return; }
toothCurrentCount++; //Increment the tooth counter
addToothLogEntry(curGap);
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
if ( (currentStatus.hasSync == false) || configPage4.useResync || (currentStatus.startRevolutions == 0) )
{
//Sync is determined by counting the number of cam teeth that have passed between the crank teeth
switch(secondaryToothCount)
{
case 0:
//If no teeth have passed, we can't do anything
break;
case 1:
//Can't do anything with a single pulse from the cam either (We need either 2 or 3 pulses)
secondaryToothCount = 0;
break;
case 2:
toothCurrentCount = 8;
currentStatus.hasSync = true;
secondaryToothCount = 0;
break;
case 3:
toothCurrentCount = 2;
currentStatus.hasSync = true;
secondaryToothCount = 0;
break;
default:
2017-08-17 15:50:39 -07:00
//Almost certainly due to noise or cranking stop/start
currentStatus.hasSync = false;
currentStatus.syncLossCounter++;
2017-08-17 15:50:39 -07:00
secondaryToothCount = 0;
break;
}
}
2017-06-15 15:45:39 -07:00
//Check sync again
if ( currentStatus.hasSync == true )
{
2017-06-15 15:45:39 -07:00
//Locked timing during cranking. This is fixed at 10* BTDC.
if ( BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK) && configPage4.ignCranklock)
2017-06-15 15:45:39 -07:00
{
if( (toothCurrentCount == 1) || (toothCurrentCount == 7) ) { endCoil1Charge(); endCoil3Charge(); }
else if( (toothCurrentCount == 4) || (toothCurrentCount == 10) ) { endCoil2Charge(); endCoil4Charge(); }
}
2017-06-15 15:45:39 -07:00
if ( toothCurrentCount > 12 ) //2 complete crank revolutions
{
toothCurrentCount = 1;
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.startRevolutions++; //Counter
}
}
2017-06-15 15:45:39 -07:00
//Recalc the new filter value
//setFilter(curGap);
}
void triggerSec_Subaru67()
{
curTime2 = micros();
curGap2 = curTime2 - toothLastSecToothTime;
//if ( curGap2 < triggerSecFilterTime ) { return; }
toothLastSecToothTime = curTime2;
2017-06-15 15:45:39 -07:00
//OPTIONAL Set filter at 25% of the current speed
//triggerSecFilterTime = curGap2 >> 2;
secondaryToothCount++;
}
2017-06-15 15:45:39 -07:00
uint16_t getRPM_Subaru67()
{
//if(currentStatus.RPM < currentStatus.crankRPM) { return crankingGetRPM(configPage4.triggerTeeth); }
2017-08-02 07:35:10 -07:00
uint16_t tempRPM = 0;
if(currentStatus.startRevolutions > 0)
{
//As the tooth count is over 720 degrees, we need to double the RPM value and halve the revolution time
2018-07-03 00:20:13 -07:00
tempRPM = stdGetRPM(720);
2017-08-02 07:35:10 -07:00
revolutionTime = revolutionTime >> 1; //Revolution time has to be divided by 2 as otherwise it would be over 720 degrees (triggerActualTeeth = nCylinders)
}
return tempRPM;
}
int getCrankAngle_Subaru67()
{
2017-06-15 15:45:39 -07:00
int crankAngle = 0;
if( currentStatus.hasSync == true )
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
//Grab some variables that are used in the trigger code and assign them to temp variables.
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
2017-06-15 15:45:39 -07:00
interrupts();
crankAngle = toothAngles[(tempToothCurrentCount - 1)] + configPage4.triggerAngle; //Perform a lookup of the fixed toothAngles array to find what the angle of the last tooth passed was.
2017-06-15 15:45:39 -07:00
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
2017-06-15 15:45:39 -07:00
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
}
return crankAngle;
}
void triggerSetEndTeeth_Subaru67()
{
lastToothCalcAdvance = currentStatus.advance;
}
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Name: Daihatsu +1 trigger for 3 and 4 cylinder engines
Desc: Tooth equal to the number of cylinders are evenly spaced on the cam. No position sensing (Distributor is retained) so crank angle is a made up figure based purely on the first teeth to be seen
Note: This is a very simple decoder. See http://www.megamanual.com/ms2/GM_7pinHEI.htm
*/
void triggerSetup_Daihatsu()
{
triggerActualTeeth = configPage2.nCylinders + 1;
triggerToothAngle = 720 / triggerActualTeeth; //The number of degrees that passes from tooth to tooth
triggerFilterTime = 60000000L / MAX_RPM / configPage2.nCylinders; // Minimum time required between teeth
triggerFilterTime = triggerFilterTime / 2; //Safety margin
secondDerivEnabled = false;
decoderIsSequential = false;
MAX_STALL_TIME = (1851UL * triggerToothAngle)*4;//Minimum 90rpm. (1851uS is the time per degree at 90rpm). This uses 90rpm rather than 50rpm due to the potentially very high stall time on a 4 cylinder if we wait that long.
if(configPage2.nCylinders == 3)
{
toothAngles[0] = 0; //tooth #1
toothAngles[1] = 30; //tooth #2 (Extra tooth)
toothAngles[2] = 240; //tooth #3
toothAngles[3] = 480; //tooth #4
}
else
{
//Should be 4 cylinders here
toothAngles[0] = 0; //tooth #1
toothAngles[1] = 30; //tooth #2 (Extra tooth)
toothAngles[2] = 180; //tooth #3
toothAngles[3] = 360; //tooth #4
toothAngles[4] = 540; //tooth #5
}
}
void triggerPri_Daihatsu()
{
curTime = micros();
curGap = curTime - toothLastToothTime;
2017-08-02 07:35:10 -07:00
//if ( curGap >= triggerFilterTime || (currentStatus.startRevolutions == 0 )
{
toothSystemCount++;
if (currentStatus.hasSync == true)
{
if( (toothCurrentCount == triggerActualTeeth) ) //Check if we're back to the beginning of a revolution
{
toothCurrentCount = 1; //Reset the counter
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.hasSync = true;
currentStatus.startRevolutions++; //Counter
//Need to set a special filter time for the next tooth
triggerFilterTime = 20; //Fix this later
}
else
{
toothCurrentCount++; //Increment the tooth counter
setFilter(curGap); //Recalc the new filter value
}
//addToothLogEntry(curGap);
if ( configPage4.ignCranklock && BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK) )
{
//This locks the cranking timing to 0 degrees BTDC (All the triggers allow for)
if(toothCurrentCount == 1) { endCoil1Charge(); }
else if(toothCurrentCount == 2) { endCoil2Charge(); }
else if(toothCurrentCount == 3) { endCoil3Charge(); }
else if(toothCurrentCount == 4) { endCoil4Charge(); }
}
}
else //NO SYNC
{
//
if(toothSystemCount >= 3) //Need to have seen at least 3 teeth to determine SYNC
{
unsigned long targetTime;
//We need to try and find the extra tooth (#2) which is located 30 degrees after tooth #1
//Aim for tooth times less than about 60 degrees
if(configPage2.nCylinders == 3)
{
targetTime = (toothLastToothTime - toothLastMinusOneToothTime) / 4; //Teeth are 240 degrees apart for 3 cylinder. 240/4 = 60
}
else
{
targetTime = ((toothLastToothTime - toothLastMinusOneToothTime) * 3) / 8; //Teeth are 180 degrees apart for 4 cylinder. (180*3)/8 = 67
}
if(curGap < targetTime)
{
//Means we're on the extra tooth here
toothCurrentCount = 2; //Reset the counter
currentStatus.hasSync = true;
triggerFilterTime = targetTime; //Lazy, but it works
}
}
}
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
} //Trigger filter
}
void triggerSec_Daihatsu() { return; } //Not required (Should never be called in the first place)
uint16_t getRPM_Daihatsu()
{
2017-06-28 21:37:26 -07:00
uint16_t tempRPM = 0;
if( (currentStatus.RPM < currentStatus.crankRPM) && false) //Disable special cranking processing for now
{
//Cn't use standard cranking RPM functin due to extra tooth
if( currentStatus.hasSync == true )
{
if(toothCurrentCount == 2) { tempRPM = currentStatus.RPM; }
else if (toothCurrentCount == 3) { tempRPM = currentStatus.RPM; }
else
{
noInterrupts();
revolutionTime = (toothLastToothTime - toothLastMinusOneToothTime) * (triggerActualTeeth-1);
interrupts();
tempRPM = (US_IN_MINUTE / revolutionTime);
if(tempRPM >= MAX_RPM) { tempRPM = currentStatus.RPM; } //Sanity check
} //is tooth #2
}
else { tempRPM = 0; } //No sync
}
else
2018-07-03 00:20:13 -07:00
{ tempRPM = stdGetRPM(720); } //TRacking over 2 crank revolutions
return tempRPM;
}
int getCrankAngle_Daihatsu()
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
int crankAngle;
//Grab some variables that are used in the trigger code and assign them to temp variables.
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
interrupts();
crankAngle = toothAngles[tempToothCurrentCount-1] + configPage4.triggerAngle; //Crank angle of the last tooth seen
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += CRANK_ANGLE_MAX; }
return crankAngle;
}
void triggerSetEndTeeth_Daihatsu()
{
lastToothCalcAdvance = currentStatus.advance;
}
/* -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Code for decoder.ino
Name: Harley
Desc: 2 uneven Spaced Tooth
Note: Within the code below, the sync tooth is referred to as tooth #1.
Derived from GMX7 and adapted for Harley
Only rising Edge is used for simplisity.The second input is ignored, as it does not help to desolve cam position
*/
void triggerSetup_Harley()
{
triggerToothAngle = 0; // The number of degrees that passes from tooth to tooth, ev. 0. It alternates uneven
secondDerivEnabled = false;
decoderIsSequential = false;
MAX_STALL_TIME = (3333UL * 60); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
if(initialisationComplete == false) { toothLastToothTime = micros(); } //Set a startup value here to avoid filter errors when starting. This MUST have the initi check to prevent the fuel pump just staying on all the time
triggerFilterTime = 1500;
}
void triggerPri_Harley()
{
lastGap = curGap;
curTime = micros();
curGap = curTime - toothLastToothTime;
setFilter(curGap); // Filtering adjusted according to setting
if (curGap > triggerFilterTime)
{
if ( READ_PRI_TRIGGER() == HIGH) // Has to be the same as in main() trigger-attach, for readability we do it this way.
{
addToothLogEntry(curGap);
targetGap = lastGap ; //Gap is the Time to next toothtrigger, so we know where we are
toothCurrentCount++;
if (curGap > targetGap)
{
toothCurrentCount = 1;
triggerToothAngle = 0;// Has to be equal to Angle Routine
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.hasSync = true;
}
else
{
toothCurrentCount = 2;
triggerToothAngle = 157;
// toothOneMinusOneTime = toothOneTime;
// toothOneTime = curTime;
}
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
currentStatus.startRevolutions++; //Counter
}
else
{
if (currentStatus.hasSync == true) { currentStatus.syncLossCounter++; }
currentStatus.hasSync = false;
toothCurrentCount = 0;
} //Primary trigger high
} //Trigger filter
}
void triggerSec_Harley()
// Needs to be enabled in main()
{
return;// No need for now. The only thing it could help to sync more quikly or confirm position.
} // End Sec Trigger
uint16_t getRPM_Harley()
{
uint16_t tempRPM = 0;
if (currentStatus.hasSync == true)
{
if ( currentStatus.RPM < (unsigned int)(configPage4.crankRPM * 100) )
{
// Kein Unterschied mit dieser Option
int tempToothAngle;
unsigned long toothTime;
if ( (toothLastToothTime == 0) || (toothLastMinusOneToothTime == 0) ) { tempRPM = 0; }
else
{
noInterrupts();
tempToothAngle = triggerToothAngle;
/* High-res mode
if(toothCurrentCount == 1) { tempToothAngle = 129; }
else { tempToothAngle = toothAngles[toothCurrentCount-1] - toothAngles[toothCurrentCount-2]; }
*/
revolutionTime = (toothOneTime - toothOneMinusOneTime); //The time in uS that one revolution would take at current speed (The time tooth 1 was last seen, minus the time it was seen prior to that)
toothTime = (toothLastToothTime - toothLastMinusOneToothTime); //Note that trigger tooth angle changes between 129 and 332 depending on the last tooth that was seen
interrupts();
toothTime = toothTime * 36;
tempRPM = ((unsigned long)tempToothAngle * 6000000UL) / toothTime;
}
}
else {
2018-07-03 00:20:13 -07:00
tempRPM = stdGetRPM(360);
}
}
return tempRPM;
}
int getCrankAngle_Harley()
{
//This is the current angle ATDC the engine is at. This is the last known position based on what tooth was last 'seen'. It is only accurate to the resolution of the trigger wheel (Eg 36-1 is 10 degrees)
unsigned long tempToothLastToothTime;
int tempToothCurrentCount;
//Grab some variables that are used in the trigger code and assign them to temp variables.
noInterrupts();
tempToothCurrentCount = toothCurrentCount;
tempToothLastToothTime = toothLastToothTime;
lastCrankAngleCalc = micros(); //micros() is no longer interrupt safe
interrupts();
//Check if the last tooth seen was the reference tooth (Number 3). All others can be calculated, but tooth 3 has a unique angle
int crankAngle;
if ( (tempToothCurrentCount == 1) || (tempToothCurrentCount == 3) )
{
crankAngle = 0 + configPage4.triggerAngle; //Number of teeth that have passed since tooth 1, multiplied by the angle each tooth represents, plus the angle that tooth 1 is ATDC. This gives accuracy only to the nearest tooth.
}
else {
crankAngle = 157 + configPage4.triggerAngle;
}
//Estimate the number of degrees travelled since the last tooth}
elapsedTime = (lastCrankAngleCalc - tempToothLastToothTime);
crankAngle += timeToAngle(elapsedTime, CRANKMATH_METHOD_INTERVAL_REV);
if (crankAngle >= 720) { crankAngle -= 720; }
if (crankAngle > CRANK_ANGLE_MAX) { crankAngle -= CRANK_ANGLE_MAX; }
if (crankAngle < 0) { crankAngle += 360; }
return crankAngle;
}
void triggerSetEndTeeth_Harley()
{
lastToothCalcAdvance = currentStatus.advance;
}
//************************************************************************************************************************
/*
Name: 36-2-2-2 trigger wheel wheel
Desc: A crank based trigger with a nominal 36 teeth, but 6 of these removed in 3 groups of 2. 2 of these groups are located concurrently.
Note: http://thefactoryfiveforum.com/attachment.php?attachmentid=34279&d=1412431418
*/
void triggerSetup_ThirtySixMinus222()
{
triggerToothAngle = 10; //The number of degrees that passes from tooth to tooth
triggerActualTeeth = 30; //The number of physical teeth on the wheel. Doing this here saves us a calculation each time in the interrupt
triggerFilterTime = (int)(1000000 / (MAX_RPM / 60 * configPage4.triggerTeeth)); //Trigger filter time is the shortest possible time (in uS) that there can be between crank teeth (ie at max RPM). Any pulses that occur faster than this time will be disgarded as noise
secondDerivEnabled = false;
decoderIsSequential = false;
checkSyncToothCount = (configPage4.triggerTeeth) >> 1; //50% of the total teeth.
toothLastMinusOneToothTime = 0;
toothCurrentCount = 0;
toothOneTime = 0;
toothOneMinusOneTime = 0;
MAX_STALL_TIME = (3333UL * triggerToothAngle * 2 ); //Minimum 50rpm. (3333uS is the time per degree at 50rpm)
}
void triggerPri_ThirtySixMinus222()
{
curTime = micros();
curGap = curTime - toothLastToothTime;
if ( curGap >= triggerFilterTime ) //Pulses should never be less than triggerFilterTime, so if they are it means a false trigger. (A 36-1 wheel at 8000pm will have triggers approx. every 200uS)
{
toothCurrentCount++; //Increment the tooth counter
addToothLogEntry(curGap);
//Begin the missing tooth detection
//If the time between the current tooth and the last is greater than 2x the time between the last tooth and the tooth before that, we make the assertion that we must be at the first tooth after a gap
//toothSystemCount is used to keep track of which missed tooth we're on. It will be set to 1 if that last tooth seen was the middle one in the -2-2 area. At all other times it will be 0
if(toothSystemCount == 0) { targetGap = ((toothLastToothTime - toothLastMinusOneToothTime)) * 2; } //Multiply by 2 (Checks for a gap 2x greater than the last one)
if( (toothLastToothTime == 0) || (toothLastMinusOneToothTime == 0) ) { curGap = 0; }
if ( (curGap > targetGap) )
{
{
if(toothSystemCount == 1)
{
//This occurs when where at the first tooth after the 2 lots of 2x missing tooth.
toothCurrentCount = 19;
toothSystemCount = 0;
currentStatus.hasSync = true;
}
else
{
//We've seen a missing tooth set, but do not yet know whether it is the single one or the double one.
toothSystemCount = 1;
toothCurrentCount++;
toothCurrentCount++; //Accurately reflect the actual tooth count, including the skipped ones
}
triggerToothAngleIsCorrect = false; //The tooth angle is double at this point
triggerFilterTime = 0; //This is used to prevent a condition where serious intermitent signals (Eg someone furiously plugging the sensor wire in and out) can leave the filter in an unrecoverable state
}
}
else
{
if(toothCurrentCount > 36)
{
//Means a complete rotation has occured.
toothCurrentCount = 1;
revolutionOne = !revolutionOne; //Flip sequential revolution tracker
toothOneMinusOneTime = toothOneTime;
toothOneTime = curTime;
currentStatus.startRevolutions++; //Counter
}
else if(toothSystemCount == 1)
{
//This occurs when a set of missing teeth had been seen, but the next one was NOT missing.
toothCurrentCount = 35;
currentStatus.hasSync = true;
}
//Filter can only be recalc'd for the regular teeth, not the missing one.
setFilter(curGap);
triggerToothAngleIsCorrect = true;
toothSystemCount = 0;
}
toothLastMinusOneToothTime = toothLastToothTime;
toothLastToothTime = curTime;
//EXPERIMENTAL!
if(configPage2.perToothIgn == true)
{
uint16_t crankAngle = ( (toothCurrentCount-1) * triggerToothAngle ) + configPage4.triggerAngle;
checkPerToothTiming(crankAngle, toothCurrentCount);
}
}
}
void triggerSec_ThirtySixMinus222()
{
//NOT USED - This pattern uses the missing tooth version of this function
}
int getCrankAngle_ThirtySixMinus222()
{
//NOT USED - This pattern uses the missing tooth version of this function
return 0;
}
void triggerSetEndTeeth_ThirtySixMinus222()
{
if(currentStatus.advance < 10) { ignition1EndTooth = 36; }
else if(currentStatus.advance < 20) { ignition1EndTooth = 35; }
else if(currentStatus.advance < 30) { ignition1EndTooth = 34; }
else { ignition1EndTooth = 31; }
if(currentStatus.advance < 30) { ignition2EndTooth = 16; }
else { ignition2EndTooth = 13; }
lastToothCalcAdvance = currentStatus.advance;
}