* Add optimized 32-bit shifting
* Tooth based time to angle coversion is only used by a few decoders.
So move the functions into decoders.cpp
* Better separation of deocders and crank maths.
* Apply optimised shifts
* Doxygen
* Disable SD on T4.1 temporarily to prevent lockups. See #847
* Fix unit test value
* Improve closedloop boost control (#736)
* First try on updating closedloop boost control
* added eeprom updates for backward comp[atibility
* fix merge conflict
* Change updates to next release EEPROM version.
* Fix some issues after merging master
* some cleanup to minimize changes and speedup review
* cleanup updates
* chances on updates to alaign with new table format
* move LUT to new config page in eeprom
* little cleanup
* Update storage.h comments
* fix some ini warnings
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
* Minor cleanup of boost dialog from previous PR
* Add dynamic EEPROM block write limit based on RPM. Should fix#859
* Only set the idle up pin state on init if it's enabled
* AFR protection function (#861)
* Implementing AFR protection
* Update globals.h
* Bug fixes and code refactoring
* Moved variables to prevent ODR
* Dialog for AFR protection
* Data size and math corrections
* Possibility to use either AFR or lambda
* Updated default AFR protection values
* No need to do multiplications due to existing RPMdiv100 variable
* The X100 multiplier was wrongfully removed
* Add defaults in updates.ino, minor formatting cleanups
Co-authored-by: Josh Stewart <josh@noisymime.org>
* Prevent cranking and ASE corrections running at once. Alternative fix to #868
* Corrected RPM to TPS (#878). Fixes#874
* Fixed value mode for AFR protection (#877)
* bug fix. A workaround for failing emulated on internal flash writes + a root cause fix (#876)
* workaround for failing flash writes
* Root cause fix for EEPROM emulation on STM32
* Oops, remove some debugging functions.
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
* Correct typos found by codespell (#880)
* Fix broken build on Teensy from #880
* Narrow scope of EEPROM_MAX_WRITE_BLOCK to writeConfig (#881)
* EEPROM_MAX_WRITE_BLOCK can be local to writeConfig()
This saves a byte of memory ;-)
* Fix MISRA/lint warnings
Correctly cast address parameter of eeprom_read_block
Statically access table 3d type_key member
* Remove force burn code - unused
* Replace eepromWritesPending with bit set/check
* Refactor: chain write_location instances.
Clearer code.
* Fix hanging on boot (#858)
* Further fixes to the ASE correction
* Enable use of disabled functions pins (#549)
* Enable use pins of disabled functions or unused ign channels
* Added new pins and functions to check
* Fix for semi-seq inj after #478 (#883)
* Don't try to run inappropriate CI on forked repositories (#871)
* Remove old unused corrections code
* Remove controller priority on trigger edge. Fixes#860
This was added for a specific FW update in 2018 and no longer needed.
* Add engine protection flags to datalog
* Add option for SD logging with external switch
* TS option to display pressure in bar #842 (#864)
Adds options in TunerStudio project settings to have default units
for fuel and oil pressure in bar. Adds gauge in kPa. This only
adds convertion from psi to bar, not affecting firmware.
Co-authored-by: Min <min@infcof.com>
* Fix typo from last commit
* Missing commas in ini
* bug fix EGO PID controller + some improvements. (#879)
* Fix for EGO pid
* Further improvements on ego PID
* Stop EGO controllers from calculating while DFCO is active. To prevent integrator windup.
* Fix bug in DFCO enable/disable of the controller
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
* Add necessary pin translations (#887). Fixes#867
* Signatures for 202207
* Update README.md
* Update signatures for 202207 in legacy comms
* Dev signatures for 202210-dev
* Volatile decoder variables (#902)
* triggerToothAngle is modified by interrupts
* triggerActualTeeth is never modified in interrupts
* fix check for DFCO off in correctionAFRclosedLoop() (#899)
line 608 has bit-and of configpage6.egotype > 0 & DFCO off.
it should be logical and &&
* cl boost control above baro should use logical and/or (#901)
* libdivide structs can be const - saves a few bytes (#886)
* Add OLCL mode to initBoard() for teensy (#903)
Co-authored-by: csmergs <christopher@smeraglinolo.com>
* Fix for idle PWM on STM32. Enable idle timer when idle pwm is enabled. Fixes#907
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
* Disable automatic retransmission (#910)
* Allow for float values in SD log where supported with FPU
* Increase most F temp field max values to 419F
* Revert "Merge branch 'master' into DoubleMissing"
This reverts commit bda3d89bf553df40951167870c826792ba92a715.
* recover missing files
* add vvt
* missing files
* fix stall time from debug version
* Revert "Merge remote-tracking branch 'noisymime/master'"
This reverts commit 58e6e283e6.
* initial version
* added speeduino.ini so can select pattern
* fixes to pattern detection and crank angle calcs
* temp fix low speed cranking
* comments on tooth sizes
* fix filters
* update - per tooth ignition doesn't work
* remove debug for decoder & fix spark1 dwell
* Fix merge error with decoders.h
K6A definitions missed on the merge, now added back in
* Change default case for decoder back to RISING/FALLING edge
---------
Co-authored-by: Josh Stewart <josh@noisymime.org>
Co-authored-by: Tjeerd <33102280+Tjeerdie@users.noreply.github.com>
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
Co-authored-by: larmicfre <49905831+larmicfre@users.noreply.github.com>
Co-authored-by: Daniel Tobias <dantob@users.noreply.github.com>
Co-authored-by: tx_haggis <13982343+adbancroft@users.noreply.github.com>
Co-authored-by: Pasi Kemppainen <48950874+pazi88@users.noreply.github.com>
Co-authored-by: Vitor Moreno B. Sales <vitor.m.benevides@outlook.com>
Co-authored-by: Min <72794870+zceemja@users.noreply.github.com>
Co-authored-by: Min <min@infcof.com>
Co-authored-by: Afroboltski <70011435+Afroboltski@users.noreply.github.com>
Co-authored-by: DeionSi <DeionSi@users.noreply.github.com>
Co-authored-by: Jon Billings <jon.billings@bbc.co.uk>
Co-authored-by: a32guy <turboe30@gmail.com>
Co-authored-by: csmergs <christopher@smeraglinolo.com>
* Disable SD on T4.1 temporarily to prevent lockups. See #847
* Fix unit test value
* Improve closedloop boost control (#736)
* First try on updating closedloop boost control
* added eeprom updates for backward comp[atibility
* fix merge conflict
* Change updates to next release EEPROM version.
* Fix some issues after merging master
* some cleanup to minimize changes and speedup review
* cleanup updates
* chances on updates to alaign with new table format
* move LUT to new config page in eeprom
* little cleanup
* Update storage.h comments
* fix some ini warnings
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
* Minor cleanup of boost dialog from previous PR
* Add dynamic EEPROM block write limit based on RPM. Should fix#859
* Only set the idle up pin state on init if it's enabled
* AFR protection function (#861)
* Implementing AFR protection
* Update globals.h
* Bug fixes and code refactoring
* Moved variables to prevent ODR
* Dialog for AFR protection
* Data size and math corrections
* Possibility to use either AFR or lambda
* Updated default AFR protection values
* No need to do multiplications due to existing RPMdiv100 variable
* The X100 multiplier was wrongfully removed
* Add defaults in updates.ino, minor formatting cleanups
Co-authored-by: Josh Stewart <josh@noisymime.org>
* Prevent cranking and ASE corrections running at once. Alternative fix to #868
* Corrected RPM to TPS (#878). Fixes#874
* Fixed value mode for AFR protection (#877)
* bug fix. A workaround for failing emulated on internal flash writes + a root cause fix (#876)
* workaround for failing flash writes
* Root cause fix for EEPROM emulation on STM32
* Oops, remove some debugging functions.
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
* Correct typos found by codespell (#880)
* Fix broken build on Teensy from #880
* Narrow scope of EEPROM_MAX_WRITE_BLOCK to writeConfig (#881)
* EEPROM_MAX_WRITE_BLOCK can be local to writeConfig()
This saves a byte of memory ;-)
* Fix MISRA/lint warnings
Correctly cast address parameter of eeprom_read_block
Statically access table 3d type_key member
* Remove force burn code - unused
* Replace eepromWritesPending with bit set/check
* Refactor: chain write_location instances.
Clearer code.
* Fix hanging on boot (#858)
* Further fixes to the ASE correction
* Enable use of disabled functions pins (#549)
* Enable use pins of disabled functions or unused ign channels
* Added new pins and functions to check
* Fix for semi-seq inj after #478 (#883)
* Don't try to run inappropriate CI on forked repositories (#871)
* Remove old unused corrections code
* Remove controller priority on trigger edge. Fixes#860
This was added for a specific FW update in 2018 and no longer needed.
* Add engine protection flags to datalog
* Add option for SD logging with external switch
* TS option to display pressure in bar #842 (#864)
Adds options in TunerStudio project settings to have default units
for fuel and oil pressure in bar. Adds gauge in kPa. This only
adds convertion from psi to bar, not affecting firmware.
Co-authored-by: Min <min@infcof.com>
* Fix typo from last commit
* Missing commas in ini
* bug fix EGO PID controller + some improvements. (#879)
* Fix for EGO pid
* Further improvements on ego PID
* Stop EGO controllers from calculating while DFCO is active. To prevent integrator windup.
* Fix bug in DFCO enable/disable of the controller
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
* Add necessary pin translations (#887). Fixes#867
* Signatures for 202207
* Update README.md
* Update signatures for 202207 in legacy comms
* Dev signatures for 202210-dev
* Volatile decoder variables (#902)
* triggerToothAngle is modified by interrupts
* triggerActualTeeth is never modified in interrupts
* fix check for DFCO off in correctionAFRclosedLoop() (#899)
line 608 has bit-and of configpage6.egotype > 0 & DFCO off.
it should be logical and &&
* cl boost control above baro should use logical and/or (#901)
* libdivide structs can be const - saves a few bytes (#886)
* Add OLCL mode to initBoard() for teensy (#903)
Co-authored-by: csmergs <christopher@smeraglinolo.com>
* Fix for idle PWM on STM32. Enable idle timer when idle pwm is enabled. Fixes#907
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
* Disable automatic retransmission (#910)
* Allow for float values in SD log where supported with FPU
* Increase most F temp field max values to 419F
* Revert "Merge branch 'master' into DoubleMissing"
This reverts commit bda3d89bf553df40951167870c826792ba92a715.
* recover missing files
* add vvt
* missing files
* fix stall time from debug version
* Add 3 tooth cam support
* added vvt2 and potential I4 cam
* fix
* fixes to VVT1 to always trigger on rotation 1
* fix attempt to vtt1 trigger
* fixed VVT trigger
* updated how vvt2 is calculated
* made code more readable and portable
instead of trying to set an unsigned int to its max value and handling different sized unsigned ints across different processes, using -1 and adding a comment to explain why. This will then work across all processors
* Allow updating of trigger edge for third cam
* Add logging to second cam & filtering
* include high speed logger in legacy comms
* adding VVT logging and trigger edge editing
fix missing define (temp fix?)
Revert "fix missing define (temp fix?)"
This reverts commit c6280f38ff69cc41278148a79c888736a71754b1.
fixes
* Create an additional logger screen in tunerstudio
Changes to create a third high speed logger window in tuner studio.
* missed save
* Change variable name
Discord discussion requested compositeLogEnabled didn't do a test for false as the type is now a byte. Variable renamed to be compositeTriggerUsed and false replaced with 0. Variable name and values used should now make more logical sense.
* fix tertiary cam trigger
tertiary cam trigger is supposed to trigger on 2nd tooth, code had bug meaning it would never trigger.
* change how tertiary cam reset
(needs testing)
* added 4th composite logger for both cams
allows you to log both cams together and see the relationship between them.
* added more logging
Log the primary, secondary and third inputs as well as engine cycle on all composite logs. Still have 3 different logs to allow you to visualise which is the best way to present the information.
* Improve VVT1 detection
* fixes to merge
* update VVT2 trigger detection and reduce filtering
* Revert "Merge remote-tracking branch 'noisymime/master'"
This reverts commit 58e6e283e6.
* Correct merge error with master
missed decoders.h merge missing a reference to recordVVT1Angle which has been renamed to fit better into the naming convention within this file to triggerRecordVVT1Angle
* Removed tertiary decoder
Tertiary decoder hasn't completed testing & is specifically for certain v8 engines, removing so this can be submitted and built into the next release covering other Toyota engines (eg those used in Lexius inline 6)
* Make triggerRecordVVT1Angle static
---------
Co-authored-by: Josh Stewart <josh@noisymime.org>
Co-authored-by: Tjeerd <33102280+Tjeerdie@users.noreply.github.com>
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
Co-authored-by: larmicfre <49905831+larmicfre@users.noreply.github.com>
Co-authored-by: Daniel Tobias <dantob@users.noreply.github.com>
Co-authored-by: tx_haggis <13982343+adbancroft@users.noreply.github.com>
Co-authored-by: Pasi Kemppainen <48950874+pazi88@users.noreply.github.com>
Co-authored-by: Vitor Moreno B. Sales <vitor.m.benevides@outlook.com>
Co-authored-by: Min <72794870+zceemja@users.noreply.github.com>
Co-authored-by: Min <min@infcof.com>
Co-authored-by: Afroboltski <70011435+Afroboltski@users.noreply.github.com>
Co-authored-by: DeionSi <DeionSi@users.noreply.github.com>
Co-authored-by: Jon Billings <jon.billings@bbc.co.uk>
Co-authored-by: a32guy <turboe30@gmail.com>
Co-authored-by: csmergs <christopher@smeraglinolo.com>
* initialiseSchedulers: factor out shared code.
* Proxy setFuelSchedule\d through generic
setFuelSchedule() function
* Directly call setFuelSchedule
* Simplify unit tests
* Proxy setIgnitionSchedule\d through generic
setIgnitionSchedule() function
* Directly call setIgnitionSchedule
* Simplify unit tests
* Optimize by partially inlining
the set[Fuel|Ignition]Schedule funcs
* Use the embedded schedule compare
& counter members instead of using
hardcoded individual channel macros.
* Unit test adjustCrankAngle
* Add udiv_32_16
* Apply udiv_32_16() where possible
* Convert udiv_32_16 to assembler
It's worth 20 loop/s
* Remove unused functions
* Remove degreesPeruSx2048 - unused
* Remove angleToTime - replace with direct calls
1. Drop angleToTime()
It's slow, only partially implemented and adds zero value
(and has MISRA violations)
2. Consistent function naming
3. Doxygen
* triggerPri_Nissan360 shouldn't set timePerDegree.
It will be overwritten every loop by doCrankSpeedCalcs()
* Use angleToTimeMicroSecPerDegree() instead of timePerDegree
No loss in performance
Increased injection open/close time accuracy (so unit test values must change)
Can remove timePerDegree global.
* Hide (encapsulate) crank math globals.
* Base all angle to time conversions on decoder computed variables.
This is within 2us of the revolution based method
and is much faster - which is essentially zero percent change.
* Performance: move calculation of degreesPeruSx32768
into decoders.
Remove doCrankSpeedCalcs() - it's doing nothing
at the moment.
* Apply libdivide to triggerSetEndTeeth functions.
Since triggerToothAngle is set once at initialization
time, we can generate the libdivide struct
once and reuse it many times.
* Remove lastToothCalcAdvance - unused
* Replace 16-bit division with shift
* Replace 32-bit divison with 16-bit division
* Avoid 32-bit division; use div100()
* inline percentage()
* Optimize div100()
* MISRA fixes
* Replace magic numbers with #defs
* Replace libdivide structs with inline constants
No perf or memory changes
* Use fixed types for PWM max count variables
* Accurate rounded integer division
* Formalise rounding behavior (DIV_ROUND_CORRECT)
* Apply DIV_ROUND_CORRECT to DIV_ROUND_CLOSEST(),
UDIV_ROUND_CLOSEST(), div100(), div360(),
percentage() & halfPercentage()
* Add, fix & improve unit tests
* Add udiv_32_16_closest()
* Perf: Limit percentage calculations to 16-bits
* MISRA fixes
* Add compare_executiontime() to encapsulate common perf testing code
* Signed to unsigned division
* Convert ignitionLimits() to an inline function.
Slight speed up, probably due to removing
multiple evaluations of macro arguments.
* Split unit tests up.
* udiv_32_16 - check for valid parameters
tx_haggis
nickamuch
Josh Stewart
Daniel Tobias
mike501