Commit Graph

102 Commits

Author SHA1 Message Date
Josh Stewart e44f4c7b54 Fix issue where staging fuel channels would be active even when not required 2023-06-26 10:46:11 +10:00
Josh Stewart 1502b6ff88
Dwell error correction (#1049)
* Initial work on dwell error correction

* Fix error message in TS

* Add averaging to schedules 5-8

* Cleanup warning

* Final cleanup and comments
2023-05-22 13:37:40 +10:00
tx_haggis 424a96d9ea
Test start/end callback assignment (#1044) 2023-05-07 19:42:09 +10:00
tx_haggis 4a509d19f2
Unit test fuel and ignition scheduler initialisation (#1039)
* Unit test fuel schedule initialisation

* Move initialisation tests to their own harness
Saves memory

* Rename test_misc to test_tables

* Rename test_misc2 to test_math

* Reduce memory usage

* Fill out remaining ignition init unit tests
2023-04-27 14:43:04 +10:00
Josh Stewart 76dd7dc1bf Cleanup warnings on non-AVR architectures (scheduler interrupts were not static) 2023-04-24 15:33:02 +10:00
DeionSi 2312102d4b
Replace 8 channelXInjEnabled variables with 1 (#1001) 2023-02-06 11:48:11 +11:00
Josh Stewart 2fc29ceef5 MISRA cleanup rule: misra-c2012-8.2 2022-11-06 09:43:29 +11:00
Daniel Tobias 540b3a4fa2
Correct typos found by codespell (#880) 2022-06-27 10:39:14 +10:00
Tjeerd dc87795718
bug fix. A workaround for failing emulated on internal flash writes + a root cause fix (#876)
* workaround for failing flash writes

* Root cause fix for EEPROM emulation on STM32

* Oops, remove some debugging functions.

Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
2022-06-27 09:30:40 +10:00
Daniel Tobias 7020705dbe
fix typos in code documentation (#816)
* fix typos in code documentation

* minor reverts

* fix typos in ini

Co-authored-by: Josh Stewart <josh@noisymime.org>
2022-04-11 10:49:58 +10:00
DeionSi eafd4030d1
Add SET_COMPARE; Change some types to COMPARE_TYPE (#691) 2021-11-12 15:11:42 +11:00
Olli Hollmen 61b1401b49
Add doxygen documentation (#597)
* Add Doxygen markup for grouping decoders. Tidy-up doucumentation just enough to make
Doxygen 'Modules' page neat / somewhat consistent (w/o stripping any info, on the contrary
some info is now added for few decoders that had only name present).
Add minimally modified Doxygen Doxyfile configuration.

* Document statuses and config* structure members in globals.h:
- Convert existing documentation to doxygen
- Document some of the undocumented members cross-referencing code files
  where they are used (often containing good explanations in code comments) or
  deriving meaning from code (leave question mark as marker of uncertainty
  or need for clarification)
- Same activity in misc .h header files w. struct declarations.
Misc .ino files with code:
- Convert existing code documentation to doxygen
- Add documentation to undocumented functions (deriving idea from raw code and
  code embedded comments)
- Some additions to existing documentation.
End sentences with period, as it has many iportant meanings for Doxygen
e.g. auto-brief ends at first-sentence period and in (doxygen generated)
HTML ascii newline does not break lines (or sentences).
Doxyfile: Add README.md file as INPUT from upper (codebase root) directory.
2021-06-22 15:30:52 +10:00
Josh Stewart 5853c6e630 Potential fix for new ignition mode on channels 4+ 2020-12-07 17:08:47 +11:00
Josh Stewart ac915536a3 Pull Teensy interrupts into board file 2020-07-27 10:09:50 +10:00
Josh Stewart d5bc11e006 Fix bug with the delayed inj priming that could cause lockup 2020-07-14 14:05:07 +10:00
Josh Stewart bf8d9558fe Minor changes to the injector priming routine 2020-07-06 22:17:56 +10:00
Vitor Moreno B. Sales 7bcf4bcb15
[FP] Add injector delay for priming (#391)
* [FP] Add injector delay for priming

* Fix build

* Add the startup TPS read back in to ensure proper flood clear check

Co-authored-by: Josh Stewart <josh@noisymime.org>
2020-07-05 14:28:57 +10:00
Tjeerd 7c82095d44
STM32F407 32bit timer issue fix (new) (#374)
* Fixed 32 bit timers again

* Set the battery voltage to a default value when board starts. So before a sensible value is read this is 0. The dwell correction is creating the ignition spurious pulses direct after reset of the  board. (When "flying start" the engine)
2020-07-02 10:35:27 +10:00
Josh Stewart 33dc5e58dd Add unit tests for pulse width calculation 2020-04-23 16:20:09 +10:00
Josh Stewart 21412e74a1 Provide missing externs from last commit to allow unit testing 2020-04-02 09:54:43 +11:00
iLeeeZi 8722065168
6 and 8 cylinder sequential injection (#280)
* 6 cyl sequential related cleanup

* disable 6cyl seq fuel trim tables for now

* add the over 2 squirts fix

* Add 5 and 6 cylinder semi and full sequential

* 5 cylinder changes

* fix priming pulse when using paired or semi-sequential injection

* add 5 cyl special case back

* Add missing 8 cyl stuff

* add missing PW8

* allow to change inj4Ang with non sequential 5 cylinder

* add missing helptext
2020-04-01 17:03:11 +11:00
iLeeeZi 9ea5f44e93
fix typos (#337) 2020-03-17 06:33:50 +10:00
Pasi Kemppainen 3529f6a2f7
6&8 cyl sequential ignition (#323)
* Required changes done

Needs testing

* Additions

* 8cyl changes for mega 2560

* Decoder fixes
2020-02-28 10:22:33 +11:00
Bruno Bousquet 76319fdf22
Separate one schedule unit test per function (#315)
* one test per function

* add tests

* use initialiseSchedulers in tests

* remove generic tests for schedules

* fix schedule accuracy tests

* fix warning static function never defined

* fix test_schedule not working
2020-02-04 09:19:42 +11:00
Josh Stewart fd10cb729c Remove static declarations from corrections.ino (Did nothing) 2020-02-03 17:35:29 +11:00
Josh Stewart a93e78c3f3 Merge branch 'master' of https://github.com/noisymime/speeduino 2020-02-03 09:07:41 +11:00
Josh Stewart 51b557639c Disable some unused bits in scheduler for unit testing 2020-02-03 09:07:37 +11:00
Bruno Bousquet 68f2288dd7
add schedule test (#312)
add temp test file to gitignore


improve schedule testing


add check for schedule delays and pending variants

move time sampling to callback methods

add comments and improve pending tests
2020-01-30 16:17:20 +11:00
Josh Stewart 3265f1b937 Fix for potential missed ignition signals at high rpm/high dwell 2019-12-19 13:23:11 +11:00
Josh Stewart fbbeb8a7a1 Basework for new DB board 2019-12-15 09:55:46 +11:00
Josh Stewart 386720918e Remove the special handling for fuel5 schedule 2019-11-12 17:10:32 +11:00
Josh Stewart e449f319c2 RAM cleanup of the schedule structs 2019-11-12 15:04:36 +11:00
Josh Stewart 964163d2ec Remove debug line that was left in on last commit 2019-11-07 15:11:01 +11:00
Josh Stewart 081b2071c6 Clear injector interrupt flag. Prevents false pulse at low RPM with seq. Fixes #266 2019-11-07 15:01:28 +11:00
Josh Stewart 938501b88f Fix some IGN/INJ copy/paste errors 2019-10-22 10:42:20 +11:00
Bruno Bousquet 9fec203c5b remove _SLOW versions of MAX_TIMER_PERIOD and uS_TO_TIMER_COMPARE 2019-08-22 20:18:07 -04:00
Josh Stewart 4357b1b4cf Clean compile on Teensy 4 2019-08-21 15:15:19 +10:00
Bruno Bousquet 6355d7d859 Fix ignition5 and idle interrupt mix 2019-07-19 19:17:14 -04:00
Josh Stewart bb9ade4657 Fix for Teensy not compiling when number of channels was set to 8/8 2019-03-07 22:59:36 +11:00
Josh Stewart 05e3d928ad Minor bits missed from last commit 2019-03-06 18:17:33 +11:00
Josh Stewart 9101356c5a Workaround for potential stray spark signals on startup 2019-03-06 16:58:26 +11:00
Vitor_Boss dd942c55aa fix code version 2019-03-03 02:08:33 -03:00
Vitor_Boss 1777f0aae7 STM32 update 2019-03-03 01:43:43 -03:00
Josh Stewart d337eed783 Add in missing bits to allow up to 8 ignition channels 2019-01-27 10:56:27 +13:00
Josh Stewart 0fbab60841 Move most of the stm32 runtime into board file 2019-01-22 10:56:25 +13:00
Josh Stewart c2c84b7ef3 Move some of the board specific init code into their respective board files 2019-01-21 17:51:33 +13:00
Josh Stewart 343fd4e88c Remove some warnings during Teensy compile 2019-01-18 21:17:47 +11:00
Josh Stewart 207b389b41 Move all Teensy 3.5 headers to dedicated board file 2019-01-18 21:15:27 +11:00
connor rigby 72e1e2f9f8
Fix a few typos and comment formatting consistency 2019-01-06 10:16:04 -08:00
Josh Stewart c4d289ed02 Missed commit to return to normal ignition callback rather than testing 2018-09-07 10:38:31 +10:00