Change ForceAccepted to process list of already stored vtxs

This commit is contained in:
Aaron Buchwald 2020-06-18 12:29:17 -04:00
parent be6be7ae1c
commit a3d3ef4787
1 changed files with 18 additions and 8 deletions

View File

@ -126,11 +126,14 @@ func (b *bootstrapper) fetch(vtxID ids.ID) error {
}
// Process vertices
func (b *bootstrapper) process(vtx avalanche.Vertex) error {
func (b *bootstrapper) process(vtxs ...avalanche.Vertex) error {
toProcess := newMaxVertexHeap()
if _, ok := b.processedCache.Get(vtx.ID()); !ok { // only process if we haven't already
toProcess.Push(vtx)
for _, vtx := range vtxs {
if _, ok := b.processedCache.Get(vtx.ID()); !ok { // only process if we haven't already
toProcess.Push(vtx)
}
}
for toProcess.Len() > 0 {
vtx := toProcess.Pop()
switch vtx.Status() {
@ -217,14 +220,19 @@ func (b *bootstrapper) MultiPut(vdr ids.ShortID, requestID uint32, vtxs [][]byte
return b.fetch(neededVtxID)
}
processVertices := make([]avalanche.Vertex, 1, len(vtxs))
processVertices[0] = neededVtx
for _, vtxBytes := range vtxs { // Parse/persist all the vertices
if _, err := b.State.ParseVertex(vtxBytes); err != nil { // Persists the vtx
if vtx, err := b.State.ParseVertex(vtxBytes); err != nil { // Persists the vtx
b.BootstrapConfig.Context.Log.Debug("Failed to parse vertex: %w", err)
b.BootstrapConfig.Context.Log.Verbo("vertex: %s", formatting.DumpBytes{Bytes: vtxBytes})
} else {
processVertices = append(processVertices, vtx)
}
}
return b.process(neededVtx)
return b.process(processVertices...)
}
// GetAncestorsFailed is called when a GetAncestors message we sent fails
@ -245,15 +253,17 @@ func (b *bootstrapper) ForceAccepted(acceptedContainerIDs ids.Set) error {
err)
}
storedVtxs := make([]avalanche.Vertex, 0, acceptedContainerIDs.Len())
for _, vtxID := range acceptedContainerIDs.List() {
if vtx, err := b.State.GetVertex(vtxID); err == nil {
if err := b.process(vtx); err != nil {
return err
}
storedVtxs = append(storedVtxs, vtx)
} else if err := b.fetch(vtxID); err != nil {
return err
}
}
if err := b.process(storedVtxs...); err != nil {
return err
}
b.processedStartingAcceptedFrontier = true
if numPending := b.outstandingRequests.Len(); numPending == 0 {