From 4223e1f9d53bf769aada5a9ee0e2703d7029b23d Mon Sep 17 00:00:00 2001
From: Dan Laine <daniel.laine@avalabs.org>
Date: Tue, 16 Jun 2020 17:51:49 -0400
Subject: [PATCH 1/2] remove unnecessary call to Has

---
 vms/components/state/state.go | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/vms/components/state/state.go b/vms/components/state/state.go
index d4d0da8..24b50e3 100644
--- a/vms/components/state/state.go
+++ b/vms/components/state/state.go
@@ -128,19 +128,10 @@ func (s *state) Get(db database.Database, typeID uint64, key ids.ID) (interface{
 	// The unique ID of this key/typeID pair
 	uID := s.uniqueID(key, typeID)
 
-	// See if exists in database
-	exists, err := db.Has(uID.Bytes())
-	if err != nil {
-		return nil, err
-	}
-	if !exists {
-		return nil, database.ErrNotFound
-	}
-
 	// Get the value from the database
 	valueBytes, err := db.Get(uID.Bytes())
 	if err != nil {
-		return nil, fmt.Errorf("problem getting value from database: %w", err)
+		return nil, err
 	}
 
 	// Unmarshal the value from bytes and return it

From ddcc2d73a2022c260f0d0b24906435e46ae29765 Mon Sep 17 00:00:00 2001
From: Dan Laine <daniel.laine@avalabs.org>
Date: Tue, 16 Jun 2020 18:14:16 -0400
Subject: [PATCH 2/2] lazily fetch block status

---
 vms/components/core/block.go      |  4 +--
 vms/components/core/block_test.go | 48 +++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+), 3 deletions(-)
 create mode 100644 vms/components/core/block_test.go

diff --git a/vms/components/core/block.go b/vms/components/core/block.go
index 3609477..6d1d37b 100644
--- a/vms/components/core/block.go
+++ b/vms/components/core/block.go
@@ -34,8 +34,7 @@ type Block struct {
 func (b *Block) Initialize(bytes []byte, vm *SnowmanVM) {
 	b.VM = vm
 	b.Metadata.Initialize(bytes)
-	status := b.VM.State.GetStatus(vm.DB, b.ID())
-	b.SetStatus(status)
+	b.SetStatus(choices.Unknown) // don't set status until it is queried
 }
 
 // ParentID returns [b]'s parent's ID
@@ -55,7 +54,6 @@ func (b *Block) Parent() snowman.Block {
 // Recall that b.vm.DB.Commit() must be called to persist to the DB
 func (b *Block) Accept() error {
 	b.SetStatus(choices.Accepted) // Change state of this block
-
 	blkID := b.ID()
 
 	// Persist data
diff --git a/vms/components/core/block_test.go b/vms/components/core/block_test.go
new file mode 100644
index 0000000..d9d30bc
--- /dev/null
+++ b/vms/components/core/block_test.go
@@ -0,0 +1,48 @@
+package core
+
+import (
+	"testing"
+
+	"github.com/ava-labs/gecko/snow/choices"
+	"github.com/ava-labs/gecko/snow/consensus/snowman"
+
+	"github.com/ava-labs/gecko/ids"
+
+	"github.com/ava-labs/gecko/database/memdb"
+	"github.com/ava-labs/gecko/database/versiondb"
+)
+
+func TestBlock(t *testing.T) {
+	parentID := ids.NewID([32]byte{1, 2, 3, 4, 5})
+	db := versiondb.New(memdb.New())
+	state, err := NewSnowmanState(func([]byte) (snowman.Block, error) { return nil, nil })
+	if err != nil {
+		t.Fatal(err)
+	}
+	b := NewBlock(parentID)
+
+	b.Initialize([]byte{1, 2, 3}, &SnowmanVM{
+		DB:    db,
+		State: state,
+	})
+
+	// should be unknown until someone queries for it
+	if status := b.Metadata.status; status != choices.Unknown {
+		t.Fatalf("status should be unknown but is %s", status)
+	}
+
+	// querying should change status to processing
+	if status := b.Status(); status != choices.Processing {
+		t.Fatalf("status should be processing but is %s", status)
+	}
+
+	b.Accept()
+	if status := b.Status(); status != choices.Accepted {
+		t.Fatalf("status should be accepted but is %s", status)
+	}
+
+	b.Reject()
+	if status := b.Status(); status != choices.Rejected {
+		t.Fatalf("status should be rejected but is %s", status)
+	}
+}