Merge pull request #4717 from MetaMask/chrome-promise-bugfix

Conditionally use Promise-based extension API when creating windows
This commit is contained in:
Dan Finlay 2018-07-03 11:16:35 -07:00 committed by GitHub
commit 2e9bd7e9d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions

View File

@ -26,15 +26,15 @@ class NotificationManager {
// bring focus to existing chrome popup
extension.windows.update(popup.id, { focused: true })
} else {
const cb = (currentPopup) => { this._popupId = currentPopup.id }
// create new notification popup
extension.windows.create({
const creation = extension.windows.create({
url: 'notification.html',
type: 'popup',
width,
height,
}).then((currentPopup) => {
this._popupId = currentPopup.id
})
}, cb)
creation && creation.then && creation.then(cb)
}
})
}