From 77d42f3bcaeac47ccfdfbf81f00315edffc583d1 Mon Sep 17 00:00:00 2001
From: Victor Baranov <baranov.viktor.27@gmail.com>
Date: Wed, 19 Dec 2018 19:44:04 +0300
Subject: [PATCH 1/7] Select in put for boolean type

---
 old-ui/app/components/send/send-contract.js | 78 +++++++++++++++++----
 1 file changed, 65 insertions(+), 13 deletions(-)

diff --git a/old-ui/app/components/send/send-contract.js b/old-ui/app/components/send/send-contract.js
index c2e292c09..c2b40a3ef 100644
--- a/old-ui/app/components/send/send-contract.js
+++ b/old-ui/app/components/send/send-contract.js
@@ -11,13 +11,12 @@ import abiEncoder from 'web3-eth-abi'
 import Web3 from 'web3'
 import copyToClipboard from 'copy-to-clipboard'
 
-class SendTransactionInput extends Component {
+class SendTransactionInputText extends Component {
 	constructor (props) {
 		super(props)
 		this.state = {
 			inputVal: props.defaultValue,
 		}
-		this.timerID = null
 	}
 
 	static propTypes = {
@@ -34,16 +33,55 @@ class SendTransactionInput extends Component {
 				className="input large-input"
 				placeholder={this.props.placeholder}
 				value={this.state.inputVal}
-				onChange={e => {
+				onChange={(val) => {
 						this.setState({
-							inputVal: e.target.value,
+							inputVal: val,
 						})
-						this.props.onChange(e)
+						this.props.onChange(val)
 					}
 				}
 				style={{ marginTop: '5px' }}
 			/>
-			)
+		)
+	}
+}
+
+class SendTransactionInputSelect extends Component {
+	constructor (props) {
+		super(props)
+		this.state = {
+			inputVal: props.defaultValue,
+		}
+	}
+
+	static propTypes = {
+		defaultValue: PropTypes.string,
+		value: PropTypes.string,
+		onChange: PropTypes.func,
+	}
+
+	render () {
+		return (
+			<Select
+				clearable={false}
+				value={this.state.inputVal}
+				options={[{
+					label: 'false',
+					value: false
+				}, {
+					label: 'true',
+					value: true
+				}]}
+				onChange={(opt) => {
+						this.setState({
+							inputVal: opt.value,
+						})
+						this.props.onChange(opt.value)
+					}
+				}
+				style={{ marginTop: '5px' }}
+			/>
+		)
 	}
 }
 
@@ -63,6 +101,7 @@ class SendTransactionScreen extends PersistentForm {
 			output: '',
 			copyDisabled: true,
 		}
+		this.timerID = null
 		PersistentForm.call(this)
 	}
 
@@ -148,15 +187,27 @@ class SendTransactionScreen extends PersistentForm {
 				{params.name || `Input ${ind + 1}`}
 			</h3>
 		)
-		const input = (
-			<SendTransactionInput
+		let input
+		if (params.type === 'bool') {
+			input = (
+			<SendTransactionInputSelect
 				key={Math.random()}
 				ind={ind}
-				placeholder={params.type}
 				defaultValue={(this.props.inputValues && this.props.inputValues[ind]) || ''}
-				onChange={e => this.handleInputChange(e, ind)}
+				onChange={val => this.handleInputChange(val, ind)}
 			/>
 		)
+		} else {
+			input = (
+				<SendTransactionInputText
+					key={Math.random()}
+					ind={ind}
+					placeholder={params.type}
+					defaultValue={(this.props.inputValues && this.props.inputValues[ind]) || ''}
+					onChange={e => this.handleInputChange(e.target.value, ind)}
+				/>
+			)
+		}
 		const inputObj = (
 			<div key={`method_label_container_${ind}`}>
 				{label}
@@ -166,10 +217,11 @@ class SendTransactionScreen extends PersistentForm {
 		return inputObj
 	}
 
-	handleInputChange (e, ind) {
+	handleInputChange (val, ind) {
+		console.log(val, ind)
 		const { inputValues } = this.state
-		if (e.target.value) {
-			inputValues[ind] = e.target.value
+		if (val) {
+			inputValues[ind] = val
 		} else {
 			delete inputValues[ind]
 		}

From c79358ff5aedabab5a6da6c6b038acc3bcc667ae Mon Sep 17 00:00:00 2001
From: dennistikhomirov <dennis00010011b@gmail.com>
Date: Thu, 20 Dec 2018 00:58:50 -0800
Subject: [PATCH 2/7] e2e: execute method boolean dropdown

---
 test/e2e/elements.js      |  1 +
 test/e2e/func.js          |  5 ++---
 test/e2e/metamask.spec.js | 39 +++++++++++++++++++++++----------------
 3 files changed, 26 insertions(+), 19 deletions(-)

diff --git a/test/e2e/elements.js b/test/e2e/elements.js
index 5952e44de..9a036e146 100644
--- a/test/e2e/elements.js
+++ b/test/e2e/elements.js
@@ -377,3 +377,4 @@ module.exports = {
 }
 
 
+
diff --git a/test/e2e/func.js b/test/e2e/func.js
index b27b09018..8670b2701 100644
--- a/test/e2e/func.js
+++ b/test/e2e/func.js
@@ -78,9 +78,7 @@ function buildFirefoxWebdriver () {
 
 async function getExtensionIdChrome (driver) {
   await driver.get('chrome://extensions')
-  const extensionId = await driver.executeScript('return document.querySelector("extensions-manager").shadowRoot.querySelector("extensions-view-manager extensions-item-list").shadowRoot.querySelector("extensions-item:nth-child(2)").getAttribute("id")')
-  // const extensionId = 'fmdpnlapjechkkicpkahdmanomngknlf'
-
+  const extensionId = await driver.executeScript('return document.querySelector("extensions-manager").shadowRoot.querySelector("cr-view-manager extensions-item-list").shadowRoot.querySelector("extensions-item:nth-child(2)").getAttribute("id")')
   return extensionId
 }
 
@@ -110,3 +108,4 @@ async function verboseReportOnFailure ({ browser, driver, title }) {
   const htmlSource = await driver.getPageSource()
   await fs.writeFile(`${filepathBase}-dom.html`, htmlSource)
 }
+
diff --git a/test/e2e/metamask.spec.js b/test/e2e/metamask.spec.js
index d01027cca..47deb3ee7 100644
--- a/test/e2e/metamask.spec.js
+++ b/test/e2e/metamask.spec.js
@@ -466,7 +466,7 @@ describe('Metamask popup page', async function () {
         })
       })
       describe('Check output for data type : BOOLEAN', () => {
-          it("Select method 'returnBoolean'", async function () {
+        it("Select method 'returnBoolean'", async function () {
           const field = await waitUntilShowUp(screens.executeMethod.selectArrow)
           await field.click()
           await waitUntilShowUp(screens.executeMethod.items)
@@ -475,11 +475,14 @@ describe('Metamask popup page', async function () {
           assert.equal(list.length, 22, "drop down menu isn't displayed")
         })
 
-        it('Fill out input parameter field, value is TRUE', async function () {
-          await waitUntilShowUp(screens.executeMethod.fieldParameter)
-          const fields = await driver.findElements(screens.executeMethod.fieldParameter)
-          assert.notEqual(fields[0], false, "field parameter#1 isn't displayed")
-          await fields[0].sendKeys('true')
+        it('Select value TRUE from dropdown menu', async function () {
+          const arrows = await driver.findElements(screens.executeMethod.selectArrow)
+          await arrows[1].click()
+          await waitUntilShowUp(screens.executeMethod.items)
+          const list = await driver.findElements(screens.executeMethod.items)
+          assert.equal(await list[1].getText(), 'true', 'TRUE menu item: incorrect text')
+          assert.equal(list.length, 2, "drop down menu isn't displayed")
+          await list[1].click()
         })
 
         it("Click button 'Call data' ", async function () {
@@ -493,16 +496,19 @@ describe('Metamask popup page', async function () {
           await delay(3000)
           await waitUntilShowUp(screens.executeMethod.fieldOutput)
           const fields = await driver.findElements(screens.executeMethod.fieldOutput)
-          assert.notEqual(fields[1], false, "field 'Output'  isn't displayed")
-          const text = await waitUntilHasValue(fields[1])
+          assert.notEqual(fields[0], false, "field 'Output'  isn't displayed")
+          const text = await waitUntilHasValue(fields[0])
           assert.equal(text, 'true', 'incorrect value was returned')
         })
-        it('Fill out input parameter field, value is FALSE ', async function () {
-          await waitUntilShowUp(screens.executeMethod.fieldParameter)
-          const fields = await driver.findElements(screens.executeMethod.fieldParameter)
-          assert.notEqual(fields[0], false, "field parameter#1 isn't displayed")
-          await clearField(fields[0])
-          await fields[0].sendKeys('false')
+
+        it('Select value FALSE from dropdown menu', async function () {
+          const arrows = await driver.findElements(screens.executeMethod.selectArrow)
+          await arrows[1].click()
+          await waitUntilShowUp(screens.executeMethod.items)
+          const list = await driver.findElements(screens.executeMethod.items)
+          assert.equal(await list[0].getText(), 'false', 'FALSE menu item: incorrect text')
+          assert.equal(list.length, 2, "drop down menu isn't displayed")
+          await list[0].click()
         })
 
         it("Click button 'Call data' ", async function () {
@@ -516,8 +522,8 @@ describe('Metamask popup page', async function () {
           await delay(3000)
           await waitUntilShowUp(screens.executeMethod.fieldOutput)
           const fields = await driver.findElements(screens.executeMethod.fieldOutput)
-          assert.notEqual(fields[1], false, "field 'Output'  isn't displayed")
-          const text = await waitUntilHasValue(fields[1])
+          assert.notEqual(fields[0], false, "field 'Output'  isn't displayed")
+          const text = await waitUntilHasValue(fields[0])
           assert.equal(text, 'false', 'incorrect value was returned')
         })
 
@@ -2815,3 +2821,4 @@ describe('Metamask popup page', async function () {
 })
 
 
+

From a383d56ad2407d0ad6641d3ce3aca12d6f35e528 Mon Sep 17 00:00:00 2001
From: dennistikhomirov <dennis00010011b@gmail.com>
Date: Thu, 20 Dec 2018 02:51:18 -0800
Subject: [PATCH 3/7] e2e:install lastest chrome

---
 .circleci/config.yml | 686 ++++++++++++++++++++++---------------------
 1 file changed, 347 insertions(+), 339 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 9102eb818..328641705 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -4,330 +4,338 @@ workflows:
   version: 2
   full_test:
     jobs:
-    - prep-deps-npm
-    - prep-build:
-        requires:
-        - prep-deps-npm
-    - prep-docs:
-        requires:
-        - prep-deps-npm
-    - prep-scss:
-        requires:
-        - prep-deps-npm
-    - test-lint:
-        requires:
-        - prep-deps-npm
-    - test-deps:
-        requires:
-        - prep-deps-npm
-    - test-e2e-chrome:
-        requires:
-        - prep-deps-npm
-        - prep-build
-    - test-e2e-firefox:
-        requires:
-        - prep-deps-npm
-        - prep-build
-    - test-unit:
-        requires:
-        - prep-deps-npm
-    - test-integration-mascara-chrome:
-        requires:
-        - prep-deps-npm
-        - prep-scss
-    - test-integration-mascara-firefox:
-        requires:
-        - prep-deps-npm
-        - prep-scss
-    - test-integration-flat-chrome:
-        requires:
-        - prep-deps-npm
-        - prep-scss
-    - test-integration-flat-firefox:
-        requires:
-        - prep-deps-npm
-        - prep-scss
-    - all-tests-pass:
-        requires:
-        - test-lint
-        - test-unit
-        - test-e2e-chrome
-        - test-e2e-firefox
-        - test-integration-mascara-chrome
-        - test-integration-mascara-firefox
-        - test-integration-flat-chrome
-        - test-integration-flat-firefox
-    - job-screens:
-        requires:
-        - prep-deps-npm
-        - prep-build
-    #           - all-tests-pass
-    - job-publish-prerelease:
-        requires:
-        - prep-deps-npm
-        - prep-build
-        - job-screens
-    #           - all-tests-pass
-    - job-publish-release:
-        filters:
-          branches:
-            only: master
-        requires:
-        - prep-deps-npm
-        - prep-build
-        - prep-docs
-        - job-screens
-    #           - all-tests-pass
-    - job-publish-postrelease:
-        filters:
-          branches:
-            only: master
-        requires:
-        - prep-deps-npm
-        - prep-build
-        - prep-docs
-        - job-screens
+      - prep-deps-npm
+      - prep-build:
+          requires:
+            - prep-deps-npm
+      - prep-docs:
+          requires:
+            - prep-deps-npm
+      - prep-scss:
+          requires:
+            - prep-deps-npm
+      - test-lint:
+          requires:
+            - prep-deps-npm
+      - test-deps:
+          requires:
+            - prep-deps-npm
+      - test-e2e-chrome:
+          requires:
+            - prep-deps-npm
+            - prep-build
+      - test-e2e-firefox:
+          requires:
+            - prep-deps-npm
+            - prep-build
+      - test-unit:
+          requires:
+            - prep-deps-npm
+      - test-integration-mascara-chrome:
+          requires:
+            - prep-deps-npm
+            - prep-scss
+      - test-integration-mascara-firefox:
+          requires:
+            - prep-deps-npm
+            - prep-scss
+      - test-integration-flat-chrome:
+          requires:
+            - prep-deps-npm
+            - prep-scss
+      - test-integration-flat-firefox:
+          requires:
+            - prep-deps-npm
+            - prep-scss
+      - all-tests-pass:
+          requires:
+            - test-lint
+            - test-unit
+            - test-e2e-chrome
+            - test-e2e-firefox
+            - test-integration-mascara-chrome
+            - test-integration-mascara-firefox
+            - test-integration-flat-chrome
+            - test-integration-flat-firefox
+      - job-screens:
+          requires:
+            - prep-deps-npm
+            - prep-build
+      #           - all-tests-pass
+      - job-publish-prerelease:
+          requires:
+            - prep-deps-npm
+            - prep-build
+            - job-screens
+      #           - all-tests-pass
+      - job-publish-release:
+          filters:
+            branches:
+              only: master
+          requires:
+            - prep-deps-npm
+            - prep-build
+            - prep-docs
+            - job-screens
+      #           - all-tests-pass
+      - job-publish-postrelease:
+          filters:
+            branches:
+              only: master
+          requires:
+            - prep-deps-npm
+            - prep-build
+            - prep-docs
+            - job-screens
 #            - all-tests-pass
 
 jobs:
   prep-deps-npm:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: Install npm 6 + deps via npm
-        command: |
-          sudo npm install -g npm@6.4.1 && npm install --no-save
-    - save_cache:
-        key: dependency-cache-{{ .Revision }}
-        paths:
-        - node_modules
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: Install npm 6 + deps via npm
+          command: |
+            sudo npm install -g npm@6.4.1 && npm install --no-save
+      - run:
+          name: Install Chromedriver latest version
+          command: |
+            sudo apt-get update
+            sudo apt-get install lsb-release
+            curl -L -o google-chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
+            sudo dpkg -i google-chrome.deb
+            rm google-chrome.deb
+      - save_cache:
+          key: dependency-cache-{{ .Revision }}
+          paths:
+            - node_modules
 
   prep-build:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: build:dist
-        command: NODE_ENV='production' npm run dist
-    - run:
-        name: build:debug
-        command: find dist/ -type f -exec md5sum {} \; | sort -k 2
-    - save_cache:
-        key: build-cache-{{ .Revision }}
-        paths:
-        - dist
-        - builds
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: build:dist
+          command: NODE_ENV='production' npm run dist
+      - run:
+          name: build:debug
+          command: find dist/ -type f -exec md5sum {} \; | sort -k 2
+      - save_cache:
+          key: build-cache-{{ .Revision }}
+          paths:
+            - dist
+            - builds
 
   prep-docs:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: build:dist
-        command: npm run doc
-    - save_cache:
-        key: docs-cache-{{ .Revision }}
-        paths:
-        - docs/jsdoc
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: build:dist
+          command: npm run doc
+      - save_cache:
+          key: docs-cache-{{ .Revision }}
+          paths:
+            - docs/jsdoc
 
   prep-scss:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: Get Scss Cache key
-        # this allows us to checksum against a whole directory
-        command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
-    - run:
-        name: Build for integration tests
-        command: npm run test:integration:build
-    - save_cache:
-        key: scss-cache-{{ checksum "scss_checksum" }}
-        paths:
-        - ui/app/css/output
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: Get Scss Cache key
+          # this allows us to checksum against a whole directory
+          command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
+      - run:
+          name: Build for integration tests
+          command: npm run test:integration:build
+      - save_cache:
+          key: scss-cache-{{ checksum "scss_checksum" }}
+          paths:
+            - ui/app/css/output
 
   test-lint:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: Test
-        command: npm run lint
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: Test
+          command: npm run lint
 
   test-deps:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: Test
-        command: sudo npm install -g npm@6 && npm audit
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: Test
+          command: sudo npm install -g npm@6 && npm audit
 
   test-e2e-chrome:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - restore_cache:
-        key: build-cache-{{ .Revision }}
-    - run:
-        name: test:e2e:chrome
-        command: npm run test:e2e:chrome
-    - store_artifacts:
-        path: test-artifacts
-        destination: test-artifacts
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - restore_cache:
+          key: build-cache-{{ .Revision }}
+      - run:
+          name: test:e2e:chrome
+          command: npm run test:e2e:chrome
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
 
   test-e2e-firefox:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-firefox-{{ .Revision }}
-    - run:
-        name: Install firefox
-        command: ./.circleci/scripts/firefox-install
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - restore_cache:
-        key: build-cache-{{ .Revision }}
-    - run:
-        name: test:e2e:firefox
-        command: npm run test:e2e:firefox
-    - store_artifacts:
-        path: test-artifacts
-        destination: test-artifacts
+      - checkout
+      - restore_cache:
+          key: dependency-cache-firefox-{{ .Revision }}
+      - run:
+          name: Install firefox
+          command: ./.circleci/scripts/firefox-install
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - restore_cache:
+          key: build-cache-{{ .Revision }}
+      - run:
+          name: test:e2e:firefox
+          command: npm run test:e2e:firefox
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
 
   test-e2e-beta-chrome:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - restore_cache:
-        key: build-cache-{{ .Revision }}
-    - run:
-        name: test:e2e:chrome:beta
-        command: npm run test:e2e:chrome:beta
-    - store_artifacts:
-        path: test-artifacts
-        destination: test-artifacts
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - restore_cache:
+          key: build-cache-{{ .Revision }}
+      - run:
+          name: test:e2e:chrome:beta
+          command: npm run test:e2e:chrome:beta
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
 
   test-e2e-beta-firefox:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-firefox-{{ .Revision }}
-    - run:
-        name: Install firefox
-        command: ./.circleci/scripts/firefox-install
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - restore_cache:
-        key: build-cache-{{ .Revision }}
-    - run:
-        name: test:e2e:firefox:beta
-        command: npm run test:e2e:firefox:beta
-    - store_artifacts:
-        path: test-artifacts
-        destination: test-artifacts
+      - checkout
+      - restore_cache:
+          key: dependency-cache-firefox-{{ .Revision }}
+      - run:
+          name: Install firefox
+          command: ./.circleci/scripts/firefox-install
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - restore_cache:
+          key: build-cache-{{ .Revision }}
+      - run:
+          name: test:e2e:firefox:beta
+          command: npm run test:e2e:firefox:beta
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
 
   job-screens:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - restore_cache:
-        key: build-cache-{{ .Revision }}
-    - run:
-        name: Test
-        command: npm run test:screens
-    - save_cache:
-        key: job-screens-{{ .Revision }}
-        paths:
-        - test-artifacts
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - restore_cache:
+          key: build-cache-{{ .Revision }}
+      - run:
+          name: Test
+          command: npm run test:screens
+      - save_cache:
+          key: job-screens-{{ .Revision }}
+          paths:
+            - test-artifacts
 
   job-publish-prerelease:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - restore_cache:
-        key: build-cache-{{ .Revision }}
-    - restore_cache:
-        key: job-screens-{{ .Revision }}
-    - store_artifacts:
-        path: dist/mascara
-        destination: builds/mascara
-    - store_artifacts:
-        path: dist/sourcemaps
-        destination: builds/sourcemaps
-    - store_artifacts:
-        path: builds
-        destination: builds
-    - store_artifacts:
-        path: test-artifacts
-        destination: test-artifacts
-    - run:
-        name: build:announce
-        command: ./development/metamaskbot-build-announce.js
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - restore_cache:
+          key: build-cache-{{ .Revision }}
+      - restore_cache:
+          key: job-screens-{{ .Revision }}
+      - store_artifacts:
+          path: dist/mascara
+          destination: builds/mascara
+      - store_artifacts:
+          path: dist/sourcemaps
+          destination: builds/sourcemaps
+      - store_artifacts:
+          path: builds
+          destination: builds
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
+      - run:
+          name: build:announce
+          command: ./development/metamaskbot-build-announce.js
 
   job-publish-release:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - restore_cache:
-        key: build-cache-{{ .Revision }}
-    - run:
-        name: build:release
-        command: node ./development/publish-release.js
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - restore_cache:
+          key: build-cache-{{ .Revision }}
+      - run:
+          name: build:release
+          command: node ./development/publish-release.js
 
   job-publish-postrelease:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - restore_cache:
-        key: build-cache-{{ .Revision }}
-    - restore_cache:
-        key: docs-cache-{{ .Revision }}
-    - restore_cache:
-        key: job-screens-{{ .Revision }}
-    - run:
-        name: sentry sourcemaps upload
-        command: npm run sentry:publish
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - restore_cache:
+          key: build-cache-{{ .Revision }}
+      - restore_cache:
+          key: docs-cache-{{ .Revision }}
+      - restore_cache:
+          key: job-screens-{{ .Revision }}
+      - run:
+          name: sentry sourcemaps upload
+          command: npm run sentry:publish
   #        - run:
   #            name: github gh-pages docs publish
   #            command: >
@@ -337,105 +345,105 @@ jobs:
 
   test-unit:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: test:coverage
-        command: npm run test:coverage
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: test:coverage
+          command: npm run test:coverage
 
   test-integration-flat-firefox:
     environment:
       browsers: '["Firefox"]'
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-firefox-{{ .Revision }}
-    - run:
-        name: Install firefox
-        command: ./.circleci/scripts/firefox-install
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: Get Scss Cache key
-        # this allows us to checksum against a whole directory
-        command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
-    - restore_cache:
-        key: scss-cache-{{ checksum "scss_checksum" }}
-    - run:
-        name: test:integration:flat
-        command: npm run test:flat
+      - checkout
+      - restore_cache:
+          key: dependency-cache-firefox-{{ .Revision }}
+      - run:
+          name: Install firefox
+          command: ./.circleci/scripts/firefox-install
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: Get Scss Cache key
+          # this allows us to checksum against a whole directory
+          command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
+      - restore_cache:
+          key: scss-cache-{{ checksum "scss_checksum" }}
+      - run:
+          name: test:integration:flat
+          command: npm run test:flat
 
   test-integration-flat-chrome:
     environment:
       browsers: '["Chrome"]'
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: Get Scss Cache key
-        # this allows us to checksum against a whole directory
-        command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
-    - restore_cache:
-        key: scss-cache-{{ checksum "scss_checksum" }}
-    - run:
-        name: test:integration:flat
-        command: npm run test:flat
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: Get Scss Cache key
+          # this allows us to checksum against a whole directory
+          command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
+      - restore_cache:
+          key: scss-cache-{{ checksum "scss_checksum" }}
+      - run:
+          name: test:integration:flat
+          command: npm run test:flat
 
   test-integration-mascara-firefox:
     environment:
       browsers: '["Firefox"]'
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-firefox-{{ .Revision }}
-    - run:
-        name: Install firefox
-        command: ./.circleci/scripts/firefox-install
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: Get Scss Cache key
-        # this allows us to checksum against a whole directory
-        command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
-    - restore_cache:
-        key: scss-cache-{{ checksum "scss_checksum" }}
-    - run:
-        name: test:integration:mascara
-        command: npm run test:mascara
+      - checkout
+      - restore_cache:
+          key: dependency-cache-firefox-{{ .Revision }}
+      - run:
+          name: Install firefox
+          command: ./.circleci/scripts/firefox-install
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: Get Scss Cache key
+          # this allows us to checksum against a whole directory
+          command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
+      - restore_cache:
+          key: scss-cache-{{ checksum "scss_checksum" }}
+      - run:
+          name: test:integration:mascara
+          command: npm run test:mascara
 
   test-integration-mascara-chrome:
     environment:
       browsers: '["Chrome"]'
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - checkout
-    - restore_cache:
-        key: dependency-cache-{{ .Revision }}
-    - run:
-        name: Get Scss Cache key
-        # this allows us to checksum against a whole directory
-        command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
-    - restore_cache:
-        key: scss-cache-{{ checksum "scss_checksum" }}
-    - run:
-        name: test:integration:mascara
-        command: npm run test:mascara
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Revision }}
+      - run:
+          name: Get Scss Cache key
+          # this allows us to checksum against a whole directory
+          command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
+      - restore_cache:
+          key: scss-cache-{{ checksum "scss_checksum" }}
+      - run:
+          name: test:integration:mascara
+          command: npm run test:mascara
 
   all-tests-pass:
     docker:
-    - image: circleci/node:8.12.0-browsers
+      - image: circleci/node:8.12.0-browsers
     steps:
-    - run:
-        name: All Tests Passed
-        command: echo 'weew - everything passed!'
\ No newline at end of file
+      - run:
+          name: All Tests Passed
+          command: echo 'weew - everything passed!'

From 8028070f4a824186c29bd74a3cf1c9e8209be7c8 Mon Sep 17 00:00:00 2001
From: dennistikhomirov <dennis00010011b@gmail.com>
Date: Thu, 20 Dec 2018 03:02:25 -0800
Subject: [PATCH 4/7] e2e:lintt fix

---
 .circleci/config.yml      | 686 +++++++++++++++++++-------------------
 test/e2e/elements.js      |   1 -
 test/e2e/func.js          |   3 +-
 test/e2e/metamask.spec.js |   1 -
 4 files changed, 341 insertions(+), 350 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 328641705..9102eb818 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -4,338 +4,330 @@ workflows:
   version: 2
   full_test:
     jobs:
-      - prep-deps-npm
-      - prep-build:
-          requires:
-            - prep-deps-npm
-      - prep-docs:
-          requires:
-            - prep-deps-npm
-      - prep-scss:
-          requires:
-            - prep-deps-npm
-      - test-lint:
-          requires:
-            - prep-deps-npm
-      - test-deps:
-          requires:
-            - prep-deps-npm
-      - test-e2e-chrome:
-          requires:
-            - prep-deps-npm
-            - prep-build
-      - test-e2e-firefox:
-          requires:
-            - prep-deps-npm
-            - prep-build
-      - test-unit:
-          requires:
-            - prep-deps-npm
-      - test-integration-mascara-chrome:
-          requires:
-            - prep-deps-npm
-            - prep-scss
-      - test-integration-mascara-firefox:
-          requires:
-            - prep-deps-npm
-            - prep-scss
-      - test-integration-flat-chrome:
-          requires:
-            - prep-deps-npm
-            - prep-scss
-      - test-integration-flat-firefox:
-          requires:
-            - prep-deps-npm
-            - prep-scss
-      - all-tests-pass:
-          requires:
-            - test-lint
-            - test-unit
-            - test-e2e-chrome
-            - test-e2e-firefox
-            - test-integration-mascara-chrome
-            - test-integration-mascara-firefox
-            - test-integration-flat-chrome
-            - test-integration-flat-firefox
-      - job-screens:
-          requires:
-            - prep-deps-npm
-            - prep-build
-      #           - all-tests-pass
-      - job-publish-prerelease:
-          requires:
-            - prep-deps-npm
-            - prep-build
-            - job-screens
-      #           - all-tests-pass
-      - job-publish-release:
-          filters:
-            branches:
-              only: master
-          requires:
-            - prep-deps-npm
-            - prep-build
-            - prep-docs
-            - job-screens
-      #           - all-tests-pass
-      - job-publish-postrelease:
-          filters:
-            branches:
-              only: master
-          requires:
-            - prep-deps-npm
-            - prep-build
-            - prep-docs
-            - job-screens
+    - prep-deps-npm
+    - prep-build:
+        requires:
+        - prep-deps-npm
+    - prep-docs:
+        requires:
+        - prep-deps-npm
+    - prep-scss:
+        requires:
+        - prep-deps-npm
+    - test-lint:
+        requires:
+        - prep-deps-npm
+    - test-deps:
+        requires:
+        - prep-deps-npm
+    - test-e2e-chrome:
+        requires:
+        - prep-deps-npm
+        - prep-build
+    - test-e2e-firefox:
+        requires:
+        - prep-deps-npm
+        - prep-build
+    - test-unit:
+        requires:
+        - prep-deps-npm
+    - test-integration-mascara-chrome:
+        requires:
+        - prep-deps-npm
+        - prep-scss
+    - test-integration-mascara-firefox:
+        requires:
+        - prep-deps-npm
+        - prep-scss
+    - test-integration-flat-chrome:
+        requires:
+        - prep-deps-npm
+        - prep-scss
+    - test-integration-flat-firefox:
+        requires:
+        - prep-deps-npm
+        - prep-scss
+    - all-tests-pass:
+        requires:
+        - test-lint
+        - test-unit
+        - test-e2e-chrome
+        - test-e2e-firefox
+        - test-integration-mascara-chrome
+        - test-integration-mascara-firefox
+        - test-integration-flat-chrome
+        - test-integration-flat-firefox
+    - job-screens:
+        requires:
+        - prep-deps-npm
+        - prep-build
+    #           - all-tests-pass
+    - job-publish-prerelease:
+        requires:
+        - prep-deps-npm
+        - prep-build
+        - job-screens
+    #           - all-tests-pass
+    - job-publish-release:
+        filters:
+          branches:
+            only: master
+        requires:
+        - prep-deps-npm
+        - prep-build
+        - prep-docs
+        - job-screens
+    #           - all-tests-pass
+    - job-publish-postrelease:
+        filters:
+          branches:
+            only: master
+        requires:
+        - prep-deps-npm
+        - prep-build
+        - prep-docs
+        - job-screens
 #            - all-tests-pass
 
 jobs:
   prep-deps-npm:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: Install npm 6 + deps via npm
-          command: |
-            sudo npm install -g npm@6.4.1 && npm install --no-save
-      - run:
-          name: Install Chromedriver latest version
-          command: |
-            sudo apt-get update
-            sudo apt-get install lsb-release
-            curl -L -o google-chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
-            sudo dpkg -i google-chrome.deb
-            rm google-chrome.deb
-      - save_cache:
-          key: dependency-cache-{{ .Revision }}
-          paths:
-            - node_modules
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: Install npm 6 + deps via npm
+        command: |
+          sudo npm install -g npm@6.4.1 && npm install --no-save
+    - save_cache:
+        key: dependency-cache-{{ .Revision }}
+        paths:
+        - node_modules
 
   prep-build:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: build:dist
-          command: NODE_ENV='production' npm run dist
-      - run:
-          name: build:debug
-          command: find dist/ -type f -exec md5sum {} \; | sort -k 2
-      - save_cache:
-          key: build-cache-{{ .Revision }}
-          paths:
-            - dist
-            - builds
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: build:dist
+        command: NODE_ENV='production' npm run dist
+    - run:
+        name: build:debug
+        command: find dist/ -type f -exec md5sum {} \; | sort -k 2
+    - save_cache:
+        key: build-cache-{{ .Revision }}
+        paths:
+        - dist
+        - builds
 
   prep-docs:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: build:dist
-          command: npm run doc
-      - save_cache:
-          key: docs-cache-{{ .Revision }}
-          paths:
-            - docs/jsdoc
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: build:dist
+        command: npm run doc
+    - save_cache:
+        key: docs-cache-{{ .Revision }}
+        paths:
+        - docs/jsdoc
 
   prep-scss:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: Get Scss Cache key
-          # this allows us to checksum against a whole directory
-          command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
-      - run:
-          name: Build for integration tests
-          command: npm run test:integration:build
-      - save_cache:
-          key: scss-cache-{{ checksum "scss_checksum" }}
-          paths:
-            - ui/app/css/output
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: Get Scss Cache key
+        # this allows us to checksum against a whole directory
+        command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
+    - run:
+        name: Build for integration tests
+        command: npm run test:integration:build
+    - save_cache:
+        key: scss-cache-{{ checksum "scss_checksum" }}
+        paths:
+        - ui/app/css/output
 
   test-lint:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: Test
-          command: npm run lint
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: Test
+        command: npm run lint
 
   test-deps:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: Test
-          command: sudo npm install -g npm@6 && npm audit
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: Test
+        command: sudo npm install -g npm@6 && npm audit
 
   test-e2e-chrome:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - restore_cache:
-          key: build-cache-{{ .Revision }}
-      - run:
-          name: test:e2e:chrome
-          command: npm run test:e2e:chrome
-      - store_artifacts:
-          path: test-artifacts
-          destination: test-artifacts
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - restore_cache:
+        key: build-cache-{{ .Revision }}
+    - run:
+        name: test:e2e:chrome
+        command: npm run test:e2e:chrome
+    - store_artifacts:
+        path: test-artifacts
+        destination: test-artifacts
 
   test-e2e-firefox:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-firefox-{{ .Revision }}
-      - run:
-          name: Install firefox
-          command: ./.circleci/scripts/firefox-install
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - restore_cache:
-          key: build-cache-{{ .Revision }}
-      - run:
-          name: test:e2e:firefox
-          command: npm run test:e2e:firefox
-      - store_artifacts:
-          path: test-artifacts
-          destination: test-artifacts
+    - checkout
+    - restore_cache:
+        key: dependency-cache-firefox-{{ .Revision }}
+    - run:
+        name: Install firefox
+        command: ./.circleci/scripts/firefox-install
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - restore_cache:
+        key: build-cache-{{ .Revision }}
+    - run:
+        name: test:e2e:firefox
+        command: npm run test:e2e:firefox
+    - store_artifacts:
+        path: test-artifacts
+        destination: test-artifacts
 
   test-e2e-beta-chrome:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - restore_cache:
-          key: build-cache-{{ .Revision }}
-      - run:
-          name: test:e2e:chrome:beta
-          command: npm run test:e2e:chrome:beta
-      - store_artifacts:
-          path: test-artifacts
-          destination: test-artifacts
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - restore_cache:
+        key: build-cache-{{ .Revision }}
+    - run:
+        name: test:e2e:chrome:beta
+        command: npm run test:e2e:chrome:beta
+    - store_artifacts:
+        path: test-artifacts
+        destination: test-artifacts
 
   test-e2e-beta-firefox:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-firefox-{{ .Revision }}
-      - run:
-          name: Install firefox
-          command: ./.circleci/scripts/firefox-install
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - restore_cache:
-          key: build-cache-{{ .Revision }}
-      - run:
-          name: test:e2e:firefox:beta
-          command: npm run test:e2e:firefox:beta
-      - store_artifacts:
-          path: test-artifacts
-          destination: test-artifacts
+    - checkout
+    - restore_cache:
+        key: dependency-cache-firefox-{{ .Revision }}
+    - run:
+        name: Install firefox
+        command: ./.circleci/scripts/firefox-install
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - restore_cache:
+        key: build-cache-{{ .Revision }}
+    - run:
+        name: test:e2e:firefox:beta
+        command: npm run test:e2e:firefox:beta
+    - store_artifacts:
+        path: test-artifacts
+        destination: test-artifacts
 
   job-screens:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - restore_cache:
-          key: build-cache-{{ .Revision }}
-      - run:
-          name: Test
-          command: npm run test:screens
-      - save_cache:
-          key: job-screens-{{ .Revision }}
-          paths:
-            - test-artifacts
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - restore_cache:
+        key: build-cache-{{ .Revision }}
+    - run:
+        name: Test
+        command: npm run test:screens
+    - save_cache:
+        key: job-screens-{{ .Revision }}
+        paths:
+        - test-artifacts
 
   job-publish-prerelease:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - restore_cache:
-          key: build-cache-{{ .Revision }}
-      - restore_cache:
-          key: job-screens-{{ .Revision }}
-      - store_artifacts:
-          path: dist/mascara
-          destination: builds/mascara
-      - store_artifacts:
-          path: dist/sourcemaps
-          destination: builds/sourcemaps
-      - store_artifacts:
-          path: builds
-          destination: builds
-      - store_artifacts:
-          path: test-artifacts
-          destination: test-artifacts
-      - run:
-          name: build:announce
-          command: ./development/metamaskbot-build-announce.js
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - restore_cache:
+        key: build-cache-{{ .Revision }}
+    - restore_cache:
+        key: job-screens-{{ .Revision }}
+    - store_artifacts:
+        path: dist/mascara
+        destination: builds/mascara
+    - store_artifacts:
+        path: dist/sourcemaps
+        destination: builds/sourcemaps
+    - store_artifacts:
+        path: builds
+        destination: builds
+    - store_artifacts:
+        path: test-artifacts
+        destination: test-artifacts
+    - run:
+        name: build:announce
+        command: ./development/metamaskbot-build-announce.js
 
   job-publish-release:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - restore_cache:
-          key: build-cache-{{ .Revision }}
-      - run:
-          name: build:release
-          command: node ./development/publish-release.js
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - restore_cache:
+        key: build-cache-{{ .Revision }}
+    - run:
+        name: build:release
+        command: node ./development/publish-release.js
 
   job-publish-postrelease:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - restore_cache:
-          key: build-cache-{{ .Revision }}
-      - restore_cache:
-          key: docs-cache-{{ .Revision }}
-      - restore_cache:
-          key: job-screens-{{ .Revision }}
-      - run:
-          name: sentry sourcemaps upload
-          command: npm run sentry:publish
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - restore_cache:
+        key: build-cache-{{ .Revision }}
+    - restore_cache:
+        key: docs-cache-{{ .Revision }}
+    - restore_cache:
+        key: job-screens-{{ .Revision }}
+    - run:
+        name: sentry sourcemaps upload
+        command: npm run sentry:publish
   #        - run:
   #            name: github gh-pages docs publish
   #            command: >
@@ -345,105 +337,105 @@ jobs:
 
   test-unit:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: test:coverage
-          command: npm run test:coverage
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: test:coverage
+        command: npm run test:coverage
 
   test-integration-flat-firefox:
     environment:
       browsers: '["Firefox"]'
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-firefox-{{ .Revision }}
-      - run:
-          name: Install firefox
-          command: ./.circleci/scripts/firefox-install
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: Get Scss Cache key
-          # this allows us to checksum against a whole directory
-          command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
-      - restore_cache:
-          key: scss-cache-{{ checksum "scss_checksum" }}
-      - run:
-          name: test:integration:flat
-          command: npm run test:flat
+    - checkout
+    - restore_cache:
+        key: dependency-cache-firefox-{{ .Revision }}
+    - run:
+        name: Install firefox
+        command: ./.circleci/scripts/firefox-install
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: Get Scss Cache key
+        # this allows us to checksum against a whole directory
+        command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
+    - restore_cache:
+        key: scss-cache-{{ checksum "scss_checksum" }}
+    - run:
+        name: test:integration:flat
+        command: npm run test:flat
 
   test-integration-flat-chrome:
     environment:
       browsers: '["Chrome"]'
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: Get Scss Cache key
-          # this allows us to checksum against a whole directory
-          command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
-      - restore_cache:
-          key: scss-cache-{{ checksum "scss_checksum" }}
-      - run:
-          name: test:integration:flat
-          command: npm run test:flat
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: Get Scss Cache key
+        # this allows us to checksum against a whole directory
+        command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
+    - restore_cache:
+        key: scss-cache-{{ checksum "scss_checksum" }}
+    - run:
+        name: test:integration:flat
+        command: npm run test:flat
 
   test-integration-mascara-firefox:
     environment:
       browsers: '["Firefox"]'
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-firefox-{{ .Revision }}
-      - run:
-          name: Install firefox
-          command: ./.circleci/scripts/firefox-install
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: Get Scss Cache key
-          # this allows us to checksum against a whole directory
-          command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
-      - restore_cache:
-          key: scss-cache-{{ checksum "scss_checksum" }}
-      - run:
-          name: test:integration:mascara
-          command: npm run test:mascara
+    - checkout
+    - restore_cache:
+        key: dependency-cache-firefox-{{ .Revision }}
+    - run:
+        name: Install firefox
+        command: ./.circleci/scripts/firefox-install
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: Get Scss Cache key
+        # this allows us to checksum against a whole directory
+        command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
+    - restore_cache:
+        key: scss-cache-{{ checksum "scss_checksum" }}
+    - run:
+        name: test:integration:mascara
+        command: npm run test:mascara
 
   test-integration-mascara-chrome:
     environment:
       browsers: '["Chrome"]'
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ .Revision }}
-      - run:
-          name: Get Scss Cache key
-          # this allows us to checksum against a whole directory
-          command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
-      - restore_cache:
-          key: scss-cache-{{ checksum "scss_checksum" }}
-      - run:
-          name: test:integration:mascara
-          command: npm run test:mascara
+    - checkout
+    - restore_cache:
+        key: dependency-cache-{{ .Revision }}
+    - run:
+        name: Get Scss Cache key
+        # this allows us to checksum against a whole directory
+        command: find ui/app/css -type f -exec md5sum {} \; | sort -k 2 > scss_checksum
+    - restore_cache:
+        key: scss-cache-{{ checksum "scss_checksum" }}
+    - run:
+        name: test:integration:mascara
+        command: npm run test:mascara
 
   all-tests-pass:
     docker:
-      - image: circleci/node:8.12.0-browsers
+    - image: circleci/node:8.12.0-browsers
     steps:
-      - run:
-          name: All Tests Passed
-          command: echo 'weew - everything passed!'
+    - run:
+        name: All Tests Passed
+        command: echo 'weew - everything passed!'
\ No newline at end of file
diff --git a/test/e2e/elements.js b/test/e2e/elements.js
index 9a036e146..5952e44de 100644
--- a/test/e2e/elements.js
+++ b/test/e2e/elements.js
@@ -377,4 +377,3 @@ module.exports = {
 }
 
 
-
diff --git a/test/e2e/func.js b/test/e2e/func.js
index 8670b2701..c738ff173 100644
--- a/test/e2e/func.js
+++ b/test/e2e/func.js
@@ -78,7 +78,8 @@ function buildFirefoxWebdriver () {
 
 async function getExtensionIdChrome (driver) {
   await driver.get('chrome://extensions')
-  const extensionId = await driver.executeScript('return document.querySelector("extensions-manager").shadowRoot.querySelector("cr-view-manager extensions-item-list").shadowRoot.querySelector("extensions-item:nth-child(2)").getAttribute("id")')
+  // const extensionId = await driver.executeScript('return document.querySelector("extensions-manager").shadowRoot.querySelector("cr-view-manager extensions-item-list").shadowRoot.querySelector("extensions-item:nth-child(2)").getAttribute("id")')
+  const extensionId = await driver.executeScript('return document.querySelector("extensions-manager").shadowRoot.querySelector("extensions-view-manager extensions-item-list").shadowRoot.querySelector("extensions-item:nth-child(2)").getAttribute("id")')
   return extensionId
 }
 
diff --git a/test/e2e/metamask.spec.js b/test/e2e/metamask.spec.js
index 47deb3ee7..17d6ed78e 100644
--- a/test/e2e/metamask.spec.js
+++ b/test/e2e/metamask.spec.js
@@ -2821,4 +2821,3 @@ describe('Metamask popup page', async function () {
 })
 
 
-

From 2f89dfc5bbf8f9a1fe3816ce78713faba76368a7 Mon Sep 17 00:00:00 2001
From: Victor Baranov <baranov.viktor.27@gmail.com>
Date: Thu, 20 Dec 2018 16:43:38 +0300
Subject: [PATCH 5/7] onChange input handler fix

---
 old-ui/app/components/send/send-contract.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/old-ui/app/components/send/send-contract.js b/old-ui/app/components/send/send-contract.js
index 38433fb9e..114f91eb9 100644
--- a/old-ui/app/components/send/send-contract.js
+++ b/old-ui/app/components/send/send-contract.js
@@ -39,11 +39,11 @@ class SendTransactionField extends Component {
 				placeholder={this.props.placeholder}
 				value={this.state.val}
 				disabled={this.props.disabled}
-				onChange={(val) => {
+				onChange={(e) => {
 					this.setState({
-						val,
+						val: e.target.value,
 					})
-					this.props.onChange(val)
+					this.props.onChange(e.target.value)
 				}}
 				style={{ marginTop: '5px' }}
 			/>
@@ -231,7 +231,7 @@ class SendTransactionScreen extends PersistentForm {
 					disabled={!isInput}
 					placeholder={params.type}
 					defaultValue={defaultValue}
-					onChange={e => isInput ? this.handleInputChange(e.target.value, params.type, ind) : null}
+					onChange={val => isInput ? this.handleInputChange(val, params.type, ind) : null}
 				/>
 			)
 		}

From b67cc628f4e3988a6abed054d1274452812da2df Mon Sep 17 00:00:00 2001
From: dennistikhomirov <dennis00010011b@gmail.com>
Date: Thu, 20 Dec 2018 05:52:36 -0800
Subject: [PATCH 6/7] e2e: remove comment

---
 test/e2e/func.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/e2e/func.js b/test/e2e/func.js
index c738ff173..8e835e798 100644
--- a/test/e2e/func.js
+++ b/test/e2e/func.js
@@ -78,7 +78,6 @@ function buildFirefoxWebdriver () {
 
 async function getExtensionIdChrome (driver) {
   await driver.get('chrome://extensions')
-  // const extensionId = await driver.executeScript('return document.querySelector("extensions-manager").shadowRoot.querySelector("cr-view-manager extensions-item-list").shadowRoot.querySelector("extensions-item:nth-child(2)").getAttribute("id")')
   const extensionId = await driver.executeScript('return document.querySelector("extensions-manager").shadowRoot.querySelector("extensions-view-manager extensions-item-list").shadowRoot.querySelector("extensions-item:nth-child(2)").getAttribute("id")')
   return extensionId
 }

From c499a78dbedebb3d81e79de1c12375ff02dcbb2f Mon Sep 17 00:00:00 2001
From: Victor Baranov <baranov.viktor.27@gmail.com>
Date: Mon, 24 Dec 2018 12:16:12 +0300
Subject: [PATCH 7/7] remove key prop from bool input

---
 old-ui/app/components/send/send-contract.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/old-ui/app/components/send/send-contract.js b/old-ui/app/components/send/send-contract.js
index bbbc66305..1d93ff52c 100644
--- a/old-ui/app/components/send/send-contract.js
+++ b/old-ui/app/components/send/send-contract.js
@@ -227,7 +227,6 @@ class SendTransactionScreen extends PersistentForm {
 		if (params.type === 'bool' && isInput) {
 			field = (
 				<SendTransactionInputSelect
-					key={Math.random()}
 					ind={ind}
 					defaultValue={defaultValue}
 					onChange={val => this.handleInputChange(val, params.type, ind)}