Commit Graph

130 Commits

Author SHA1 Message Date
Dan Finlay ba7d6b437f Fix password validation and persistence issue
Was wiping the vault on each successful password attempt... :P
2016-11-03 16:14:37 -07:00
Dan Finlay e0246975a7 Finish fixing nicknaming bug 2016-11-03 13:44:29 -07:00
Dan Finlay bd2a429a85 Fix account nicknaming bug
When nicknaming, we weren't normalizing the input, and so we were retrieving with differently formatted addresses than we were persisting.
2016-11-03 11:59:20 -07:00
Dan Finlay 9ca3c57339 Fix vault creation bug 2016-11-03 11:34:57 -07:00
Dan Finlay 185396ff08 Fix dual vault creation bug 2016-11-02 16:35:46 -07:00
Dan Finlay 4cf1b606e4 Fix handling of migrating old vault style
Now old vaults are recognized as an "Initialized" MetaMask instance.

Upon logging in, when fetching the initial password-derived key, if there is no new-style vault, but there is an old style vault, it is migrated to the new format before proceeding through the usual unlocking steps.
2016-11-02 15:04:50 -07:00
Dan Finlay 18e5173f06 Now migrating old vaults to new DEN format 2016-10-29 02:29:25 -07:00
Dan Finlay 331d9c91ee Add vault migration test 2016-10-28 13:26:14 -07:00
Dan Finlay 2690d1acfd Added hd wallet tests 2016-10-27 17:23:26 -07:00
Dan Finlay 6c469a1826 Merge branch 'i328-MultiVault' of github.com:MetaMask/metamask-plugin into i328-MultiVault 2016-10-25 17:00:19 -07:00
Dan Finlay f9ff6cb55e Merge branch 'master' into i328-MultiVault 2016-10-25 16:59:58 -07:00
Kevin Serrano b3cb3e9ec6
Remove debugger statement. 2016-10-25 13:24:57 -07:00
Kevin Serrano 678301a20e
Phase out extra warning screen. 2016-10-25 13:24:03 -07:00
kumavis 3af3565000 test - fix delegate-call test 2016-10-24 16:12:44 -07:00
kumavis 85d03cc8fb Merge branch 'master' into i743-FixDelegateCallFlag 2016-10-24 12:24:19 -07:00
Dan Finlay 152419a79b Merge branch 'master' into i328-MultiVault 2016-10-21 17:58:18 -07:00
Dan Finlay 626b52d24a Fix bug in new KeyringController vault restoring logic. 2016-10-21 13:11:30 -07:00
Dan Finlay ee73e373a0 Create new vault before each keyringController unit test 2016-10-21 12:26:56 -07:00
Dan Finlay 44aa1be277 Create basic keyring-controller unit test file 2016-10-21 12:11:54 -07:00
Dan Finlay c3e1c5c57f Added SimpleKeyring tests 2016-10-21 11:10:36 -07:00
Frankie d4c0a4949b Clean up tests 2016-10-20 12:26:35 -07:00
Dan Finlay 0deed17752 Fix tests 2016-10-20 12:07:53 -07:00
Frankie aa4746f4c7 Add test and ability for isHex to handle hex strings with hex-prefix 2016-10-19 19:35:44 -07:00
Frankie 4366f72fe1 Add unit test for isHex and add to CHANGELOG.md 2016-10-19 15:22:56 -07:00
Kevin Serrano afbc4c832b
Git merge resolution. 2016-10-19 14:57:30 -07:00
Kevin Serrano ad3fa24a28
Intermediary commit. 2016-10-19 14:55:08 -07:00
Kevin Serrano 17506fe14f
Merge in crypto. 2016-10-19 11:17:29 -07:00
Dan Finlay 049705004f Reproduced issue 743 in test case
This contract hex does include the value `f4`, but it was compiled from a contract with no instance of `.delegatecall`. I believe `f4` in this case is part of some other value or contract address, and `ethBinToOps` has some error in how it skips pushed data.

@kumavis
2016-10-17 14:48:25 -07:00
Dan Finlay 827d7553fc Restore hex prefix to gas price 2016-10-17 13:05:45 -07:00
Dan Finlay 91f43fa213 Increase gas estimate by 100000 wei
To prevent minor gas estimation errors, probably usually related to operating on dynamic state.

Fixes #738.
2016-10-17 12:47:37 -07:00
Dan Finlay 535d832a64 Merge branch 'master' into i328-MultiVault 2016-10-12 10:58:58 -07:00
Kevin Serrano 5c0c370fe4
Remove comments. 2016-10-11 15:52:44 -07:00
Kevin Serrano 5e9bc31c58
Cleanup. 2016-10-11 15:50:02 -07:00
Dan Finlay ea1a934c7d Add initial KeyringController files 2016-10-11 15:12:23 -07:00
Kevin Serrano e20e0f661d
Fix integration test. 2016-10-05 19:49:53 -07:00
Kevin Serrano c0d6dcff00
Rewritten to react standards. Way easier. 2016-10-05 02:42:19 -07:00
Dan Finlay cf31e19029 Remove logs 2016-09-14 18:24:52 -07:00
Dan Finlay 0626adc0b4 Merge pull request #669 from MetaMask/Version-2.12.1
Version 2.12.1
2016-09-14 18:23:12 -07:00
Dan Finlay c3d1404e72 Fix clearing of account cache on vault restore 2016-09-12 15:18:32 -07:00
Dan Finlay e0e38b879f Fix some references 2016-09-12 11:21:27 -07:00
Dan Finlay 363c2a0939 Fix account unlocking
SubmitPassword was not creating a new id-management

This is because I broke up the old "createIdmgmt" method to not perform as much conditional logic.

Now the pieces are reusable and do what they should do.
2016-09-12 11:13:26 -07:00
Dan Finlay 5c1d8e299e Select first address when restoring vault
Fixes #642
2016-09-12 08:50:42 -07:00
Dan Finlay 9b861b6687 Fixed caching bug
Fixed bug where the second new vault created in an IdStore would initially return the accounts from the original store.

Also fixed some tests that were incorrect.
2016-09-10 15:45:34 -07:00
Dan Finlay 5e60b2f0c4 Correct assertion for BIP32 compliance
According to [axic's work here](https://github.com/MetaMask/metamask-plugin/issues/640#issuecomment-246133672), MetaMask is generating the correct address, so I've corrected that assertion accordingly.
2016-09-10 12:57:11 -07:00
Dan Finlay b1590f179e Remove log 2016-09-10 12:39:50 -07:00
Dan Finlay cdd367dc39 Add more bip44 assertions 2016-09-10 12:38:04 -07:00
Dan Finlay 8922ae1a55 Made bip44 assertions easier to add to 2016-09-10 12:35:52 -07:00
Dan Finlay 1b77d5300b Clean up tests 2016-09-10 12:15:05 -07:00
Dan Finlay 59fd86383f Correctly clear ethStore cache on new vault restore 2016-09-10 12:08:27 -07:00
Dan Finlay 6763871c41 Captured #640 in failing test 2016-09-10 11:46:50 -07:00