Commit Graph

34 Commits

Author SHA1 Message Date
Maximilian Krüger 59d354bde0 test: withdraw should succeed if gas price != requested gas price but sender is receiver 2018-02-13 16:51:24 +01:00
Maximilian Krüger 845ab3359c fix syntax error 2018-02-13 16:38:28 +01:00
Maximilian Krüger 22e9b5d695 add test that fails when gas price != requested gas price 2018-02-13 16:13:58 +01:00
Maximilian Krüger c97785862b remove unused function param 2018-02-13 14:25:54 +01:00
Maximilian Krüger ff9f7bb7f6 fix error handling in truffle tests
only catch/ignore such errors that we want to happen.
propagate all other errors correctly and don't ignore them.
2018-02-13 11:00:09 +01:00
Maximilian Krüger 4c63d4469e test/home: reduce homeGasPrice everywhere to keep coverage test from failing 2018-02-12 17:55:07 +01:00
Maximilian Krüger 71fed91200 test/home: trying lower gas price in to not fail when computing coverage 2018-02-12 17:39:56 +01:00
Maximilian Krüger e667321760 truffle tests fail on travis only :/ trying something 2018-02-12 17:17:05 +01:00
Maximilian Krüger 88a117a5ba fix test helpers.createMessage: allow setting of homeGasPrice 2018-02-09 09:44:55 +01:00
Maximilian Krüger 467c5dc2f2 remove contract code that dealt with removed ignoring of insufficient value withdraws 2018-02-09 09:44:55 +01:00
Maximilian Krüger f2e29764c2 make existing truffle tests run again after 112 2018-02-09 09:41:46 +01:00
Maximilian Krüger 80d67642ad add test "withdraw should fail if duplicate signature is provided" 2018-01-15 11:30:45 +01:00
Maximilian Krüger 6a052c12e3 add test "withdraw should fail if not enough signatures are provided" 2018-01-15 11:21:46 +01:00
Maximilian Krüger 3f1d4950bf test/home: fix test: should not allow withdraw with message.length != 84 2018-01-13 15:53:59 +01:00
Maximilian Krüger 06e363dfca bridge.sol: extract message related fns into `Message` library 2018-01-12 17:28:02 +01:00
Maximilian Krüger d96ebc026e truffle tests: move `createMessage` to helpers 2018-01-12 17:26:14 +01:00
Maximilian Krüger 56b5e6d22d test: isMessageValueSufficientToCoverRelay should work correctly 2018-01-09 14:35:31 +01:00
Maximilian Krüger 22e70cc079 test: remove unused var 2018-01-09 14:35:17 +01:00
Maximilian Krüger f7f78e7cfc improve test description 2018-01-09 12:52:49 +01:00
Maximilian Krüger 68d02ac5fd refactor test code a bit 2018-01-09 11:42:08 +01:00
Maximilian Krüger ba8aedecb1 add test for message part getters (getRecipientFromMessage) 2018-01-09 11:36:00 +01:00
Maximilian Krüger d66f51839c add test: should revert withdraw if value <= estimatedWeiCostOfWithdraw 2018-01-05 15:12:06 +01:00
Maximilian Krüger 3fccc2ad7f tests: add comment explaining gas price 2018-01-05 15:01:20 +01:00
Maximilian Krüger 5bfa568833 tests: remove console.log statements for debugging on travis 2018-01-05 15:00:59 +01:00
Maximilian Krüger 4ebe2a8e54 fix travis: remove assertion which fails during coverage testing
since coverage testing inserts instructions which increase the gas cost
2018-01-05 14:27:47 +01:00
Maximilian Krüger 49981435fb travis fix: fetch gas price dynamically 2018-01-05 13:51:25 +01:00
Maximilian Krüger a900fcffd4 fix travis: explicitely setting gas price to lower value 2018-01-05 13:19:49 +01:00
Maximilian Krüger 6a64f4c6dc trying more things to debug why tests only fail on travis 2018-01-05 13:11:50 +01:00
Maximilian Krüger 609c8065a4 debugging test which only fails on travis 2018-01-04 19:05:40 +01:00
Maximilian Krüger a28fa13f87 add test that recipient pays for relay 2018-01-04 18:49:54 +01:00
Maximilian Krüger 03aacc8f16 truffle tests: use camelcase consistently for variable names 2018-01-04 18:17:14 +01:00
Maximilian Krüger 66bc676891 make tests pass again after introducing `estimatedGasCostOfWithdraw` 2018-01-04 15:15:32 +01:00
snd 58a80b4ace fix for #61 and tests for withdraw (#66)
* readme: add section on running truffle tests

* extract `sign` from test/foreign into test/helpers and improve it

* add test helper signatureToVRS

* add test helper bigNumberToHexString

* add test helper bigNumberToPaddedBytes32

* add test "should allow correct withdraw" which fails and exposes #61

* resolve #61 and document it

* fix typo

* fix typo

* use num.toString(16) instead of bigNumberToHexString

https://github.com/paritytech/parity-bridge/pull/66#discussion_r156030874

* add comment

* use explicit transaction hash

* add test "withdraw without funds on HomeBridge should fail"

* add test "should not allow withdraw with message.length != 84"

* add test ""should allow second withdraw with different transactionHash but same recipient and value"

* add test "should not allow second withdraw with same transactionHash but different recipient and value"

* fix typo

* bridge.sol: add note that anyone can call HomeBridge.withdraw

* test that anyone can call withdraw provided they have the message and signatures

* test/home.js: improve wording of test
2017-12-14 17:54:49 +01:00
debris 59403966fc rename to home/foreign, closes #46 2017-10-10 11:02:58 +02:00