extracting method

This commit is contained in:
rusefi 2023-06-12 14:43:10 -04:00
parent 45ccd8e83e
commit 60018dd841
2 changed files with 9 additions and 9 deletions

View File

@ -71,6 +71,7 @@ private:
// Chip IO helpers // Chip IO helpers
uint16_t readDram(MC33816Mem addr); uint16_t readDram(MC33816Mem addr);
void writeDram(MC33816Mem addr, uint16_t data); void writeDram(MC33816Mem addr, uint16_t data);
uint16_t readStatus(int reg);
uint16_t readDriverStatus(); uint16_t readDriverStatus();
uint16_t readDriverStatus2(); uint16_t readDriverStatus2();
void clearDriverStatus(); void clearDriverStatus();

View File

@ -185,23 +185,21 @@ void Pt2001Base::clearDriverStatus(){
deselect(); deselect();
} }
uint16_t Pt2001Base::readDriverStatus() { uint16_t Pt2001Base::readStatus(int reg) {
setupSpi(); // ensure on common page? setupSpi(); // ensure on common page?
select(); select();
send((0x8000 | 0x1D2 << 5) + 1); send((0x8000 | reg << 5) + 1);
uint16_t driverStatus = recv(); uint16_t driverStatus = recv();
deselect(); deselect();
return driverStatus; return driverStatus;
} }
uint16_t Pt2001Base::readDriverStatus() {
return readStatus(0x1D2);
}
uint16_t Pt2001Base::readDriverStatus2() { uint16_t Pt2001Base::readDriverStatus2() {
// todo: shame on me extract method! return readStatus(0x1A5);
setupSpi(); // ensure on common page?
select();
send((0x8000 | 0x1A5 << 5) + 1);
uint16_t driverStatus = recv();
deselect();
return driverStatus;
} }
static bool checkUndervoltVccP(uint16_t driverStatus){ static bool checkUndervoltVccP(uint16_t driverStatus){
@ -490,6 +488,7 @@ bool Pt2001Base::restart() {
} }
status = readDriverStatus(); status = readDriverStatus();
status2 = readDriverStatus2();
if (checkUndervoltVccP(status)) { if (checkUndervoltVccP(status)) {
onError(McFault::UnderVoltage7); onError(McFault::UnderVoltage7);
shutdown(); shutdown();