From 05eed39ca7a5b2cf30be1f7349ed687c77213914 Mon Sep 17 00:00:00 2001 From: David Holdeman Date: Sat, 28 Jan 2023 16:00:21 -0600 Subject: [PATCH] [LTS] Fail firmware builds if . in branch name (#5010) * check for dot * put message * make error more visible --- .github/workflows/build-firmware.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/build-firmware.yaml b/.github/workflows/build-firmware.yaml index 68fbae8f82..06ea5040f0 100644 --- a/.github/workflows/build-firmware.yaml +++ b/.github/workflows/build-firmware.yaml @@ -286,6 +286,9 @@ jobs: skip-rate: 95 steps: + - name: Check branch name + if: ${{ contains(github.ref_name, '.') }} + run: echo '::error::Branch names must not contain ".", this breaks firmware autoupdates.' && exit 1 - name: Execution throttle early exit # Don't skip any jobs if this workflow was run manually. if: ${{ matrix.skip-rate && github.event_name != 'workflow_dispatch' }} @@ -444,6 +447,9 @@ jobs: build-primary-bundle: runs-on: ubuntu-latest steps: + - name: Check branch name + if: ${{ contains(github.ref_name, '.') }} + run: echo '::error::Branch names must not contain ".", this breaks firmware autoupdates.' && exit 1 - uses: actions/checkout@v3 with: submodules: recursive