usability issue: Boost blend logic does not happen while not controlling boost #5864

This commit is contained in:
rusefillc 2024-01-04 20:15:15 -05:00
parent fd6ef5f939
commit 1abd93fa21
3 changed files with 7 additions and 2 deletions

View File

@ -203,7 +203,9 @@ void BoostController::onFastCallback() {
tpsTooLow = Sensor::getOrZero(SensorType::Tps1) < engineConfiguration->boostControlMinTps;
mapTooLow = Sensor::getOrZero(SensorType::Map) < engineConfiguration->boostControlMinMap;
if (rpmTooLow || tpsTooLow || mapTooLow) {
isBoostControlled = !(rpmTooLow || tpsTooLow || mapTooLow);
if (!isBoostControlled) {
// Passing unexpected will use the safe duty cycle configured by the user
setOutput(unexpected);
} else {

View File

@ -10,6 +10,7 @@ bit rpmTooLow
bit tpsTooLow
bit mapTooLow
bit isPlantValid
bit isBoostControlled
int16_t autoscale luaTargetAdd;"Boost: Lua target add";"v", 0.5,0, -100,100, 1, @@GAUGE_CATEGORY_BOOST_CONTROL@@
int16_t autoscale boostOutput;@@GAUGE_NAME_BOOST_OUTPUT@@;"percent", 0.01,0, -100,100, 2, @@GAUGE_CATEGORY_BOOST_CONTROL@@
@ -21,4 +22,4 @@ float luaOpenLoopAdd;"Boost: Lua open loop add";"v", 1,0, -100,100, 1, @@GAUGE_C
int16_t autoscale boostControlTarget;@@GAUGE_NAME_BOOST_TARGET@@;"kPa",{1/@@PACK_MULT_PRESSURE@@},0, 0, 300, 1, @@GAUGE_CATEGORY_BOOST_CONTROL@@
end_struct
end_struct

View File

@ -2695,6 +2695,7 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_
field = "#in +5.0 added to the boost open loop %."
field = "#The X axis of the bias table is controlled by the selected blend"
field = "#parameter below."
indicator = {isBoostControlled}, "No Boost Control", "Boost Control Active"
field = "Blend parameter", boostOpenLoopBlends1_blendParameter
panel = boostOpenLoopBlend1Bias
@ -2705,6 +2706,7 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_
field = "#in +5.0 added to the boost open loop %."
field = "#The X axis of the bias table is controlled by the selected blend"
field = "#parameter below."
indicator = {isBoostControlled}, "No Boost Control", "Boost Control Active"
field = "Blend parameter", boostOpenLoopBlends2_blendParameter
panel = boostOpenLoopBlend2Bias