diff --git a/firmware/config/boards/f429-discovery/board_configuration.cpp b/firmware/config/boards/f429-discovery/board_configuration.cpp index fea5cd8bed..a553fd602a 100644 --- a/firmware/config/boards/f429-discovery/board_configuration.cpp +++ b/firmware/config/boards/f429-discovery/board_configuration.cpp @@ -1,8 +1,5 @@ #include "pch.h" -void setPinConfigurationOverrides() { -} - void setSerialConfigurationOverrides() { } @@ -26,4 +23,4 @@ void setBoardDefaultConfiguration() { engineConfiguration->communicationLedPin = GPIO_UNASSIGNED; engineConfiguration->runningLedPin = GPIOG_13; /* LD3 - green */ engineConfiguration->warningLedPin = GPIO_UNASSIGNED; -} \ No newline at end of file +} diff --git a/firmware/config/boards/hellen/hellen-nb1/board_configuration.cpp b/firmware/config/boards/hellen/hellen-nb1/board_configuration.cpp index ebc8ca60ea..6fa01cdc42 100644 --- a/firmware/config/boards/hellen/hellen-nb1/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen-nb1/board_configuration.cpp @@ -97,9 +97,6 @@ void setBoardConfigOverrides() { engineConfiguration->canRxPin = GPIOD_0; } -void setPinConfigurationOverrides() { -} - void setSerialConfigurationOverrides() { engineConfiguration->useSerialPort = false; engineConfiguration->binarySerialTxPin = GPIO_UNASSIGNED; diff --git a/firmware/config/boards/hellen/hellen121vag/board_configuration.cpp b/firmware/config/boards/hellen/hellen121vag/board_configuration.cpp index 092b491bc0..4cffc940db 100644 --- a/firmware/config/boards/hellen/hellen121vag/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen121vag/board_configuration.cpp @@ -109,9 +109,6 @@ void setBoardConfigOverrides() { engineConfiguration->canRxPin = GPIOD_0; } -void setPinConfigurationOverrides() { -} - void setSerialConfigurationOverrides() { engineConfiguration->useSerialPort = false; engineConfiguration->binarySerialTxPin = GPIO_UNASSIGNED; diff --git a/firmware/config/boards/hellen/hellen128/board_configuration.cpp b/firmware/config/boards/hellen/hellen128/board_configuration.cpp index 90c395c972..3b20ba32f8 100644 --- a/firmware/config/boards/hellen/hellen128/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen128/board_configuration.cpp @@ -104,9 +104,6 @@ void setBoardConfigOverrides() { engineConfiguration->canRxPin = H176_CAN_RX; } -void setPinConfigurationOverrides() { -} - void setSerialConfigurationOverrides() { engineConfiguration->useSerialPort = false; engineConfiguration->binarySerialTxPin = GPIO_UNASSIGNED; @@ -180,6 +177,7 @@ void setBoardDefaultConfiguration() { engineConfiguration->throttlePedalSecondaryWOTVoltage = 4.24; setHellenDefaultVrThresholds(); + engineConfiguration->vrThreshold[0].pin = GPIOD_14; hellenWbo(); } diff --git a/firmware/config/boards/hellen/hellen154hyundai/board_configuration.cpp b/firmware/config/boards/hellen/hellen154hyundai/board_configuration.cpp index a197890544..790ae255fc 100644 --- a/firmware/config/boards/hellen/hellen154hyundai/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen154hyundai/board_configuration.cpp @@ -105,9 +105,6 @@ void setBoardConfigOverrides() { engineConfiguration->iat.config.bias_resistor = 4700; } -void setPinConfigurationOverrides() { -} - void setSerialConfigurationOverrides() { engineConfiguration->useSerialPort = false; engineConfiguration->binarySerialTxPin = GPIO_UNASSIGNED; diff --git a/firmware/config/boards/hellen/hellen81/board_configuration.cpp b/firmware/config/boards/hellen/hellen81/board_configuration.cpp index d6cccb772b..978acfe589 100644 --- a/firmware/config/boards/hellen/hellen81/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen81/board_configuration.cpp @@ -111,9 +111,6 @@ void setBoardConfigOverrides() { engineConfiguration->canRxPin = GPIOD_0; } -void setPinConfigurationOverrides() { -} - void setSerialConfigurationOverrides() { engineConfiguration->useSerialPort = false; engineConfiguration->binarySerialTxPin = GPIO_UNASSIGNED; diff --git a/firmware/config/boards/hellen/hellen88bmw/board_configuration.cpp b/firmware/config/boards/hellen/hellen88bmw/board_configuration.cpp index 95c04bfd1c..7dab21d612 100644 --- a/firmware/config/boards/hellen/hellen88bmw/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen88bmw/board_configuration.cpp @@ -96,9 +96,6 @@ void setBoardConfigOverrides() { engineConfiguration->iat.config.bias_resistor = 4700; } -void setPinConfigurationOverrides() { -} - void setSerialConfigurationOverrides() { engineConfiguration->useSerialPort = false; engineConfiguration->binarySerialTxPin = GPIO_UNASSIGNED; diff --git a/firmware/config/boards/hellen/hellenNA8_96/board_configuration.cpp b/firmware/config/boards/hellen/hellenNA8_96/board_configuration.cpp index ebc8ca60ea..6fa01cdc42 100644 --- a/firmware/config/boards/hellen/hellenNA8_96/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellenNA8_96/board_configuration.cpp @@ -97,9 +97,6 @@ void setBoardConfigOverrides() { engineConfiguration->canRxPin = GPIOD_0; } -void setPinConfigurationOverrides() { -} - void setSerialConfigurationOverrides() { engineConfiguration->useSerialPort = false; engineConfiguration->binarySerialTxPin = GPIO_UNASSIGNED; diff --git a/firmware/config/boards/kinetis/board_configuration.cpp b/firmware/config/boards/kinetis/board_configuration.cpp index 7c915a00e1..03fbddd428 100644 --- a/firmware/config/boards/kinetis/board_configuration.cpp +++ b/firmware/config/boards/kinetis/board_configuration.cpp @@ -91,9 +91,6 @@ void setBoardOverrides() { setSerialConfigurationOverrides(); } -void setPinConfigurationOverrides() { -} - void setSerialConfigurationOverrides() { engineConfiguration->useSerialPort = true; engineConfiguration->binarySerialTxPin = GPIOC_7; diff --git a/firmware/config/boards/microrusefi/board_configuration.cpp b/firmware/config/boards/microrusefi/board_configuration.cpp index 55a99e31e8..0bfaaa3a40 100644 --- a/firmware/config/boards/microrusefi/board_configuration.cpp +++ b/firmware/config/boards/microrusefi/board_configuration.cpp @@ -177,9 +177,6 @@ void setBoardConfigOverrides() { engineConfiguration->spi3sckPin = GPIOC_10; } -void setPinConfigurationOverrides() { -} - void setSerialConfigurationOverrides() { // why would MRE disable serial by default? we definitely have pads exposed engineConfiguration->useSerialPort = false; diff --git a/firmware/config/boards/nucleo_h743/board_configuration.cpp b/firmware/config/boards/nucleo_h743/board_configuration.cpp index 2b4e96adf0..221716367d 100644 --- a/firmware/config/boards/nucleo_h743/board_configuration.cpp +++ b/firmware/config/boards/nucleo_h743/board_configuration.cpp @@ -1,12 +1,5 @@ #include "pch.h" -/** - * @brief Board-specific pin configuration code overrides. Needed by bootloader code. - * @todo Add your board-specific code, if any. - */ -void setPinConfigurationOverrides() { -} - /** * @brief Board-specific Serial configuration code overrides. Needed by bootloader code. * @todo Add your board-specific code, if any. diff --git a/firmware/config/boards/st_stm32f4/board_extra.c b/firmware/config/boards/st_stm32f4/board_extra.c index 684e64537c..d7bab4299a 100644 --- a/firmware/config/boards/st_stm32f4/board_extra.c +++ b/firmware/config/boards/st_stm32f4/board_extra.c @@ -4,12 +4,6 @@ #include "chconf_common.h" -/** - * @brief Board-specific pin configuration code overrides. Needed by bootloader code. - * @todo Add your board-specific code, if any. - */ -void setPinConfigurationOverrides() { -} /** * @brief Board-specific Serial configuration code overrides. Needed by bootloader code. diff --git a/firmware/config/engines/mercedes.cpp b/firmware/config/engines/mercedes.cpp index 74d4371ca7..d8414d633b 100644 --- a/firmware/config/engines/mercedes.cpp +++ b/firmware/config/engines/mercedes.cpp @@ -12,7 +12,7 @@ #endif // HW_HELLEN static void common() { - engineConfiguration->vrThreshold[0].pin = GPIOD_14; + } void setHellenMercedes128_4_cyl() {