From 5c46ad25a76687a116e83a4c2dd43bdf716fbf6f Mon Sep 17 00:00:00 2001 From: rusefi Date: Sun, 3 Nov 2019 10:36:35 -0500 Subject: [PATCH] review feedback --- firmware/config/boards/skeleton/efifeatures.h | 5 +---- firmware/config/stm32f4ems/efifeatures.h | 5 +---- firmware/config/stm32f7ems/efifeatures.h | 5 +---- .../trigger/decoders/trigger_bmw.h | 5 ++--- firmware/tunerstudio/rusefi.ini | 15 +++++++++------ firmware/tunerstudio/rusefi.input | 2 +- firmware/tunerstudio/rusefi_frankenso.ini | 15 +++++++++------ firmware/tunerstudio/rusefi_microrusefi.ini | 19 +++++++++++-------- firmware/tunerstudio/rusefi_prometheus.ini | 15 +++++++++------ 9 files changed, 44 insertions(+), 42 deletions(-) diff --git a/firmware/config/boards/skeleton/efifeatures.h b/firmware/config/boards/skeleton/efifeatures.h index 3db30001bf..a401d05fad 100644 --- a/firmware/config/boards/skeleton/efifeatures.h +++ b/firmware/config/boards/skeleton/efifeatures.h @@ -9,8 +9,7 @@ * */ -#ifndef EFIFEATURES_SKELRUSEFI_H_ -#define EFIFEATURES_SKELRUSEFI_H_ +#pragma once // General software features @@ -400,5 +399,3 @@ #if (TS_UART_DMA_MODE || TS_UART_MODE) #undef EFI_CONSOLE_SERIAL_DEVICE #endif - -#endif /* EFIFEATURES_MICRORUSEFI_H_ */ diff --git a/firmware/config/stm32f4ems/efifeatures.h b/firmware/config/stm32f4ems/efifeatures.h index ba09d96bec..4ee9074219 100644 --- a/firmware/config/stm32f4ems/efifeatures.h +++ b/firmware/config/stm32f4ems/efifeatures.h @@ -7,8 +7,7 @@ * @author Andrey Belomutskiy, (c) 2012-2019 */ -#ifndef EFIFEATURES_STM32F4_H_ -#define EFIFEATURES_STM32F4_H_ +#pragma once #define EFI_GPIO_HARDWARE TRUE @@ -404,5 +403,3 @@ #define INTERMEDIATE_LOGGING_BUFFER_SIZE 2000 #define EFI_JOYSTICK TRUE - -#endif /* EFIFEATURES_STM32F4_H_ */ diff --git a/firmware/config/stm32f7ems/efifeatures.h b/firmware/config/stm32f7ems/efifeatures.h index 66fbbb233e..b111b85f75 100644 --- a/firmware/config/stm32f7ems/efifeatures.h +++ b/firmware/config/stm32f7ems/efifeatures.h @@ -12,8 +12,7 @@ #include "../stm32f4ems/efifeatures.h" -#ifndef EFIFEATURES_STM32F7_H_ -#define EFIFEATURES_STM32F7_H_ +#pragma once // Warning! This is a test config! @@ -109,5 +108,3 @@ // todo: temporary ignore errors, this is a test config #define EFI_PRINT_ERRORS_AS_WARNINGS TRUE - -#endif /* EFIFEATURES_STM32F7_H_ */ diff --git a/firmware/controllers/trigger/decoders/trigger_bmw.h b/firmware/controllers/trigger/decoders/trigger_bmw.h index b826cda8d3..ae6ef6a3c1 100644 --- a/firmware/controllers/trigger/decoders/trigger_bmw.h +++ b/firmware/controllers/trigger/decoders/trigger_bmw.h @@ -4,11 +4,10 @@ * @date May 11, 2014 * @author Andrey Belomutskiy, (c) 2012-2017 */ -#ifndef TRIGGER_BMW_H_ -#define TRIGGER_BMW_H_ + +#pragma once #include "trigger_structure.h" void configureMiniCooperTriggerShape(TriggerShape *s); -#endif /* TRIGGER_BMW_H_ */ diff --git a/firmware/tunerstudio/rusefi.ini b/firmware/tunerstudio/rusefi.ini index 8cf3ad1f3b..88cb8f1c5a 100644 --- a/firmware/tunerstudio/rusefi.ini +++ b/firmware/tunerstudio/rusefi.ini @@ -1,11 +1,14 @@ -; this is TunerStudio project for www.rusefi.com DIY engine management system -; -; rusefi.ini is generated by invoking gen_config.bat (look inside for the exact command to run it outside of Windows) -; inputs are rusefi.input template and rusefi_config.txt file +; This is a TunerStudio project for the RusEFI.com engine management system ; +; This file has been generated by invoking gen_config.bat. +; The input files are +; rusefi.input the common template +; rusefi_config.txt the project specific file ; ; In TunerStudio some fields have little question mark on the left of the name for additional field tips. -; Those tips are defined in ../integraion/rusefi_config.txt file for example +; Those tips are defined in ../integration/rusefi_config.txt +; +; For example ; ; float bias_resistor;+Pull-up resistor value on your board;"Ohm" ; here 'bias_resistor' is internal field name and the text between semicolons is what produces the tooltip @@ -82,7 +85,7 @@ enable2ndByteCanID = false ; see PAGE_0_SIZE in C source code ; CONFIG_DEFINITION_START -; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Wed Oct 30 09:25:38 EDT 2019 +; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Sun Nov 03 10:36:02 EST 2019 pageSize = 20000 page = 1 diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index 95972980db..1a16ebcbc3 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -6,7 +6,7 @@ ; rusefi_config.txt the project specific file ; ; In TunerStudio some fields have little question mark on the left of the name for additional field tips. -; Those tips are defined in ../integraion/rusefi_config.txt +; Those tips are defined in ../integration/rusefi_config.txt ; ; For example ; diff --git a/firmware/tunerstudio/rusefi_frankenso.ini b/firmware/tunerstudio/rusefi_frankenso.ini index 2610cf9e8a..363c468fde 100644 --- a/firmware/tunerstudio/rusefi_frankenso.ini +++ b/firmware/tunerstudio/rusefi_frankenso.ini @@ -1,11 +1,14 @@ -; this is TunerStudio project for www.rusefi.com DIY engine management system -; -; rusefi.ini is generated by invoking gen_config.bat (look inside for the exact command to run it outside of Windows) -; inputs are rusefi.input template and rusefi_config.txt file +; This is a TunerStudio project for the RusEFI.com engine management system ; +; This file has been generated by invoking gen_config.bat. +; The input files are +; rusefi.input the common template +; rusefi_config.txt the project specific file ; ; In TunerStudio some fields have little question mark on the left of the name for additional field tips. -; Those tips are defined in ../integraion/rusefi_config.txt file for example +; Those tips are defined in ../integration/rusefi_config.txt +; +; For example ; ; float bias_resistor;+Pull-up resistor value on your board;"Ohm" ; here 'bias_resistor' is internal field name and the text between semicolons is what produces the tooltip @@ -82,7 +85,7 @@ enable2ndByteCanID = false ; see PAGE_0_SIZE in C source code ; CONFIG_DEFINITION_START -; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Wed Oct 30 09:25:44 EDT 2019 +; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Sun Nov 03 10:36:06 EST 2019 pageSize = 20000 page = 1 diff --git a/firmware/tunerstudio/rusefi_microrusefi.ini b/firmware/tunerstudio/rusefi_microrusefi.ini index e268fbedfe..0711c79804 100644 --- a/firmware/tunerstudio/rusefi_microrusefi.ini +++ b/firmware/tunerstudio/rusefi_microrusefi.ini @@ -1,11 +1,14 @@ -; this is TunerStudio project for www.rusefi.com DIY engine management system -; -; rusefi.ini is generated by invoking gen_config.bat (look inside for the exact command to run it outside of Windows) -; inputs are rusefi.input template and rusefi_config.txt file +; This is a TunerStudio project for the RusEFI.com engine management system ; +; This file has been generated by invoking gen_config.bat. +; The input files are +; rusefi.input the common template +; rusefi_config.txt the project specific file ; ; In TunerStudio some fields have little question mark on the left of the name for additional field tips. -; Those tips are defined in ../integraion/rusefi_config.txt file for example +; Those tips are defined in ../integration/rusefi_config.txt +; +; For example ; ; float bias_resistor;+Pull-up resistor value on your board;"Ohm" ; here 'bias_resistor' is internal field name and the text between semicolons is what produces the tooltip @@ -82,7 +85,7 @@ enable2ndByteCanID = false ; see PAGE_0_SIZE in C source code ; CONFIG_DEFINITION_START -; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Wed Oct 30 09:25:41 EDT 2019 +; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Sun Nov 03 10:36:04 EST 2019 pageSize = 20000 page = 1 @@ -996,8 +999,8 @@ page = 1 cylinderBore = "Cylinder diameter, in mm." sensorSnifferRpmThreshold = "Disable sensor sniffer above this rpm" fuelAlgorithm = "This setting controls which fuel quantity control algorithm is used.\nSee also useTPSAdvanceTable\nset algorithm X" - crankingInjectionMode = "This is the injection strategy during engine start. See Fuel/Injection settings for more detail. It is suggested to use "Simultaneous"." - injectionMode = "This is where the fuel injection type is defined: "Simultaneous" means all injectors will fire together at once. "Sequential" fires the injectors on a per cylinder basis, which requires individually wired injectors. "Batched" will fire the injectors in groups. If your injectors are individually wired you will also need to enable "Two wire batch emulation". \nset injection_mode X\nSee also twoWireBatchInjection" + crankingInjectionMode = "This is the type of injection strategy (See Fuel/Injection settings for more detail) it is suggested to use "Simultaneous" for easiest starting." + injectionMode = "This is where the fuel injection type is defined: "Simultaneous" means all injectors will fire together at once. "Sequential" fires the injectors on a per cylinder basis, only use this if you have individually wired injectors. "batched" will fire the injectors in groups, if your injectors are individually wired you will also need to enable "Two wire batch emulation". \nset injection_mode X\nSee also twoWireBatchInjection" extraInjectionOffset = "this is about deciding when the injector starts it's squirt\nSee also injectionPhase map\ntodo: do we need even need this since we have the map anyway?" crankingTimingAngle = "Ignition advance angle used during engine cranking, 5-10 degrees will work as a base setting for most engines.\nset cranking_timing_angle X" ignitionMode = ""One Coil" is for use on distributed ignition system. "Individual Coils" is to be used when you have one coil per cylinder (COP or similar). "Wasted" means one coil is driving two spark plugs in two cylinders, with one of the sparks not doing anything since it's happening on the exhaust cycle\nset ignition_mode X" diff --git a/firmware/tunerstudio/rusefi_prometheus.ini b/firmware/tunerstudio/rusefi_prometheus.ini index f10c2ab7c9..869d41f178 100644 --- a/firmware/tunerstudio/rusefi_prometheus.ini +++ b/firmware/tunerstudio/rusefi_prometheus.ini @@ -1,11 +1,14 @@ -; this is TunerStudio project for www.rusefi.com DIY engine management system -; -; rusefi.ini is generated by invoking gen_config.bat (look inside for the exact command to run it outside of Windows) -; inputs are rusefi.input template and rusefi_config.txt file +; This is a TunerStudio project for the RusEFI.com engine management system ; +; This file has been generated by invoking gen_config.bat. +; The input files are +; rusefi.input the common template +; rusefi_config.txt the project specific file ; ; In TunerStudio some fields have little question mark on the left of the name for additional field tips. -; Those tips are defined in ../integraion/rusefi_config.txt file for example +; Those tips are defined in ../integration/rusefi_config.txt +; +; For example ; ; float bias_resistor;+Pull-up resistor value on your board;"Ohm" ; here 'bias_resistor' is internal field name and the text between semicolons is what produces the tooltip @@ -82,7 +85,7 @@ enable2ndByteCanID = false ; see PAGE_0_SIZE in C source code ; CONFIG_DEFINITION_START -; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Wed Oct 30 09:25:47 EDT 2019 +; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Sun Nov 03 10:36:07 EST 2019 pageSize = 20000 page = 1