From 8ae9732748f8fab8c6a081e946bbcebdd1730c23 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Tue, 2 Jan 2024 11:51:05 -0500 Subject: [PATCH] Change name from "invert "input": true/false" to "trigger edge: rising/falling" #5847 --- firmware/integration/rusefi_config.txt | 6 +++--- firmware/tunerstudio/rusefi.input | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index bdd2600379..3ee5538a78 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -904,7 +904,7 @@ custom maf_sensor_type_e 1 bits, S08, @OFFSET@, [0:1], @@maf_sensor_type_e_enum@ bit vvtBooleanForVerySpecialCases bit enableSoftwareKnock bit verboseVVTDecoding;Verbose info in console below engineSnifferRpmThreshold\nenable vvt_details - bit invertCamVVTSignal;get invertCamVVTSignal + bit invertCamVVTSignal,"Falling","Rising";get invertCamVVTSignal bit alphaNUseIat;In Alpha-N mode, compensate for air temperature. bit knockBankCyl1,"Channel 2","Channel 1" bit knockBankCyl2,"Channel 2","Channel 1" @@ -1009,8 +1009,8 @@ end_struct bit boardUse2stepPullDown,"With Pull Down","With Pull Up" bit tachPulseDurationAsDutyCycle,"Duty cycle","Constant time";Treat milliseconds value as duty cycle value, i.e. 0.5ms would become 50% bit isAlternatorControlEnabled;This enables smart alternator control and activates the extra alternator settings. - bit invertPrimaryTriggerSignal;https://wiki.rusefi.com/Trigger-Configuration-Guide\nThis setting flips the signal from the primary engine speed sensor. - bit invertSecondaryTriggerSignal;https://wiki.rusefi.com/Trigger-Configuration-Guide\nThis setting flips the signal from the secondary engine speed sensor. + bit invertPrimaryTriggerSignal,"Falling","Rising";https://wiki.rusefi.com/Trigger-Configuration-Guide\nThis setting flips the signal from the primary engine speed sensor. + bit invertSecondaryTriggerSignal,"Falling","Rising";https://wiki.rusefi.com/Trigger-Configuration-Guide\nThis setting flips the signal from the secondary engine speed sensor. bit cutFuelOnHardLimit,"yes","no" bit cutSparkOnHardLimit,"yes","no";Be careful enabling this: some engines are known to self-disassemble their valvetrain with a spark cut. Fuel cut is much safer. diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index cecd18bbb7..9a35a82056 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -2377,9 +2377,9 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_ ; not crank trigger and ((vague trigger and cam choice) or not vague trigger) field = "Cam Sensor (Primary channel)", triggerInputPins1, 1, {twoStroke == 1 || ( !(@@TRIGGER_CRANK_BASED@@) && ( ( (@@TRIGGER_TYPE_WITHOUT_KNOWN_LOCATION@@) && skippedWheelOnCam) || !(@@TRIGGER_TYPE_WITHOUT_KNOWN_LOCATION@@) ) ) } field = "Crank Sensor (Primary channel)", triggerInputPins1, 1, { !(twoStroke == 1 || ( !(@@TRIGGER_CRANK_BASED@@) && ( ( (@@TRIGGER_TYPE_WITHOUT_KNOWN_LOCATION@@) && skippedWheelOnCam) || !(@@TRIGGER_TYPE_WITHOUT_KNOWN_LOCATION@@) ) )) } - field = "Invert Primary", invertPrimaryTriggerSignal + field = "Primary Edge", invertPrimaryTriggerSignal field = "Secondary channel", triggerInputPins2, { triggerInputPins2 != 0 || (triggerInputPins1 != 0 && (@@TRIGGER_TYPE_WITH_SECOND_WHEEL@@) ) } - field = "Invert Secondary", invertSecondaryTriggerSignal, {triggerInputPins2 != 0 && (@@TRIGGER_TYPE_WITH_SECOND_WHEEL@@) } + field = "Secondary Edge", invertSecondaryTriggerSignal, {triggerInputPins2 != 0 && (@@TRIGGER_TYPE_WITH_SECOND_WHEEL@@) } dialog = trigger_cams, "Cam Inputs" field = "!https://rusefi.com/s/vvt" @@ -2395,7 +2395,7 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_ field = "Cam sensor bank 1 exhaust", camInputs2, { camInputs2 != 0 || (vvtMode2 != @@vvt_mode_e_VVT_INACTIVE@@ && camInputs1 != 0 ) } field = "Cam sensor bank 2 intake", camInputs3, { camInputs3 != 0 || (vvtMode1 != @@vvt_mode_e_VVT_INACTIVE@@ && camInputs1 != 0 ) } field = "Cam sensor bank 2 exhaust", camInputs4, { camInputs4 != 0 || (vvtMode2 != @@vvt_mode_e_VVT_INACTIVE@@ && camInputs2 != 0 ) } - field = "Invert cam inputs", invertCamVVTSignal, { camInputs1 != 0 } + field = "Cam Edge Select", invertCamVVTSignal, { camInputs1 != 0 } field = "" field = "#Set offset so VVT indicates 0 degrees in default position" field = "VVT offset bank 1 intake", vvtOffsets1, { camInputs1 != 0 }