rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

in GDI mode we should require "Require cam/VVT sync for ignition" fix #5580 

only:alphax-4chan_f7
This commit is contained in:
rusefillc 2023-09-25 12:13:46 -04:00
parent d7329a916b
commit 9359d80474
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/controllers/algo/defaults/default_base_engine.cpp
View File

@ -39,7 +39,11 @@ void setLeftRightBanksNeedBetterName() {
}
static void setDefaultHPFP() {
#if ! EFI_UNIT_TEST
// unit tests rely on 'hpfpCamLobes' for isGdiEngine() and we need not-GDI by default for unit tests
engineConfiguration->hpfpCamLobes = 3;
#endif
// todo: would be nice for unit tests to be happy about these defaults
#if EFI_PROD_CODE
engineConfiguration->hpfpPumpVolume = 0.290;

6
firmware/controllers/limp_manager.cpp
View File

@ -18,6 +18,12 @@ static bool noFiringUntilVvtSync(vvt_mode_e vvtMode) {
// in rare cases engines do not like random sequential mode
return true;
}
if (isGdiEngine()) {
engineConfiguration->isPhaseSyncRequiredForIgnition = true;
#if EFI_PROD_CODE
criticalError("For GDI please configure CAM and require sync for ignition");
#endif
}
// Odd cylinder count engines don't work properly with wasted spark, so wait for full sync (so that sequential works)
// See https://github.com/rusefi/rusefi/issues/4195 for the issue to properly support this case