rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

firmwareError: set hasFirmwareErrorFlag as soon as possible 

To avoid reentrance and infinity error loop
This commit is contained in:
Andrey Gusakov 2024-03-12 01:13:06 +03:00 committed by rusefillc
parent 92106db480
commit 93e4f06019
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/controllers/core/error_handling.cpp
View File

@ -266,6 +266,7 @@ void firmwareError(ObdCode code, const char *fmt, ...) {
#if EFI_PROD_CODE
if (hasFirmwareErrorFlag)
return;
hasFirmwareErrorFlag = true;
#if EFI_ENGINE_CONTROL
getLimpManager()->fatalError();
#endif // EFI_ENGINE_CONTROL
@ -281,7 +282,6 @@ void firmwareError(ObdCode code, const char *fmt, ...) {
criticalShutdown();
enginePins.communicationLedPin.setValue(1, /*force*/true);
hasFirmwareErrorFlag = true;
if (indexOf(fmt, '%') == -1) {
/**
* in case of simple error message let's reduce stack usage