rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CAN: That's an abnormal situation, and we probably should react? waitingForNumBytes=37 waitingForFrameIndex=4 frameIdx=3 #3682

This commit is contained in:
rusefillc 2021-12-08 22:52:34 -05:00
parent e6e259c7d9
commit a509d6a2c3
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
java_console/io/src/main/java/com/rusefi/io/can/IsoTpCanDecoder.java
View File

@ -51,6 +51,11 @@ public class IsoTpCanDecoder {
break;
case ISO_TP_FRAME_CONSECUTIVE:
frameIdx = data[0] & 0xf;
if (frameIdx < waitingForFrameIndex) {
// todo: open question why we see message duplicates but we see those
// is that rusEFI firmware bug or is that an OK thingy for CAN physical level?
return new byte[0];
}
if (this.waitingForNumBytes < 0 || this.waitingForFrameIndex != frameIdx) {
throw new IllegalStateException("ISO_TP_FRAME_CONSECUTIVE: That's an abnormal situation, and we probably should react? waitingForNumBytes=" + waitingForNumBytes + " waitingForFrameIndex=" + waitingForFrameIndex + " frameIdx=" + frameIdx);
}