From b5049c8284c5ab871182f94116c20682f7051c86 Mon Sep 17 00:00:00 2001 From: rusefi Date: Tue, 29 Nov 2022 22:13:59 -0500 Subject: [PATCH] ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 --- firmware/controllers/actuators/electronic_throttle.txt | 2 ++ firmware/controllers/limp_manager.h | 1 + firmware/tunerstudio/rusefi.input | 4 ++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/firmware/controllers/actuators/electronic_throttle.txt b/firmware/controllers/actuators/electronic_throttle.txt index 2f49356c86..46d175dab6 100644 --- a/firmware/controllers/actuators/electronic_throttle.txt +++ b/firmware/controllers/actuators/electronic_throttle.txt @@ -16,4 +16,6 @@ float luaAdjustment;"ETB: luaAdjustment" float etbDutyAverage uint16_t etbInputErrorCounter;"ETB inputs error counter" + int8_t etbErrorCode + end_struct \ No newline at end of file diff --git a/firmware/controllers/limp_manager.h b/firmware/controllers/limp_manager.h index c1398c5a53..7f5105385e 100644 --- a/firmware/controllers/limp_manager.h +++ b/firmware/controllers/limp_manager.h @@ -33,6 +33,7 @@ enum class TpsState : uint8_t { PpsError, // 3 InputJitter, PidJitter, + Lua // keep this list in sync with etbCutCodeList in rusefi.input! }; diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index 3c25d4b188..fc76e3de27 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -239,7 +239,7 @@ enable2ndByteCanID = false fuelIgnCutCodeList = bits, U08, [0:7], "None", "fatal error", "setting disabled", "RPM limit", "fault RPM limit", "boost cut", "oil pressure", "stop requested", "ETB problem", "launch control", "max injector duty", "flood clear", "engine sync", "kickstart", "ign off" ; TpsState - etbCutCodeList = bits, U08, [0:7], "None", "engine off setting", "TPS error", "PPS error", "Input noise", "PID noise" + etbCutCodeList = bits, U08, [0:7], "None", "engine off setting", "TPS error", "PPS error", "Input noise", "PID noise", "Lua" [ConstantsExtensions] ; defaultValue is used to provide TunerStudio with a value to use in the case of @@ -1468,7 +1468,7 @@ gaugeCategory = GPPWM Outputs indicator = { isTriggerError}, "Trigger OK", "Trigger ERR", white, black, red, black indicator = { fuelCutReason != 0 }, "Injection OK", { Fuel cut: bitStringValue(fuelIgnCutCodeList, fuelCutReason)}, white, black, yellow, black indicator = { sparkCutReason != 0 }, "Ignition OK", { Ign cut: bitStringValue(fuelIgnCutCodeList, sparkCutReason)}, white, black, yellow, black - indicator = { tpsErrorCode != 0 }, "ETB OK", { ETB: bitStringValue(etbCutCodeList, tpsErrorCode)}, white, black, yellow, black + indicator = { etbErrorCode != 0 }, "ETB OK", { ETB: bitStringValue(etbCutCodeList, etbErrorCode)}, white, black, yellow, black ; this is required so that the "config error" feature works in TS ; DO NOT CHANGE THIS LINE - TS is looking for an indicator with particular text/styling