From c0a576f8a32c40a8694e4a3f667834a8cfee933c Mon Sep 17 00:00:00 2001 From: Andrey Date: Wed, 14 Feb 2024 16:15:07 -0500 Subject: [PATCH] a few drop downs have "3" option which only confuses users #5942 preparation --- .../src/main/java/com/rusefi/pinout/PinoutLogic.java | 4 +--- .../src/main/java/com/rusefi/InvalidConstant.java | 8 ++++++++ 2 files changed, 9 insertions(+), 3 deletions(-) create mode 100644 java_tools/configuration_definition_base/src/main/java/com/rusefi/InvalidConstant.java diff --git a/java_tools/configuration_definition/src/main/java/com/rusefi/pinout/PinoutLogic.java b/java_tools/configuration_definition/src/main/java/com/rusefi/pinout/PinoutLogic.java index 6f054054a7..ab0217d13d 100644 --- a/java_tools/configuration_definition/src/main/java/com/rusefi/pinout/PinoutLogic.java +++ b/java_tools/configuration_definition/src/main/java/com/rusefi/pinout/PinoutLogic.java @@ -22,8 +22,6 @@ public class PinoutLogic { private static final String NONE = "NONE"; private static final String QUOTED_NONE = quote(NONE); - private static final String INVALID = "INVALID"; - public static final String QUOTED_INVALID = quote(INVALID); private final ArrayList globalList = new ArrayList<>(); private final Map tsNameById = new TreeMap<>(); @@ -114,7 +112,7 @@ public class PinoutLogic { if (key.equals(nothingName)) { arrayFormat.append(QUOTED_NONE); } else if (value == null) { - arrayFormat.append(QUOTED_INVALID); + arrayFormat.append(InvalidConstant.QUOTED_INVALID); } else { String quotedValue = quote(value); arrayFormat.append(quotedValue); diff --git a/java_tools/configuration_definition_base/src/main/java/com/rusefi/InvalidConstant.java b/java_tools/configuration_definition_base/src/main/java/com/rusefi/InvalidConstant.java new file mode 100644 index 0000000000..d6605bc021 --- /dev/null +++ b/java_tools/configuration_definition_base/src/main/java/com/rusefi/InvalidConstant.java @@ -0,0 +1,8 @@ +package com.rusefi; + +import static com.rusefi.output.JavaSensorsConsumer.quote; + +public class InvalidConstant { + private static final String INVALID = "INVALID"; + public static final String QUOTED_INVALID = quote(INVALID); +}