behave yourselves with null previousConfig

This commit is contained in:
Matthew Kennedy 2024-05-04 01:10:42 -04:00 committed by rusefillc
parent 8cb03dc264
commit c39e9146fb
4 changed files with 5 additions and 5 deletions

View File

@ -117,12 +117,12 @@ void setAltPFactor(float p) {
}
void AlternatorController::onConfigurationChange(engine_configuration_s const * previousConfiguration) {
shouldResetPid = !alternatorPid.isSame(&previousConfiguration->alternatorControl);
shouldResetPid = !previousConfiguration || !alternatorPid.isSame(&previousConfiguration->alternatorControl);
}
void initAlternatorCtrl() {
addConsoleAction("altinfo", showAltInfo);
engine->module<AlternatorController>()->init();
if (!isBrainPinValid(engineConfiguration->alternatorControlPin))

View File

@ -39,7 +39,7 @@ void BoostController::resetLua() {
}
void BoostController::onConfigurationChange(engine_configuration_s const * previousConfig) {
if (!m_pid.isSame(&previousConfig->boostPid)) {
if (!previousConfig || !m_pid.isSame(&previousConfig->boostPid)) {
m_shouldResetPid = true;
}
}

View File

@ -399,7 +399,7 @@ void IdleController::onSlowCallback() {
void IdleController::onConfigurationChange(engine_configuration_s const * previousConfiguration) {
#if ! EFI_UNIT_TEST
shouldResetPid = !getIdlePid()->isSame(&previousConfiguration->idleRpmPid);
shouldResetPid = !previousConfig || !getIdlePid()->isSame(&previousConfiguration->idleRpmPid);
mustResetPid = shouldResetPid;
#endif
}

View File

@ -43,7 +43,7 @@ void VvtController::onFastCallback() {
}
void VvtController::onConfigurationChange(engine_configuration_s const * previousConfig) {
if (!m_pid.isSame(&previousConfig->auxPid[m_cam])) {
if (!previousConfig || !m_pid.isSame(&previousConfig->auxPid[m_cam])) {
m_pid.reset();
}
}