rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

get rid of unused outOfOrder field #6374

This commit is contained in:
kifir 2024-04-22 00:38:58 +03:00 committed by rusefillc
parent ab9debf414
commit c6d40acdf9
3 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
firmware/controllers/engine_cycle/spark_logic.cpp
View File

@ -28,8 +28,8 @@ static const char *prevSparkName = nullptr;
static void fireSparkBySettingPinLow(IgnitionEvent *event, IgnitionOutputPin *output) {
#if SPARK_EXTREME_LOGGING
efiPrintf("spark goes low revolution=%d [%s] %d current=%d cnt=%d id=%d", getRevolutionCounter(), output->getName(), (int)getTimeNowUs(),
output->currentLogicValue, output->outOfOrder, event->sparkCounter);
efiPrintf("spark goes low revolution=%d [%s] %d current=%d id=%d", getRevolutionCounter(), output->getName(), (int)getTimeNowUs(),
output->currentLogicValue, event->sparkCounter);
#endif /* SPARK_EXTREME_LOGGING */
/**
@ -46,8 +46,6 @@ static void fireSparkBySettingPinLow(IgnitionEvent *event, IgnitionOutputPin *ou
printf("out-of-order coil off %s", output->getName());
#endif /* SPARK_EXTREME_LOGGING */
warning(ObdCode::CUSTOM_OUT_OF_ORDER_COIL, "out-of-order coil off %s", output->getName());
// todo: drop this year 2016 outOfOrder in favor of 2024 [tag] #6349 handling?
output->outOfOrder = true;
}
output->setLow();
}
@ -290,8 +288,8 @@ static bool startDwellByTurningSparkPinHigh(IgnitionEvent *event, IgnitionOutput
#if SPARK_EXTREME_LOGGING
efiPrintf("spark goes high revolution=%d [%s] %d current=%d cnt=%d id=%d", getRevolutionCounter(), output->getName(), (int)getTimeNowUs(),
output->currentLogicValue, output->outOfOrder, event->sparkCounter);
efiPrintf("spark goes high revolution=%d [%s] %d current=%d id=%d", getRevolutionCounter(), output->getName(), (int)getTimeNowUs(),
output->currentLogicValue, event->sparkCounter);
#endif /* SPARK_EXTREME_LOGGING */
if (output->signalFallSparkId >= event->sparkCounter) {
@ -312,10 +310,6 @@ static bool startDwellByTurningSparkPinHigh(IgnitionEvent *event, IgnitionOutput
return true;
}
if (output->outOfOrder) {
output->outOfOrder = false;
}
output->setHigh();
return false;
}

1
firmware/controllers/system/efi_gpio.cpp
View File

@ -530,7 +530,6 @@ void IgnitionOutputPin::setLow() {
}
void IgnitionOutputPin::reset() {
outOfOrder = false;
signalFallSparkId = 0;
}

1
firmware/controllers/system/efi_gpio.h
View File

@ -30,7 +30,6 @@ public:
void setLow() override;
void reset();
int signalFallSparkId;
bool outOfOrder; // https://sourceforge.net/p/rusefi/tickets/319/
int8_t coilIndex;
};