From cad5e5c84ab7fbdcc31ce976e10eae06c218b225 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Thu, 18 Apr 2024 10:30:57 -0400 Subject: [PATCH] Knock retard does not pull timing unless bottom row of "Max Knock Retard" is populated fix #6370 --- firmware/CHANGELOG.md | 1 + firmware/controllers/engine_cycle/knock_controller.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/firmware/CHANGELOG.md b/firmware/CHANGELOG.md index e6753201ce..babe10e11d 100644 --- a/firmware/CHANGELOG.md +++ b/firmware/CHANGELOG.md @@ -50,6 +50,7 @@ Release template (copy/paste this for new release): - update-ts-cacerts work-around is no longer needed #6327 - uaEFI board knock configuration #6338 - Fix a scenario where noisy trigger can cause overdwell #6349 + - knock retard calibration lookup #6370 ### Breaking Changes - wrong trigger naming for missing teeth #6258 diff --git a/firmware/controllers/engine_cycle/knock_controller.cpp b/firmware/controllers/engine_cycle/knock_controller.cpp index adf902aa76..abe2348e45 100644 --- a/firmware/controllers/engine_cycle/knock_controller.cpp +++ b/firmware/controllers/engine_cycle/knock_controller.cpp @@ -14,7 +14,7 @@ void KnockController::onConfigurationChange(engine_configuration_s const * previousConfig) { KnockControllerBase::onConfigurationChange(previousConfig); - m_maxRetardTable.initTable(config->maxKnockRetardTable, config->maxKnockRetardLoadBins, config->maxKnockRetardRpmBins); + m_maxRetardTable.initTable(config->maxKnockRetardTable, config->maxKnockRetardRpmBins, config->maxKnockRetardLoadBins); } int getCylinderKnockBank(uint8_t cylinderNumber) {