rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

trigger error message makes trigger very unhappy #888 

quick dirty temporary solution
This commit is contained in:
rusefi 2019-07-22 17:38:52 -04:00
parent e0c1b0ae67
commit d01485d484
8 changed files with 25 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
firmware/controllers/generated/engine_configuration_generated_structures.h
View File

@ -1,4 +1,4 @@
// this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Sun Jul 21 16:54:25 EDT 2019
// this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Mon Jul 22 17:38:10 EDT 2019
// by class com.rusefi.output.CHeaderConsumer
// begin
#ifndef CONTROLLERS_GENERATED_ENGINE_CONFIGURATION_GENERATED_STRUCTURES_H
@ -1491,6 +1491,7 @@ struct engine_configuration_s {
offset 1464 bit 5 */
bool isEngineChartEnabled : 1;
/**
* Sometimes we have a performance issue while printing error
offset 1464 bit 6 */
bool silentTriggerError : 1;
/**
@ -2813,4 +2814,4 @@ typedef struct persistent_config_s persistent_config_s;
#endif
// end
// this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Sun Jul 21 16:54:25 EDT 2019
// this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Mon Jul 22 17:38:10 EDT 2019

9
firmware/controllers/trigger/trigger_decoder.cpp
View File

@ -509,8 +509,15 @@ void TriggerState::decodeTriggerEvent(trigger_event_e const signal, efitime_t no
isSynchronizationPoint = isSync;
/**
* todo: technically we can afford detailed logging even with 60/2 as long as low RPM
* todo: figure out exact threshold as a function of RPM and tooth count?
* Open question what is 'triggerShape->getSize()' for 60/2 is it 58 or 58*2 or 58*4?
*/
bool silentTriggerError = triggerShape->getSize() > 40 && CONFIG(silentTriggerError);
#if EFI_PROD_CODE
if (CONFIG(verboseTriggerSynchDetails) || (someSortOfTriggerError && !CONFIG(silentTriggerError))) {
if (CONFIG(verboseTriggerSynchDetails) || (someSortOfTriggerError && !silentTriggerError)) {
#else
if (printTriggerDebug) {
#endif /* EFI_PROD_CODE */

2
firmware/integration/rusefi_config.txt
View File

@ -713,7 +713,7 @@ bit vvtDisplayInverted
bit isVerboseETB;+Prints ETB details to rusEFI console
bit useConstantDwellDuringCranking;+If set to true, will use the specified duration for cranking dwell. If set to false, will use the specified dwell angle. Unless you have a really good reason to, leave this set to true to use duration mode.
bit isEngineChartEnabled;+This options enables data for 'engine sniffer' tab in console, which comes at some CPU price
bit silentTriggerError
bit silentTriggerError;+Sometimes we have a performance issue while printing error
bit useLinearCltSensor
bit canReadEnabled
bit canWriteEnabled

4
firmware/tunerstudio/rusefi.ini
View File

@ -82,7 +82,7 @@ enable2ndByteCanID = false
; see PAGE_0_SIZE in C source code
; CONFIG_DEFINITION_START
; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Sun Jul 21 16:54:25 EDT 2019
; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Mon Jul 22 17:38:10 EDT 2019
pageSize = 20000
page = 1
@ -1009,6 +1009,7 @@ page = 1
isVerboseETB = "Prints ETB details to rusEFI console"
useConstantDwellDuringCranking = "If set to true, will use the specified duration for cranking dwell. If set to false, will use the specified dwell angle. Unless you have a really good reason to, leave this set to true to use duration mode."
isEngineChartEnabled = "This options enables data for 'engine sniffer' tab in console, which comes at some CPU price"
silentTriggerError = "Sometimes we have a performance issue while printing error"
useFSIO16ForTimingAdjustment = "See fsioTimingAdjustment"
isAlternatorControlEnabled = "This enables smart alternator control and activates the extra alternator settings."
invertPrimaryTriggerSignal = "This setting flips the signal from the primary engine speed sensor."
@ -2423,6 +2424,7 @@ cmd_set_engine_type_default = "w\x00\x31\x00\x00"
field = "Miata NB2 to (temporary)", miataNb2VVTRatioTo
field = "nbVvtIndex", nbVvtIndex
field = "print verbose sync details to console",verboseTriggerSynchDetails
field = "Do not print messages in case of sync error", silentTriggerError
field = "Enable noise filtering", useNoiselessTriggerDecoder, {trigger_type == 8}
dialog = triggerConfiguration
panel = triggerConfiguration_settings, North

1
firmware/tunerstudio/rusefi.input
View File

@ -1446,6 +1446,7 @@ cmd_set_engine_type_default = "w\x00\x31\x00\x00"
field = "Miata NB2 to (temporary)", miataNb2VVTRatioTo
field = "nbVvtIndex", nbVvtIndex
field = "print verbose sync details to console",verboseTriggerSynchDetails
field = "Do not print messages in case of sync error", silentTriggerError
field = "Enable noise filtering", useNoiselessTriggerDecoder, {trigger_type == 8}
dialog = triggerConfiguration
panel = triggerConfiguration_settings, North

4
firmware/tunerstudio/rusefi_frankenso.ini
View File

@ -82,7 +82,7 @@ enable2ndByteCanID = false
; see PAGE_0_SIZE in C source code
; CONFIG_DEFINITION_START
; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Sun Jul 21 16:54:30 EDT 2019
; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Mon Jul 22 17:38:15 EDT 2019
pageSize = 20000
page = 1
@ -1009,6 +1009,7 @@ page = 1
isVerboseETB = "Prints ETB details to rusEFI console"
useConstantDwellDuringCranking = "If set to true, will use the specified duration for cranking dwell. If set to false, will use the specified dwell angle. Unless you have a really good reason to, leave this set to true to use duration mode."
isEngineChartEnabled = "This options enables data for 'engine sniffer' tab in console, which comes at some CPU price"
silentTriggerError = "Sometimes we have a performance issue while printing error"
useFSIO16ForTimingAdjustment = "See fsioTimingAdjustment"
isAlternatorControlEnabled = "This enables smart alternator control and activates the extra alternator settings."
invertPrimaryTriggerSignal = "This setting flips the signal from the primary engine speed sensor."
@ -2423,6 +2424,7 @@ cmd_set_engine_type_default = "w\x00\x31\x00\x00"
field = "Miata NB2 to (temporary)", miataNb2VVTRatioTo
field = "nbVvtIndex", nbVvtIndex
field = "print verbose sync details to console",verboseTriggerSynchDetails
field = "Do not print messages in case of sync error", silentTriggerError
field = "Enable noise filtering", useNoiselessTriggerDecoder, {trigger_type == 8}
dialog = triggerConfiguration
panel = triggerConfiguration_settings, North

4
firmware/tunerstudio/rusefi_microrusefi.ini
View File

@ -82,7 +82,7 @@ enable2ndByteCanID = false
; see PAGE_0_SIZE in C source code
; CONFIG_DEFINITION_START
; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Sun Jul 21 16:54:28 EDT 2019
; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Mon Jul 22 17:38:13 EDT 2019
pageSize = 20000
page = 1
@ -1009,6 +1009,7 @@ page = 1
isVerboseETB = "Prints ETB details to rusEFI console"
useConstantDwellDuringCranking = "If set to true, will use the specified duration for cranking dwell. If set to false, will use the specified dwell angle. Unless you have a really good reason to, leave this set to true to use duration mode."
isEngineChartEnabled = "This options enables data for 'engine sniffer' tab in console, which comes at some CPU price"
silentTriggerError = "Sometimes we have a performance issue while printing error"
useFSIO16ForTimingAdjustment = "See fsioTimingAdjustment"
isAlternatorControlEnabled = "This enables smart alternator control and activates the extra alternator settings."
invertPrimaryTriggerSignal = "This setting flips the signal from the primary engine speed sensor."
@ -2416,6 +2417,7 @@ cmd_set_engine_type_default = "w\x00\x31\x00\x00"
field = "Miata NB2 to (temporary)", miataNb2VVTRatioTo
field = "nbVvtIndex", nbVvtIndex
field = "print verbose sync details to console",verboseTriggerSynchDetails
field = "Do not print messages in case of sync error", silentTriggerError
field = "Enable noise filtering", useNoiselessTriggerDecoder, {trigger_type == 8}
dialog = triggerConfiguration
panel = triggerConfiguration_settings, North

4
firmware/tunerstudio/rusefi_prometheus.ini
View File

@ -82,7 +82,7 @@ enable2ndByteCanID = false
; see PAGE_0_SIZE in C source code
; CONFIG_DEFINITION_START
; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Sun Jul 21 16:54:32 EDT 2019
; this section was generated automatically by rusEfi tool ConfigDefinition.jar based on integration\rusefi_config.txt Mon Jul 22 17:38:18 EDT 2019
pageSize = 20000
page = 1
@ -1009,6 +1009,7 @@ page = 1
isVerboseETB = "Prints ETB details to rusEFI console"
useConstantDwellDuringCranking = "If set to true, will use the specified duration for cranking dwell. If set to false, will use the specified dwell angle. Unless you have a really good reason to, leave this set to true to use duration mode."
isEngineChartEnabled = "This options enables data for 'engine sniffer' tab in console, which comes at some CPU price"
silentTriggerError = "Sometimes we have a performance issue while printing error"
useFSIO16ForTimingAdjustment = "See fsioTimingAdjustment"
isAlternatorControlEnabled = "This enables smart alternator control and activates the extra alternator settings."
invertPrimaryTriggerSignal = "This setting flips the signal from the primary engine speed sensor."
@ -2419,6 +2420,7 @@ cmd_set_engine_type_default = "w\x00\x31\x00\x00"
field = "Miata NB2 to (temporary)", miataNb2VVTRatioTo
field = "nbVvtIndex", nbVvtIndex
field = "print verbose sync details to console",verboseTriggerSynchDetails
field = "Do not print messages in case of sync error", silentTriggerError
field = "Enable noise filtering", useNoiselessTriggerDecoder, {trigger_type == 8}
dialog = triggerConfiguration
panel = triggerConfiguration_settings, North