rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add tests for targetSkipRatio calculation #6528

This commit is contained in:
kifir 2024-05-17 19:30:22 +03:00 committed by rusefillc
parent 110218c78a
commit fee1602fd9
3 changed files with 43 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
firmware/controllers/algo/launch_control.h
View File

@ -49,6 +49,7 @@ public:
* targetSkipRatio of '0' means 'do not skip', would always return false
*/
void setTargetSkipRatio(float targetSkipRatio);
[[nodiscard]] float getTargetSkipRatio() const { return targetSkipRatio; }
bool shouldSkip();
private:

41
unit_tests/tests/launch/test_target_skip_ratio.cpp Normal file
View File

@ -0,0 +1,41 @@
//
// Created by kifir on 5/17/24.
//
#include "pch.h"
constexpr float TEST_TRACTION_CONTROL_IGNITION_SKIP = 17.0f;
constexpr float TEST_LUA_SOFT_SPARK_SKIP = 239.0f;
constexpr float TEST_LUA_HARD_SPARK_SKIP = 174.0f;
static void setUpTestParameters() {
std::fill_n(
&engineConfiguration->tractionControlIgnitionSkip[0][0],
TRACTION_CONTROL_ETB_DROP_SIZE * TRACTION_CONTROL_ETB_DROP_SIZE,
static_cast<int8_t>(TEST_TRACTION_CONTROL_IGNITION_SKIP)
);
engine->engineState.luaSoftSparkSkip = TEST_LUA_SOFT_SPARK_SKIP;
engine->engineState.luaHardSparkSkip = TEST_LUA_HARD_SPARK_SKIP;
}
TEST(targetSkipRatio, doNotUseSkipInTraction) {
EngineTestHelper eth(engine_type_e::TEST_ENGINE);
setUpTestParameters();
EXPECT_FALSE(engineConfiguration->useHardSkipInTraction);
eth.engine.periodicFastCallback();
EXPECT_EQ(engine->softSparkLimiter.getTargetSkipRatio(), TEST_LUA_SOFT_SPARK_SKIP + TEST_TRACTION_CONTROL_IGNITION_SKIP);
EXPECT_EQ(engine->hardSparkLimiter.getTargetSkipRatio(), TEST_LUA_HARD_SPARK_SKIP);
}
TEST(targetSkipRatio, useSkipInTraction) {
EngineTestHelper eth(engine_type_e::TEST_ENGINE);
setUpTestParameters();
engineConfiguration->useHardSkipInTraction = true;
eth.engine.periodicFastCallback();
EXPECT_EQ(engine->softSparkLimiter.getTargetSkipRatio(), TEST_LUA_SOFT_SPARK_SKIP);
EXPECT_EQ(engine->hardSparkLimiter.getTargetSkipRatio(), TEST_LUA_HARD_SPARK_SKIP + TEST_TRACTION_CONTROL_IGNITION_SKIP);
}

1
unit_tests/tests/tests.mk
View File

@ -44,6 +44,7 @@ TESTS_SRC_CPP = \
tests/ignition_injection/test_fuel_computer.cpp \
tests/ignition_injection/test_injector_model.cpp \
tests/ignition_injection/test_odd_firing_engine.cpp \
tests/launch/test_target_skip_ratio.cpp \
tests/lua/test_lua_basic.cpp \
tests/lua/test_lookup.cpp \
tests/lua/test_lua_e38.cpp \