Virtual functions should not be invoked from a constructor or destructor
of the same class. Confusingly, virtual functions are resolved
statically (not dynamically) in constructors and destructors for the
same class. The call should be made explicitly static by qualifying it
using the scope resolution operator.
* big buffer
* mostly hooked up big buffer
* bad merge
* s
* sneak preview of trigger scope
* s
* constness
* channel limits
* s
* unnecessary
* efilib
* TcpServerSandbox
* includes fix
* binary format
* firmware error in case of low stack only on HW CI
* send date
* I don't java good
* I still don't java good
* send the right command
* I guess we can check it on every single test?
* javaaaaaa
* atoi breaks on later non-digit
* avoid sscanf use (for atoi)
to avoid bloating the stack
* less churn
* less churn
Co-authored-by: Nathan Schulte <nmschulte@desmas.net>
* logingcentral: check final string for prohibited chars
Invalid char can come from arguments, not only format string so
scan final buffer.
* logingcentral: comment say '\r' is also not allowed
* logingcentral: just replace all non-printable chars with space
Do not assert
* loging: remove strlen()
* Do lightweight checks first
* Dead getTimeIgnitionSeconds()
Dead since 81fffe87b7
* Get rid of efitime_t.
Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.
* Fix unit tests
* Fix misc: stm32f1_test_project
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()