Commit Graph

585 Commits

Author SHA1 Message Date
Matthew Kennedy 5644312cbe we play a little fast and loose with Timer, ensure it gets no vtable 2023-07-26 07:45:14 -04:00
mi-hol 27ff399e2d fix apparent CopyPaste error assigning OBD fault 2023-07-17 08:08:29 -04:00
rusefillc f57c4375dd only:honda checksum comment 2023-07-07 23:46:31 -04:00
Matthew Kennedy 25c4d4886b sprinkle in some constexpr 2023-07-02 23:27:32 -04:00
rusefillc c20963d302 proteus F7 hard fault on "enable self stimulation" #5354
i feel lucky so I make random changes
2023-06-25 02:21:38 -04:00
rusefillc bc2a2b9ab9 only:better method name 2023-06-25 02:08:53 -04:00
Andrey a63265bffb only:more timer API 2023-06-15 17:30:55 -04:00
rusefi 426bc8720e console "spark 1" bench hands up proteus #5320
i feel lucky!
2023-06-11 23:23:17 -04:00
rusefi f77f356e6d reducing code duplication 2023-06-11 23:17:13 -04:00
rusefi 731fd89ef7 reducing magic constant 2023-06-11 23:13:36 -04:00
rusefillc 6ceae089c1 docs 2023-06-06 19:26:31 -04:00
Mingjie Shen 495f0ea8c4 Fix invoking virtual functions from constructors
Virtual functions should not be invoked from a constructor or destructor
of the same class. Confusingly, virtual functions are resolved
statically (not dynamically) in constructors and destructors for the
same class. The call should be made explicitly static by qualifying it
using the scope resolution operator.
2023-05-24 15:27:09 -04:00
rusefillc 2f19ca94a8 https://github.com/rusefi/fw-AT-START-F435/issues/1
UNUSED flexibility
2023-05-23 23:38:02 -04:00
Matthew Kennedy 9fff7998f7 extra define
(cherry picked from commit 83dc73f0d4)
2023-04-29 07:07:28 -04:00
Matthew Kennedy 4935cf5fb3 more dead stuff
(cherry picked from commit b9d065ae4e)
2023-04-29 05:15:34 -04:00
Andrey 51d0f6e347 it's going to be painful 2023-04-29 00:44:00 -04:00
Matthew Kennedy 61e5b4b1ad change ObdCode to enum class builds firmware 2023-04-29 00:44:00 -04:00
rusefi 4add0450e3 kine: read packets as packets #5171
i need a vacation or else
only:hellen-honda-k
2023-03-10 23:02:01 -05:00
Matthew Kennedy dc6f53bda5
extract newton's method implementation (#5157)
* move expected, update libfirmware

* hellen ID solver uses shared Newton's method

* comment shouldn't have been moved
2023-03-07 08:45:17 -05:00
Andrey e9da0eeed2 K
only:mre_f4
2023-03-04 16:00:50 -05:00
Andrey ca850a8437 only:mre_f4 2023-03-01 17:20:22 -05:00
Matthew Kennedy 6e89e71d0a
more flexible GPPWM (#5032)
* gppwm improvements!

* test

* ui

* autoscale
2023-02-06 08:53:31 -04:00
rusefillc 40738fad12 smarter template 2022-12-13 16:47:35 -05:00
Matthew Kennedy 9f76dc4c6b
Use a shared buffer for "high memory" operations (#4878)
* big buffer

* mostly hooked up big buffer

* bad merge

* s

* sneak preview of trigger scope

* s

* constness

* channel limits

* s

* unnecessary

* efilib

* TcpServerSandbox

* includes fix

* binary format
2022-12-10 07:35:39 -05:00
Matthew Kennedy 614dc2f260
Strictly validate stack use in hardware CI (#4880)
* firmware error in case of low stack only on HW CI

* send date

* I don't java good

* I still don't java good

* send the right command

* I guess we can check it on every single test?

* javaaaaaa

* atoi breaks on later non-digit

* avoid sscanf use (for atoi)

to avoid bloating the stack

* less churn

* less churn

Co-authored-by: Nathan Schulte <nmschulte@desmas.net>
2022-12-08 13:20:55 -05:00
rusefillc 3606580178 error=parentheses 2022-12-03 01:12:31 -05:00
rusefillc 5e62595d69 reduce flash footprint by smarter code generation #4163 2022-12-03 00:51:41 -05:00
Andrey 3070e1b3c8 ETB duty cycle jitter #4833 2022-11-29 14:59:08 -05:00
Andrey 5b88c6b535 exp average is pretty cool 2022-11-28 19:22:45 -05:00
rusefillc 9321aae600 ETB duty cycle jitter #4833 2022-11-27 18:13:10 -05:00
Matthew Kennedy 8ea5969607
fix warnings (#4840)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-27 10:11:14 -05:00
rusefillc 926168a0d4 docs 2022-11-27 00:08:34 -05:00
rusefillc c8fa9a1ead reducing confusion 2022-11-25 18:59:43 -05:00
Nathan Schulte fd1115d01a
code style, GPS fixes (test, firmware) (#4822)
* tidy NMEA

* const in nmea

* correct gps test output

* fix GPS UART print statements

* cleanup feature toggles in settings

* fix comment typos, misc whitespace
2022-11-23 07:01:34 -04:00
Andrey 4a26b0973d A gem of dead code 2022-11-05 21:57:26 -04:00
Andrey c6e34be447 A gem of dead code 2022-11-05 21:53:38 -04:00
rusefillc f9fa729d8d less horrible constant name 2022-10-27 22:17:50 -04:00
rusefillc fe9b50e4b7 random progress 2022-10-27 21:32:23 -04:00
rusefillc ac08ffbdc4 GM SENT ETB bench test in NJ #4688 2022-10-26 10:37:35 -04:00
Andrey G 68e007caa3
loggingcentral: hotfix (#4654) 2022-10-10 19:12:04 -04:00
Andrey G b5ebb7d00e
Logging asserts (#4652)
* logingcentral: check final string for prohibited chars

Invalid char can come from arguments, not only format string so
scan final buffer.

* logingcentral: comment say '\r' is also not allowed

* logingcentral: just replace all non-printable chars with space

Do not assert

* loging: remove strlen()
2022-10-10 17:14:44 -04:00
Matthew Kennedy a9cc3223dc
plumbing for 4513 (#4599)
* plumbing for 4513

* not static
2022-09-20 06:19:51 -04:00
rusefillc 50cef9a201 tear down Engine god object #4511 2022-09-15 22:12:49 -04:00
rusefillc 52f52376de tear down Engine god object #4511 2022-09-15 21:55:15 -04:00
rusefillc 9e7f36a5ca tear down Engine god object #4511 2022-09-15 21:28:27 -04:00
Andrey G a269287b70
Os util update (#4574)
* chVTSetAny: "this could be simplified"

* os_utils: use Chibi's CriticalSectionLocker
2022-09-13 17:57:13 -04:00
Andrey G 55c1f53c75
dead code, reduce typedefs (#4566)
* Do lightweight checks first

* Dead getTimeIgnitionSeconds()

Dead since 81fffe87b7

* Get rid of efitime_t.

Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.

* Fix unit tests

* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G 8069506135
EFI_PROD_CODE guard around port_mpu_util.h include (#4564) 2022-09-11 13:42:07 -04:00
Andrey G 91d4844e38
time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
Andrey ab4b451195 os_access.h dead? 2022-09-07 15:56:45 -04:00