Commit Graph

359 Commits

Author SHA1 Message Date
rusefillc c4ff0cd19d more firing orders! 2021-09-18 00:18:06 -04:00
Matthew Kennedy 520d81d75c
Dwell voltage correction (#3234)
* cfg + impl

* ui

* value_or

* changelog

* fix
2021-09-15 08:07:33 -04:00
rusefillc 6b6c8abfc4 firing order for some 911 2021-08-24 07:31:55 -04:00
rusefillc 24ff3a5cd5 firing order for some 911 2021-08-24 07:28:56 -04:00
Matthew Kennedy b52d50bbf2
Use pch in lots of files (#3066)
* most engine.h

* most engine_configuration

* more

* more

* more

* more

* more

* moooooore

* ok I'm done for now

* oops
2021-07-26 01:05:17 -04:00
Andrey 643aa672e4 VH41DE (Japaneese Y32 Variant) firing order 2021-07-20 21:16:51 -04:00
Matthew Kennedy 2ce7777865
don't require EXTERN_ENGINE in every file (#2969)
* move enginePins

* no more extern engine

* uses

* more

* extern config too

* put this where it belongs

* include correct header

* merge
2021-07-16 18:13:33 -04:00
Andrey 3d0ba4af5c VAG canned tunes 2021-07-08 20:42:35 -04:00
Matthew Kennedy 9377a01aec
store cylinder count as plain number (#2915)
* update test framework

* eh

* hey look it's fewer warnings

* unwind

* fix

* config

* configs

* logic

* even java had some

* no need to be a typedef

* paste in actual cylinder count
2021-07-07 08:31:05 -04:00
Matthew Kennedy 2eb0b2a631
Unified cyl count macro (#2914)
* update test framework

* eh

* hey look it's fewer warnings

* unwind

* fix

* config

* configs

* logic

* even java had some

* console needs help
2021-07-06 20:14:08 -04:00
Matthew Kennedy 7d2057e74a
remove cranking dwell angle (#2814)
* config & impl

* settings

* engines & boards

* this test doesn't do anything interesting
2021-06-13 07:52:07 -04:00
Matthew Kennedy da6518dcb1
remove deprecated getEngineLoadT (#2676)
* remove

* few more
2021-05-10 08:30:41 -04:00
Matthew Kennedy 4474f9f1c2
Maf in sensor model (#2672)
* init

* consumers

* hasMafSensor

* consumers

* remove

* remove

* s

* guard

* tiny bit of ram

* ram
2021-05-09 20:59:06 -04:00
Andrey G 70e0723626
use cylinders_count_t in loops through cylinders (#2563)
to supress signed vs usigned warnings
2021-04-18 08:58:56 -04:00
Andrey G fa840a7593
hip9011 and friends (#2527)
* engine math: extrant getFiringOrderTable for reuse

* engine math: getNextFiringCylinderId helper

* introduce knock_logic: first member is getCylinderKnockBank()

moved from software_knock.cpp

* hip9011: support two inputs/banks

* fix CI

* Board Subaru EG33: populated with TPIC8101 with Advanced mode

* hip9011: test communication in advanced mode

* hip9011: handle situation when chip is already in advanced mode

* Board Subaru EG33: cylinder to knock bank mapping

* hip9011: count spi transactions in advansed mode too

* hip9011: reset incalid responce counter after chip initialization

* hip9011: make debug output more structured
2021-04-04 18:13:21 -04:00
slowriot 881c3739a2
Add two new V8 firing orders (#2423)
* fix typos, spelling

* add two V8 firing orders

* use the available number of CPU cores, not just 4

* add new firing orders to config

* updating generated files to include new v8 firing orders

* reverting update of auto-generated files

* correct firing order labels for new firing orders
2021-03-05 19:28:17 -05:00
Matthew Kennedy 4a1d3de9a6
remove unused msg parameter (#2360)
* dead parameter

* last few
2021-02-16 09:32:16 -05:00
Andrey G 25560b85c2
Supress annoing unused warnings (#2216) 2021-01-11 08:49:20 -05:00
Matthew Kennedy a5266cd6ef
part of 2217 which may fix it alone (#2220) 2021-01-11 08:01:54 -05:00
Matthew Kennedy 92ea09b0a6
switch more map to read from sensor model (#2162)
* hook up map

* check for init

* switch some consumers

* that's the rest of them

* test

* tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
Matthew Kennedy f29ca22b99
fix (#2109) 2020-12-20 19:31:14 -05:00
rusefi 89eaae8234 LM_ALPHA_N_2 rename 2020-11-27 15:44:31 -05:00
Matthew Kennedy 95798a5246
fix broken master, inject engine ptr to rpmcalculator (#1759)
* fix

* oops
2020-09-05 18:49:42 -04:00
rusefi ca21d5b4c2 refactoring 2020-09-03 19:29:15 -04:00
rusefi b09091774a VVT support for VAG trigger #883 2020-08-25 12:45:18 -04:00
rusefi 540eef5e0d VVT support for VAG trigger #883 2020-08-25 00:59:07 -04:00
Matthew Kennedy 2ba340bce4 no bins 2020-08-03 12:21:49 -07:00
Matthew Kennedy 978fa20916 Merge remote-tracking branch 'upstream/master' into remove-plain-maf 2020-07-31 14:56:29 -07:00
Matthew Kennedy ba7c47dd3c remove 2020-07-29 01:35:17 -07:00
Matthew Kennedy 08be750098 Merge remote-tracking branch 'upstream/master' into remove-plain-maf 2020-07-28 20:25:16 -07:00
Matthew Kennedy 8f27fc8b53 alphan 2020-07-25 01:14:35 -07:00
Matthew Kennedy 626f55a08a refacto 2020-07-24 18:26:24 -07:00
Matthew Kennedy 67e4fcb2a2 goodbye plain maf 2020-07-23 02:46:45 -07:00
Matthew Kennedy b3261f25f3 add reset 2020-07-14 23:54:41 -07:00
Matthew Kennedy ee6cb2c97a
correct batch fuel cylinder pairing (#1595)
* correct batch fuel cylinder pairing

* param

* only change behavior on two wire batch

* Add tests for two wire batch & sequential

* improve testing a little bit

* comments

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-13 14:46:55 -04:00
Matthew Kennedy 2b8b43ca55
plumb new load channels (#1573)
* wire up new channels

* add deprecation comment

* add gauges

* these tables are indeed used in those modes

* simplify

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-05 16:25:19 -04:00
Matthew Kennedy cddb469678
support 1-3-2 firing order (#1537)
* support 1-3-2

* oops

* correct TS

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-26 09:07:43 -04:00
Matthew Kennedy 2bdd8128db
refactor (#1481) 2020-06-03 21:12:12 -04:00
rusefi 8c70654e4e partial rollback 2020-05-23 19:17:15 -04:00
rusefi e52ec0e611 partial rollback 2020-05-23 18:11:04 -04:00
rusefi 1e69e306e1 partial rollback 2020-05-23 18:01:40 -04:00
rusefi 1686180716 partial rollback 2020-05-23 18:00:20 -04:00
Matthew Kennedy b11c5cd8c8
switch some firmware warnings to errors (#1465)
* warnings as errors

* throw instead of exit

* test massaging

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
rusefi 82e788ef3a MRE pre-sets 2020-05-21 20:44:14 -04:00
rusefi 5c9851e976 no comments 2020-05-21 18:28:35 -04:00
Matthew Kennedy 2c9cb4e291
remove "plain MAP" mode (#1398)
* consumers

* enums, input, config

* java

* default config cleanup
2020-05-05 15:04:55 -04:00
rusefi 9180154848 Add firing order fix #1385 2020-04-29 16:46:59 -04:00
Matthew Kennedy bc3f0c6b27
More TPS consumers: VE lookup (#1256)
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

* engine load

* ve lookup

* unused

* oops we needed that

* oops needed that too

* mocking

* test mocks

* oops

* helps to use the right sensor

* and cylinder cleanup

* fuel math

* typo

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-04 08:41:09 -04:00
Matthew Kennedy 8fd9842310
cleanup extern mess (#1237)
* cleanup

* move outside define
2020-03-29 19:06:03 -04:00
Matthew Kennedy 397907a06f
Support disabling most/all features (#1162)
* this flag did nothing

* guard features properly
2020-02-26 18:16:35 -05:00
Matthew Kennedy 8c118f2fbe
Stricter compile options (#1132)
* stricter

* don't warn on that one

* this code was dead
2020-02-08 08:05:40 -03:00
rusefi bb217b01dd happy new year unification 2020-01-13 21:57:43 -05:00
rusefi c5cfd21a70 just a trivial massive rename: TriggerState > TriggerWaveform 2019-12-08 01:09:39 -05:00
rusefi 1c96d9541e refactoring 2019-12-02 23:08:18 -05:00
rusefi 6f50cae286 improving API? 2019-11-24 00:15:44 -05:00
Matthew Kennedy 9ee8616cb0 Use templated array references (#1027)
* update defs

* consumers, use default params

* setArrayValues in tests

* floats

* test fixing
2019-11-22 23:27:24 -05:00
rusefi 1f1f7e86ae typo 2019-11-17 09:18:43 -05:00
rusefi 8f5895321c refactoring 2019-11-05 23:17:44 -05:00
rusefi f55c2df681 IM_TWO_COILS 2019-10-27 16:19:59 -04:00
rusefi 0a8a0d0b81 docs 2019-10-26 21:53:22 -04:00
rusefi f17fc56aa5 better handling of corner case 2019-10-10 07:07:59 -04:00
rusefi ca67249522 refactoring: better field name 2019-10-08 00:54:19 -04:00
rusefi 8e3912e6b1 firing order 1-2-7-8-4-5-6-3 2019-09-28 10:25:57 -04:00
rusefi 664777587b Most important feature: VAG W12 firing order 2019-09-14 14:47:22 -04:00
rusefi 8a4d3f9896 reducing unit test noise 2019-08-25 01:15:18 -04:00
rusefi 0102f07d77 new 4 cylinder firing order! 2019-08-15 19:36:16 -04:00
rusefi 51110b33ad WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
refactoring to begin with, zero logic change
2019-08-08 00:19:09 -04:00
Matthew Kennedy 77075fce3d Fix some maf logic (#880)
* fix maf

* thank you vscode for mangling ANSI -> utf8
2019-07-10 09:14:47 +03:00
Matthew Kennedy e0db83e027 Template-ize bin/value length for interpolation (#878)
* update consumers

* tests

* whitespace

* format
2019-07-09 21:16:36 +03:00
rusefi 5f642ac254 unit tests should not have global context, including mock values 2019-05-27 15:56:12 -04:00
rusefi 541c445a2d defined(__DOXYGEN__) ? #748 2019-04-12 22:07:03 -04:00
rusefi bd2b992918 unifying_file_naming 2019-03-29 09:11:13 -04:00
rusefi 9ed58a5ba0 better conditional compilation 2019-01-31 18:30:40 -05:00
rusefi da4fb3a19f better conditional compilation 2019-01-31 17:55:23 -05:00
rusefi c4cd774d29 #656 trying a new idea 2019-01-28 03:25:28 -05:00
rusefi 3dab4b5163 #656 global is not great 2019-01-28 02:29:13 -05:00
rusefi 7a20bda66f refactoring around GET_RPM 2019-01-21 20:33:21 -05:00
rusefi 28bde6f084 better method name and docs related to improved craking logic 2019-01-20 11:33:40 -05:00
rusefi dd8e2d9326 The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657 2019-01-10 19:25:07 -05:00
Matthew Kennedy 799923ac5d const (#648) 2019-01-05 08:06:18 -05:00
rusefi 6360719ed0 #635 2019-01-01 14:05:11 -05:00
rusefi f0344fd16c #625 big step - no more engine dependency from TriggerShape 2018-12-25 22:47:29 -05:00
rusefi 62b5e87393 #635 2018-12-25 12:27:34 -05:00
rusefi 1f90cf153d refactoring 2018-09-16 22:26:57 -04:00
rusefi 7b37195d64 names for error codes 2018-09-10 22:00:13 -04:00
rusEfi 75b10d9e54 wider macro usage 2018-07-28 19:16:58 -04:00
rusefi 5e6deaa782 making error condition less fatal
#598
2018-07-28 15:36:47 -04:00
rusefi 9b2c7239c8 #598 better state initialization 2018-07-28 14:28:52 -04:00
rusefi 22cbf774ad #598 2018-07-28 14:01:28 -04:00
rusefi e03314e4a5 #598 really strage error 2018-07-28 13:58:19 -04:00
rusefi 99e74635ef step towards more unique codes 2018-07-25 23:30:00 -04:00
rusefi 959a91ae4c unique error codes #598 2018-07-25 23:03:04 -04:00
rusefi bb15cb20fd #598 2018-07-24 20:40:44 -04:00
rusefi 2cdee04c61 refactoring: reorder to remove forward reference 2018-07-24 20:15:38 -04:00
rusEfi 9cce922b78 per error code 2018-07-23 21:38:05 -04:00
rusefi 74bd1d7e10 error code into angle validation 2018-07-23 21:03:20 -04:00
rusefi d7211d8c64 better field name 2018-05-08 13:33:49 -04:00
rusEfi 31f2811cd5 chasing that funny issue on change engine 2018-03-20 23:12:32 -04:00
andreika-git ac0189270e Impl. faster engine spin-up mode (alpha-version) (#567)
* Impl. faster engine spin-up mode (alpha-version)

* A comment for RPM_LOW_THRESHOLD

* Faster engine stop detection

* Safety check for instant RPM on spinning-up

* rusefi.xml

* unit-tests & relevant fixes
2018-03-10 20:58:51 -05:00
rusefi c724db110e progress 2018-03-03 09:11:49 -05:00