From 2fb5d7d3a50ba5ec325fb55d06bdcd0ee7acc067 Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Mon, 21 Jul 2014 10:36:08 -0300 Subject: [PATCH] change test to use sinon --- lib/NetworkMonitor.js | 1 + package.json | 3 +++ test/test.NetworkMonitor.js | 10 +++++----- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/lib/NetworkMonitor.js b/lib/NetworkMonitor.js index 3d301ff..19ccaa6 100644 --- a/lib/NetworkMonitor.js +++ b/lib/NetworkMonitor.js @@ -38,6 +38,7 @@ NetworkMonitor.prototype.init = function() { var handleTx = function(info) { var tx = info.message.tx; + self.emit('tx', tx); var from = tx.getSendingAddresses(self.networkName); for (var i = 0; i < from.length; i++) { diff --git a/package.json b/package.json index cd5ca05..c21c61c 100644 --- a/package.json +++ b/package.json @@ -112,5 +112,8 @@ "license": "MIT", "engines": { "node": ">=0.10" + }, + "devDependencies": { + "sinon": "^1.10.3" } } diff --git a/test/test.NetworkMonitor.js b/test/test.NetworkMonitor.js index 4cdf21c..62c894c 100644 --- a/test/test.NetworkMonitor.js +++ b/test/test.NetworkMonitor.js @@ -1,6 +1,7 @@ 'use strict'; var chai = chai || require('chai'); +var sinon = require('sinon'); var bitcore = bitcore || require('../bitcore'); var Transaction = bitcore.Transaction; var NetworkMonitor = bitcore.NetworkMonitor; @@ -77,12 +78,10 @@ describe('NetworkMonitor', function() { }); var observedAddress = '2NFYBLfabKgLbgoTALYrtBQhbLjEKUcs9Go'; describe('incoming tx event', function() { - it('should be called on incoming transactions', function(done) { + it('should be called on incoming transactions', function() { var nm = createConnectedNM(); - nm.incoming(observedAddress, function(tx) { - should.exist(tx); - done(); - }); + var spy = sinon.spy(); + nm.incoming(observedAddress, spy); var tx = new Transaction(); var raw = '01000000012732117ef4663b4a7a455ff37c3af26deca57dc43f5d8e7e5440b22c11cefc8b010000006a47304402201ca8b1b33e9f7a515829b887b264b812ab499a08e0002a0fb32629bdbfbc005e0220567adbec3befee04e810e1d34bf31614e1cd397d7a6e3184f219c89562cac7a3012102f1bc222f40a7dd4348e4c2b1e88812179686305f1b56374aae891aa21929ad14ffffffff02809698000000000017a914f487a0aeae655268e2636207abe75228bfcf5631874f219800000000001976a914361d24071123fb9fd88685c877b014ff8543c24488ac00000000'; tx.parse(new Buffer(raw, 'hex')); @@ -92,6 +91,7 @@ describe('NetworkMonitor', function() { tx: tx } }); + spy.calledWith(tx).should.equal(true); }); it('should not be called on unrelated transactions', function(done) { var nm = createConnectedNM();