Commit Graph

703 Commits

Author SHA1 Message Date
Zaki Manian aa8e548800 To be effective within the current Bitcoin network, the inputs to a transaction
with an nLocktime must be not the standard max value.

We set the sequence number of 0 if the value is max.

Currently sequence numbers other than MAX_INT32 have no meaning in the Bitcoin protocol
but this may change in future BIPS
2015-08-24 20:07:57 -07:00
Braydon Fuller 809ff1461e Restore error when trying to derive a hardened path with HDPublicKey.
- Restores InvalidIndexCantDeriveHardened error in spec
- Passes hardened argument in HDPublicKey (in case the feature is attempted to be used similarly to HDPrivateKey)
- Fixes undefined error with InvalidLength
- Fixes tests to check for the error type
- Various formatting cleanup improvements
2015-08-17 09:21:58 -04:00
Braydon Fuller a50fccef4d Changes behavior of `toJSON` to work as expected with `JSON.stringify`
- see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#toJSON%28%29_behavior
- Updates CONTRIBUTING with changes to Stardard Methods
- Aliases toJSON for toObject
- Removes all `fromJSON` methods, and many cases replaces with `fromObject`
- Constructors expect an object parsed via `JSON.parse` for JSON input
2015-08-13 10:46:08 -04:00
Braydon Fuller 496edf9109 Check for consitency with block header argument hash and calculated hash. 2015-08-12 20:45:57 -04:00
Braydon Fuller e7c7a9ad89 Check for consistency if object argument includes a hash. 2015-08-12 20:26:25 -04:00
Braydon Fuller be8cb7d245 Update json block test data. 2015-08-11 12:53:00 -04:00
Braydon Fuller 74dee1fda7 Include hash in toObject/toJSON results. 2015-08-11 11:42:23 -04:00
Patrick Nagurny 7c6df33ab7 Merge pull request #1301 from braydonf/pubkey
Added support for signing publickey inputs.
2015-07-30 10:21:44 -04:00
Patrick Nagurny a8b78a2f3f Merge pull request #1295 from braydonf/script-asm
Add script methods `fromASM()` and `toASM()`
2015-07-30 10:17:41 -04:00
Patrick Nagurny 0dec8e7bd8 Merge pull request #1294 from braydonf/tx-unmodified-arguments
Objects passed as arguments are unmodified.
2015-07-30 10:16:00 -04:00
Patrick Nagurny 6ac7ad9da1 Merge pull request #1293 from braydonf/script-data-encoding
Added encoding type for buildDataOut
2015-07-30 10:14:31 -04:00
Braydon Fuller eb077eb3df Added support for signing publickey inputs. 2015-07-27 15:16:58 -04:00
Braydon Fuller d9047eebf0 Detect if scriptSig (input) or scriptPubKey (output) is previously known. 2015-07-09 11:30:20 -04:00
Patrick Nagurny edfbcb6dd5 Merge pull request #1291 from braydonf/optimize-script
Optimized performance of script.isPublicKeyHashIn(). Fixes #1289
2015-07-07 13:06:54 -04:00
Braydon Fuller 474132d216 Merge pull request #1287 from eordano/cltv
Add CLTV (BIP65) support
2015-07-06 21:08:03 -04:00
Braydon Fuller 55d8c4156a Add tests for script.toASM() and new method script.fromASM() 2015-07-06 20:24:15 -04:00
Braydon Fuller b81a64e8cf Added script.toASM method 2015-07-06 19:50:10 -04:00
Braydon Fuller 3d1dc7aafe Objects passed as arguments are unmodified. 2015-07-06 19:32:34 -04:00
Braydon Fuller 3ad484fff0 Added encoding type for buildDataOut 2015-07-06 19:14:48 -04:00
Esteban Ordano 5bd5a5b937 CLTV: More tests and improved docs 2015-07-06 12:13:19 -07:00
Braydon Fuller 7e23109f9b Added more tests around script.isPublicKeyHashIn 2015-07-06 13:12:20 -04:00
Esteban Ordano 4280b993e0 Add CLTV (BIP65) support 2015-07-01 18:46:54 -07:00
Braydon Fuller 2a71863992 Added additional test cases for readUInt64LEBN 2015-07-01 15:05:26 -04:00
Braydon Fuller 805182c500 Removed readReverse() precondition for a 2x block parsing improvement. 2015-07-01 15:05:26 -04:00
mruddy 9b727afc71 fix signature hasDefinedHashtype method to be closer to the Bitcoin Core function IsDefinedHashtypeSignature 2015-07-01 07:11:08 -04:00
mruddy 02cad1645a fix root cause for bitcore.Transaction.sighash.sign not setting nhashtype.
added unit tests.
fixed an existing lint in a file that i touched.
2015-06-30 15:21:11 -04:00
Braydon Fuller 6dd599187c Merge pull request #1276 from greggzigler/feature/get-sigops-count
get-signature-count needed to measure txs with many inputs
2015-06-25 19:20:14 -04:00
Gregg Zigler b6d44f4622 camelCase variable names 2015-06-25 17:53:50 -04:00
Gregg Zigler 77645c7f03 remove skipped tests since equalivant boolean tests already exist 2015-06-24 14:44:27 -04:00
Gregg Zigler 183ffab02b match bitcore style standards, rename arg, set default to true 2015-06-24 14:18:55 -04:00
Gregg Zigler a4b8c06a2d get-signature-count needed to measure txs with many inputs or outputs 2015-06-24 13:30:25 -04:00
Braydon Fuller 8e13b68405 Merge pull request #1268 from brandonrobertz/master
modularize network version check issues/1265 (2nd)
2015-06-23 18:02:14 -04:00
Brandon Roberts 3518843f98 stylistic change and unnecessary test code removal 2015-06-23 09:47:02 -07:00
Brandon Roberts 783c59d99e removed Networks.all and associated test 2015-06-22 20:36:35 -07:00
Braydon Fuller 37b5d3d588 Merge pull request #1264 from fanatid/fix/sortOutputs
fix Transaction.sortOutputs
2015-06-18 11:06:20 -04:00
Brandon Roberts a53bd10f42 test explicitly passed invalid network 2015-06-11 08:05:35 -07:00
Ivan Socolsky f638b5bd6e test fee per kb 2015-06-10 22:28:15 -03:00
Brandon Robertz a38c0c2d93 modularize network version check/tests issues/1265 2015-06-09 14:06:22 -07:00
Kirill Fomichev b9d52b79c8 fix Transaction.sortOutputs 2015-06-05 21:11:40 +03:00
mpolci 0d2784eb1e created test to verify correct network initialization in PrivateKey.fromJSON() 2015-06-05 01:51:27 -07:00
Braydon Fuller a03e6b9385 Add base option for BN.fromString 2015-05-27 14:11:43 -04:00
Manuel Araoz e2542866d1 expose BN.fromString problem 2015-05-27 15:01:26 -03:00
Patrick Nagurny 4c1ba674c5 Merge pull request #1248 from braydonf/bug/misleading-error
Fixes bug with misleading error with getSerializationError. Closes #1236
2015-05-26 11:32:51 -06:00
Braydon Fuller ffe6b449cb Check the compressed property in Signature.fromCompact tests. 2015-05-26 01:15:11 -04:00
Braydon Fuller a5cd5a1407 Added support for uncompressed public keys to Signature.fromCompact 2015-05-25 23:57:46 -04:00
Braydon Fuller 7719d1bfd4 Add test with uncompressed pubkey compact signature. 2015-05-25 23:31:42 -04:00
Braydon Fuller ee651df635 Added test for null input for transaction.verify() 2015-05-23 20:28:33 -04:00
David de Kloet 3ace170ac5 Ignore fee error when unspent output is actually negative, rather than already when the check for negative unspent output is disabled. 2015-05-23 20:13:53 -04:00
David de Kloet ac2fbe2777 When disableMoreOutputThanInput is set for getSerializationError, also disable the fee checks as the concept of a fee is meaningless when unspent output value is negative. This also allows for removing the opts from buildSkipTest again and simplifying the skip test for disableMoreOutputThanInput. 2015-05-23 20:13:53 -04:00
David de Kloet dc07788e53 Put )); on a separate line. 2015-05-23 20:13:53 -04:00