Commit Graph

2840 Commits

Author SHA1 Message Date
Manuel Araoz e2542866d1 expose BN.fromString problem 2015-05-27 15:01:26 -03:00
Braydon Fuller 5ee1c3f6aa Bump package version to 0.12.7 2015-05-27 10:30:35 -04:00
Patrick Nagurny 4c1ba674c5 Merge pull request #1248 from braydonf/bug/misleading-error
Fixes bug with misleading error with getSerializationError. Closes #1236
2015-05-26 11:32:51 -06:00
Patrick Nagurny 7cf97ac379 Merge pull request #1250 from braydonf/feature/compact-uncompressed
Support Uncompressed Public Key Compact Signatures
2015-05-26 11:32:42 -06:00
Patrick Nagurny c9a9ed3bd4 Merge pull request #1251 from braydonf/maintainers-update
Update Readme
2015-05-26 11:07:43 -06:00
Braydon Fuller 6decfbc5d1 Update readme maintainers. 2015-05-26 13:04:21 -04:00
Braydon Fuller ffe6b449cb Check the compressed property in Signature.fromCompact tests. 2015-05-26 01:15:11 -04:00
Braydon Fuller a5cd5a1407 Added support for uncompressed public keys to Signature.fromCompact 2015-05-25 23:57:46 -04:00
Braydon Fuller 7719d1bfd4 Add test with uncompressed pubkey compact signature. 2015-05-25 23:31:42 -04:00
Braydon Fuller ee651df635 Added test for null input for transaction.verify() 2015-05-23 20:28:33 -04:00
Braydon Fuller 589d017a14 Refactored transaction.getSerializationError to be more concise.
- _hasMoreOutputThanInput() and _isInvalidSatoshis() merged with getSerializationError()
- _isFeeDifferent(), _isFeeTooLarge() and _isFeeTooSmall merged with _hasFeeError()
2015-05-23 20:13:53 -04:00
David de Kloet 0b6eaf0f1e Call getUnspentValue() only once in getSerializationError(). 2015-05-23 20:13:53 -04:00
David de Kloet 3ace170ac5 Ignore fee error when unspent output is actually negative, rather than already when the check for negative unspent output is disabled. 2015-05-23 20:13:53 -04:00
David de Kloet ac2fbe2777 When disableMoreOutputThanInput is set for getSerializationError, also disable the fee checks as the concept of a fee is meaningless when unspent output value is negative. This also allows for removing the opts from buildSkipTest again and simplifying the skip test for disableMoreOutputThanInput. 2015-05-23 20:13:53 -04:00
David de Kloet dc07788e53 Put )); on a separate line. 2015-05-23 20:13:53 -04:00
David de Kloet 6729b38944 Expect the correct error to be thrown. 2015-05-23 20:13:53 -04:00
David de Kloet 8c5b2c851b When checking for transaction serialization errors, check the output amount before checking fee errors. Added a test for it and also improved buildSkipTest by specifying which error to expect and using it for some tests where it wasn't used yet. 2015-05-23 20:13:53 -04:00
Braydon Fuller 001f71d1bf Merge pull request #1245 from maraoz/reorg-tests
reorganize block test files
2015-05-23 17:13:05 -04:00
Manuel Araoz 74e285dadd fix imports for block tests 2015-05-23 16:44:11 -03:00
Manuel Araoz 6e49ed0e40 reorganize block test files 2015-05-20 14:42:48 -03:00
Braydon Fuller ea9be99854 Bump package version to 0.12.6 2015-05-20 10:35:07 -04:00
Braydon Fuller b53f249d02 Merge pull request #1235 from maraoz/transaction/clearOutputs
add Transaction#clearOutputs
2015-05-18 16:24:02 -04:00
Braydon Fuller 85dd29e576 Merge pull request #1227 from fanatid/fix/inBrowser
remove inBrowser
2015-05-18 16:22:14 -04:00
Braydon Fuller c251c2bfd1 Merge pull request #1226 from dskloet/refactor/get-serialization-error
Simplify transaction.getSerializationError()
2015-05-18 15:08:50 -04:00
Braydon Fuller 1c8ebc0eb5 Simplify version guard
- Updated index.js test to run in Node.js and browsers
- Simplified message and clarified case where two of the same versions would conflict
2015-05-18 15:00:45 -04:00
Patrick Nagurny 83103cb5e2 Merge pull request #1239 from braydonf/bug/getdata
Added test case for an empty OP_RETURN for script.getData() Fixes #1237
2015-05-18 10:05:49 -05:00
Braydon Fuller 7723dd302a Added test case for an empty OP_RETURN for script.getData() Fixes #1237 2015-05-18 10:39:15 -04:00
Kirill Fomichev 7e3993578c improve guard for prevent more than one instance of bitcore 2015-05-17 10:09:18 +03:00
David de Kloet 99d8ac1957 Remove an unnecessary space. 2015-05-16 22:54:30 +02:00
David de Kloet 3d9560c0c5 Don't break lines at 80 characters. 2015-05-16 22:50:44 +02:00
David de Kloet 8a8412f04a Don't break lines at 80 characters. 2015-05-16 17:06:35 +02:00
Manuel Araoz 8a13a22baf add Transaction#clearOutputs 2015-05-15 15:29:05 -03:00
Braydon Fuller 5fe53ac36d Bump package version to 0.12.5 2015-05-14 10:50:33 -04:00
Patrick Nagurny 796fbc2346 Merge pull request #1231 from braydonf/bug/output-to-script
Handling Invalid Output Scripts. Closes #1230
2015-05-14 09:31:13 -05:00
Braydon Fuller 458abe069e Fixed issue with handling invalid output scripts
- Changed toObject serialization to always use a hexa string for a script
- Updated inspect method to handle a null script
- Roundtrip toObject/fromObject with an invalid script
- Additional test coverage for Output
2015-05-14 01:50:14 -04:00
Braydon Fuller 0dbd9db0ea Merge pull request #1233 from carnesen/typo
Typo "formated"
2015-05-13 18:59:31 -04:00
Chris Arnesen ec2d726e49 typo "formated" 2015-05-13 15:48:23 -07:00
Braydon Fuller beeb294e45 Merge pull request #1217 from fanatid/fix/writeable
fix typo: defineProperty.writeable
2015-05-13 09:22:56 -04:00
Braydon Fuller 4bc3356b78 Merge pull request #1229 from dskloet/test/fix-transaction
Some transaction tests were not run…
2015-05-13 09:13:54 -04:00
David de Kloet e294505486 Some transaction tests were not run because of the way they were built. Fixed this so they are run and fixed one test that still assumed the dust limit at 5460 instead of 546. 2015-05-13 09:14:00 +02:00
David de Kloet 26bd5a864a Simplify transaction.getSerializationError(). This takes care of some lint errors about number of statements and cyclomatic complexity. 2015-05-13 00:26:33 +02:00
Braydon Fuller bb843ee6a5 Merge pull request #1225 from pnagurny/feature/nullScript
If output.script is InvalidBuffer, return null instead of throwing error. Closes #880. Closes #1216.
2015-05-12 17:36:47 -04:00
Patrick Nagurny de078a40d3 If output.script is InvalidBuffer, return null instead of throwing error 2015-05-12 17:23:56 -04:00
Braydon Fuller a02258dfba Merge pull request #1218 from maraoz/docs/pubkeys
improve PublicKey docs and fix #1215
2015-05-12 13:31:34 -04:00
Manuel Araoz 48761fd08f formatting fixes on pubkey docs 2015-05-12 13:47:14 -03:00
Eric Martindale 8e7528d13f Merge pull request #1219 from braydonf/coverage/transaction
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 17:48:50 -04:00
Eric Martindale fd36c392e4 Merge pull request #1220 from braydonf/fix/hd-docs
Update HDPrivateKey docs. Fixes #1209
2015-05-11 17:39:56 -04:00
Eric Martindale 993125428e Merge pull request #1213 from braydonf/bug/is-fully-signed
Fixed script.isPublicKeyHashIn bug with variable length signatures.
2015-05-11 15:12:44 -04:00
Braydon Fuller 55f663737f Update HDPrivateKey docs. Fixes #1209 2015-05-11 14:30:58 -04:00
Braydon Fuller 53b6171547 Added coverage to transaction and fixed bug with serialization check. 2015-05-11 13:39:53 -04:00