Commit Graph

321 Commits

Author SHA1 Message Date
Christopher Jeffrey 6eab175467 Revert "paypro: attempted debugging with KJUR."
This reverts commit 5788fdbb52.
2014-08-22 13:21:21 -07:00
Christopher Jeffrey 5788fdbb52 paypro: attempted debugging with KJUR. 2014-08-22 13:21:18 -07:00
Christopher Jeffrey 1a0de813fc paypro: fix browser kjur usage. 2014-08-22 13:21:02 -07:00
Christopher Jeffrey 6dbff09d40 Revert "paypro: more debugging."
This reverts commit b406eeadff.
2014-08-22 12:50:26 -07:00
Christopher Jeffrey b406eeadff paypro: more debugging. 2014-08-22 12:50:22 -07:00
Christopher Jeffrey e9b0e7b969 Revert "paypro: asn1.js debugging - try to get tbs buffer."
This reverts commit 3c7aeb4f62.
2014-08-22 12:20:36 -07:00
Christopher Jeffrey 3c7aeb4f62 paypro: asn1.js debugging - try to get tbs buffer. 2014-08-22 12:19:17 -07:00
Christopher Jeffrey 11c478d1a9 paypro: fix chain validation for browser. 2014-08-22 12:18:58 -07:00
Christopher Jeffrey 4e325c3fa9 paypro: fix root cert check. 2014-08-22 09:05:05 -07:00
Christopher Jeffrey f0757498b6 paypro: use asn1.js in browser paypro. 2014-08-22 08:56:30 -07:00
Christopher Jeffrey 4a12d5a491 paypro: verify chain refactor. 2014-08-22 08:38:19 -07:00
Christopher Jeffrey 16b646d0e7 paypro: asn1.js - cleanup. 2014-08-22 00:34:41 -07:00
Christopher Jeffrey 5085880bd0 paypro: use fedor's asn1.js to deal with DER certificates. 2014-08-22 00:31:20 -07:00
Christopher Jeffrey 569e60065a paypro: verify the certificate chain. 2014-08-21 16:13:34 -07:00
Christopher Jeffrey 6828f560da paypro: fix root certs. 2014-08-21 16:02:53 -07:00
Aaron Caswell e6190f9e9b Update Transaction.js
Global leak fix
2014-08-19 23:30:08 -07:00
Curtis Lacy 798f8ad1be Revised error message per feedback on PR. 2014-08-18 15:26:06 -04:00
Curtis Lacy 49bd46b8b1 Made the error message when we encounter an unknown script pubkey more clear. 2014-08-18 14:39:06 -04:00
Christopher Jeffrey 730e8236cf bip21: fix regex parse error. 2014-08-12 11:26:12 -04:00
Christopher Jeffrey 363e27d493 bip21: check for arg `r=` and set merchant. 2014-08-12 11:03:43 -04:00
Christopher Jeffrey 11ecfd1667 bip21: use triple equal for consistency. 2014-08-12 11:03:24 -04:00
Christopher Jeffrey f46cc65aba bip21: use RegExp.exec instead of String.match. 2014-08-12 11:03:01 -04:00
Yemel Jardi ea22f1361f Add validation of required arguments for future use 2014-08-11 17:57:28 -03:00
Yemel Jardi ac525f226c Add BIP21 implementation 2014-08-11 17:57:28 -03:00
Ryan X. Charles 9f9e2f1d41 k should be 32 bytes, not 8 bytes
This is a bug with security implications. It is much easier to guess the value
of k within a 64 byte range. This would lead to compromised private keys.

The cryptography interface of bitcore is extremely poor. I recommend:
* Get rid of the C++ code, since it makes everything more difficult with little benefit
* Refactor all crypto, and have easily auditable bignum, point, ecdsa, and key classes
* Then actually audit the crypto
2014-08-10 21:25:52 -04:00
Manuel Aráoz 7d03056e09 Merge pull request #459 from ryanxcharles/feature/message-signing
add support for signing messages in compressed format
2014-08-06 10:56:07 -03:00
Manuel Aráoz 742edf9164 Merge pull request #478 from manan19/walletkey-params
setting networks.livenet as the default for WalletKey
2014-08-06 10:29:55 -03:00
Manan Patel 589418d66c setting networks.livenet as the default for WalletKey 2014-08-05 08:10:20 -07:00
Manuel Araoz 895046cc32 fix browser tests 2014-08-04 15:52:57 -03:00
Manuel Araoz ca16817a1c generalize version numbers 2014-08-04 15:52:56 -03:00
Manuel Araoz e44b2480aa add AuthMessage and fix browser tests 2014-08-04 15:52:56 -03:00
Ryan X. Charles cd353ac02e Merge pull request #467 from maraoz/add/missing-tests
Add missing tests for new methods added
2014-07-30 14:50:52 -04:00
Christopher Jeffrey 124d1a2fc3 paypro: expose RootCerts on PayPro. 2014-07-29 10:58:35 -07:00
Manuel Araoz 80b5fcc614 add is* tests for Script 2014-07-28 14:40:16 -03:00
Manuel Araoz b727cc0d7c add Script validation tests 2014-07-28 14:03:22 -03:00
Manuel Araoz bed6ccaac0 start adding script tests 2014-07-28 10:20:11 -03:00
Ryan X. Charles b9f3479b12 Merge pull request #455 from chjj/root-certs
Root certs
2014-07-25 19:19:47 -04:00
Ryan X. Charles f87da3b5ba add support for signing messages in compressed format
...this is the standard way to sign messages in bitcoin-qt. Note that the
format of a compressed signature, for messages, is quite distinct from DER
format, which is used in transactions. This commit also adds support for
recovering the public key from a signature, which is necessary for this. The
code for public key recover is taken from bitcoinjs-lib.
2014-07-25 14:07:03 -07:00
Ryan X. Charles 9937ec6312 Merge pull request #458 from matiu/feature/builder03
Fix loosing signatures after from-toObj roundtrip
2014-07-25 16:29:53 -04:00
Matias Alejo Garcia 1c6ec69c48 fix lossing signatured after from-toObj roundtrip 2014-07-25 16:43:18 -03:00
Christopher Jeffrey 8a84092be9 root-certs: use hasOwnProperty check instead of __proto__=null. 2014-07-25 10:53:21 -07:00
Christopher Jeffrey c533db4f42 minor: remove redundant toUpperCase calls. 2014-07-24 23:07:52 -07:00
Christopher Jeffrey dd165ecf63 paypro: root certs - do not inherit from Object. 2014-07-24 23:07:52 -07:00
Christopher Jeffrey 5b4c4f3894 paypro: get root cert names. 2014-07-24 23:07:52 -07:00
Christopher Jeffrey 0020e289d8 paypro: allow identification of root certs. 2014-07-24 23:07:52 -07:00
Matias Alejo Garcia 1b37d88e9a accept amount a strings in setOutput 2014-07-24 20:02:41 -03:00
Manuel Aráoz cbfd30af16 Merge pull request #453 from matiu/feature/builder01
fix checkMerge, and tests
2014-07-24 18:50:55 -03:00
Matias Alejo Garcia 8660120add fix checkMerge, and tests 2014-07-24 18:46:12 -03:00
Manuel Araoz 0cfd5e43a8 fix merge 2014-07-24 18:02:42 -03:00
Manuel Araoz c0d51916df add support code for copay's new tx proposal check 2014-07-24 18:01:14 -03:00
Manuel Araoz b222550dd0 add Transaction#getReceivingAddresses and send 2014-07-24 18:01:14 -03:00
Ryan X. Charles 552a18b760 Merge pull request #452 from matiu/feature/txproposal10
TransactionBuilder .fromObj .toObj rewrite
2014-07-24 16:57:36 -04:00
Manuel Araoz f1d7662a70 fix browser tests 2014-07-24 17:44:57 -03:00
Manuel Araoz 8a88c3ccd0 finish basic tests 2014-07-24 17:44:57 -03:00
Manuel Araoz 2fb5d7d3a5 change test to use sinon 2014-07-24 17:44:57 -03:00
Manuel Araoz 837658034a one test passes 2014-07-24 17:44:57 -03:00
Manuel Araoz f8d7d1da9d add Transaction#getReceivingAddresses and send 2014-07-24 17:44:56 -03:00
Manuel Araoz 486f2ae1dc starting NetworkMonitor implementation 2014-07-24 17:42:51 -03:00
Matias Alejo Garcia 68b1211c4c formated using js-beautify 2014-07-24 17:35:21 -03:00
Matias Alejo Garcia 8e1de31797 test passing. 2014-07-24 17:33:40 -03:00
Ryan X. Charles 0f737b4f00 Merge pull request #450 from matiu/feature/sin03
Feature/sin03
2014-07-24 16:25:02 -04:00
Matias Alejo Garcia 2f97390849 formatted with js-beautify 2014-07-24 16:48:45 -03:00
Matias Alejo Garcia 397fc8607f new to/from Obj. WIP 2014-07-24 16:34:57 -03:00
Matias Alejo Garcia 71f992138b add check in constructor of Address 2014-07-24 01:40:56 -03:00
Matias Alejo Garcia 19584e1f26 add check in constructor 2014-07-24 01:40:13 -03:00
Ryan X. Charles cd1d667fe1 Merge pull request #448 from matiu/feature/sin02
Feature/sin02
2014-07-23 20:48:33 -04:00
Matias Alejo Garcia 15c55e560a support uncompressed pub keys also 2014-07-23 19:49:42 -03:00
Christopher Jeffrey 11c977ba70 fix: typo - s/Payment/PaymentACK/ 2014-07-23 15:02:19 -07:00
Matias Alejo Garcia 14d3165a73 add fromPubKey to SIN 2014-07-23 18:53:57 -03:00
Ryan X. Charles 1936bfd374 Merge pull request #446 from chjj/paypro
PayPro: Fix payment protocol with regards to pki_data DER certs
2014-07-23 17:30:16 -04:00
Christopher Jeffrey 2f6938bad0 paypro: fix handling of pki_data - cert arrays. 2014-07-23 14:22:56 -07:00
Matias Alejo Garcia 733835dc7c removes unused / obsolete class "Sign.js" 2014-07-23 18:11:27 -03:00
Christopher Jeffrey 017f044b53 paypro: fix browser signatures with KJUR. move pem/der functions to common. 2014-07-21 19:52:43 -07:00
Christopher Jeffrey 604ac04f47 paypro: split up paypro into node/browser/common. 2014-07-21 18:15:52 -07:00
Christopher Jeffrey cec71a51fd paypro: add isTrusted function to RootCerts. 2014-07-21 14:56:48 -07:00
Christopher Jeffrey 672e667e9c paypro: remove x509.js 2014-07-21 14:56:48 -07:00
Christopher Jeffrey 85d5e69fc1 paypro: move root certs to common. 2014-07-21 14:56:48 -07:00
Christopher Jeffrey 86efcbed1b paypro: remove all references of KJUR. 2014-07-21 14:56:48 -07:00
Christopher Jeffrey 92b7fad243 paypro: start using our own DERtoPEM functions so we don't have to require jsrsasign. 2014-07-21 14:56:48 -07:00
Christopher Jeffrey ec5a948400 paypro: fix pem/der functions. 2014-07-21 14:56:48 -07:00
Christopher Jeffrey 02f9ce8dfd paypro: temporarily fix tests. 2014-07-21 14:56:47 -07:00
Christopher Jeffrey aafbca46d9 paypro: move x509 sign and verify to their own methods. 2014-07-21 14:56:47 -07:00
Christopher Jeffrey 575352dd03 paypro: port root certs script to node for portability. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey a68c112371 paypro: fix DERtoPEM. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 271ac2e9a5 minor: fix typo. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey eb9fd652d2 paypro: potentially stop using jsrsasign in node. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 0db74604db paypro: update root certs and fix tests. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 8725516afb paypro: convert root certs to hash table in build file. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey cc7657d843 paypro: treat pki_data as an array. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 47e1ca5f1e minor: remove unused code. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 4dcdd3c091 paypro: temporarily disable untrusted cert error for tests. typo fix. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey f7e89b6a58 paypro: handle untrusted certs on browser and node. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey f79a31ff3c paypro: get single DER certs working. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 4ec9a247aa paypro: multiple fixes. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 24ae03247f paypro: stat using jsrsasign to convert DER to PEM and derive public keys for sig verification. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 37f20f3268 paypro: fix browser paypro. TODO: fix parsing DER certs. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 4e606c7ed2 paypro: move root certs to non-browser. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 2e422c001e paypro: fix payment protocol for DER certs. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 119ef0d611 paypro: begin checking trusted certs. 2014-07-21 14:55:10 -07:00
Christopher Jeffrey 29b067ab73 paypro: add createTrusted to browser build script. 2014-07-21 14:55:10 -07:00