Commit Graph

743 Commits

Author SHA1 Message Date
Patrick Nagurny de078a40d3 If output.script is InvalidBuffer, return null instead of throwing error 2015-05-12 17:23:56 -04:00
Braydon Fuller a02258dfba Merge pull request #1218 from maraoz/docs/pubkeys
improve PublicKey docs and fix #1215
2015-05-12 13:31:34 -04:00
Eric Martindale 8e7528d13f Merge pull request #1219 from braydonf/coverage/transaction
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 17:48:50 -04:00
Eric Martindale 993125428e Merge pull request #1213 from braydonf/bug/is-fully-signed
Fixed script.isPublicKeyHashIn bug with variable length signatures.
2015-05-11 15:12:44 -04:00
Braydon Fuller 53b6171547 Added coverage to transaction and fixed bug with serialization check. 2015-05-11 13:39:53 -04:00
Manuel Araoz 951a07c011 fix PublicKey.toObject 2015-05-11 12:24:45 -03:00
David de Kloet 056f171e22 Remove the ability to disable the check that a specified fee is equal to the unspent value. 2015-05-10 01:32:28 +02:00
David de Kloet b1e54101d3 Call the parent error of the fee errors FeeError for backwards compatibility. 2015-05-10 00:38:56 +02:00
David de Kloet 8da9c4a44a Give the 3 fee errors a common parent error. 2015-05-10 00:32:27 +02:00
David de Kloet d1eb190626 Introduce different kinds of FeeError to distinguish the different cases. Fix the issue uncovered by this, which is that getFee might not be the actual fee, but only an estimate, if a change address is specified but there isn't enough to pay a fee and have change. 2015-05-09 21:06:40 +02:00
David de Kloet 16dc489b08 Make sure a specified transaction fee and outputs add up to the sum of the inputs. Don't ignore the fee when it's explicitly specified. 2015-05-09 18:44:26 +02:00
Braydon Fuller d8e90685f4 Fixed script.isPublicKeyHashIn bug with variable length signatures.
- DER encoded signatures have a max length of 72 bytes, however a minimum size isn't defined.
- R and S values can have arbitrary lengths
- For more information: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#der-encoding
2015-05-08 22:09:42 -04:00
Braydon Fuller f8ea7e39cc Included satoshis check during checked serialization. 2015-04-30 13:23:44 -04:00
Braydon Fuller cd12164fae Added test coverage to transaction.verify 2015-04-30 12:09:59 -04:00
Braydon Fuller 3d447ded79 Update bn.js to 2.0.4 to handle 53 bit precision number input. 2015-04-30 11:20:09 -04:00
Manuel Araoz a018a23b6b fix bug in recognizing p2sh input scripts 2015-04-30 03:24:15 -03:00
Manuel Araoz db6234b500 remove duplicate code, increase coverage 2015-04-29 19:45:41 -03:00
Manuel Araoz fe17f20a97 remove console.log 2015-04-29 18:57:17 -03:00
Manuel Araoz d556a0c33d fix regressions 2015-04-29 18:55:42 -03:00
Manuel Araoz dfc075e5d1 fix block parsing problem 2015-04-29 17:29:33 -03:00
Manuel Araoz 270413a655 add simpler test that fails 2015-04-29 15:54:41 -03:00
Manuel Araoz 722eddb894 add test that exposes bug 2015-04-29 15:31:46 -03:00
Braydon Fuller a03daab866 Merge pull request #1196 from maraoz/script/coverage
increase script test coverage
2015-04-29 10:20:45 -04:00
Manuel Araoz e1921429cf remove stray console.log 2015-04-28 19:17:45 -03:00
Manuel Araoz 100e370295 fix regressions after changes 2015-04-28 17:10:06 -03:00
Manuel Araoz 9a50958943 fix Block#toObject API 2015-04-28 16:42:56 -03:00
Manuel Araoz dff0891871 add failing test for Block#toObject 2015-04-28 15:17:41 -03:00
Daniel Cousens 05a8cf9630 sighash: remove dead branch 2015-04-27 18:49:45 +10:00
Manuel Araoz 2cccf20c9d improve docs to show signatures type 2015-04-22 14:33:09 -03:00
Manuel Araoz ee6f8d35ef increase script test coverage 2015-04-22 14:32:10 -03:00
Manuel Araoz e25ffde6db refactor networks 2015-04-20 12:21:14 -03:00
Kirill Fomichev ca96359f40 Immutable network Object 2015-04-11 17:05:46 +03:00
Braydon Fuller bcd4efb724 Added `checkState` for positive integer in Output satoshis 2015-04-10 18:39:08 -04:00
Braydon Fuller 3005e19cbf Added precondition to transaction.to for a positive integer as an amount 2015-04-10 18:07:20 -04:00
Braydon Fuller 6367cbe368 Fixed typos in transaction.verify error messages 2015-04-08 12:46:18 -04:00
Manuel Araoz e331c4ea49 allow addresses to have surrounding whitespace in validation 2015-03-31 17:54:06 -03:00
Kirill Fomichev c010cb8c50 drop cached value for inputAmount and outputAmount 2015-03-31 16:22:27 +03:00
Manuel Aráoz 53d23e501c Merge pull request #1162 from fanatid/fix/isPublicKeyHashOut
[BUG] Script.isPublicKeyHashOut
2015-03-30 02:31:09 -03:00
eordano 662099a36e Use Networks.get with 2 args when possible 2015-03-29 22:57:31 -03:00
eordano 4f4b2b93fb Allow arrays as second arg to Networks.get 2015-03-29 22:56:29 -03:00
Kirill Fomichev 116024a7cb fix Script.isPublicKeyHashOut 2015-03-29 20:55:13 +03:00
Braydon Fuller f034a71929 Network Fixes
- Fixed Address classification for a custom network
- Added ability to remove a custom network
- Increased test coverage for Address
2015-03-28 19:09:58 -04:00
Chris Arnesen 8af63ec8d0 update transaction.getFee() JSDoc 2015-03-26 15:41:41 -07:00
Eric Martindale c759401373 Fix tests, address commentary from @braydonf. 2015-03-24 17:57:39 -04:00
Eric Martindale 9ece2f78ed Fix bug if no value is supplied. 2015-03-24 16:28:13 -04:00
Manuel Araoz 21266570d4 refactor code 2015-03-20 15:49:26 -03:00
Manuel Araoz 7da4c7925a lazy calc for xpubkey in HDPrivateKey 2015-03-20 15:49:26 -03:00
Manuel Araoz ef7eafbb0c increase test coverage and fix some bugs 2015-03-18 18:58:41 -03:00
Manuel Araoz e0b1ca0e10 move some script logic from Address to Script 2015-03-18 17:59:09 -03:00
Manuel Araoz 3619c7c9e2 fix problematic cases 2015-03-18 17:40:26 -03:00