zcash-hackworks
/
bitcore-node-zcash
mirror of https://github.com/zcash-hackworks/bitcore-node-zcash.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

bitcoind: subscribe to zmq events once synced 

prevents flooding tx and and block events that can cause issues
This commit is contained in:
Braydon Fuller 2016-04-19 16:00:17 -04:00
parent 7dabd8c4ab
commit 2b38f08175
2 changed files with 77 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
lib/services/bitcoind.js
View File

@ -65,6 +65,7 @@ Bitcoin.DEFAULT_MAX_ADDRESSES_QUERY = 10000;
Bitcoin.DEFAULT_TRY_ALL_INTERVAL = 1000;
Bitcoin.DEFAULT_REINDEX_INTERVAL = 10000;
Bitcoin.DEFAULT_START_RETRY_INTERVAL = 5000;
Bitcoin.DEFAULT_TIP_UPDATE_INTERVAL = 15000;
Bitcoin.DEFAULT_CONFIG_SETTINGS = {
server: 1,
whitelist: '127.0.0.1',
@ -431,6 +432,34 @@ Bitcoin.prototype._zmqTransactionHandler = function(node, message) {
}
};
Bitcoin.prototype._checkSyncedAndSubscribeZmqEvents = function(node) {
var self = this;
var interval;
interval = setInterval(function() {
// update tip
node.client.getBestBlockHash(function(err, response) {
if (err) {
return log.error(self._wrapRPCError(err));
}
var blockhash = new Buffer(response.result, 'hex');
self._updateTip(node, blockhash);
// check if synced
node.client.getBlockchainInfo(function(err, response) {
if (err) {
return log.error(self._wrapRPCError(err));
}
var percentSynced = response.result.verificationprogress * 100;
if (Math.round(percentSynced) >= 99) {
// subscribe to events for further updates
self._subscribeZmqEvents(node);
clearInterval(interval);
}
});
});
}, node._tipUpdateInterval || Bitcoin.DEFAULT_TIP_UPDATE_INTERVAL).unref();
};
Bitcoin.prototype._subscribeZmqEvents = function(node) {
var self = this;
node.zmqSubSocket.subscribe('hashblock');
@ -574,7 +603,7 @@ Bitcoin.prototype._spawnChildProcess = function(callback) {
if (err) {
return callback(err);
}
self._subscribeZmqEvents(node);
self._checkSyncedAndSubscribeZmqEvents(node);
callback(null, node);
});
@ -606,7 +635,7 @@ Bitcoin.prototype._connectProcess = function(config, callback) {
}
self._initZmqSubSocket(node, config.zmqpubrawtx);
self._subscribeZmqEvents(node);
self._checkSyncedAndSubscribeZmqEvents(node);
callback(null, node);
});

51
test/services/bitcoind.unit.js
View File

@ -669,6 +669,47 @@ describe('Bitcoin Service', function() {
});
});
describe('#_checkSyncedAndSubscribeZmqEvents', function() {
var sandbox = sinon.sandbox.create();
before(function() {
sandbox.stub(log, 'error');
});
after(function() {
sandbox.restore();
});
it('log errors, update tip and subscribe to zmq events', function(done) {
var bitcoind = new BitcoinService(baseConfig);
bitcoind._updateTip = sinon.stub();
bitcoind._subscribeZmqEvents = sinon.stub();
var getBestBlockHash = sinon.stub().callsArgWith(0, null, {
result: '00000000000000001bb82a7f5973618cfd3185ba1ded04dd852a653f92a27c45'
});
getBestBlockHash.onCall(0).callsArgWith(0, {code: -1 , message: 'Test error'});
var getBlockchainInfo = sinon.stub().callsArgWith(0, null, {
result: {
verificationprogress: 0.99
}
});
getBlockchainInfo.onCall(0).callsArgWith(0, {code: -1, message: 'Test error'});
var node = {
_reindex: true,
_reindexWait: 1,
_tipUpdateInterval: 1,
client: {
getBestBlockHash: getBestBlockHash,
getBlockchainInfo: getBlockchainInfo
}
};
bitcoind._checkSyncedAndSubscribeZmqEvents(node);
setTimeout(function() {
log.error.callCount.should.equal(2);
bitcoind._updateTip.callCount.should.equal(2);
bitcoind._subscribeZmqEvents.callCount.should.equal(1);
done();
}, 10);
});
});
describe('#_subscribeZmqEvents', function() {
it('will call subscribe on zmq socket', function() {
var bitcoind = new BitcoinService(baseConfig);
@ -888,7 +929,7 @@ describe('Bitcoin Service', function() {
bitcoind._loadTipFromNode = sinon.stub().callsArgWith(1, null);
bitcoind._initZmqSubSocket = sinon.stub();
bitcoind._subscribeZmqEvents = sinon.stub();
bitcoind._checkSyncedAndSubscribeZmqEvents = sinon.stub();
bitcoind._checkReindex = sinon.stub().callsArgWith(1, null);
bitcoind._spawnChildProcess(function(err, node) {
should.not.exist(err);
@ -906,8 +947,8 @@ describe('Bitcoin Service', function() {
bitcoind._initZmqSubSocket.callCount.should.equal(1);
should.exist(bitcoind._initZmqSubSocket.args[0][0].client);
bitcoind._initZmqSubSocket.args[0][1].should.equal('tcp://127.0.0.1:30001');
bitcoind._subscribeZmqEvents.callCount.should.equal(1);
should.exist(bitcoind._subscribeZmqEvents.args[0][0].client);
bitcoind._checkSyncedAndSubscribeZmqEvents.callCount.should.equal(1);
should.exist(bitcoind._checkSyncedAndSubscribeZmqEvents.args[0][0].client);
should.exist(node);
should.exist(node.client);
done();
@ -968,7 +1009,7 @@ describe('Bitcoin Service', function() {
bitcoind._loadTipFromNode = sinon.stub().callsArgWith(1, null);
bitcoind._initZmqSubSocket = sinon.stub();
bitcoind._subscribeZmqEvents = sinon.stub();
bitcoind._checkSyncedAndSubscribeZmqEvents = sinon.stub();
bitcoind._checkReindex = sinon.stub().callsArgWith(1, new Error('test'));
bitcoind._spawnChildProcess(function(err) {
@ -993,7 +1034,7 @@ describe('Bitcoin Service', function() {
it('will init zmq/rpc on node', function(done) {
var bitcoind = new BitcoinService(baseConfig);
bitcoind._initZmqSubSocket = sinon.stub();
bitcoind._subscribeZmqEvents = sinon.stub();
bitcoind._checkSyncedAndSubscribeZmqEvents = sinon.stub();
bitcoind._loadTipFromNode = sinon.stub().callsArgWith(1, null);
var config = {};
bitcoind._connectProcess(config, function(err, node) {