From 3f34fb6ea0b28683758a9a7092b25d09582b0c13 Mon Sep 17 00:00:00 2001 From: Braydon Fuller Date: Mon, 25 Apr 2016 11:02:37 -0400 Subject: [PATCH] bitcoind: always log errors emitted instead of being uncaught exceptions --- lib/services/bitcoind.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/services/bitcoind.js b/lib/services/bitcoind.js index f99f30bd..e3314b7a 100644 --- a/lib/services/bitcoind.js +++ b/lib/services/bitcoind.js @@ -58,6 +58,10 @@ function Bitcoin(options) { // available bitcoind nodes this._initClients(); + + this.on('error', function(err) { + log.error(err.stack); + }); } util.inherits(Bitcoin, Service); @@ -429,7 +433,6 @@ Bitcoin.prototype._updateTip = function(node, message) { node.client.getBlock(self.tiphash, function(err, response) { if (err) { var error = self._wrapRPCError(err); - log.error(error); self.emit('error', error); } else { self.height = response.result.height; @@ -441,7 +444,6 @@ Bitcoin.prototype._updateTip = function(node, message) { if(!self.node.stopping) { self.syncPercentage(function(err, percentage) { if (err) { - log.error(err); self.emit('error', err); } else { if (Math.round(percentage) >= 100) {