Net: Fix resource leak in ReadBinaryFile(...)

Introduced in 3290567bbd via PR #2177.
This commit is contained in:
practicalswift 2017-06-14 17:32:45 +02:00 committed by Jack Grigg
parent d52ac0d498
commit 1240717431
No known key found for this signature in database
GPG Key ID: 665DBCD284F7DAFF
1 changed files with 3 additions and 1 deletions

View File

@ -376,8 +376,10 @@ static std::pair<bool,std::string> ReadBinaryFile(const std::string &filename, s
while ((n=fread(buffer, 1, sizeof(buffer), f)) > 0) {
// Check for reading errors so we don't return any data if we couldn't
// read the entire file (or up to maxsize)
if (ferror(f))
if (ferror(f)) {
fclose(f);
return std::make_pair(false,"");
}
retval.append(buffer, buffer+n);
if (retval.size() > maxsize)
break;