From 8a22734ec1ee950f5e3f1279d4a636aafe29a977 Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Wed, 4 Apr 2018 19:18:23 +0100 Subject: [PATCH] test: Check return value of snprintf --- src/test/dbwrapper_tests.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/test/dbwrapper_tests.cpp b/src/test/dbwrapper_tests.cpp index a23d646ab..c9b119ab2 100644 --- a/src/test/dbwrapper_tests.cpp +++ b/src/test/dbwrapper_tests.cpp @@ -190,7 +190,8 @@ BOOST_AUTO_TEST_CASE(iterator_string_ordering) CDBWrapper dbw(ph, (1 << 20), true, false); for (int x=0x00; x<10; ++x) { for (int y = 0; y < 10; y++) { - snprintf(buf, sizeof(buf), "%d", x); + int n = snprintf(buf, sizeof(buf), "%d", x); + assert(n > 0 && n < sizeof(buf)); StringContentsSerializer key(buf); for (int z = 0; z < y; z++) key += key; @@ -201,12 +202,14 @@ BOOST_AUTO_TEST_CASE(iterator_string_ordering) boost::scoped_ptr it(const_cast(&dbw)->NewIterator()); for (int seek_start : {0, 5}) { - snprintf(buf, sizeof(buf), "%d", seek_start); + int n = snprintf(buf, sizeof(buf), "%d", seek_start); + assert(n > 0 && n < sizeof(buf)); StringContentsSerializer seek_key(buf); it->Seek(seek_key); for (int x=seek_start; x<10; ++x) { for (int y = 0; y < 10; y++) { - snprintf(buf, sizeof(buf), "%d", x); + int n = snprintf(buf, sizeof(buf), "%d", x); + assert(n > 0 && n < sizeof(buf)); string exp_key(buf); for (int z = 0; z < y; z++) exp_key += exp_key;